From: Dmitry Safonov <0x7f454...@gmail.com>
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
Documentation/networking/tcp_ao.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/networking/tcp_ao.rst
b/Documentation/networking/tcp_ao.rst
index 8a58321acce7..e96e
From: Dmitry Safonov <0x7f454...@gmail.com>
Two reasons:
1. It's grown up enough
2. In order to not do header spaghetti by including
, which is necessary for TCP tracepoints.
While at it, unexport and make static tcp_inbound_ao_hash().
Reviewed-by: Eric Dumazet
Signed-off-by: Dmitry Safonov
From: Dmitry Safonov <0x7f454...@gmail.com>
Now there are tracepoints, that cover all functionality of
tcp_hash_fail(), but also wire up missing places
They are also faster, can be disabled and provide filtering.
This potentially may create a regression if a userspace depends on dmesg
logs. Finge
From: Dmitry Safonov <0x7f454...@gmail.com>
It's going to be used more in TCP-AO tracepoints.
Reviewed-by: Eric Dumazet
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
include/net/tcp_ao.h | 5 +
net/ipv4/tcp_ao.c| 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --g
From: Dmitry Safonov <0x7f454...@gmail.com>
It's possible to clean-up some ifdefs by hiding that
tcp_{md5,ao}_needed static branch is defined and compiled only
under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce
AO/MD5 logs if there are any keys").
Reviewed-by: Eric Dumazet
From: Dmitry Safonov <0x7f454...@gmail.com>
Instead of forcing userspace to parse dmesg (that's what currently is
happening, at least in codebase of my current company), provide a better
way, that can be enabled/disabled in runtime.
Currently, there are already tcp events, add hashing related one
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
Changes in v4:
- Fix the build for CONFIG_TCP_MD5SIG=n (Matthieu Baerts, netdev dashboard)
- Link to v3:
https://lore.kernel.org/r/20240606-tcp_ao-tracepoints-v3-0-13621988c...@gmail.com
Changes in v3:
- Unexported tcp_inbound_ao_hash() and
From: Dmitry Safonov <0x7f454...@gmail.com>
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
Documentation/networking/tcp_ao.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/networking/tcp_ao.rst
b/Documentation/networking/tcp_ao.rst
index 8a58321acce7..e96e
From: Dmitry Safonov <0x7f454...@gmail.com>
Now there are tracepoints, that cover all functionality of
tcp_hash_fail(), but also wire up missing places
They are also faster, can be disabled and provide filtering.
This potentially may create a regression if a userspace depends on dmesg
logs. Finge
From: Dmitry Safonov <0x7f454...@gmail.com>
Two reasons:
1. It's grown up enough
2. In order to not do header spaghetti by including
, which is necessary for TCP tracepoints.
While at it, unexport and make static tcp_inbound_ao_hash().
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
From: Dmitry Safonov <0x7f454...@gmail.com>
It's possible to clean-up some ifdefs by hiding that
tcp_{md5,ao}_needed static branch is defined and compiled only
under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce
AO/MD5 logs if there are any keys").
Reviewed-by: Eric Dumazet
From: Dmitry Safonov <0x7f454...@gmail.com>
Instead of forcing userspace to parse dmesg (that's what currently is
happening, at least in codebase of my current company), provide a better
way, that can be enabled/disabled in runtime.
Currently, there are already tcp events, add hashing related one
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
Changes in v3:
- Unexported tcp_inbound_ao_hash() and made static (Eric Dumazet)
- Link to v2:
https://lore.kernel.org/r/20240605-tcp_ao-tracepoints-v2-0-e91e16128...@gmail.com
Changes in v2:
- Fix the build with CONFIG_IPV6=m (Eric Dumazet
From: Dmitry Safonov <0x7f454...@gmail.com>
It's going to be used more in TCP-AO tracepoints.
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
include/net/tcp_ao.h | 5 +
net/ipv4/tcp_ao.c| 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/net/tcp_ao.h b
From: Dmitry Safonov <0x7f454...@gmail.com>
Instead of forcing userspace to parse dmesg (that's what currently is
happening, at least in codebase of my current company), provide a better
way, that can be enabled/disabled in runtime.
Currently, there are already tcp events, add hashing related one
From: Dmitry Safonov <0x7f454...@gmail.com>
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
Documentation/networking/tcp_ao.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/networking/tcp_ao.rst
b/Documentation/networking/tcp_ao.rst
index 8a58321acce7..e96e
From: Dmitry Safonov <0x7f454...@gmail.com>
Two reasons:
1. It's grown up enough
2. In order to not do header spaghetti by including
, which is necessary for TCP tracepoints.
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
include/net/tcp.h | 65 --
From: Dmitry Safonov <0x7f454...@gmail.com>
Now there are tracepoints, that cover all functionality of
tcp_hash_fail(), but also wire up missing places
They are also faster, can be disabled and provide filtering.
This potentially may create a regression if a userspace depends on dmesg
logs. Finge
From: Dmitry Safonov <0x7f454...@gmail.com>
It's going to be used more in TCP-AO tracepoints.
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
include/net/tcp_ao.h | 5 +
net/ipv4/tcp_ao.c| 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/net/tcp_ao.h b
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com>
---
Changes in v2:
- Fix the build with CONFIG_IPV6=m (Eric Dumazet)
- Move unused keyid/rnext/maclen later in the series to the patch
that uses them (Simon Horman)
- Reworked tcp_ao selftest lib to allow async tracing non-tcp events
(was wor
From: Dmitry Safonov <0x7f454...@gmail.com>
It's possible to clean-up some ifdefs by hiding that
tcp_{md5,ao}_needed static branch is defined and compiled only
under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce
AO/MD5 logs if there are any keys").
Signed-off-by: Dmitry Safon
21 matches
Mail list logo