Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-19 Thread Christoph Hellwig
On Tue, Nov 19, 2024 at 11:49:09AM +0100, Roberto Sassu wrote: > From: Roberto Sassu > > Introduce ksys_finit_module() to let kernel components request a kernel > module without requiring running modprobe. That does sound more than sketchy, even more so because the commit log completely fails to

Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-17 Thread Christoph Hellwig
On Sat, Nov 16, 2024 at 05:59:18PM +, Pasha Tatashin wrote: > } while (start = next, start < end); > return err; > } > +EXPORT_SYMBOL_GPL(walk_page_range); Umm, no. We really should not expose all these page table detail to modules. > +EXPORT_SYMBOL_GPL(walk_page_range_kernel);

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread Christoph Hellwig
On Tue, Jul 02, 2024 at 08:19:01PM +1000, Alistair Popple wrote: > > (B) As long as we have subpage mapcounts, this prevents vmemmap > > optimizations [1]. Is that only used for device-dax for now and are > > there no plans to make use of that for fs-dax? > > I don't have any plans to. Thi

Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn

2024-07-02 Thread Christoph Hellwig
On Tue, Jul 02, 2024 at 09:18:31AM +0200, David Hildenbrand wrote: > We have this comparably nasty vmf_insert_mixed() that FS dax abused to > insert into !VM_MIXED VMAs. Is that abuse now stopping and are there maybe > ways to get rid of vmf_insert_mixed()? Unfortunately it is also used by a few

Re: [PATCH 10/13] fs/dax: Properly refcount fs dax pages

2024-06-26 Thread Christoph Hellwig
> diff --git a/drivers/dax/device.c b/drivers/dax/device.c > index eb61598..b7a31ae 100644 > --- a/drivers/dax/device.c > +++ b/drivers/dax/device.c > @@ -126,11 +126,11 @@ static vm_fault_t __dev_dax_pte_fault(struct dev_dax > *dev_dax, > return VM_FAULT_SIGBUS; > } > > -

Re: [PATCH 05/13] mm: Allow compound zone device pages

2024-06-26 Thread Christoph Hellwig
On Thu, Jun 27, 2024 at 10:54:20AM +1000, Alistair Popple wrote: > static struct nouveau_dmem_chunk *nouveau_page_to_chunk(struct page *page) > { > - return container_of(page->pgmap, struct nouveau_dmem_chunk, pagemap); > + return container_of(page_dev_pagemap(page), struct nouveau_dmem_c

Re: [PATCH 04/13] fs/dax: Add dax_page_free callback

2024-06-26 Thread Christoph Hellwig
On Thu, Jun 27, 2024 at 10:54:19AM +1000, Alistair Popple wrote: > When a fs dax page is freed it has to notify filesystems that the page > has been unpinned/unmapped and is free. Currently this involves > special code in the page free paths to detect a transition of refcount > from 2 to 1 and to c

Re: [PATCH 03/13] fs/dax: Refactor wait for dax idle page

2024-06-26 Thread Christoph Hellwig
; Signed-off-by: Alistair Popple > Reviewed-by: Jan Kara I'm pretty sure I already review this ages ago, but: Reviewed-by: Christoph Hellwig

Re: [PATCH 02/13] pci/p2pdma: Don't initialise page refcount to one

2024-06-26 Thread Christoph Hellwig
On Thu, Jun 27, 2024 at 10:54:17AM +1000, Alistair Popple wrote: > The reference counts for ZONE_DEVICE private pages should be > initialised by the driver when the page is actually allocated by the > driver allocator, not when they are first created. This is currently > the case for MEMORY_DEVICE_

Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn

2024-06-26 Thread Christoph Hellwig
On Thu, Jun 27, 2024 at 10:54:21AM +1000, Alistair Popple wrote: > +extern void prep_compound_page(struct page *page, unsigned int order); No need for the extern. > static int insert_page_into_pte_locked(struct vm_area_struct *vma, pte_t > *pte, > - unsigned long addr, struc

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-15 Thread Christoph Hellwig
On Mon, Apr 15, 2024 at 10:35:21AM +0200, Greg KH wrote: > On Mon, Apr 15, 2024 at 01:07:41AM -0700, Christoph Hellwig wrote: > > No, this advice is wronger than wrong. If you set panic_on_warn you > > get to keep the pieces. > > > > But don't add new WARN() c

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-15 Thread Christoph Hellwig
No, this advice is wronger than wrong. If you set panic_on_warn you get to keep the pieces.

Re: [PATCH v2] docs: submitting-patches: encourage direct notifications to commenters

2023-10-05 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH] docs: submitting-patches: encourage direct notifications to reviewers

2023-10-02 Thread Christoph Hellwig
On Mon, Oct 02, 2023 at 10:36:01AM +0300, Jani Nikula wrote: > On Sun, 01 Oct 2023, Christoph Hellwig wrote: > > On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: > >> > This does not scale. > >> > >> Could you elaborate in which way it do

Re: [PATCH] docs: submitting-patches: encourage direct notifications to reviewers

2023-10-01 Thread Christoph Hellwig
On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: > > This does not scale. > > Could you elaborate in which way it doesn't scale? If I send a modest cross-subsystem series it often touches 20+ subsystems. Between mailing lists and maintainers that's usually already 60+ recipients

Re: [PATCH] docs: submitting-patches: encourage direct notifications to reviewers

2023-09-28 Thread Christoph Hellwig
NAK. This does not scale. Please read the mailinglist, that's the whole point of having it.

Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()

2021-11-29 Thread Christoph Hellwig
On Mon, Nov 29, 2021 at 03:49:46PM +, Joao Martins wrote: > Hmmm -- if by individual helpers moving to __dev_dax_{pte,pmd,pud}_fault() > it would be slightly less straighforward. Unless you might mean to move > to check_vma() (around the dax_alive() check) and that might actually > remove the o

Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()

2021-11-28 Thread Christoph Hellwig
On Fri, Nov 26, 2021 at 06:39:39PM +, Joao Martins wrote: > @@ -230,23 +235,18 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault > *vmf, > id = dax_read_lock(); > switch (pe_size) { > case PE_SIZE_PTE: > - fault_size = PAGE_SIZE; > rc = __dev_d

Re: [PATCH v6 04/10] mm/memremap: add ZONE_DEVICE support for compound pages

2021-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2021 at 07:09:59PM +, Joao Martins wrote: > Add a new @vmemmap_shift property for struct dev_pagemap which specifies that > a > devmap is composed of a set of compound pages of order @vmemmap_shift, > instead of > base pages. When a compound page devmap is requested, all but t

Re: [PATCH v5 6/8] device-dax: use struct_size()

2021-11-17 Thread Christoph Hellwig
> + pgmap = devm_kzalloc( > + dev, struct_size(pgmap, ranges, dev_dax->nr_range - > 1), > + GFP_KERNEL); Keeping the dev argument on the previous line would not only make this much more readable but also avoid the overly long line.

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-17 Thread Christoph Hellwig
On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: > Use the newly added compound devmap facility which maps the assigned dax > ranges as compound pages at a page size of @align. > > dax devices are created with a fixed @align (huge page size) which is > enforced through as well at mmap

Re: [PATCH v5 7/8] device-dax: ensure dev_dax->pgmap is valid for dynamic devices

2021-11-17 Thread Christoph Hellwig
> +bool static_dev_dax(struct dev_dax *dev_dax) > +{ > + return is_static(dev_dax->region); > +} > +EXPORT_SYMBOL_GPL(static_dev_dax); This function would massively benefit from documentic what a static DAX region is and why someone would want to care. Because even as someone occasionally dab

Re: [PATCH v4 04/14] mm/memremap: add ZONE_DEVICE support for compound pages

2021-09-01 Thread Christoph Hellwig
On Fri, Aug 27, 2021 at 05:00:11PM +0100, Joao Martins wrote: > So felt like doing it inline straight away inline when calling > percpu_ref_get_many(): > > (pfn_end(pgmap, range_id) - pfn_first(pgmap, range_id)) / > pgmap_geometry(pgmap); > > I can switch to a shift if you prefer: >

Re: [PATCH v4 04/14] mm/memremap: add ZONE_DEVICE support for compound pages

2021-08-27 Thread Christoph Hellwig
On Fri, Aug 27, 2021 at 03:58:09PM +0100, Joao Martins wrote: > + * @geometry: structural definition of how the vmemmap metadata is populated. > + * A zero or 1 defaults to using base pages as the memmap metadata > + * representation. A bigger value will set up compound struct pages > + * rep

Re: [PATCH] Documentation: admin-guide: add earlycon documentation for RISC-V

2019-10-17 Thread Christoph Hellwig
On Wed, Oct 09, 2019 at 12:53:50PM -0700, Paul Walmsley wrote: > > Kernels booting on RISC-V can specify "earlycon" with no options on > the Linux command line, and the generic DT earlycon support will query > the "chosen/stdout-path" property (if present) to determine which > early console device

[PATCH v2] Documentation: document earlycon without options for more platforms

2019-09-17 Thread Christoph Hellwig
The earlycon options without arguments is supposed to work on all device tree platforms, not just arm64. Signed-off-by: Christoph Hellwig --- Changes since v1: - add comma, fix typo Documentation/admin-guide/kernel-parameters.txt | 10 -- 1 file changed, 4 insertions(+), 6 deletions

[PATCH] Documentation: document earlycon without options for more platforms

2019-09-16 Thread Christoph Hellwig
The earlycon options without arguments is supposed on all device tree platforms, not just arm64. Signed-off-by: Christoph Hellwig --- Documentation/admin-guide/kernel-parameters.txt | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Documentation/admin-guide/kernel

Re: [PATCH] doc: replace IFF abbreviation with 'if and only if'

2019-09-09 Thread Christoph Hellwig
On Sat, Sep 07, 2019 at 12:51:16PM +0200, Federico Vaga wrote: > In a normal piece of text the use of 'iff' does not guarantee a correct > interpretation because it is easy to confuse it for a typo (if or iff?). > > I believe that IFF should not be used outside a logical/mathematical > expression.

Re: [PATCH v2] dma-mapping: Fix filename references

2019-09-02 Thread Christoph Hellwig
On Mon, Sep 02, 2019 at 04:22:50PM +0300, Andy Shevchenko wrote: > > > Any comment on this? > > > > Fine with me, and I also agree with the glue code comment. > > Are you going to apply this? Thanks, applied to the dma-mapping tree for 5.4.

Re: [PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource()

2019-08-30 Thread Christoph Hellwig
On Thu, Aug 29, 2019 at 04:48:36PM +0200, Geert Uytterhoeven wrote: > Hi Bartosz, > > On Thu, Aug 29, 2019 at 4:38 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The new devm_platform_ioremap_resource() helper has now been widely > > adopted and used in many drivers. Users o

Re: [PATCH v2] dma-mapping: Fix filename references

2019-08-13 Thread Christoph Hellwig
On Tue, Aug 13, 2019 at 05:42:22PM +0300, Andy Shevchenko wrote: > On Wed, Jun 19, 2019 at 05:19:55PM +0300, Andy Shevchenko wrote: > > After the commit cf65a0f6f6ff > > > > ("dma-mapping: move all DMA mapping code to kernel/dma") > > > > some of the files are referring to outdated information,

[PATCH] Documentation: move Documentation/virtual to Documentation/virt

2019-07-24 Thread Christoph Hellwig
16648eb5b8 ("Move kvm, uml, and lguest subdirectories under a common "virtual" directory, I.E:") Signed-off-by: Christoph Hellwig --- Documentation/admin-guide/kernel-parameters.txt | 2 +- Documentation/{virtual => virt}/index.rst | 0 ...

Re: [linux-kernel-mentees] [PATCH v6] Doc : fs : convert xfs.txt to ReST

2019-07-09 Thread Christoph Hellwig
On Tue, Jul 09, 2019 at 01:48:59PM +0100, Sheriff Esseson wrote: > Convert xfs.txt to ReST, rename and fix broken references, consequently. The subject line still uses completely b0rked naming conventions.

Re: [Linux-kernel-mentees] [PATCH] Doc : fs : move xfs.txt to admin-guide

2019-07-08 Thread Christoph Hellwig
The subjet line seems to be a bit messed up.

Re: [PATCH 3/3] LICENSES: Rename other to deprecated

2019-05-14 Thread Christoph Hellwig
On Tue, May 14, 2019 at 12:26:32PM +0200, Borislav Petkov wrote: > This breaks scripts/spdxcheck.py, it needs below hunk. Also, should > "dual" be added to license_dirs too? Yes. In fact two people already submitted patches for that before you, just waiting for them to get picked up.

[PATCH 1/5] ccio: allow large DMA masks

2019-02-15 Thread Christoph Hellwig
There is no harm in setting a 64-bit mask even if we don't need it, and the current ccio code is one of the few place in the kernel still rejecting larger than required DMA masks. Signed-off-by: Christoph Hellwig --- drivers/parisc/ccio-dma.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH 5/5] Documentation/DMA-API-HOWTO: update dma_mask sections

2019-02-15 Thread Christoph Hellwig
We don't require drivers to guess a DMA mask that might actually match the system capabilities any more, so fix up the documentation to clear this up. Signed-off-by: Christoph Hellwig --- Documentation/DMA-API-HOWTO.txt | 121 +++- 1 file changed, 41 inser

allow larger than require DMA masks

2019-02-15 Thread Christoph Hellwig
Hi all, this series finishes off converting our dma mask model to split between device capabilities (dev->dma_mask and dev->coherent_dma_mask) and system limitations (dev->bus_dma_mask). We already accept larger than required masks in most dma_map_ops implementation, in case of x86 and implementa

[PATCH 2/5] sparc64: refactor the ali DMA quirk

2019-02-15 Thread Christoph Hellwig
Do the quirk first in the dma_supported routines, as we don't need any of the other checks for it, and remove the duplicate mask checking that is already done by the callers. Signed-off-by: Christoph Hellwig --- arch/sparc/kernel/iommu.c | 7 +++--- arch/sparc/kernel/kernel.h

[PATCH 3/5] sparc64/iommu: allow large DMA masks

2019-02-15 Thread Christoph Hellwig
plied dma mask is large enough as nothing in the iommu.c code (or the core DMA code) actually looks at the DMA mask later on. Signed-off-by: Christoph Hellwig --- arch/sparc/kernel/iommu.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/sparc/kernel/iommu.c b/arch/

[PATCH 4/5] sparc64/pci_sun4v: allow large DMA masks

2019-02-15 Thread Christoph Hellwig
plied dma mask is large enough. and adjust the mapping code to check ATU presence in addition to the DMA mask to decice on the mapping method. Signed-off-by: Christoph Hellwig --- arch/sparc/kernel/pci_sun4v.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --

[PATCH] Documentation/DMA-ISA-LPC: fix an incorrect reference

2019-02-11 Thread Christoph Hellwig
AFAIK we never had a isa_virt_to_phys, it always was isa_virt_to_bus. Signed-off-by: Christoph Hellwig --- Documentation/DMA-ISA-LPC.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/DMA-ISA-LPC.txt b/Documentation/DMA-ISA-LPC.txt index 8c2b8be6e45b

Re: [PATCH v2] dma-debug: add dumping facility via debugfs

2019-02-01 Thread Christoph Hellwig
Thanks! I had to adjust the patch a bit for the debugfs cleanups form Greg that I applied before, can you check the result here: http://git.infradead.org/users/hch/dma-mapping.git/commitdiff/0a3b192c26da198fce38e1ee242a34f558670246

Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

2019-01-19 Thread Christoph Hellwig
This seems like a pretty horrible idea and waste of kernel memory. Just add support to kbuild to store a compressed archive in initramfs and unpack it in the right place.

Re: [PATCH 2/3] kbuild: generate asm-generic wrappers if mandatory headers are missing

2018-12-06 Thread Christoph Hellwig
On Wed, Dec 05, 2018 at 08:28:05PM +0900, Masahiro Yamada wrote: > Some time ago, Sam pointed out a certain degree of overwrap between > generic-y and mandatory-y. (https://lkml.org/lkml/2017/7/10/121) > > I a bit tweaked the meaning of mandatory-y; now it defines the minimum > set of ASM headers

Re: [PATCH] arm64: Make kpti command line options x86 compatible

2018-11-15 Thread Christoph Hellwig
On Tue, Nov 13, 2018 at 04:20:46PM +0100, Alexander Graf wrote: > I've already stumbled over 2 cases where people got confused about how to > disable kpti on AArch64. In both cases, they used existing x86_64 options > and just applied that to an AArch64 system, expecting it to work. > > I think it

Re: Re-run features-refresh.sh

2018-11-15 Thread Christoph Hellwig
FYI, we really should kill ARCH_SG_CHAIN in its current form. See my series here, which could use a review or two: https://lkml.org/lkml/2018/11/9/958

Re: [dm-devel] [PATCH] dm: add secdel target

2018-10-19 Thread Christoph Hellwig
On Fri, Oct 19, 2018 at 02:49:44PM +0300, Vitaly Chikunov wrote: > On Thu, Oct 18, 2018 at 11:19:45PM -0700, Christoph Hellwig wrote: > > Just as a note: the name is a complete misowner, a couple overwrite > > are not in any way secure deletion. So naming it this way and expos

Re: [dm-devel] [PATCH] dm: add secdel target

2018-10-18 Thread Christoph Hellwig
Just as a note: the name is a complete misowner, a couple overwrite are not in any way secure deletion. So naming it this way and exposing this as erase is a problem that is going to get back to bite us. If you really want this anyway at least give it a different way, and do a one-time warning w

Re: [GIT PULL] IDA/IDR fixes for 4.19

2018-10-17 Thread Christoph Hellwig
removed we should include something like this: --- >From c3660257f981e7a7254d18f52af64a2077f7bb49 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 18 Oct 2018 08:22:39 +0200 Subject: LICENSES: Remove CC-BY-SA-4.0 license text Using non-GPL licenses for our documentation is rather problem

Re: [PATCH v2 00/22] xfs-4.20: major documentation surgery

2018-10-15 Thread Christoph Hellwig
On Thu, Oct 11, 2018 at 11:27:35AM -0600, Jonathan Corbet wrote: > On Sat, 6 Oct 2018 10:51:54 +1000 > Dave Chinner wrote: > > > Can you let us know whether the CC-by-SA 4.0 license is acceptible > > or not? That's really the only thing that we need clarified at this > > point - if it's OK I'll t

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Christoph Hellwig
> * Use either while holding wait_queue_head::lock or when used for wakeups > - * with an extra smp_mb() like: > + * with an extra smp_mb() like:: Independent of any philosophical discussion not allowing a setence to end with a single ':' is completely idiotic. Please fix the tooling instead to

Re: [PATCH 2/3] mm: replace __HAVE_ARCH_PTE_SPECIAL

2018-04-09 Thread Christoph Hellwig
> -#ifdef __HAVE_ARCH_PTE_SPECIAL > +#ifdef CONFIG_ARCH_HAS_PTE_SPECIAL > # define HAVE_PTE_SPECIAL 1 > #else > # define HAVE_PTE_SPECIAL 0 I'd say kill this odd indirection and just use the CONFIG_ARCH_HAS_PTE_SPECIAL symbol directly. -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 00/16] remove eight obsolete architectures

2018-03-15 Thread Christoph Hellwig
On Thu, Mar 15, 2018 at 11:42:25AM +0100, Arnd Bergmann wrote: > Is anyone producing a chip that includes enough of the Privileged ISA spec > to have things like system calls, but not the MMU parts? Various SiFive SOCs seem to support M and U mode, but no S mode or iommu. That should be enough fo

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-08 Thread Christoph Hellwig
On Thu, Mar 08, 2018 at 01:24:45PM +, Robin Murphy wrote: > Implementing dma_map_ops inside a driver for real hardware is almost always > the wrong thing to do. Agreed. dma_map_ops should be a platform decision based on the bus. Even our dma_virt_ops basically just works around bad driver l

Re: [PATCH] pci: Add a acs_disable option for pci kernel parameter

2017-10-26 Thread Christoph Hellwig
On Thu, Oct 26, 2017 at 08:37:49PM -0600, sba...@raithlin.com wrote: > From: Stephen Bates > > On some servers the BIOS sets up ACS on any valid pci_dev in the > system. The kernel has no way of backing this out since the kernel > only turns ACS capabilities on. > > This patch adds a new boot op

Re: [PATCH, RESEND 08/12] ima: added parser for RPM data type

2017-08-01 Thread Christoph Hellwig
On Tue, Aug 01, 2017 at 12:20:36PM +0200, Roberto Sassu wrote: > This patch introduces a parser for RPM packages. It extracts the digests > from the RPMTAG_FILEDIGESTS header section and converts them to binary data > before adding them to the hash table. > > The advantage of this data type is tha

Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite()

2017-07-25 Thread Christoph Hellwig
On Tue, Jul 25, 2017 at 11:35:08AM +0200, Jan Kara wrote: > On Tue 25-07-17 10:01:58, Christoph Hellwig wrote: > > On Tue, Jul 25, 2017 at 01:14:00AM +0300, Kirill A. Shutemov wrote: > > > I guess it's up to filesystem if it wants to reuse the same spot to write > >

Re: [PATCH v5 1/5] mm: add vm_insert_mixed_mkwrite()

2017-07-25 Thread Christoph Hellwig
On Tue, Jul 25, 2017 at 01:14:00AM +0300, Kirill A. Shutemov wrote: > I guess it's up to filesystem if it wants to reuse the same spot to write > data or not. I think your assumptions works for ext4 and xfs. I wouldn't > be that sure for btrfs or other filesystems with CoW support. Or XFS with ref

Re: [PATCH] changes.rst: explain the usage of virtual environment

2017-06-19 Thread Christoph Hellwig
On Mon, Jun 19, 2017 at 08:24:10AM -0300, Mauro Carvalho Chehab wrote: > As the Sphinx build seems very fragile, specially for > PDF output, add a notice about how to use it on a virtual > environment. Please don't. python venv are good at one thing only, and that is making a mess of your python

Re: [PATCH v6 25/34] swiotlb: Add warnings for use of bounce buffers with SME

2017-06-08 Thread Christoph Hellwig
On Wed, Jun 07, 2017 at 02:17:32PM -0500, Tom Lendacky wrote: > Add warnings to let the user know when bounce buffers are being used for > DMA when SME is active. Since the bounce buffers are not in encrypted > memory, these notifications are to allow the user to determine some > appropriate actio

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-07 Thread Christoph Hellwig
On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > This patchset moves drivers/staging/unisys/include to > > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > > drivers/virt/visorbus. > > Um, are you t

Re: [PATCH 1/3] include: linux: visorbus: Add visorbus to include/linux directory

2017-06-07 Thread Christoph Hellwig
Please don't send any move patches but the actual code added to the kernel proper. And based on what's in linux-next I don't think this giant pile of junk is anywhere near mergeable. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

2017-03-08 Thread Christoph Hellwig
On Wed, Mar 08, 2017 at 03:32:03PM +, Joao Pinto wrote: > #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register) \ > ((0x3 << 20) | (region << 9) | \ > (0x1 << 8) Can you turn this and any similar macro

Re: [PATCH v2 04/22] Documentation: PCI: Guide to use pci endpoint configfs

2017-02-17 Thread Christoph Hellwig
I'm commenting on the configfs layout here instead of the patch with the code as the issues are easier to explain that way. I think the layout is a bit confusing and could be cleaner by making use of pre-created entries and symlinks. Here is my suggestion: /sys/kernel/config/pci_ep/functions/

Re: [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for configuring EP functions

2017-02-17 Thread Christoph Hellwig
On Fri, Feb 17, 2017 at 03:20:23PM +0530, Kishon Vijay Abraham I wrote: > Introduce a new configfs entry to configure the EP function (like > configuring the standard configuration header entries) and to > bind the EP function with EP controller. > > Signed-off-by: Kishon Vijay Abraham I > --- >

two small PCI documentation fixups

2017-02-14 Thread Christoph Hellwig
Avoid mentioning deprecated APIs and make the text a little easier to understand. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] PCI: update pci.txt to talk about pci_alloc_irq_vectors

2017-02-14 Thread Christoph Hellwig
instead of the deprecated pci_enable_msi* APIs. Signed-off-by: Christoph Hellwig --- Documentation/PCI/pci.txt | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/PCI/pci.txt b/Documentation/PCI/pci.txt index 77f49dc5be23..98875f8cb7ba

[PATCH 2/2] PCI: update MSI/MSI-X bits in PCIEBUS-HOWTO

2017-02-14 Thread Christoph Hellwig
Stop talking about low-level details that mention deprecated APIs and concentrate on what service drivers should do and why. Signed-off-by: Christoph Hellwig --- Documentation/PCI/PCIEBUS-HOWTO.txt | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff

Re: [PATCH 31/37] misc: Add host side pci driver for pci test function device

2017-01-24 Thread Christoph Hellwig
On Thu, Jan 12, 2017 at 03:56:20PM +0530, Kishon Vijay Abraham I wrote: > Add PCI endpoint test driver that can verify base address > register, legacy interrupt/MSI interrupt and read/write/copy > buffers between host and device. The corresponding pci-epf-test > function driver should be used on th

Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions

2017-01-16 Thread Christoph Hellwig
On Mon, Jan 16, 2017 at 11:31:23AM +0530, Kishon Vijay Abraham I wrote: > Actually not all devices have hardcoded headers. E.g the platform I'm using > doesn't have hardcoded headers and it can be configured based on the function > the user would like to use. If the devices are hardcoded, then usin

Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions

2017-01-13 Thread Christoph Hellwig
Hi Kishon, a couple comments on the configfs layout based on my experiments with your previous drop to implement a NVMe device using it. I don't think most of these configfs files should be present here, as they are properties of the implemented PCIe devices. E.g. for my NVMe device they will be

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-09 Thread Christoph Hellwig
On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: > Regularly, when a new header is created in include/uapi/, the developer > forgets to add it in the corresponding Kbuild file. This error is usually > detected after the release is out. > > In fact, all headers under uapi directorie

Re: [PATCH] fs: configfs: don't return anything from drop_link

2016-12-01 Thread Christoph Hellwig
Thanks a lot Andrzej! I've applied the patch, but I undid the reformatting of the nvmet code to keep the patch as simple as possible. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 07:27:38PM +, Winkler, Tomas wrote: > I value your opinion but I'm not responsible for inventing RPMB > and/or its implementation storage devices (eMMC, UFC, NVMe), it's pretty > much done deal out there in the wild. > I'm just trying to provide common API above it.

Re: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 09:53:12PM +0200, Tomas Winkler wrote: > Register UFS RPMB LUN with the RPMB subsystem and provide > implementation for the RPMB access operations. RPMB partition is > accessed via a sequence of security protocol in and security protocol > out commands with UFS specific para

Re: [RFC PATCH-tip v4 02/10] locking/rwsem: Stop active read lock ASAP

2016-10-15 Thread Christoph Hellwig
On Wed, Oct 12, 2016 at 08:06:40AM +1100, Dave Chinner wrote: > Um, I seem to have completely missed that change - when did that > happen and why? > > Oh, it was part of the misguided "enable DAX on block devices" > changes - o, that commit just switched it to use ->f_mapping: - return (fi

Re: [RFC PATCH 05/11] pci: rename *host* directory to *controller*

2016-10-12 Thread Christoph Hellwig
This is a big and painful change. I'd suggest to either drop it for now or convince Bjorn to take it as a scripted renamed just after -rc1. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [RFC PATCH 02/11] pci: endpoint: introduce configfs entry for configuring EP functions

2016-10-12 Thread Christoph Hellwig
On Wed, Sep 14, 2016 at 10:41:58AM +0530, Kishon Vijay Abraham I wrote: > diff --git a/drivers/pci/endpoint/Kconfig b/drivers/pci/endpoint/Kconfig > index a6d827c..f1dd206 100644 > --- a/drivers/pci/endpoint/Kconfig > +++ b/drivers/pci/endpoint/Kconfig > @@ -13,7 +13,9 @@ config PCI_ENDPOINT > >

Re: [RFC PATCH 00/11] pci: support for configurable PCI endpoint

2016-10-12 Thread Christoph Hellwig
On Mon, Sep 26, 2016 at 11:38:41AM +0530, Kishon Vijay Abraham I wrote: > > Ok, so in theory there can be other hardware (and quite likely is) > > that supports multiple functions, and we can extend the framework > > to support them without major obstacles, but your hardware doesn't, > > so you kep

Re: [RFC PATCH 01/11] pci: endpoint: add EP core layer to enable EP controller and EP functions

2016-10-12 Thread Christoph Hellwig
> +/** > + * pci_epc_stop() - stop the PCI link > + * @epc: the link of the EPC device that has to be stopped > + * > + * Invoke to stop the PCI link > + */ > +void pci_epc_stop(struct pci_epc *epc) > +{ > + if (IS_ERR(epc) || !epc->ops->stop) > + return; > + > + spin_lock_irq(&

Re: [RFC PATCH-tip v4 02/10] locking/rwsem: Stop active read lock ASAP

2016-10-10 Thread Christoph Hellwig
On Mon, Oct 10, 2016 at 05:07:45PM +1100, Dave Chinner wrote: > > > *However*, the DAX IO path locking in XFS has changed in 4.9-rc1 to > > > match the buffered IO single writer POSIX semantics - the test is a > > > bad test based on the fact it exercised a path that is under heavy > > > developme

Re: [RFC PATCH-tip v4 02/10] locking/rwsem: Stop active read lock ASAP

2016-10-09 Thread Christoph Hellwig
On Fri, Oct 07, 2016 at 08:47:51AM +1100, Dave Chinner wrote: > Except that it's DAX, and in 4.7-rc1 that used shared locking at the > XFS level and never took exclusive locks. > > *However*, the DAX IO path locking in XFS has changed in 4.9-rc1 to > match the buffered IO single writer POSIX sema

Re: [PATCH] printk: introduce kptr_restrict level 3

2016-10-06 Thread Christoph Hellwig
On Thu, Oct 06, 2016 at 01:47:47PM +, Roberts, William C wrote: > Out of tree modules still affect core kernel security. So don't use them. > I would also bet money, that somewhere > In-tree someone has put a %p when they wanted a %pK. So fix them. > So this method is just quite error > pro

Re: [PATCH] printk: introduce kptr_restrict level 3

2016-10-06 Thread Christoph Hellwig
On Wed, Oct 05, 2016 at 02:04:46PM -0400, william.c.robe...@intel.com wrote: > From: William Roberts > > Some out-of-tree modules do not use %pK and just use %p, as it's > the common C paradigm for printing pointers. Because of this, > kptr_restrict has no affect on the output and thus, no way to

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-04 Thread Christoph Hellwig
FYI, the patches look fine to me: Acked-by: Christoph Hellwig but we're past the merge window for 4.9 now unfortunately. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Christoph Hellwig
On Sun, Sep 11, 2016 at 11:14:09AM -0600, Jason Gunthorpe wrote: > > > We stil always have the common structure first. And at least for > > > cgroups supports that's what matters. > > > > > > Re the actual structures - we'll really need to make sure we > > > > > > a) expose proper userspace abi h

[PATCH] DMA-API-HOWTO: is no more

2016-09-11 Thread Christoph Hellwig
So don't mention it. Signed-off-by: Christoph Hellwig --- Documentation/DMA-API-HOWTO.txt | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt index 781024e..494ffac 100644 --- a/Documentation/DM

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Christoph Hellwig
On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > Sadly, it isn't a step backwards, it is status quo - at least as far > as the uapi is concerned. Sort of, see below: > struct mlx5_create_cq { > struct ibv_create_cqibv_cmd; > __u64

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Christoph Hellwig
On Wed, Sep 07, 2016 at 11:51:42AM +0300, Matan Barak wrote: > All recent proposals of the new ABI schema deals with extending the > flexibility of the current schema by letting drivers define their specific > types, actions, attributes, etc. Even more than that, the dispatching > starts from th

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Christoph Hellwig
On Wed, Sep 07, 2016 at 01:25:13PM +0530, Parav Pandit wrote: > > a) delay cgroups support until the grand rewrite is done > > b) add it now and deal with the consequences later > > > Can we do (b) now and differ adding any HW resources to cgroup until > they are clearly called out. > Architectur

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-01 Thread Christoph Hellwig
On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: > Well, if I recall, the reason doing so last time was in order to allow > flexible updating of ib_core independently, which is obviously not a good > reason (to say the least). > > Since the new ABI will probably define new object type

Re: [PATCHv11 0/3] rdmacg: IB/core: rdma controller support

2016-08-25 Thread Christoph Hellwig
On Wed, Aug 24, 2016 at 05:17:47PM -0400, Tejun Heo wrote: > Looks good to me. I just have a nit in the documentation. Christoph, > what do you think? Looks reasonable from a quick look, but I didn't do a full review yet. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in

Re: [PATCH 03/10] docs: sphinxify sparse.txt and move to dev-tools

2016-08-18 Thread Christoph Hellwig
On Thu, Aug 18, 2016 at 05:46:30PM -0600, Jonathan Corbet wrote: > So would the old hats be happier with a patch that looks like this? The > quality of the formatted output suffers slightly, but it's not a big > deal... I think this a major improvement. The only thing that still strikes me as ra

Re: [PATCH 03/10] docs: sphinxify sparse.txt and move to dev-tools

2016-08-09 Thread Christoph Hellwig
On Tue, Aug 09, 2016 at 10:28:38AM +0200, Daniel Vetter wrote: > The point is to make the docs more discoverable by being able to > cross-link them. Old hats like us don't need that, but it definitely > has value in bringing new folks on board. But do that in a way that keeps the old hats happy.

Re: [PATCH 03/10] docs: sphinxify sparse.txt and move to dev-tools

2016-08-09 Thread Christoph Hellwig
On Tue, Aug 09, 2016 at 11:19:50AM +0300, Jani Nikula wrote: > On Tue, 09 Aug 2016, Christoph Hellwig wrote: > > The ugly format is a major regression over a proper simple text > > file. What's the point? > > Major regression? Please be reasonable. > > I think t

Re: [PATCH 03/10] docs: sphinxify sparse.txt and move to dev-tools

2016-08-09 Thread Christoph Hellwig
The ugly format is a major regression over a proper simple text file. What's the point? -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] DMA-API-HOWTO: is no more

2016-07-11 Thread Christoph Hellwig
So don't mention it. Signed-off-by: Christoph Hellwig --- Documentation/DMA-API-HOWTO.txt | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt index 781024e..494ffac 100644 --- a/Documentation/DM

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Christoph Hellwig
On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: > _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, > field of the struct page, to _refcount") broke kdump. makedumpfile(8) does > stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While > it

Re: [PATCH] Add kernel parameter to blacklist modules

2016-06-14 Thread Christoph Hellwig
On Mon, Jun 13, 2016 at 08:32:41AM -0400, Prarit Bhargava wrote: > Blacklisting a module in linux has long been a problem. The process of > blacklisting a module has changed over time, and it seems that every OS > does it slightly differently and depends on the age of the init system > used on tha

  1   2   >