On Sep 03 2024, Benjamin Tissoires wrote:
> On Sep 03 2024, Peter Hutterer wrote:
> > On Tue, Sep 03, 2024 at 01:14:34AM +0900, Benjamin Tissoires wrote:
> > > The use case is when we fix a device through HID-BPF, 99% of the cases
> > > we want the device to use h
On Sep 03 2024, Peter Hutterer wrote:
> On Tue, Sep 03, 2024 at 01:14:36AM +0900, Benjamin Tissoires wrote:
> > We make struct hid_device_id writeable and use the .driver_data field
> > of hid-generic as the connect mask.
>
> I think this needs to be spelled out a bit more:
On Sep 03 2024, Peter Hutterer wrote:
> On Tue, Sep 03, 2024 at 01:14:34AM +0900, Benjamin Tissoires wrote:
> > The use case is when we fix a device through HID-BPF, 99% of the cases
> > we want the device to use hid-generic now instead of a dedicated device.
>
> s/dedic
hat
> has a lot of "?" instead of the proper UTF-8 characters that
> are produced by the tree command.
>
> At its new index.rst, let's add a :orphan: while this is not linked to
> the main index.rst file, in order to avoid build warnings.
>
> Signed-off-by:
hat
> has a lot of "?" instead of the proper UTF-8 characters that
> are produced by the tree command.
>
> At its new index.rst, let's add a :orphan: while this is not linked to
> the main index.rst file, in order to avoid build warnings.
>
> Signed-off-by: Mauro Car
On Apr 11 2017 or thereabouts, Mauro Carvalho Chehab wrote:
> Some mice have a switch on their wheel, allowing to switch
> between ratchet and free wheel mode. Add support for it.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
Patches 1 to 3 are:
Acked-by: Benjamin Tissoires
C
On Apr 07 2017 or thereabouts, Mauro Carvalho Chehab wrote:
> Em Fri, 7 Apr 2017 14:17:51 +0200
> Benjamin Tissoires escreveu:
>
> > Hi Mauro,
> >
> > On Apr 07 2017 or thereabouts, Mauro Carvalho Chehab wrote:
> > > As some devices can produce either low-
Hi Mauro,
On Apr 07 2017 or thereabouts, Mauro Carvalho Chehab wrote:
> As some devices can produce either low-res or high-res
> vertical wheel EV_REL events, add a new event to allow
> userspace to distinguish between them.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/input/e
On Oct 10 2016 or thereabouts, Dmitry Torokhov wrote:
> Hi Benjamin,
>
> On Mon, Oct 10, 2016 at 9:42 AM, Benjamin Tissoires
> wrote:
> > The Thinkpad series 13 uses Host Notify to report the interrupt.
> > Add elan_smb_alert() to handle those interrupts and disable the
just revert this commit and data should
be available.
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
new in v2
---
drivers/i2c/busses/i2c-i801.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busse
ff-by: Benjamin Tissoires
---
new in v4
---
Documentation/i2c/smbus-protocol | 10 ++--
drivers/i2c/busses/i2c-i801.c| 31 +++
drivers/i2c/i2c-core.c | 117 +++
drivers/i2c/i2c-smbus.c | 102 --
include/
No functional changes, just typos and remove unused #define.
Reviewed-by: Jean Delvare
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/i2c/busses/i2c-i801.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a
i801 mixes hexadecimal and decimal values for defining bits. However,
we have a nice BIT() macro for this exact purpose.
No functional changes, cleanup only.
Reviewed-by: Jean Delvare
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/i2c
Also do not override any other configuration in this register.
Signed-off-by: Benjamin Tissoires
---
changes in v4:
- add the i801_disable_host_notify function here as this gets the
first in the series
no changes in v3
new in v2
---
drivers/i2c/busses/i2c-i801.c | 17 -
1
The Thinkpad series 13 uses Host Notify to report the interrupt.
Add elan_smb_alert() to handle those interrupts and disable the irq
handling on this case.
Signed-off-by: Benjamin Tissoires
---
new in v4 (was submitted on linux-input with the .alert callback)
---
drivers/input/mouse
no functional changes
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
new in v2
---
drivers/i2c/busses/i2c-i801.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index
And make sure we have one available.
Signed-off-by: Benjamin Tissoires
---
new in v4
---
drivers/input/mouse/elan_i2c_core.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/mouse
i2c (trackstick and binding from PS/2) so maybe this might not be the
best solution to have the I2C tree taking the changes.
Also, if this gets merged, that would mean for RMI4, only the HID backend
will not be using IRQ, but we could do the same IRQ reporting than here.
Cheers,
Benjamin
Benjam
On Jul 18 2016 or thereabouts, Jean Delvare wrote:
> Hi Benjamin, Wolfram,
>
> Now that I have reviewed the i2c-i801 part of the implementation, I'm
> wondering...
>
> On Thu, 9 Jun 2016 16:53:48 +0200, Benjamin Tissoires wrote:
> > +/**
> > + * i2c_setup
e time to look at
> the patches. Looks good overall, with just two minor comments:
>
> On jeu., 2016-06-09 at 16:53 +0200, Benjamin Tissoires wrote:
> > SMBus Host Notify allows a slave device to act as a master on a bus to
> > notify the host of an interrupt. On Intel chipsets, t
On Jun 24 2016 or thereabouts, Dmitry Torokhov wrote:
> On Fri, Jun 24, 2016 at 09:19:32AM +0200, Benjamin Tissoires wrote:
> > On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote:
> > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote:
> > >
On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote:
> Hi Benjamin,
>
> On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote:
> > +
> > +struct mapping_table_entry {
> > + u16 rmiaddr;
>
> Should be __le16 rmiaddr, otherwise:
>
>
On Jun 16 2016 or thereabouts, Wolfram Sang wrote:
> > > - removed the .resume hook as upstream changed suspend/resume hooks and
> > > there
> > > is no need in the end to re-enable host notify on resume (tested on
> > > Lenovo
> > > t440 and t450).
> >
> > Actually, this hook seemed to be r
On Jun 09 2016 or thereabouts, Benjamin Tissoires wrote:
> The i801 chip can handle the Host Notify feature since ICH 3 as mentioned
> in
> http://www.intel.com/content/dam/doc/datasheet/82801ca-io-controller-hub-3-datasheet.pdf
>
> Enable the functionality unconditionally an
itted with the use of this "new"
feature.
Cheers,
Benjamin
Benjamin Tissoires (4):
i2c: add a protocol parameter to the alert callback
i2c-smbus: add SMBus Host Notify support
i2c: i801: add support of Host Notify
Input: synaptics-rmi4 - add SMBus support
Documentation/i2c/
implements Host Notify, the
payload data is always 0x, so I am not sure if the device actually
sends the payload or if there is a problem regarding the implementation.
Tested-by: Andrew Duggan
Acked-by: Wolfram Sang
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- removed the
: Benjamin Tissoires
---
changes in v2:
- do the actual processing of finding the device in i2c-smbus.c
- remove the i2c-core implementations
- remove the manual toggle of SMBus Host Notify
no changes in v3
changes in v4:
- schedule the worker in i2c_handle_smbus_host_notify() -> it can now be cal
through .alert().
Tested-by: Andrew Duggan
For hwmon:
Acked-by: Guenter Roeck
For IPMI:
Acked-by: Corey Minyard
Signed-off-by: Benjamin Tissoires
---
new in v2
changes in v3:
- added also lm90.c to support the new API
no changes in v4
no changes in v5
changes in v6:
- made sure lm90 also
Code obtained from
https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c
and updated to match upstream. And fixed to make it work.
Signed-off-by: Benjamin Tissoires
Signed-off-by: Andrew Duggan
---
new in v5
no changes in v6
changes in v7:
- fixed
Hi Wolfram,
On Jun 05 2016 or thereabouts, Wolfram Sang wrote:
> Hi Benjamin,
>
> > this is mostly a resubmission of the v6 with the acks, tested-by and few
> > typos
> > here and there.
>
> I actually reviewed v6 but got an NMI so writing the mails fell through
> the cracks :( Sorry about that
jamin
Benjamin Tissoires (4):
i2c: add a protocol parameter to the alert callback
i2c-smbus: add SMBus Host Notify support
i2c: i801: add support of Host Notify
Input: synaptics-rmi4 - add SMBus support
Documentation/i2c/smbus-protocol | 3 +
drivers/char/ipmi/ipmi_ssif.c
through .alert().
Tested-by: Andrew Duggan
For IPMI:
Acked-by: Corey Minyard
Signed-off-by: Benjamin Tissoires
---
new in v2
changes in v3:
- added also lm90.c to support the new API
no changes in v4
no changes in v5
changes in v6:
- made sure lm90 also checks for the type of alert first
no
implements Host Notify, the
payload data is always 0x, so I am not sure if the device actually
sends the payload or if there is a problem regarding the implementation.
Tested-by: Andrew Duggan
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- removed the description of the Slave
: Benjamin Tissoires
---
changes in v2:
- do the actual processing of finding the device in i2c-smbus.c
- remove the i2c-core implementations
- remove the manual toggle of SMBus Host Notify
no changes in v3
changes in v4:
- schedule the worker in i2c_handle_smbus_host_notify() -> it can now be cal
Code obtained from
https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c
and updated to match upstream. And fixed to make it work.
Signed-off-by: Benjamin Tissoires
Signed-off-by: Andrew Duggan
---
new in v5
no changes in v6
changes in v7:
- fixed
Hi,
On Mar 16 2016 or thereabouts, Benjamin Tissoires wrote:
> Hi,
>
> this is a quick respin of the series with the kbuild test bot fixes and the
> requested lm90 change.
>
> Again, I think applying the RMI4 input driver needs the merge of the input
> tree
> in
implements Host Notify, the
payload data is always 0x, so I am not sure if the device actually
sends the payload or if there is a problem regarding the implementation.
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- removed the description of the Slave functionality support in the
Code obtained from
https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c
and updated to match upstream. And fixed to make it work.
Signed-off-by: Benjamin Tissoires
Signed-off-by: Andrew Duggan
---
new in v5
no changes in v6
drivers/input/rmi4
Hi,
this is a quick respin of the series with the kbuild test bot fixes and the
requested lm90 change.
Again, I think applying the RMI4 input driver needs the merge of the input tree
in master first, but having reviews on the Host Notify implementation would be
good.
Cheers,
Benjamin
Benjamin
() behaves like i2c_handle_smbus_alert().
When called, it schedules a task that will be able to sleep to go through
the list of devices attached to the adapter.
The current implementation allows one Host Notification to be scheduled
while an other is running.
Signed-off-by: Benjamin Tissoires
through .alert().
Signed-off-by: Benjamin Tissoires
---
new in v2
changes in v3:
- added also lm90.c to support the new API
no changes in v4
no changes in v5
changes in v6:
- made sure lm90 also checks for the type of alert first
drivers/char/ipmi/ipmi_ssif.c | 6 +-
drivers/hwmon/lm90.c
On Mar 15 2016 or thereabouts, Guenter Roeck wrote:
> On Tue, Mar 15, 2016 at 03:53:41PM +0100, Benjamin Tissoires wrote:
> > .alert() is meant to be generic, but there is currently no way
> > for the device driver to know which protocol generated the alert.
> > Add a paramete
through .alert().
Signed-off-by: Benjamin Tissoires
---
drivers/char/ipmi/ipmi_ssif.c | 6 +-
drivers/hwmon/lm90.c | 3 ++-
drivers/i2c/i2c-smbus.c | 3 ++-
include/linux/i2c.h | 7 ++-
4 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/char/ipmi
() behaves like i2c_handle_smbus_alert().
When called, it schedules a task that will be able to sleep to go through
the list of devices attached to the adapter.
The current implementation allows one Host Notification to be scheduled
while an other is running.
Signed-off-by: Benjamin Tissoires
. It would be good if we could have a
review for the smbus part so we can finally switch the Synaptics devices
into a better reporting mode where they report 5 true fingers.
Cheers,
Benjamin
[1] http://thread.gmane.org/gmane.linux.drivers.i2c/23899/focus=2044469
Benjamin Tissoires (4):
i2c: add
implements Host Notify, the
payload data is always 0x, so I am not sure if the device actually
sends the payload or if there is a problem regarding the implementation.
Signed-off-by: Benjamin Tissoires
---
drivers/i2c/busses/i2c-i801.c | 85 +--
1 file
Code obtained from
https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c
and updated to match upstream. And fixed to make it work.
Signed-off-by: Benjamin Tissoires
Signed-off-by: Andrew Duggan
---
drivers/input/rmi4/Kconfig | 12 ++
drivers
47 matches
Mail list logo
