On 9/11/19 9:37 PM, André Almeida wrote:
> +/**
> + * scsi_queue_insert - Insert a command in the midlevel queue.
> + * @cmd:command that we are adding to queue.
> + * @reason: why we are inserting command to queue.
> *
> - * Returns: Nothing.
> + * We do this for one of two cases. Either
On 9/11/19 9:37 PM, André Almeida wrote:
> Remove all trailing whitespaces from scsi_lib.c
I don't like patches that only change whitespace if no significant
functional changes are included in the same patch series. Such patches
namely pollute the change history, make the output of git log -p and
imize dependencies on the version of emacs that is being used.
I have verified with several large and nontrivial kernel source files
that the new settings format code according to what checkpatch expects.
Signed-off-by: Bart Van Assche
Cc: Matthew Wilcox
Cc: Jani Nikula
Cc: Alison Chaiken
Cc
On 1/5/19 11:58 AM, Alison Chaiken wrote:
On 2019-01-04 14:39, Bart Van Assche wrote:
As a general comment, I personally think that it worth to mention the
fact
that the user can take this code (actually part of it) and put it in
a .dir-
locals.el file in the top-level directory.
I'
On Fri, 2019-01-04 at 23:10 +0100, Federico Vaga wrote:
> On Friday, January 4, 2019 10:08:33 PM CET Bart Van Assche wrote:
> > In emacs 23.1 support for directory-local variables was added (see also
> > https://lists.gnu.org/archive/html/info-gnu-emacs/2009-07/msg0.html).
&
On Fri, 2019-01-04 at 13:08 -0800, Bart Van Assche wrote:
> For new kernel developers who use emacs it is tedious to follow the
> instructions in Documentation/process/coding-style.rst for configuring
> [ ... ]
Please ignore this patch - this is the old version (v1). The other patch,
the
imize dependencies on the version of emacs that is being used.
I have verified with several large and nontrivial kernel source files
that the new settings format code according to what checkpatch expects.
Signed-off-by: Bart Van Assche
Cc: Matthew Wilcox
Cc: Geyslan G. Bem
Cc: Tiago Natel de Mour
Italian and Chinese translations of the modified paragraphs have
been generated by Google Translate.
Signed-off-by: Bart Van Assche
Cc: Geyslan G. Bem
Cc: Tiago Natel de Moura
Cc: Alison Chaiken
Cc: Joe Perches
Cc: Federico Vaga
Cc: Zhang Le
Cc: Li Yang
---
.dir-locals.el
On Fri, 2019-01-04 at 13:18 +0200, Jani Nikula wrote:
> Also, you probably do not wish the file to change when you switch
> branches with different upstream baselines. Or deal with possible emacs
> version dependent changes. I do like having the example in the kernel
> tree, but let the users deal
On Fri, 2019-01-04 at 10:44 +0100, Federico Vaga wrote:
> On Friday, January 4, 2019 1:39:57 AM CET Bart Van Assche wrote:
> > For new kernel developers who use emacs it is tedious to follow the
> > instructions in Documentation/process/coding-style.rst for configuring
> >
On Thu, 2019-01-03 at 18:12 -0800, Matthew Wilcox wrote:
> On Thu, Jan 03, 2019 at 04:39:57PM -0800, Bart Van Assche wrote:
> > @@ -571,50 +571,11 @@ item, explaining its use.
> > 9) You've made a mess of it
> > ---
> >
> > -That&
Italian and Chinese translations of the modified paragraphs have
been generated by Google Translate.
Signed-off-by: Bart Van Assche
Cc: Geyslan G. Bem
Cc: Tiago Natel de Moura
Cc: Alison Chaiken
Cc: Joe Perches
Cc: Federico Vaga
Cc: Zhang Le
Cc: Li Yang
---
.dir-locals.el
On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote:
> When the drive closes it can take tens of seconds until the disc is
> analyzed. Wait for the drive to become ready or report an error.
>
> Signed-off-by: Michal Suchanek
> ---
> drivers/cdrom/cdrom.c | 9 +
> 1 file changed, 9 i
On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote:
> +static int cdrom_tray_close(struct cdrom_device_info *cdi)
> +{
> + int ret;
> +
> + ret = cdi->ops->tray_move(cdi, 0);
> + if (ret || !cdi->ops->drive_status)
> + return ret;
> +
> + return poll_event_interrup
On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote:
> - ret=cdo->tray_move(cdi,0);
> + ret = cdo->tray_move(cdi, 0);
Please separate whitespace-only changes from functional changes such that
this patch series becomes easier to review.
On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote:
> Add convenience macro for polling an event that does not have a
> waitqueue.
>
> Signed-off-by: Michal Suchanek
> ---
> include/linux/delay.h | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/delay.h
On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote:
> On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote:
>
> > > Today when we run checkers we get so many warnings it is too hard to
> > > make any sense of it.
> >
> > Here is a list of the checkpatch messages for drivers/infiniban
On Thu, 2017-08-24 at 16:11 -0600, Jonathan Corbet wrote:
> /**
> * scsi_initialize_rq - initialize struct scsi_cmnd.req
> + * @rq: Request used to locate the scsi_cmnd structure.
> *
> * Called from inside blk_get_request().
> */
Since the request structure and the SCSI command structure
gt; all
> * hardware supports 64-bit addresses for consistent allocations
Thanks Jonathan for this patch.
Reviewed-by: Bart Van Assche
On 11/19/16 09:15, Jonathan Corbet wrote:
> Might there be a tool or an extension out there that would allow us
> to express these diagrams in a text-friendly, editable form?
How about using the graphviz languages for generating diagrams that can
be described easily in one of the graphviz langua
On 06/01/2016 07:36 AM, Kevin Groeneveld wrote:
Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of
->host_failed
I wonder if this could be related to
http://www.spinics.net/lists/linux-scsi/msg86808.html?
I never did get to the bottom of that. If I have time I hope to
21 matches
Mail list logo
