Re: [PATCH 2/2 v5] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo

2019-01-06 Thread Baoquan He
On 01/07/19 at 09:47am, Lianbo Jiang wrote: > For AMD machine with SME feature, makedumpfile tools need to know > whether the crash kernel was encrypted or not. If SME is enabled ^ crashed > in the first kernel, the crash kernel's page table(pgd/pud/pmd/pte)

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Baoquan He
On 11/19/18 at 11:16am, David Hildenbrand wrote: > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 933cb3e45b98..093c9f917ed0 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -464,6 +464,8 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_NUM

Re: [PATCH 4/3 v2] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-08 Thread Baoquan He
On 10/09/18 at 08:35am, Baoquan He wrote: > Hi Andy, Ingo > > On 10/06/18 at 03:17pm, Andy Lutomirski wrote: > > On Sat, Oct 6, 2018 at 10:03 AM Ingo Molnar wrote: > > > ... but unless I'm missing something it's not really fundamental for it > > > to

Re: [PATCH 4/3 v2] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-08 Thread Baoquan He
Hi Andy, Ingo On 10/06/18 at 03:17pm, Andy Lutomirski wrote: > On Sat, Oct 6, 2018 at 10:03 AM Ingo Molnar wrote: > > ... but unless I'm missing something it's not really fundamental for it to > > be at the PGD level > > - it could be two levels lower as well, and it could move back to the same

Re: [PATCH 4/3 v2] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-06 Thread Baoquan He
ly how incredibly large 64-bit address space is. Thanks, this looks much better than the old version and my change. Reviewed-by: Baoquan He Thanks Baoquan > + > +==

Re: [PATCH 4/3] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-06 Thread Baoquan He
On 10/06/18 at 02:33pm, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > + > > +| Complete virtual memory map with 4-level page tables | > > + > > > +

Re: [PATCH 0/3] x86/mm/doc: Clean up mm.txt

2018-10-06 Thread Baoquan He
On 10/06/18 at 04:43pm, Baoquan He wrote: > This clean up is suggested by Ingo. > > It firstly fix the confusions in mm layout tables by unifying > each memory region description in the consistent style. > > Secondly take the KASLR words out of the mm layout tables to make

[PATCH 1/3] x86/KASLR: Update KERNEL_IMAGE_SIZE description

2018-10-06 Thread Baoquan He
Currently CONFIG_RANDOMIZE_BASE=y is set by default, which makes some of the old comments above the KERNEL_IMAGE_SIZE definition out of date. Update them to the current state of affairs. Signed-off-by: Baoquan He --- arch/x86/include/asm/page_64_types.h | 15 +-- 1 file changed, 9

[PATCH 0/3] x86/mm/doc: Clean up mm.txt

2018-10-06 Thread Baoquan He
me typo and incorrect descriptions found in v1 post. Baoquan He (3): x86/KASLR: Update KERNEL_IMAGE_SIZE description x86/mm/doc: Clean up the memory region layout descriptions x86/doc/kaslr.txt: Create a separate part of document abourt KASLR at the end of file Documentation/x86/x8

[PATCH 2/3] x86/mm/doc: Clean up the memory region layout descriptions

2018-10-06 Thread Baoquan He
line So fix them to make them in consistent style. Signed-off-by: Baoquan He --- Documentation/x86/x86_64/mm.txt | 84 - 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/Documentation/x86/x86_64/mm.txt b/Documentation/x86/x86_64/mm.tx

[PATCH 3/3] x86/doc/kaslr.txt: Create a separate part of document abourt KASLR at the end of file

2018-10-06 Thread Baoquan He
Take the original content as the first part to only list static mm layout tables in non-KASLR case. Then add KASLR related description at the end. Signed-off-by: Baoquan He --- Documentation/x86/x86_64/mm.txt | 64 +++-- 1 file changed, 55 insertions(+), 9

Re: [PATCH v2 2/3] x86/mm/doc: Clean up the memory region layout descriptions

2018-10-03 Thread Baoquan He
On 10/02/18 at 11:14am, Ingo Molnar wrote: > > * Baoquan He wrote: > > -8000 - 9fff (=512 MB) kernel text mapping, from > > phys 0 > > -a000 - feff (1520 MB) module mapping space > > +fe00 -

Re: [PATCH v2 1/3] x86/KASLR: Update document about KERNEL_IMAGE_SIZE

2018-10-03 Thread Baoquan He
On 10/03/18 at 09:52am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > Currently CONFIG_RANDOMIZE_BASE=y is default set, update the relevant > > document about KERNEL_IMAGE_SIZE. > > Suggested wording: > > x86/KASLR: Update KERNEL_IMAGE_SI

Re: [PATCH 0/3] x86/mm/doc: Clean up mm.txt

2018-09-26 Thread Baoquan He
On 09/21/18 at 10:05am, Baoquan He wrote: > This clean up is suggested by Ingo. This series is messy, have sent v2. So NACK this v1 series. > > It firstly fix the confusions in mm layout tables by unifying > each memory region description in the consistent style. > > Secon

[PATCH v2 2/3] x86/mm/doc: Clean up the memory region layout descriptions

2018-09-26 Thread Baoquan He
line So fix them to make them in consistent style. Signed-off-by: Baoquan He --- Documentation/x86/x86_64/mm.txt | 76 - 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/Documentation/x86/x86_64/mm.txt b/Documentation/x86/x86_64/mm.tx

[PATCH v2 1/3] x86/KASLR: Update document about KERNEL_IMAGE_SIZE

2018-09-26 Thread Baoquan He
Currently CONFIG_RANDOMIZE_BASE=y is default set, update the relevant document about KERNEL_IMAGE_SIZE. Signed-off-by: Baoquan He --- arch/x86/include/asm/page_64_types.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/page_64_types.h b/arch/x86

[PATCH v2 3/3] x86/doc/kaslr.txt: Create a separate part of document abourt KASLR at the end of file

2018-09-26 Thread Baoquan He
Take the original content as the first part to only list static mm layout tables in non-KASLR case. Then add KASLR document at the end. Signed-off-by: Baoquan He --- Documentation/x86/x86_64/mm.txt | 64 +++-- 1 file changed, 56 insertions(+), 8 deletions

[PATCH v2 0/3] x86/mm/doc: Clean up mm.txt

2018-09-26 Thread Baoquan He
KASLR document at the end of mm.txt. Meanwhile update document about KERNEL_IMAGE_SIZE in arch/x86/include/asm/page_64_types.h . v1->v2: Resend v2 since some typo and incorrect descriptions found in v1 post. Baoquan He (3): x86/KASLR: Update document about KERNEL_IMAGE_SIZE x86/mm/doc: Cl

Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.

2017-08-21 Thread Baoquan He
On 08/17/17 at 10:14pm, Michal Suchanek wrote: > Remove quotes from argument value only if there is qoute on both sides. > > Signed-off-by: Michal Suchanek Sounds reasonable. Just for curiosity, do we have chance to pass in option with a single '"'? > --- > arch/powerpc/kernel/fadump.c | 6 ++-

Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-17 Thread Baoquan He
On 05/18/17 at 11:03am, Bharat Bhushan wrote: > This patch have minor updates in Documentation for arm64i as > relocatable kernel. > Also this patch updates documentation for using uncompressed > image "Image" which is used for ARM64. > > Signed-off-by: Bharat Bhushan > --- > Documentation/kdump

[PATCH v3 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description

2017-04-26 Thread Baoquan He
ap=100MG" gets passed to the kernel. Clarify all this. Signed-off-by: Baoquan He Cc: Jonathan Corbet Cc: "Rafael J. Wysocki" Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Bjorn Helgaas Cc: Mauro Carvalho Chehab Cc: linux-doc@vger.kernel.org --- Documentation/admin-guide/kerne

Re: [PATCH v2 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description

2017-04-23 Thread Baoquan He
On 04/24/17 at 11:53am, Dou Liyang wrote: > > > At 04/24/2017 10:40 AM, Baoquan He wrote: > > In commit: > > > > 9710f581bb4c ("x86, mm: Let "memmap=" take more entries one time") > > > > ... 'memmap=' was changed to adopt

[PATCH v2 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description

2017-04-23 Thread Baoquan He
ap=100MG" gets passed to the kernel. Clarify all this. Signed-off-by: Baoquan He Cc: Jonathan Corbet Cc: "Rafael J. Wysocki" Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Bjorn Helgaas Cc: Mauro Carvalho Chehab Cc: linux-doc@vger.kernel.org --- Documentation/admin-guide/kerne

[PATCH 4/4] doc: Update description about memmap option in kernel-parameter.txt

2017-04-17 Thread Baoquan He
equal to mem=nn[KMG], update it too here. And for memmap=nn[KMG]$ss[KMG], escape character need be added before '$' for some bootloaders. E.g in grub2, if specified memmap=100M$5G, actually it passed memmap=100MG to kernel. Signed-off-by: Baoquan He Cc: Jonathan Corbet Cc: "Rafael

Re: [PATCH] Add +~800M crashkernel explaination

2016-12-09 Thread Baoquan He
On 12/09/16 at 05:22pm, Robert LeBlanc wrote: > When trying to configure crashkernel greater than about 800 MB, the > kernel fails to allocate memory on x86 and x86_64. This is due to an > undocumented limit that the crashkernel and other low memory items must > be allocated below 896 MB unless the

Re: [PATCH v10 RESEND 0/3] Documentation: Add description of enable multi-cpus support for kdump

2016-09-20 Thread Baoquan He
On 09/20/16 at 06:03pm, Jonathan Corbet wrote: > On Mon, 19 Sep 2016 13:59:46 +0800 > Baoquan He wrote: > > > This is v10 post. In this patchset patch 1/3 is added to give more details > > about nr_cpus and maxcpus in kernel-parameters.txt. This is suggested by > > Jon

[PATCH v10 RESEND 2/3] Documentation: kdump: Remind user of nr_cpus

2016-09-18 Thread Baoquan He
From: Zhou Wenjian nr_cpus can help to save memory. So we should remind user of it. Signed-off-by: Zhou Wenjian Acked-by: Baoquan He Acked-by: Xunlei Pang --- Documentation/kdump/kdump.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/kdump/kdump.txt b/Documentation

[PATCH v10 RESEND 1/3] docs: kernel-parameter : Improve the description of nr_cpus and maxcpus

2016-09-18 Thread Baoquan He
of already plugged cpus and hot plug cpus can't exceed its value. However maxcpus is used to limit how many cpus are allowed to be brought up during bootup. Signed-off-by: Baoquan He --- Documentation/kernel-parameters.txt | 20 +--- 1 file changed, 13 insertions(+), 7 del

[PATCH v10 RESEND 3/3] Documentation: kdump: Add description of enable multi-cpus support

2016-09-18 Thread Baoquan He
From: Zhou Wenjian Multi-cpu support is useful to improve the performance of kdump in some cases. So add the description of enable multi-cpu support in dump-capture kernel. Signed-off-by: Zhou Wenjian Acked-by: Baoquan He Acked-by: Xunlei Pang --- Documentation/kdump/kdump.txt | 7

[PATCH v10 RESEND 0/3] Documentation: Add description of enable multi-cpus support for kdump

2016-09-18 Thread Baoquan He
her change for 2/3 and 3/3 which comprise the old post. Please access below link to check the previous changelog. https://lkml.org/lkml/2016/8/17/646 Baoquan He (1): docs: kernel-parameter : Improve the description of nr_cpus and maxcpus Zhou Wenjian (2): Documentation: kdump: remind user

Re: [PATCH v10 3/3] Documentation: kdump: add description of enable multi-cpus support

2016-09-18 Thread Baoquan He
On 09/19/16 at 12:01pm, Baoquan He wrote: > From: Zhou Wenjian > > Multi-cpu support is useful to improve the performance of kdump in > some cases. So add the description of enable multi-cpu support in > dump-capture kernel. > > Signed-off-by: Zhou Wenjian > Acked-by

[PATCH v10 1/3] docs: kernel-parameter : Improve the description of nr_cpus and maxcpus

2016-09-18 Thread Baoquan He
of already plugged cpus and hot plug cpus can't exceed its value. However maxcpus is used to limit how many cpus are allowed to be brought up during bootup. Signed-off-by: Baoquan He --- Documentation/kernel-parameters.txt | 20 +--- 1 file changed, 13 insertions(+), 7 del

[PATCH v10 2/3] Documentation: kdump: remind user of nr_cpus

2016-09-18 Thread Baoquan He
From: Zhou Wenjian nr_cpus can help to save memory. So we should remind user of it. Signed-off-by: Zhou Wenjian Acked-by: Baoquan He Acked-by: Xunlei Pang Signed-off-by: Baoquan He --- Documentation/kdump/kdump.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/kdump

[PATCH v10 3/3] Documentation: kdump: add description of enable multi-cpus support

2016-09-18 Thread Baoquan He
From: Zhou Wenjian Multi-cpu support is useful to improve the performance of kdump in some cases. So add the description of enable multi-cpu support in dump-capture kernel. Signed-off-by: Zhou Wenjian Acked-by: Baoquan He Acked-by: Xunlei Pang Signed-off-by: Baoquan He --- Documentation

[PATCH v10 0/3] Documentation: add description of enable multi-cpus support for kdump

2016-09-18 Thread Baoquan He
her change for 2/3 and 3/3 which comprise the old post. Please access below link to check the previous changelog. https://lkml.org/lkml/2016/8/17/646 Baoquan He (1): docs: kernel-parameter : Improve the description of nr_cpus and maxcpus Zhou Wenjian (2): Documentation: kdump: remind user

Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus

2016-08-26 Thread Baoquan He
think it's OK. Let's wait for Jon's feekback. > > -- > Thanks > Zhou > > On 08/24/2016 01:06 PM, Baoquan He wrote: > >On 08/22/16 at 09:14am, "Zhou, Wenjian/周文剑" wrote: > >>On 08/19/2016 11:57 PM, Jonathan Corbet wrote: > >>

Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus

2016-08-26 Thread Baoquan He
On 08/25/16 at 01:10pm, Jonathan Corbet wrote: > On Wed, 24 Aug 2016 13:06:45 +0800 > Baoquan He wrote: > > > Hi Jon, do you think change as below is OK to you? > > So nr_cpus is the maximum value, and maxcpus is the current number. > Figures. No wonder the documentat

Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus

2016-08-23 Thread Baoquan He
ified, smp is disabled. I am not very sure why this is introduced, number of possible cpu is decided by the min value of nr_cpus= and possible_cpus=. nr_cpus and maxcpus might not be very clear to people which are described in Documentation/kernel-parameters.txt. Hi Jon, do you think change as below

Re: [PATCH 11/12] kexec: allow architectures to override boot mapping

2016-05-11 Thread Baoquan He
On 04/28/16 at 10:28am, Russell King wrote: > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > index 52a3a221bcb2..99cb9dac7909 100644 > --- a/include/linux/kexec.h > +++ b/include/linux/kexec.h > @@ -318,6 +318,44 @@ int __weak arch_kexec_apply_relocations_add(const > Elf_Ehdr *ehdr,

Re: [PATCH 10/12] kexec: arrange for paddr_vmcoreinfo_note() to return phys_addr_t

2016-05-03 Thread Baoquan He
On 05/03/16 at 11:12am, Russell King - ARM Linux wrote: > On Tue, May 03, 2016 at 12:24:41PM +0800, Baoquan He wrote: > > Could you please help tell why arm PAE kernel can be put above 4G? > > Since the change is related to common code, I am curious about how > > it's so

Re: [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping (x86_64)

2016-05-03 Thread Baoquan He
On 05/02/16 at 02:58pm, Dave Hansen wrote: > On 05/02/2016 02:41 PM, Thomas Garnier wrote: > > Minor change that allows early boot physical mapping of PUD level virtual > > addresses. This change prepares usage of different virtual addresses for > > KASLR memory randomization. It has no impact on d

Re: [PATCH 10/12] kexec: arrange for paddr_vmcoreinfo_note() to return phys_addr_t

2016-05-03 Thread Baoquan He
On 05/03/16 at 11:23am, Pratyush Anand wrote: > Hi Baoquan, > > On 03/05/2016:12:24:41 PM, Baoquan He wrote: > > Hi Pratyush, > > > > Could you please help tell why arm PAE kernel can be put above 4G? > > PAE system can have physical addresses above 4G. So, if

Re: [PATCH 10/12] kexec: arrange for paddr_vmcoreinfo_note() to return phys_addr_t

2016-05-02 Thread Baoquan He
This patch is clearly related to kdump. The prefix of subject should be changed to kdump. Kexec doesn't need to handle vmcore things. And patches realted to kexec/kdump should be CCed to Andrew, he usually picks up and add them into akpm tree. Hi Pratyush, Could you please help tell why arm PAE