0-386d7c3ee...@gmail.com/T/#u
> > [0]
> >
> > Signed-off-by: Tamir Duberstein
>
> I have just quickly tested this before leaving for a week.
> And I am fine with the result.
Seems reasonable to me. But I want a consensus with Rasmus.
--
With Best Regards,
Andy Shevchenko
On Mon, Apr 29, 2024 at 09:35:18AM +0200, Krzysztof Kozlowski wrote:
> On 23/04/2024 15:19, Andy Shevchenko wrote:
> > The recommendation is based on the following rationale:
> >
> > - it makes the commit messages much cleaner and easy to read, especially
> > o
+Cc: Dmitry
(have been told by colleague of mine that you also has an opinion on this
topic, sorry if I added you by a mistake).
On Tue, Apr 23, 2024 at 04:19:36PM +0300, Andy Shevchenko wrote:
> Add a couple of recommendations on how to utilise Cc header in
> environment friendly way.
>
On Tue, Apr 23, 2024 at 08:44:24AM -0600, Jonathan Corbet wrote:
> Andy Shevchenko writes:
>
> >> A lot of patches get sent with
> >> more Cc's in the mail message than in the commit message.
> >
> > Note, this is the recommendation as it's stated.
On Tue, Apr 23, 2024 at 07:37:34PM +0300, Jani Nikula wrote:
> On Tue, 23 Apr 2024, Andy Shevchenko
> wrote:
> > On Tue, Apr 23, 2024 at 05:30:49PM +0300, Jani Nikula wrote:
> >> The Cc's on the mailing list archive are harder to dig up, and do not
> >> accu
On Tue, Apr 23, 2024 at 09:07:09AM -0700, Greg KH wrote:
> On Tue, Apr 23, 2024 at 06:28:44PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 23, 2024 at 08:13:37AM -0700, Greg KH wrote:
> > > On Tue, Apr 23, 2024 at 04:19:38PM +0300, Andy Shevchenko wrote:
> > > > The
On Tue, Apr 23, 2024 at 08:13:37AM -0700, Greg KH wrote:
> On Tue, Apr 23, 2024 at 04:19:38PM +0300, Andy Shevchenko wrote:
> > The recommendation is based on the following rationale:
> >
> > - it makes the commit messages much cleaner and easy to read, especially
> &
On Tue, Apr 23, 2024 at 05:30:49PM +0300, Jani Nikula wrote:
> On Tue, 23 Apr 2024, Andy Shevchenko
> wrote:
> > The recommendation is based on the following rationale:
> >
> > - it makes the commit messages much cleaner and easy to read, especially
> > on the
Add a couple of recommendations on how to utilise Cc header in
environment friendly way.
Andy Shevchenko (2):
Documentation: process: Avoid unneeded Cc: tags
Documentation: process: Recommend to put Cc: tags after cutter '---'
line
Documentation/process/5.Posting.rst
automation
they will be still available via mail archives, such as
https://lore.kernel.org, assuming the Link: or Message-ID tag is
provided.
Let's be environment friendly and save the planet!
Signed-off-by: Andy Shevchenko
---
Documentation/process/5.Posting.rst
Add a note that explains that Cc: email header is implied by other
tags, such as Reviewed-by:. In this case an explicit Cc: is _not_
needed.
Signed-off-by: Andy Shevchenko
---
Documentation/process/5.Posting.rst | 4 +++-
Documentation/process/submitting-patches.rst | 5 -
2 files
h Best Regards,
Andy Shevchenko
return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpu_enabled_mask));
> +}
> +static DEVICE_ATTR(enabled, 0444, print_cpus_enabled, NULL);
Hmm... DEVICE_ATTR_RO() ?
--
With Best Regards,
Andy Shevchenko
On Wed, Oct 16, 2019 at 5:52 PM Petr Mladek wrote:
>
> On Wed 2019-10-16 16:49:41, Andy Shevchenko wrote:
> > On Tue, Oct 15, 2019 at 10:07 PM Rasmus Villemoes
> > wrote:
> >
> > > +const char *errname(int err)
> > > +{
> > > +
return NULL;
> +
> + return err > 0 ? name + 1 : name;
> +}
--
With Best Regards,
Andy Shevchenko
On Sat, Oct 12, 2019 at 8:17 PM Jonathan Neuschäfer
wrote:
>
> This document describes how an admin can use the dell_rbu driver, rather
> than any in-kernel API details.
Acked-by: Andy Shevchenko
> Signed-off-by: Jonathan Neuschäfer
> ---
> Documentation/{driver-
On Thu, Sep 19, 2019 at 04:06:20PM +0200, Rasmus Villemoes wrote:
> No users left.
There are in linux-next.
NAK.
--
With Best Regards,
Andy Shevchenko
r == EDQUOT) /* 1133 */
> + return "EDQUOT";
> + return NULL;
> +}
> + long err = PTR_ERR(ptr);
> + const char *sym = errcode(-err);
Do we need additional sign change if we already have such check inside
errcode()?
--
With Best Regards,
Andy Shevchenko
char%d or %x
> + short int %d or %x
> + s8 %d or %x
> + s16 %d or %x
This is incorrect. Integral promotions promotes also sign, which will
produce too many f:s.
--
With Best Regards,
Andy Shevchenko
On Tue, Aug 13, 2019 at 04:45:36PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 13, 2019 at 05:42:22PM +0300, Andy Shevchenko wrote:
> > On Wed, Jun 19, 2019 at 05:19:55PM +0300, Andy Shevchenko wrote:
> > > After the commit cf65a0f6f6ff
> > >
> > > ("
t makes sense only for debug where the user is supposed to be
developer and thus needs anyway to know code base better than average.
--
With Best Regards,
Andy Shevchenko
might not like mass and "blind" code
> > changes. Some might not like the output at all.
>
> I don't intend to mass convert existing code. I would restrict myself to
> updating the documentation and then maybe send a patch per subsystem as an
> example to let maintainers know and judge for themselves if they like it or
> not. And if it doesn't get picked up, we can just remove the feature again
> next
> year (or so).
>
> I dropped the example conversion, I think the idea should be clear now
> even without an explicit example.
>
Hold on, can you in less than 20 words put WHY this is needed?
--
With Best Regards,
Andy Shevchenko
> + if (copy > end - buf)
> + copy = end - buf;
> + buf = memcpy(buf, errname, copy);
> +
> + return buf + errnamelen;
> +}
> +
> static noinline_for_stack
> char *special_hex_number(char *buf, char *end, unsigned long long num, int
> size)
> {
> @@ -2566,7 +2752,12 @@ int vsnprintf(char *buf, size_t size, const char *fmt,
> va_list args)
> num = va_arg(args, unsigned int);
> }
>
> - str = number(str, end, num, spec);
> + if (spec.type == FORMAT_TYPE_INT && *fmt == 'E') {
> + fmt++;
> + str = errstr(str, end, num, spec);
> + } else {
> + str = number(str, end, num, spec);
> + }
> }
> }
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
On Wed, Jun 19, 2019 at 05:19:55PM +0300, Andy Shevchenko wrote:
> After the commit cf65a0f6f6ff
>
> ("dma-mapping: move all DMA mapping code to kernel/dma")
>
> some of the files are referring to outdated information, i.e. old file names
> of DMA mapping sources.
On Tue, Aug 13, 2019 at 03:19:12PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 12, 2019 at 03:13:17PM -0600, Jonathan Corbet wrote:
> > On Mon, 12 Aug 2019 19:06:31 +0300
> > Andy Shevchenko wrote:
> >
> > > In C is a valid construction to have an anonymous enum
On Mon, Aug 12, 2019 at 03:13:17PM -0600, Jonathan Corbet wrote:
> On Mon, 12 Aug 2019 19:06:31 +0300
> Andy Shevchenko wrote:
>
> > In C is a valid construction to have an anonymous enumerator.
> >
> > Though we have now:
> >
> > drivers/pinctrl/i
In C is a valid construction to have an anonymous enumerator.
Though we have now:
drivers/pinctrl/intel/pinctrl-intel.c:240: error: Cannot parse enum!
Support it in the kernel-doc script.
Signed-off-by: Andy Shevchenko
---
scripts/kernel-doc | 2 +-
1 file changed, 1 insertion(+), 1
t yet
> implemented.
Acked-by: Andy Shevchenko
> driver-api/nvdimm/btt:: nested tables are not yet implemented.
> s390/debugging390:: nested tables are not yet implemented.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documenta
+F: drivers/platform/x86/intel_speed_select_if/
> > +F: tools/power/x86/intel-speed-select/
> > +F: include/uapi/linux/isst_if.h
> > +
> > INTEL TELEMETRY DRIVER
> > M: Rajneesh Bhardwaj
> > M: "David E. Box"
> >
>
>
>
>
--
With Best Regards,
Andy Shevchenko
On Tue, Jul 2, 2019 at 5:42 PM Len Brown wrote:
>
> Acked-by: Len Brown
>
Thanks!
I hope this is applicable for v2.
> On Sat, Jun 29, 2019 at 10:31 AM Andy Shevchenko
> wrote:
> >
> > On Thu, Jun 27, 2019 at 1:39 AM Srinivas Pandruvada
> > wrote:
>
Added entry to tools/build/Makefile
> - Rename directory to match the executable name
> - Fix one error message
Thanks!
I pushed to my review and testing queue, while still waiting for some ACKs.
It seems I can promote the driver itself now,w/o tools, if you want me to do so.
--
With Best Regards,
Andy Shevchenko
On Sat, Jun 29, 2019 at 5:53 PM Srinivas Pandruvada
wrote:
> On Sat, 2019-06-29 at 17:31 +0300, Andy Shevchenko wrote:
> > On Thu, Jun 27, 2019 at 1:39 AM Srinivas Pandruvada
> > wrote:
> > I need an Ack from tools/power maintainer(s) for this.
> > Also see below.
>
On Sat, Jun 29, 2019 at 5:53 PM Srinivas Pandruvada
wrote:
> On Sat, 2019-06-29 at 17:31 +0300, Andy Shevchenko wrote:
> > On Thu, Jun 27, 2019 at 1:39 AM Srinivas Pandruvada
> > wrote:
> > > +++ b/tools/power/x86/intel_speed_select/Makefile
> >
> > My experi
On Thu, Jun 27, 2019 at 1:39 AM Srinivas Pandruvada
wrote:
>
> The Intel(R) Speed select technologies contains four features.
>
> Performance profile:An non architectural mechanism that allows multiple
> optimized performance profiles per system via static and/or dynamic
> adjustment of core count
rm/x86/intel_speed_select_if/isst_if_mbox_pci.c
> create mode 100644 drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> create mode 100644 include/uapi/linux/isst_if.h
> create mode 100644 tools/power/x86/intel_speed_select/Makefile
> create mode 100644 tools/power/x86/intel_speed_select/isst.h
> create mode 100644 tools/power/x86/intel_speed_select/isst_config.c
> create mode 100644 tools/power/x86/intel_speed_select/isst_core.c
> create mode 100644 tools/power/x86/intel_speed_select/isst_display.c
>
> --
> 2.17.2
>
--
With Best Regards,
Andy Shevchenko
On Fri, Jun 28, 2019 at 3:30 PM Mauro Carvalho Chehab
wrote:
>
> The docs under Documentation/laptops contain users specific
> information.
>
Acked-by: Andy Shevchenko
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/ABI/testing/sysfs-block-device
On Fri, Jun 28, 2019 at 3:12 PM Mauro Carvalho Chehab
wrote:
>
> Changeset 163ede97a9a2 ("Documentation: platform: Delete
> x86-laptop-drivers.txt")
> removed the x86-laptop-drivers.txt file, but forgot to update its
> Kconfig.
Acked-by: Andy Shevchenko
>
> Fixe
eone would try to do something like:
>
> grep hwmon*/jtag_enable
>
> It wouldn't find anything.
>
> Fix the What fields in a way that it can be parseable by a
> script and other search tools.
>
Acked-by: Andy Shevchenko
Thanks, Mauro, for fixing this.
> Si
On Thu, Jun 20, 2019 at 9:38 PM Puranjay Mohan wrote:
>
> The list of laptops supported by drivers in PDx86 subsystem is quite
> big and growing. x86-laptop-drivers.txt contains details of very few
> laptop models. Remove it because it does not serve any purpose.
>
Acked-by:
+0530, Puranjay Mohan wrote:
> > I bet it should be deleted, but we should ask the platform driver
> > maintainers first before we do that :)
> Adding Platform driver maintainers Darren Hart and Andy Shevchenko, and
> Compal laptop maintainer Cezary Jackiewicz to the discussion
On Wed, Jun 19, 2019 at 12:05 AM Mauro Carvalho Chehab
wrote:
>
> The docs under Documentation/laptops contain users specific
> information.
>
Acked-by: Andy Shevchenko
with a caveat about Documentation/admin-guide/sysctl/vm.rst.
How block bump is related to laptops? It sounds r
tely.
Cc: Christoph Hellwig
Signed-off-by: Andy Shevchenko
---
- address Bjorn's comments
Documentation/x86/x86_64/boot-options.rst | 2 +-
arch/ia64/kernel/setup.c | 2 +-
arch/x86/kernel/pci-swiotlb.c | 1 -
arch/x86/kernel/setup.c | 2 +-
arc
On Wed, Mar 20, 2019 at 04:31:17PM -0500, Bjorn Helgaas wrote:
> On Wed, Mar 20, 2019 at 11:13 AM Andy Shevchenko
> wrote:
> >
> > After the commit cf65a0f6f6ff
> >
> > ("dma-mapping: move all DMA mapping code to kernel/dma")
> >
> > some of
e this is not linked to
> the main index.rst file, in order to avoid build warnings.
>
Thanks!
Acked-by: Andy Shevchenko
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/ABI/testing/sysfs-block-device | 2 +-
> .../ABI/testing/sysfs-platform-asus-laptop| 2 +-
Some times integer power functions, such as int_sqrt(), are needed, but
there is nothing about them in the generated documentation.
Fill the gap by adding a reference to the corresponding exported functions.
Signed-off-by: Andy Shevchenko
---
Documentation/core-api/kernel-api.rst | 9
Some times string helpers are needed, but there is nothing about them
in the generated documentation.
Fill the gap by adding a reference to string_helpers.c exported functions.
Signed-off-by: Andy Shevchenko
---
Documentation/core-api/kernel-api.rst | 3 +++
1 file changed, 3 insertions
After the commit cf65a0f6f6ff
("dma-mapping: move all DMA mapping code to kernel/dma")
some of the files are referring to outdated information, i.e. old file names
of DMA mapping sources.
Fix it here.
Cc: Christoph Hellwig
Signed-off-by: Andy Shevchenko
---
Documentation/x86/x
u8 %hhu or %hhx
> + s16 %hd or %hx
> + u16 %hu or %hx
> s32 %d or %x
> u32 %u or %x
> s64 %lld or %llx
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
t; Documentation/laptops/lg-laptop.rst:16: WARNING: Unexpected indentation.
> Documentation/laptops/lg-laptop.rst:17: WARNING: Block quote ends without a
> blank line; unexpected unindent.
>
Thanks!
Acked-by: Andy Shevchenko
> Signed-off-by: Randy Dunlap
> Cc: Matan Ziv-Av
On Sun, Feb 10, 2019 at 10:26:53PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap
>
> Fix markup warning: insert a blank line before the hint.
>
> Documentation/driver-api/dmaengine/dmatest.rst:63: WARNING: Unexpected
> indentation.
Thanks.
Acked-by: Andy Shevchenko
On Tue, Nov 6, 2018 at 8:47 AM Peng Hao wrote:
>
> Make header files alphabetical order.
>
Reviewed-by: Andy Shevchenko
> Signed-off-by: Peng Hao
> ---
> drivers/misc/pvpanic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mi
On Mon, Nov 5, 2018 at 2:58 PM Andy Shevchenko
wrote:
>
> On Mon, Nov 5, 2018 at 4:31 AM Peng Hao wrote:
> >
> > By default, when ACPI tables and FDT coexist for ARM64,
> > current kernel takes precedence over FDT to get device information.
> > Virt machine in q
On Mon, Nov 5, 2018 at 4:31 AM Peng Hao wrote:
>
> Remove a redundant comma in pvpanic_device_ids.
>
Reviewed-by: Andy Shevchenko
> Acked-by: Mark Rutland
> Signed-off-by: Peng Hao
> ---
> drivers/misc/pvpanic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 dele
ill go under #ifdef later on)
- do the OF extension
After addressing the split,
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
ion through FDT.
> +#include
> +#include
> #include
> #include
> -#include
> +#include
> +#include
> +#include
> #include
> -#include
Adding new headers in this change is okay, while shuffling them is
logically a separate change.
--
With Best Regards,
Andy Shevchenko
ion.
> return AE_OK;
--
With Best Regards,
Andy Shevchenko
On Sat, Nov 3, 2018 at 4:27 AM wrote:
>
> >>
> >> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> >> this can be used standalone. Add MMIO support to the pvpanic driver.
> >>
> >
> >0day complains b/c of 1st
urn platform_driver_register(&pvpanic_mmio_driver);
> + else
> + return acpi_bus_register_driver(&pvpanic_driver);
> +}
> +
> +static void __exit pvpanic_mmio_exit(void)
> +{
> + if (acpi_disabled)
> + platform_driver_unregister(&pvpanic_mmio_driver);
> + else
> + acpi_bus_unregister_driver(&pvpanic_driver);
> +}
> +
> +module_init(pvpanic_mmio_init);
> +module_exit(pvpanic_mmio_exit);
> --
> 1.8.3.1
>
--
With Best Regards,
Andy Shevchenko
On Fri, Nov 2, 2018 at 6:46 AM Peng Hao wrote:
>
> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> this can be used standalone. Add MMIO support to the pvpanic driver.
>
0day complains b/c of 1st patch in the series.
Reviewed-by: Andy Shevchenko
>
On Fri, Nov 2, 2018 at 6:46 AM Peng Hao wrote:
>
> Move pvpanic.c from drivers/platform/x86 to drivers/misc.
> Following patches will use pvpanic device as common driver.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Mark Rutland
> Signed-off-by: Peng Hao
> ---
base = (void __iomem *) ioport_map(r.start,
> + r.end - r.start + 1);
> + else
> + base = ioremap(r.start, r.end - r.start + 1);
> +
--
With Best Regards,
Andy Shevchenko
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> use acpi_dev_resource_io API.
>
Same comments as per patch 1.
This should be patch 2/8 in the series.
Otherwise,
Reviewed-by: Andy Shevchenko
Also, you might consider to use Suggested-by tag here.
> Signed-off-by: Peng Hao
>
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
After addressing Mark's comment consider to move this to be patch 7/8
in the series.
Otherwise,
Reviewed-by: Andy Shevchenko
>
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> remove unnecessary header file init.h.
>
Same comments as per patch 1, on top of this is ordering issue. This
patch should be 6/8.
Also, address Mark's comments, please.
Otherwise,
Reviewed-by: Andy Shevchenko
> Signed
; index fd86dab..059005c 100644
> > --- a/drivers/misc/pvpanic.c
> > +++ b/drivers/misc/pvpanic.c
> > @@ -35,7 +35,7 @@
> >
> > static const struct acpi_device_id pvpanic_device_ids[] = {
> > { "QEMU0001", 0 },
> > - { "", 0 },
> > + { "", 0 }
> > };
> > MODULE_DEVICE_TABLE(acpi, pvpanic_device_ids);
> >
> > --
> > 1.8.3.1
> >
--
With Best Regards,
Andy Shevchenko
sentenses
- don't forget the tags people gave you in case you didn't (much) change a patch
Other than that, this one looks good to me
Reviewed-by: Andy Shevchenko
P.S. WRT tags this one in v6 should have something like:
...
Reviewed-by: me
Acked-by: Mark
Signed-off-by: you
at the en
> -#include
This one also in a separate patch.
So, the one should be split to three AFAICS.
--
With Best Regards,
Andy Shevchenko
return acpi_bus_register_driver(&pvpanic_driver);
> +}
> +
> +static void __exit pvpanic_mmio_exit(void)
> +{
> + if (acpi_disabled)
> + platform_driver_unregister(&pvpanic_mmio_driver);
> + else
> + acpi_bus_unregister_driver(&pvpanic_driver);
> +}
> +
> +module_init(pvpanic_mmio_init);
> +module_exit(pvpanic_mmio_exit);
> --
> 1.8.3.1
>
--
With Best Regards,
Andy Shevchenko
oes the rest.
Moreover, please, read carefully the code of those functions — hint:
they check for resource type themselves.
> + if (base)
Same question. At which conditions the base here can be NULL?
> + iounmap(base);
--
With Best Regards,
Andy Shevchenko
On Wed, Oct 31, 2018 at 7:27 AM Peng Hao wrote:
>
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
Reviewed-by: Andy Shevchenko
> Signed-off-by: Peng Hao
> ---
> drivers/misc/pvpanic.c | 17 ++---
> 1 fi
not sure:
a) how it's related to the rest in this patch (should be split I suppose);
b) how come arm64->arm replacement — are platform drivers independent
from the (ARM) architecture?
--
With Best Regards,
Andy Shevchenko
I should resume one check like this to deal with the failure of
> ioremap/ioport_map.
> if (base)
>iounmap(base)
I'm a bit confused, how come that base == NULL when you about to call
iounmap()? Where you would like to put this check?
> The patch of QEMU is still in review.
--
With Best Regards,
Andy Shevchenko
x86 code for iounmap that
> checked the base.
> so I think it is safe for x86. But I'm not sure if other architectures using
> ioport are also secure
> in the same way of processing.
> Do you have any suggestions?
I would consider it as a bug if on some architectures iounmap() is not
able to take a base got from ioport_map().
--
With Best Regards,
Andy Shevchenko
mentioned you better to use -C -M.
> >This is currently a bit hard to review.
>
> sorry, I don't understand what "-C -M" means.
> I should have asked you when you first mention it.
git format-patch -C -M ...
--
With Best Regards,
Andy Shevchenko
return acpi_bus_register_driver(&pvpanic_driver);
> +}
> +
> +static void __exit pvpanic_mmio_exit(void)
> +{
> + if (acpi_disabled)
> + platform_driver_unregister(&pvpanic_mmio_driver);
> + else
> + acpi_bus_unregister_driver(&pvpanic_driver);
> +}
> +
> +module_init(pvpanic_mmio_init);
> +module_exit(pvpanic_mmio_exit);
> --
> 1.8.3.1
>
--
With Best Regards,
Andy Shevchenko
ress_length);
> return AE_OK;
Ouch. Sorry, I forgot to look at this previously.
This should be converted to use
acpi_dev_resource_io()
acpi_dev_resource_memory()
--
With Best Regards,
Andy Shevchenko
-
> drivers/platform/x86/pvpanic.c | 124
> -
As I mentioned you better to use -C -M.
This is currently a bit hard to review.
--
With Best Regards,
Andy Shevchenko
ixes this by printing hashed addresses instead.
Looks nice!
Reviewed-by: Andy Shevchenko
>
> Changes compared to v1:
> - Get rid of the forward declaration for ptr_to_id(),
> - Add Reviewed-by.
>
> Thanks!
>
> Geert Uytterhoeven (3):
> lib/vsprintf: Pre
On Mon, Oct 08, 2018 at 04:37:29PM +0200, Geert Uytterhoeven wrote:
> Hi Andy,
>
> On Mon, Oct 8, 2018 at 4:25 PM Andy Shevchenko
> wrote:
> > On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote:
> > > - Make the ptr argument const, to a
r *ptr_to_id(char *buf, char *end, const void *ptr,
> +struct printf_spec spec);
--
With Best Regards,
Andy Shevchenko
omment in a certain place,
re-check _entire_ series for the same / similar patterns!
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.k
.cpu_id = 0x50650, /* Family code: 6, Model number: 85
> (0x55) */
> + .core_max = CORE_MAX_ON_SKX },
> +};
Are we talking about x86 CPU IDs here?
If so, why x86 corresponding headers, including intel-family.h are not
used?
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this lis
On Fri, Mar 2, 2018 at 8:35 PM, Daniel Kurtz wrote:
> On Thu, Mar 1, 2018 at 1:02 PM Andy Shevchenko
> wrote:
>> On Thu, Mar 1, 2018 at 9:22 PM, Daniel Kurtz wrote:
>> > On Thu, Mar 1, 2018 at 11:47 AM Andy Shevchenko <
> andy.shevche...@gmail.com>
>>
On Thu, Mar 1, 2018 at 11:24 PM, Aaron Durbin wrote:
> On Thu, Mar 1, 2018 at 1:02 PM, Andy Shevchenko
> wrote:
>> On Thu, Mar 1, 2018 at 9:22 PM, Daniel Kurtz wrote:
>>> On Thu, Mar 1, 2018 at 11:47 AM Andy Shevchenko
>>> wrote:
>>
>>> &quo
On Thu, Mar 1, 2018 at 9:22 PM, Daniel Kurtz wrote:
> On Thu, Mar 1, 2018 at 11:47 AM Andy Shevchenko
> wrote:
> "earlycon simply does not utilize the information".
>
> earlycon parses iotype, mapbase and baud (from options). However, it is
> hard-coded to a
On Thu, Mar 1, 2018 at 8:43 PM, Daniel Kurtz wrote:
Please, hold on with new versions.
I'm not satisfied (yet?) by the approach.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@
-
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type,
use PROPERTY_ENTRY_U32() dedicated macro.
It will help modify internals of built-in device properties API.
No functional change intended.
Signed-off-by: Andy Shevchenko
---
Documentation/input/devices/rotary-encoder.rst
an be removed here.
>
> While at it an obvious typo (new new) was also fixed.
AFAIU It is right only in case when someone does this, e.g.
module_i2c_driver() macro. Otherwise the field is pretty valid and
must be filled.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this li
On Mon, 2017-10-23 at 13:30 +, mario.limoncie...@dell.com wrote:
> Acked-by: Mario Limonciello
Thanks.
Since Mika established a dedicated repository for Thunderbolt patches I
assume he takes this.
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the l
WMI is the bus inside kernel, so, we may access the GUID via
/sys/bus/wmi instead of doing this through /sys/devices path.
Signed-off-by: Andy Shevchenko
---
Documentation/admin-guide/thunderbolt.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/admin-guide
The device will not appear until we rescan the bus.
Signed-off-by: Andy Shevchenko
---
Documentation/admin-guide/thunderbolt.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/admin-guide/thunderbolt.rst
b/Documentation/admin-guide/thunderbolt.rst
index 9b55952039a6
On Tue, 2017-10-17 at 17:59 +0200, Rafael J. Wysocki wrote:
> On Tuesday, October 17, 2017 5:33:17 PM CEST Andy Shevchenko wrote:
> > On Mon, 2017-10-16 at 03:32 +0200, Rafael J. Wysocki wrote:
> > > If DPM_FLAG_SMART_SUSPEND is not set, DPM_FLAG_AVOID_RPM has no
> > >
if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND) &&
> + dev_pm_test_driver_flags(dev, DPM_FLAG_AVOID_RPM)) {
Wasn't interface designed to allow something like:
if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND |
DPM_FLAG_AVOID_RPM)) {
instead?
Does it make sense t
On Wed, Jul 19, 2017 at 5:53 PM, Thomas Gleixner wrote:
> On Wed, 19 Jul 2017, Andy Shevchenko wrote:
>> On Wed, Jul 19, 2017 at 5:19 PM, Marc Zyngier wrote:
>> > echo 1 >/proc/irq/9/trigger
>> > (or the corresponding /sys/kernel/debug/irq/irqs/ interface if we wan
s
> is really not for production use...).
or /sys/kernel/irq as a successor of /proc/irq
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
ase of the signal.
It looks to me much simpler if you allow to have linked / virtual
channels instead of creating a lot of (duplicated) properties.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to
s, obviously, duty=100% in case of emulation,
though separate state for HW assisted kind of that.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 6, 2017 at 11:43 AM, Nicolas Dichtel
wrote:
> This header file is exported, thus move it to uapi.
Just hint for the future:
-M (move)
-C (copy)
-D (delete) [though this is NOT for applying]
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the l
; + .data = (void *)0, },
> + { .compatible = "i2c-mux-simple,mux-locked",
> + .data = (void *)1, },
> + {},
> +};
Perhaps
#define I2C_MUX_LOCKED_PARENT 0
#define I2C_MUX_LOCKED 1
?
--
With Best Regards,
Andy Shevchenko
--
To unsubsc
1 - 100 of 105 matches
Mail list logo
