Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.

2019-10-17 Thread Andrey Ryabinin
On 10/8/19 9:11 AM, Nick Hu wrote: > Skip the memmove checking for those archs who don't support it. The patch is fine but the changelog sounds misleading. We don't skip memmove checking. If arch don't have memmove than the C implementation from lib/string.c used. It's instrumented by compile

Re: [PATCH v3 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Andrey Ryabinin
On 5/31/19 6:08 PM, Marco Elver wrote: > This adds bitops tests to the test_kasan module. In a follow-up patch, > support for bitops instrumentation will be added. > > Signed-off-by: Marco Elver > --- > Changes in v3: > * Use kzalloc instead of kmalloc. > * Use sizeof(*bits). > > Changes in v

Re: [PATCH v3 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation

2019-06-13 Thread Andrey Ryabinin
e flagged by objtool. > > For consistency, kernel/signal.c was changed to mirror this change, > however, is never instrumented with KASAN (currently unsupported under > x86 32bit). > > Signed-off-by: Marco Elver > Suggested-by: H. Peter Anvin Reviewed-by: Andrey Ryabinin

Re: [PATCH v3 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-06-13 Thread Andrey Ryabinin
n with bitops tests (pre-requisite patch). > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198439 > Signed-off-by: Marco Elver Reviewed-by: Andrey Ryabinin

Re: [PATCH v4 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Andrey Ryabinin
On 6/13/19 3:30 PM, Marco Elver wrote: > This adds bitops tests to the test_kasan module. In a follow-up patch, > support for bitops instrumentation will be added. > > Signed-off-by: Marco Elver > Acked-by: Mark Rutland > --- Reviewed-by: Andrey Ryabinin > +static

Re: [PATCH 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-05-29 Thread Andrey Ryabinin
On 5/29/19 1:57 PM, Dmitry Vyukov wrote: > On Wed, May 29, 2019 at 12:30 PM Peter Zijlstra wrote: >> >> On Wed, May 29, 2019 at 12:16:31PM +0200, Marco Elver wrote: >>> On Wed, 29 May 2019 at 12:01, Peter Zijlstra wrote: On Wed, May 29, 2019 at 11:20:17AM +0200, Marco Elver wrote: >>

Re: [GIT PULL] Compiler Attributes for v4.20-rc1

2018-11-02 Thread Andrey Ryabinin
On 11/02/2018 07:11 PM, Linus Torvalds wrote: > On Fri, Nov 2, 2018 at 6:16 AM Andrey Ryabinin > wrote: >> >> On 11/02/2018 04:46 AM, Linus Torvalds wrote: >>> >>> So I _think_ the KASAN config should have a >>> >>> depends on CC_I

Re: [GIT PULL] Compiler Attributes for v4.20-rc1

2018-11-02 Thread Andrey Ryabinin
On 11/02/2018 04:46 AM, Linus Torvalds wrote: > On Thu, Nov 1, 2018 at 10:06 AM Linus Torvalds > wrote: >> >> The logic for using __no_sanitize_address *used* to be >> >> #if GCC_VERSION >= 40902 > > Ok, looking around, I think this has less to do with the attribute > being recognized, and

Re: [GIT PULL] Compiler Attributes for v4.20-rc1

2018-11-02 Thread Andrey Ryabinin
On 11/01/2018 08:06 PM, Linus Torvalds wrote: > On Mon, Oct 22, 2018 at 3:59 AM Miguel Ojeda > wrote: >> >> Here it is the Compiler Attributes series/tree, which tries to disentangle >> the include/linux/compiler*.h headers and bring them up to date. > > I've finally emptied the "normal" pull que

Re: [PATCH v9 01/20] kasan, mm: change hooks signatures

2018-10-31 Thread Andrey Ryabinin
gfp_t flags); This patch missed couple call-sites, in kmem_cache_alloc_trace() and kmem_cache_alloc_node_trace() in include/linux/slab.h, the return value of kasan_kmalloc() is ignored. Probably worth adding __must_check to functions like this. Once that fixed you can add Reviewed-by: Andrey Ryabinin here and to the rest of the patches. They look fine me.

Re: [PATCH v2] kasan: Support for r/w instrumentation control

2016-12-14 Thread Andrey Ryabinin
On 12/13/2016 11:58 AM, Dmitry Vyukov wrote: > --- a/Documentation/dev-tools/kasan.rst > +++ b/Documentation/dev-tools/kasan.rst > @@ -40,6 +40,14 @@ similar to the following to the respective kernel Makefile: > > KASAN_SANITIZE := n > > +Sometimes it may be useful to disable instrumentat

Re: [PATCH v2] kasan: Support for r/w instrumentation control

2016-12-13 Thread Andrey Ryabinin
On 12/13/2016 05:13 PM, Dmitry Vyukov wrote: > On Tue, Dec 13, 2016 at 2:59 PM, Andrey Ryabinin > wrote: >> On 12/13/2016 12:38 PM, Dmitry Vyukov wrote: >>> On Tue, Dec 13, 2016 at 10:20 AM, Andrey Ryabinin >>> wrote: >>>> >>>> >>>

Re: [PATCH v2] kasan: Support for r/w instrumentation control

2016-12-13 Thread Andrey Ryabinin
On 12/13/2016 12:38 PM, Dmitry Vyukov wrote: > On Tue, Dec 13, 2016 at 10:20 AM, Andrey Ryabinin > wrote: >> >> >> On 12/13/2016 11:58 AM, Dmitry Vyukov wrote: >> >>> --- a/Documentation/dev-tools/kasan.rst >>> +++ b/Documentation/dev-tools

Re: [PATCH 06/10] docs: sphinxify kasan.txt and move to dev-tools

2016-08-17 Thread Andrey Ryabinin
On 08/09/2016 02:34 AM, Jonathan Corbet wrote: > No textual changes beyond formatting. > > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Dmitry Vyukov > Signed-off-by: Jonathan Corbet > --- > Documentation/d

Re: [PATCH 07/10] docs: sphinxify ubsan.txt and move it to dev-tools

2016-08-17 Thread Andrey Ryabinin
On 08/09/2016 02:34 AM, Jonathan Corbet wrote: > Cc: Andrey Ryabinin > Signed-off-by: Jonathan Corbet > --- Acked-by: Andrey Ryabinin -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH] mm, kasan: Update kasan docs to indicate arm64 support

2016-08-17 Thread Andrey Ryabinin
On 08/16/2016 07:30 PM, Laura Abbott wrote: > KASAN has been supported on arm64 since 39d114ddc682 ("arm64: add KASAN > support"). Update the docs to indicate this. > > Signed-off-by: Laura Abbott Acked-by: Andrey Ryabinin > --- > Documentation/kasan.txt