Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-11 Thread Jie Gan
On 2/11/2025 9:58 PM, Jie Luo wrote: On 2/10/2025 10:12 AM, Jie Gan wrote: +static int ppe_clock_init_and_reset(struct ppe_device *ppe_dev) +{ +    unsigned long ppe_rate = ppe_dev->clk_rate; +    struct device *dev = ppe_dev->dev; +    struct reset_control *rstc; +    struct clk_bulk_data

Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-11 Thread Jie Gan
On 2/11/2025 9:04 PM, Andrew Lunn wrote: +#ifndef __PPE_H__ +#define __PPE_H__ + +#include +#include + +struct device; #include ? +struct regmap; Same with previous one, include it's header file? If the structure is opaque at this level, it is fine to not include the header. There is

Re: [PATCH 0/4] Raise the bar with regards to Python and Sphinx requirements

2025-02-11 Thread Kees Cook
On Tue, Feb 11, 2025 at 07:19:00AM +0100, Mauro Carvalho Chehab wrote: > This series increases the minimal requirements for Sphinx and Python, and > drop some backward-compatible code from Sphinx extension. > > Looking at Sphinx release dates: > > Release 2.4.0 (released Feb 09, 2020) >

Re: [PATCH v2 14/15] RISC-V: KVM: add support for FWFT SBI extension

2025-02-11 Thread Deepak Gupta
On Tue, Feb 11, 2025 at 11:31:28AM +0100, Clément Léger wrote: On 11/02/2025 06:43, Deepak Gupta wrote: +static int kvm_sbi_fwft_get(struct kvm_vcpu *vcpu, unsigned long feature, +    unsigned long *value) +{ +    int ret; +    struct kvm_sbi_fwft_config *conf; + +    ret = kvm_fwf

Re: [PATCH net-next v3 01/14] dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC

2025-02-11 Thread Jie Luo
On 2/10/2025 10:47 AM, Jie Gan wrote: diff --git a/Documentation/devicetree/bindings/net/qcom,ipq9574- ppe.yaml b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml new file mode 100644 index ..be6f9311eebb --- /dev/null +++ b/Documentation/devicetree/bindings/net/qcom,ip

Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-11 Thread Jie Luo
On 2/10/2025 10:12 AM, Jie Gan wrote: +static int ppe_clock_init_and_reset(struct ppe_device *ppe_dev) +{ +    unsigned long ppe_rate = ppe_dev->clk_rate; +    struct device *dev = ppe_dev->dev; +    struct reset_control *rstc; +    struct clk_bulk_data *clks; +    struct clk *clk; +    int re

Re: [PATCH net-next v3 13/14] net: ethernet: qualcomm: Add PPE debugfs support for PPE counters

2025-02-11 Thread Andrew Lunn
> +#define PRINT_COUNTER_PREFIX(desc, cnt_type) \ > + seq_printf(seq, "%-16s %16s", desc, cnt_type) > + > +#define PRINT_CPU_CODE_COUNTER(cnt, code)\ > + seq_printf(seq, "%10u(cpucode:%d)", cnt, code) > + > +#define PRINT_DROP_CODE_COUNTER(cnt, port, code) \ > +

Re: [PATCH net-next v3 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings

2025-02-11 Thread Andrew Lunn
> +/* Scheduler configuration for the assigning and releasing buffers for the > + * packet passing through PPE, which is different per SoC. > + */ > +static const struct ppe_scheduler_bm_config ipq9574_ppe_sch_bm_config[] = { > + {1, 0, 0, 0, 0}, > + {1, 1, 0, 0, 0}, > + {1, 0, 5, 0, 0}

Re: [PATCH net-next v3 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574

2025-02-11 Thread Andrew Lunn
> + /* Configure BM flow control related threshold. */ > + PPE_BM_PORT_FC_SET_WEIGHT(bm_fc_val, port_cfg.weight); > + PPE_BM_PORT_FC_SET_RESUME_OFFSET(bm_fc_val, port_cfg.resume_offset); > + PPE_BM_PORT_FC_SET_RESUME_THRESHOLD(bm_fc_val, port_cfg.resume_ceil); > + PPE_BM_PORT_FC

Re: [PATCH net-next v3 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574

2025-02-11 Thread Andrew Lunn
> +/* Assign the share buffer number 1550 to group 0 by default. */ > +static const int ipq9574_ppe_bm_group_config = 1550; To a large extent, the comment is useless. What should be in the comment is why, not what. Andrew

Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-11 Thread Andrew Lunn
> > +#ifndef __PPE_H__ > > +#define __PPE_H__ > > + > > +#include > > +#include > > + > > +struct device; > #include ? > > > +struct regmap; > Same with previous one, include it's header file? > If the structure is opaque at this level, it is fine to not include the header. There is nothing i

Re: [PATCH net-next v3 02/14] docs: networking: Add PPE driver documentation for Qualcomm IPQ9574 SoC

2025-02-11 Thread Lei Wei
On 2/10/2025 10:15 AM, Bagas Sanjaya wrote: On Sun, Feb 09, 2025 at 10:29:36PM +0800, Luo Jie wrote: +The Ethernet functionality in the PPE (Packet Process Engine) is comprised of three +components: the switch core, port wrapper and Ethernet DMA. + +The Switch core in the IPQ9574 PPE has max

Re: [PATCH v2 14/15] RISC-V: KVM: add support for FWFT SBI extension

2025-02-11 Thread Clément Léger
On 11/02/2025 06:43, Deepak Gupta wrote: >> +static int kvm_sbi_fwft_get(struct kvm_vcpu *vcpu, unsigned long >> feature, >> +    unsigned long *value) >> +{ >> +    int ret; >> +    struct kvm_sbi_fwft_config *conf; >> + >> +    ret = kvm_fwft_get_feature(vcpu, feature, &conf); >> +

Re: [PATCH v4] docs: clarify rules wrt tagging other people

2025-02-11 Thread Thorsten Leemhuis
On 10.02.25 19:12, Jonathan Corbet wrote: > Thorsten Leemhuis writes: >> Point out that explicit permission is usually needed to tag other people >> in changes, but mention that implicit permission can be sufficient in >> certain cases. This fixes slight inconsistencies between Reported-by: >> and

Re: [PATCH v4] docs: clarify rules wrt tagging other people

2025-02-11 Thread Thorsten Leemhuis
On 10.02.25 17:16, Mauro Carvalho Chehab wrote: > Em Fri, 7 Feb 2025 09:24:56 +0100 > Thorsten Leemhuis escreveu: > >> On 07.02.25 02:42, Bagas Sanjaya wrote: >>> On Thu, Feb 06, 2025 at 03:30:10PM +0100, Thorsten Leemhuis wrote: diff --git a/Documentation/process/5.Posting.rst b/Doc

Re: [PATCH v4] docs: clarify rules wrt tagging other people

2025-02-11 Thread Thorsten Leemhuis
On 10.02.25 12:15, Laurent Pinchart wrote: > On Sat, Feb 08, 2025 at 04:36:47PM +0100, Thorsten Leemhuis wrote: >> On 07.02.25 10:05, Laurent Pinchart wrote: >>> On Thu, Feb 06, 2025 at 03:30:10PM +0100, Thorsten Leemhuis wrote: >>> [...] +Be careful in the addition of the aforementioned tags