Re: [PATCH] docs: submitting-patches: document the format for affiliation

2025-02-03 Thread Geert Uytterhoeven
Hi Jakub, On Mon, 3 Feb 2025 at 18:46, Jakub Kicinski wrote: > Adding company name in round brackets to From/SoB lines > is fairly common, but I don't see it documented anywhere. > Every now and then people try to add the sponsorship lines > to the commit message, fun example from this merge wind

Re: [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-03 Thread Abdul Rahim, Faizal
On 4/2/2025 8:49 am, Song Yoong Siang wrote: Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel I225-LM Ethernet controller. Below are the test steps and result. Test 1

Re: [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-03 Thread Abdul Rahim, Faizal
On 4/2/2025 8:49 am, Song Yoong Siang wrote: Refactor the code for inserting an empty packet into a new function igc_insert_empty_packet(). This change extracts the logic for inserting an empty packet from igc_xmit_frame_ring() into a separate function, allowing it to be reused in future imple

Re: [PATCH bpf-next v7 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-03 Thread Choong Yong Liang
On 4/2/2025 8:49 am, Song Yoong Siang wrote: Enable launch time (Time-Based Scheduling) support for XDP zero copy via the XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result.

[PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-03 Thread Song Yoong Siang
Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel I225-LM Ethernet controller. Below are the test steps and result. Test 1: Send a single packet with the launch time set to

[PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-03 Thread Song Yoong Siang
Refactor the code for inserting an empty packet into a new function igc_insert_empty_packet(). This change extracts the logic for inserting an empty packet from igc_xmit_frame_ring() into a separate function, allowing it to be reused in future implementations, such as the XDP zero copy transmit fun

[PATCH bpf-next v7 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-03 Thread Song Yoong Siang
Enable launch time (Time-Based Scheduling) support for XDP zero copy via the XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result. Test 1: Send a single packet with the launch time

[PATCH bpf-next v7 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-03 Thread Song Yoong Siang
Add launch time hardware offload request to xdp_hw_metadata. Users can configure the delta of launch time relative to HW RX-time using the "-l" argument. By default, the delta is set to 0 ns, which means the launch time is disabled. By setting the delta to a non-zero value, the launch time hardware

[PATCH bpf-next v7 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-03 Thread Song Yoong Siang
Extend the XDP Tx metadata framework so that user can requests launch time hardware offload, where the Ethernet device will schedule the packet for transmission at a pre-determined time called launch time. The value of launch time is communicated from user space to Ethernet driver via launch_time f

[PATCH bpf-next v7 0/5] xsk: TX metadata Launch Time support

2025-02-03 Thread Song Yoong Siang
This series expands the XDP TX metadata framework to allow user applications to pass per packet 64-bit launch time directly to the kernel driver, requesting launch time hardware offload support. The XDP TX metadata framework will not perform any clock conversion or packet reordering. Please note t

[PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-03 Thread Mina Almasry
Augment dmabuf binding to be able to handle TX. Additional to all the RX binding, we also create tx_vec needed for the TX path. Provide API for sendmsg to be able to send dmabufs bound to this device: - Provide a new dmabuf_tx_cmsg which includes the dmabuf to send from. - MSG_ZEROCOPY with SCM_D

[PATCH net-next v3 6/6] net: devmem: make dmabuf unbinding scheduled work

2025-02-03 Thread Mina Almasry
The TX path may release the dmabuf in a context where we cannot wait. This happens when the user unbinds a TX dmabuf while there are still references to its netmems in the TX path. In that case, the netmems will be put_netmem'd from a context where we can't unmap the dmabuf, resulting in a BUG like

[PATCH net-next v3 4/6] net: devmem: TCP tx netlink api

2025-02-03 Thread Mina Almasry
From: Stanislav Fomichev Add bind-tx netlink call to attach dmabuf for TX; queue is not required, only ifindex and dmabuf fd for attachment. Signed-off-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- v3: - Fix ynl-regen.sh error (Simon). --- Documentation/netlink/specs/netdev.yaml |

[PATCH net-next v3 3/6] net: add get_netmem/put_netmem support

2025-02-03 Thread Mina Almasry
Currently net_iovs support only pp ref counts, and do not support a page ref equivalent. This is fine for the RX path as net_iovs are used exclusively with the pp and only pp refcounting is needed there. The TX path however does not use pp ref counts, thus, support for get_page/put_page equivalent

[PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX

2025-02-03 Thread Mina Almasry
Add support for devmem TX in ncdevmem. This is a combination of the ncdevmem from the devmem TCP series RFCv1 which included the TX path, and work by Stan to include the netlink API and refactored on top of his generic memory_provider support. Signed-off-by: Mina Almasry Signed-off-by: Stanislav

[PATCH net-next v3 1/6] net: add devmem TCP TX documentation

2025-02-03 Thread Mina Almasry
Add documentation outlining the usage and details of the devmem TCP TX API. Signed-off-by: Mina Almasry --- v2: - Update documentation for iov_base is the dmabuf offset (Stan) --- Documentation/networking/devmem.rst | 144 +++- 1 file changed, 140 insertions(+), 4 delet

[PATCH net-next v3 0/6] Device memory TCP TX

2025-02-03 Thread Mina Almasry
v3: https://patchwork.kernel.org/project/netdevbpf/list/?series=929401&state=* === Address minor comments from RFCv2 and fix a few build warnings and ynl-regen issues. No major changes. RFC v2: https://patchwork.kernel.org/project/netdevbpf/list/?series=920056&state=* === RFC v2 addresses m

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Doug Covelli
On Mon, Feb 3, 2025 at 2:53 PM Sean Christopherson wrote: > > On Mon, Feb 03, 2025, Paolo Bonzini wrote: > > On 2/3/25 20:41, Sean Christopherson wrote: > > > -EFAULT isn't the problem, KVM not being able to return useful > > > information in > > > all situations is the issue. > > > > Yes, that's

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Sean Christopherson
On Mon, Feb 03, 2025, Paolo Bonzini wrote: > On 2/3/25 20:41, Sean Christopherson wrote: > > -EFAULT isn't the problem, KVM not being able to return useful information > > in > > all situations is the issue. > > Yes, that's why I don't want it to be an automatically opted-in API. If > incrementa

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-03 Thread Mauro Carvalho Chehab
Em Mon, 3 Feb 2025 20:50:39 +0100 Mauro Carvalho Chehab escreveu: > Em Mon, 03 Feb 2025 08:00:56 -0700 > Jonathan Corbet escreveu: > > > Simon Horman writes: > > > > > Document preference for non inline functions in .c files. > > > This has been the preference for as long as I can recall > >

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-03 Thread Mauro Carvalho Chehab
Em Mon, 03 Feb 2025 08:00:56 -0700 Jonathan Corbet escreveu: > Simon Horman writes: > > > Document preference for non inline functions in .c files. > > This has been the preference for as long as I can recall > > and I was recently surprised to discover that it is undocumented. > > > > Reported

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Paolo Bonzini
On 2/3/25 20:41, Sean Christopherson wrote: -EFAULT isn't the problem, KVM not being able to return useful information in all situations is the issue. Yes, that's why I don't want it to be an automatically opted-in API. If incremental improvements are possible, it may be useful to allow int

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Sean Christopherson
On Mon, Feb 03, 2025, Doug Covelli wrote: > On Mon, Feb 3, 2025 at 1:22 PM Paolo Bonzini wrote: > > > > On Mon, Feb 3, 2025 at 5:35 PM Doug Covelli > > wrote: > > > OK. It seems like fully embracing the in-kernel APIC is the way to go > > > especially considering it really simplifies using KVM'

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-03 Thread Randy Dunlap
Hi Simon, Another nit: On 2/3/25 5:59 AM, Simon Horman wrote: > Document preference for non inline functions in .c files. > This has been the preference for as long as I can recall > and I was recently surprised to discover that it is undocumented. > > Reported-by: Alexandre Ferrieux > Closes:

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Doug Covelli
On Mon, Feb 3, 2025 at 1:22 PM Paolo Bonzini wrote: > > On Mon, Feb 3, 2025 at 5:35 PM Doug Covelli wrote: > > OK. It seems like fully embracing the in-kernel APIC is the way to go > > especially considering it really simplifies using KVM's support for nested > > virtualization. Speaking of nes

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Paolo Bonzini
On Mon, Feb 3, 2025 at 5:35 PM Doug Covelli wrote: > OK. It seems like fully embracing the in-kernel APIC is the way to go > especially considering it really simplifies using KVM's support for nested > virtualization. Speaking of nested virtualization we have been working on > adding support for

[PATCH] docs: submitting-patches: document the format for affiliation

2025-02-03 Thread Jakub Kicinski
Adding company name in round brackets to From/SoB lines is fairly common, but I don't see it documented anywhere. Every now and then people try to add the sponsorship lines to the commit message, fun example from this merge window: Sponsored by: The FreeBSD Foundation from commit 2ce67f8bf1ce

Re: [PATCH v2 0/2] checkpatch: Add support for checkpatch-ignore note

2025-02-03 Thread Brendan Jackman
On Wed, 15 Jan 2025 at 16:33, Brendan Jackman wrote: > Changes in v2: > - Switched to the "graveyard" instead of the actual commit message. > - Link to v1: > https://lore.kernel.org/r/20250113-checkpatch-ignore-v1-0-63a7a740f...@google.com Hi Joe & Andy, any thoughts on this?

Re: [PATCH 2/3] KVM: x86: Add support for VMware guest specific hypercalls

2025-02-03 Thread Doug Covelli
On Tue, Jan 7, 2025 at 12:10 PM Paolo Bonzini wrote: > > On Wed, Dec 18, 2024 at 4:44 AM Sean Christopherson wrote: > > > Changing our legacy BIOS is not an option so in order to support Windows > > > VMs > > > with the legacy BIOS with decent performance we would either need to add > > > suppo

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-03 Thread Andrew Lunn
> Conversely, spelling and grammar fixes are not discouraged. > > +Inline functions > + > + > +The use of static inline functions in .c file is strongly discouraged I don't think 'static' is relevant here. They probably are static, if they are inline, and to avoid warnings about

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-03 Thread Jonathan Corbet
Simon Horman writes: > Document preference for non inline functions in .c files. > This has been the preference for as long as I can recall > and I was recently surprised to discover that it is undocumented. > > Reported-by: Alexandre Ferrieux > Closes: > https://lore.kernel.org/all/9662e6fe-cc

Re: [PATCH v2 6/6] module: Introduce hash-based integrity checking

2025-02-03 Thread Petr Pavlu
On 1/20/25 18:44, Thomas Weißschuh wrote: > The current signature-based module integrity checking has some drawbacks > in combination with reproducible builds: > Either the module signing key is generated at build time, which makes > the build unreproducible, or a static key is used, which preclude

[PATCH net] docs: netdev: Document guidance on inline functions

2025-02-03 Thread Simon Horman
Document preference for non inline functions in .c files. This has been the preference for as long as I can recall and I was recently surprised to discover that it is undocumented. Reported-by: Alexandre Ferrieux Closes: https://lore.kernel.org/all/9662e6fe-cc91-4258-aba1-ab5b016a0...@orange.com

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-02-03 Thread Christian Heusel
Hey Thomas, On 25/01/20 06:44PM, Thomas Weißschuh wrote: > Thomas Weißschuh (6): > kbuild: add stamp file for vmlinux BTF data > module: Make module loading policy usable without MODULE_SIG > module: Move integrity checks into dedicated function > module: Move lockdown chec

Re: [PATCH v6 22/26] device/dax: Properly refcount device dax pages when mapping

2025-02-03 Thread Alistair Popple
On Mon, Jan 13, 2025 at 10:12:41PM -0800, Dan Williams wrote: > Alistair Popple wrote: > > Device DAX pages are currently not reference counted when mapped, > > instead relying on the devmap PTE bit to ensure mapping code will not > > get/put references. This requires special handling in various pa