Re: [RFCv1 6/6] selftests/page_detective: Introduce self tests for Page Detective

2024-11-16 Thread Muhammad Usama Anjum
On 11/16/24 10:59 PM, Pasha Tatashin wrote: > Add self tests for Page Detective, it contains testing of several memory > types, and also some negative/bad input tests. > > Signed-off-by: Pasha Tatashin > --- > MAINTAINERS | 1 + > tools/testing/selftests/Makef

Re: [RFCv1 4/6] misc/page_detective: Introduce Page Detective

2024-11-16 Thread Jonathan Corbet
Pasha Tatashin writes: > Page Detective is a kernel debugging tool that provides detailed > information about the usage and mapping of physical memory pages. > > It operates through the Linux debugfs interface, providing access > to both virtual and physical address inquiries. The output, present

[RFCv1 4/6] misc/page_detective: Introduce Page Detective

2024-11-16 Thread Pasha Tatashin
Page Detective is a kernel debugging tool that provides detailed information about the usage and mapping of physical memory pages. It operates through the Linux debugfs interface, providing access to both virtual and physical address inquiries. The output, presented via kernel log messages (access

[RFCv1 5/6] misc/page_detective: enable loadable module

2024-11-16 Thread Pasha Tatashin
Export the missing symbols, and allow page_detective to be built as a loadable module. This can be make this available in the field, where Page Detective is loaded only once it is needed. Signed-off-by: Pasha Tatashin --- drivers/misc/Kconfig | 2 +- fs/kernfs/dir.c | 1 + kernel/pid.c

[RFCv1 6/6] selftests/page_detective: Introduce self tests for Page Detective

2024-11-16 Thread Pasha Tatashin
Add self tests for Page Detective, it contains testing of several memory types, and also some negative/bad input tests. Signed-off-by: Pasha Tatashin --- MAINTAINERS | 1 + tools/testing/selftests/Makefile | 1 + .../selftests/page_detective/.gi

[RFCv1 3/6] mm: Add a dump_page variant that accept log level argument

2024-11-16 Thread Pasha Tatashin
Page Detective uses info level, while dump_page() uses warn level. Add a new function dump_page_lvl() that accepts log level argument to be able to dump pages at specific level. Also, this enables adding a modules specific prefix to output of this function. Signed-off-by: Pasha Tatashin --- fs/

[RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-16 Thread Pasha Tatashin
Page Detective will use it to walk the kernel page table. Make this function accessible from modules, and also while here make walk_page_range() accessible from modules, so Page Detective could use it to walk user page tables. Signed-off-by: Pasha Tatashin --- include/linux/pagewalk.h | 2 ++ m

[RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-16 Thread Pasha Tatashin
Page Detective will be using get_vma_name() that is currently used by fs/proc to show names of VMAs in /proc//smaps for example. Move this function to mm/vma.c, and make it accessible by modules. Signed-off-by: Pasha Tatashin --- fs/proc/task_mmu.c | 61 -

[RFCv1 0/6] Page Detective

2024-11-16 Thread Pasha Tatashin
Page Detective is a new kernel debugging tool that provides detailed information about the usage and mapping of physical memory pages. It is often known that a particular page is corrupted, but it is hard to extract more information about such a page from live system. Examples are: - Checksum fai

Re: [PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Mauro Carvalho Chehab
Em Sat, 16 Nov 2024 13:27:44 +0100 Thorsten Leemhuis escreveu: > On 16.11.24 12:50, Mauro Carvalho Chehab wrote: > > Em Sat, 16 Nov 2024 11:42:06 +0100 > > Greg KH escreveu: > >> On Sat, Nov 16, 2024 at 10:33:59AM +0100, Thorsten Leemhuis wrote: > >>> Point out that explicit permission is us

Re: [PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Thorsten Leemhuis
On 16.11.24 12:38, Geert Uytterhoeven wrote: > On Sat, Nov 16, 2024 at 10:39 AM Thorsten Leemhuis > wrote: >> The latter is not a theoretical issue, as one maintainer mentioned that >> his employer received a EU GDPR (general data protection regulation) >> complaint after exposing a email address

Re: [PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Thorsten Leemhuis
On 16.11.24 12:50, Mauro Carvalho Chehab wrote: > Em Sat, 16 Nov 2024 11:42:06 +0100 > Greg KH escreveu: >> On Sat, Nov 16, 2024 at 10:33:59AM +0100, Thorsten Leemhuis wrote: >>> Point out that explicit permission is usually needed to tag other people >>> in changes, but mention that implicit perm

Re: [PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Mauro Carvalho Chehab
Em Sat, 16 Nov 2024 11:42:06 +0100 Greg KH escreveu: > On Sat, Nov 16, 2024 at 10:33:59AM +0100, Thorsten Leemhuis wrote: > > Point out that explicit permission is usually needed to tag other people > > in changes, but mention that implicit permission can be sufficient in > > certain cases. This

Re: [PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Geert Uytterhoeven
Hi Thorsten, On Sat, Nov 16, 2024 at 10:39 AM Thorsten Leemhuis wrote: > The latter is not a theoretical issue, as one maintainer mentioned that > his employer received a EU GDPR (general data protection regulation) > complaint after exposing a email address used in bugzilla through a tag > in a

[PATCH v2 1/2] docs: 5.Posting: mentioned Suggested-by: tag

2024-11-16 Thread Thorsten Leemhuis
Mentioned the Suggested-by: tag in 5.Posting.rst in a way similar to submitting-patches.rst, which according to the header of the latter is the less detailed document of the two. Signed-off-by: Thorsten Leemhuis --- Documentation/process/5.Posting.rst | 4 1 file changed, 4 insertions(+) d

Re: [PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Greg KH
On Sat, Nov 16, 2024 at 10:33:59AM +0100, Thorsten Leemhuis wrote: > Point out that explicit permission is usually needed to tag other people > in changes, but mention that implicit permission can be sufficient in > certain cases. This fixes slight inconsistencies between Reported-by: > and Suggest

Re: [PATCH v2 1/2] docs: 5.Posting: mentioned Suggested-by: tag

2024-11-16 Thread Greg KH
On Sat, Nov 16, 2024 at 10:33:58AM +0100, Thorsten Leemhuis wrote: > Mentioned the Suggested-by: tag in 5.Posting.rst in a way similar to > submitting-patches.rst, which according to the header of the latter is > the less detailed document of the two. > > Signed-off-by: Thorsten Leemhuis > --- >

[PATCH v2 2/2] docs: clarify rules wrt tagging other people

2024-11-16 Thread Thorsten Leemhuis
Point out that explicit permission is usually needed to tag other people in changes, but mention that implicit permission can be sufficient in certain cases. This fixes slight inconsistencies between Reported-by: and Suggested-by: and makes the usage more intuitive. While at it, explicitly mention

[PATCH v2 0/2] docs: reminder to not expose potentially private email addresses

2024-11-16 Thread Thorsten Leemhuis
Remind developers to not expose private email addresses, as some people become upset if their addresses end up in the lore archives or the Linux git tree -- especially when it comes to bugzilla.kernel.org. This fixes a few issues along the way that came up during preparation or review of the chang