Re: [PATCH] tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F

2024-07-02 Thread Google
On Tue, 2 Jul 2024 15:33:54 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > To prevent conflicts with other ioctl numbers to allow strace to have an > idea of what is happening, add the rang of ioctls for the trace buffer > mapping from _IO("T", 0x1) to the range of "R" 0x20 -

Re: [PATCH v2 0/2] Documentation: update information for mailing lists

2024-07-02 Thread Steven Rostedt
On Wed, 19 Jun 2024 14:24:05 -0400 Konstantin Ryabitsev wrote: > - drops the recommendation to use /r/ subpaths in lore.kernel.org links > (it has been unnecessary for a number of years) > - adds some detail on how to reference specific Link trailers from > inside the commit message > > Some of

Re: [PATCH] tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F

2024-07-02 Thread Steven Rostedt
On Tue, 2 Jul 2024 15:38:10 -0400 Mathieu Desnoyers wrote: > On 2024-07-02 15:33, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > To prevent conflicts with other ioctl numbers to allow strace to have an > > idea of what is happening, add the rang of ioctls for the trace buffer

Re: [PATCH] tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F

2024-07-02 Thread Mathieu Desnoyers
On 2024-07-02 15:33, Steven Rostedt wrote: From: "Steven Rostedt (Google)" To prevent conflicts with other ioctl numbers to allow strace to have an idea of what is happening, add the rang of ioctls for the trace buffer mapping from _IO("T", 0x1) to the range of "R" 0x20 - 0x2F. Link: https://

[PATCH] tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F

2024-07-02 Thread Steven Rostedt
From: "Steven Rostedt (Google)" To prevent conflicts with other ioctl numbers to allow strace to have an idea of what is happening, add the rang of ioctls for the trace buffer mapping from _IO("T", 0x1) to the range of "R" 0x20 - 0x2F. Link: https://lore.kernel.org/linux-trace-kernel/2024063010

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread David Hildenbrand
On 02.07.24 13:30, Alistair Popple wrote: David Hildenbrand writes: On 02.07.24 12:19, Alistair Popple wrote: David Hildenbrand writes: On 27.06.24 02:54, Alistair Popple wrote: Currently DAX folio/page reference counts are managed differently to normal pages. To allow these to be manage

Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn

2024-07-02 Thread David Hildenbrand
On 02.07.24 13:46, Christoph Hellwig wrote: On Tue, Jul 02, 2024 at 09:18:31AM +0200, David Hildenbrand wrote: We have this comparably nasty vmf_insert_mixed() that FS dax abused to insert into !VM_MIXED VMAs. Is that abuse now stopping and are there maybe ways to get rid of vmf_insert_mixed()?

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread Christoph Hellwig
On Tue, Jul 02, 2024 at 08:19:01PM +1000, Alistair Popple wrote: > > (B) As long as we have subpage mapcounts, this prevents vmemmap > > optimizations [1]. Is that only used for device-dax for now and are > > there no plans to make use of that for fs-dax? > > I don't have any plans to. Thi

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread Alistair Popple
David Hildenbrand writes: > On 02.07.24 12:19, Alistair Popple wrote: >> David Hildenbrand writes: >> >>> On 27.06.24 02:54, Alistair Popple wrote: Currently DAX folio/page reference counts are managed differently to normal pages. To allow these to be managed the same as normal page

Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn

2024-07-02 Thread Christoph Hellwig
On Tue, Jul 02, 2024 at 09:18:31AM +0200, David Hildenbrand wrote: > We have this comparably nasty vmf_insert_mixed() that FS dax abused to > insert into !VM_MIXED VMAs. Is that abuse now stopping and are there maybe > ways to get rid of vmf_insert_mixed()? Unfortunately it is also used by a few

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread David Hildenbrand
On 02.07.24 12:19, Alistair Popple wrote: David Hildenbrand writes: On 27.06.24 02:54, Alistair Popple wrote: Currently DAX folio/page reference counts are managed differently to normal pages. To allow these to be managed the same as normal pages introduce dax_insert_pfn_pud. This will map t

Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn

2024-07-02 Thread Alistair Popple
David Hildenbrand writes: > On 27.06.24 02:54, Alistair Popple wrote: >> Currently to map a DAX page the DAX driver calls vmf_insert_pfn. This >> creates a special devmap PTE entry for the pfn but does not take a >> reference on the underlying struct page for the mapping. This is >> because DAX

Re: [PATCH 09/13] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages

2024-07-02 Thread David Hildenbrand
On 02.07.24 01:47, Alistair Popple wrote: David Hildenbrand writes: On 27.06.24 02:54, Alistair Popple wrote: Longterm pinning of FS DAX pages should already be disallowed by various pXX_devmap checks. However a future change will cause these checks to be invalid for FS DAX pages so make fol

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread Alistair Popple
David Hildenbrand writes: > On 27.06.24 02:54, Alistair Popple wrote: >> Currently DAX folio/page reference counts are managed differently to >> normal pages. To allow these to be managed the same as normal pages >> introduce dax_insert_pfn_pud. This will map the entire PUD-sized folio >> and t

Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn

2024-07-02 Thread David Hildenbrand
On 27.06.24 02:54, Alistair Popple wrote: Currently to map a DAX page the DAX driver calls vmf_insert_pfn. This creates a special devmap PTE entry for the pfn but does not take a reference on the underlying struct page for the mapping. This is because DAX page refcounts are treated specially, as

Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages

2024-07-02 Thread David Hildenbrand
On 27.06.24 02:54, Alistair Popple wrote: Currently DAX folio/page reference counts are managed differently to normal pages. To allow these to be managed the same as normal pages introduce dax_insert_pfn_pud. This will map the entire PUD-sized folio and take references as it would for a normally