[PATCH 2/2] docs: stable-kernel-rules: remind reader about DCO

2024-06-05 Thread Shung-Hsi Yu
When sending patch authored by someone else to stable, it is quite easy for the sender to forget adding the Developer's Certification of Origin (DCO, i.e. Signed-off-by). Mention DCO explicilty so senders are less likely to forget to do so and cause another round-trip. Add a label in submitting-pa

[PATCH 1/2] docs: stable-kernel-rules: provide example of specifying target series

2024-06-05 Thread Shung-Hsi Yu
Provide a concrete example of how to specify what stable series should be targeted for change inclusion. Looking around on the stable mailing list this seems like a common practice already, so let's mention that in the documentation as well (but worded so it is not interpreted as the only way to do

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Dmitry Safonov
On Wed, 5 Jun 2024 at 18:37, Eric Dumazet wrote: > > On Wed, Jun 5, 2024 at 7:35 PM Dmitry Safonov <0x7f454...@gmail.com> wrote: > > > > Hi Eric, > > > > Thanks for the review, > > > > On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: [..] > > > Then we probably do not need EXPORT_SYMBOL(tcp_inbou

[PATCH net-next v3 6/6] Documentation/tcp-ao: Add a few lines on tracepoints

2024-06-05 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Documentation/networking/tcp_ao.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/tcp_ao.rst b/Documentation/networking/tcp_ao.rst index 8a58321acce7..e96e

[PATCH net-next v3 5/6] net/tcp: Remove tcp_hash_fail()

2024-06-05 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Now there are tracepoints, that cover all functionality of tcp_hash_fail(), but also wire up missing places They are also faster, can be disabled and provide filtering. This potentially may create a regression if a userspace depends on dmesg logs. Finge

[PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. While at it, unexport and make static tcp_inbound_ao_hash(). Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> ---

[PATCH net-next v3 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

2024-06-05 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> It's possible to clean-up some ifdefs by hiding that tcp_{md5,ao}_needed static branch is defined and compiled only under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce AO/MD5 logs if there are any keys"). Reviewed-by: Eric Dumazet

[PATCH net-next v3 4/6] net/tcp: Add tcp-md5 and tcp-ao tracepoints

2024-06-05 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Instead of forcing userspace to parse dmesg (that's what currently is happening, at least in codebase of my current company), provide a better way, that can be enabled/disabled in runtime. Currently, there are already tcp events, add hashing related one

[PATCH net-next v3 0/6] net/tcp: TCP-AO and TCP-MD5 tracepoints

2024-06-05 Thread Dmitry Safonov via B4 Relay
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Changes in v3: - Unexported tcp_inbound_ao_hash() and made static (Eric Dumazet) - Link to v2: https://lore.kernel.org/r/20240605-tcp_ao-tracepoints-v2-0-e91e16128...@gmail.com Changes in v2: - Fix the build with CONFIG_IPV6=m

[PATCH net-next v3 2/6] net/tcp: Add a helper tcp_ao_hdr_maclen()

2024-06-05 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> It's going to be used more in TCP-AO tracepoints. Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- include/net/tcp_ao.h | 5 + net/ipv4/tcp_ao.c| 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/net/tcp_ao.h b

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Eric Dumazet
On Wed, Jun 5, 2024 at 7:35 PM Dmitry Safonov <0x7f454...@gmail.com> wrote: > > Hi Eric, > > Thanks for the review, > > On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: > > > > On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay > > wrote: > > > > > > From: Dmitry Safonov <0x7f454...@gmail

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Dmitry Safonov
Hi Eric, Thanks for the review, On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: > > On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay > wrote: > > > > From: Dmitry Safonov <0x7f454...@gmail.com> > > > > Two reasons: > > 1. It's grown up enough > > 2. In order to not do header spaghett

Re: [PATCH net-next v2 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

2024-06-05 Thread Dmitry Safonov
On Wed, 5 Jun 2024 at 05:50, Ratheesh Kannoth wrote: > > On 2024-06-05 at 07:50:02, Dmitry Safonov via B4 Relay > (devnull+0x7f454c46.gmail@kernel.org) wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > > > It's possible to clean-up some ifdefs by hiding that > > tcp_{md5,ao}_needed s

[PATCH v5 2/2] proc: restrict /proc/pid/mem

2024-06-05 Thread Adrian Ratiu
v5: * Fixed 2 typos by Randy D. (thanks!) * Fixed mm_access() resource leak * Rebased on next-20240605 --- .../admin-guide/kernel-parameters.txt | 38 + fs/proc/base.c| 130 +- security/Kconfig | 68 ++

[PATCH v5 1/2] proc: pass file instead of inode to proc_mem_open

2024-06-05 Thread Adrian Ratiu
inside it. Cc: Jann Horn Cc: Kees Cook Cc: Christian Brauner Cc: Jeff Xu Signed-off-by: Adrian Ratiu Reviewed-by: Kees Cook --- Changes in v5: * Fixed task_nommu.c 0day build error * Added Reviewed-by tag by Kees C. (thanks!) * Rebased on next-20240605 --- fs/proc/base.c | 6 +++--- fs/proc

Re: [PATCH net-next v2 5/6] net/tcp: Remove tcp_hash_fail()

2024-06-05 Thread Eric Dumazet
On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > Now there are tracepoints, that cover all functionality of > tcp_hash_fail(), but also wire up missing places > They are also faster, can be disabled and provide filtering. > > Thi

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Eric Dumazet
On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > Signed-off-by: Dmitry Safonov <0x7f4

Re: [PATCH net-next v2 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

2024-06-05 Thread Eric Dumazet
On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > It's possible to clean-up some ifdefs by hiding that > tcp_{md5,ao}_needed static branch is defined and compiled only > under related configs, since commit 4c8530dc7d7d ("net/tcp: