Re: [PATCH v2 4/4] remoteproc: qcom_q6v5_pas: Add hwspinlock bust on stop

2024-05-28 Thread Bjorn Andersson
On Fri, May 24, 2024 at 06:26:43PM -0700, Chris Lew wrote: > From: Richard Maina > > When remoteproc goes down unexpectedly this results in a state where any > acquired hwspinlocks will remain locked possibly resulting in deadlock. > In order to ensure all locks are freed we include a call to > q

Re: [PATCH v2 2/4] hwspinlock: qcom: implement bust operation

2024-05-28 Thread Bjorn Andersson
On Fri, May 24, 2024 at 06:26:41PM -0700, Chris Lew wrote: > From: Richard Maina > > Implement a new operation qcom_hwspinlock_bust() which can be invoked > to bust any locks that are in use when a remoteproc is stopped or > crashed. > > Signed-off-by: Richard Maina > Signed-off-by: Chris Lew

Re: [PATCH v2 1/4] hwspinlock: Introduce hwspin_lock_bust()

2024-05-28 Thread Bjorn Andersson
On Fri, May 24, 2024 at 06:26:40PM -0700, Chris Lew wrote: > From: Richard Maina > > When a remoteproc crashes or goes down unexpectedly this can result in > a state where locks held by the remoteproc will remain locked possibly > resulting in deadlock. This new API hwspin_lock_bust() allows > hw

Re: Re: [PATCH v2 3/4] soc: qcom: smem: Add qcom_smem_bust_hwspin_lock_by_host()

2024-05-28 Thread Bjorn Andersson
On Tue, May 28, 2024 at 03:50:25PM -0700, Chris Lew wrote: > > > On 5/28/2024 2:55 PM, Bjorn Andersson wrote: > > On Fri, May 24, 2024 at 06:26:42PM GMT, Chris Lew wrote: > > > Add qcom_smem_bust_hwspin_lock_by_host to enable remoteproc to bust the > > > hwspin_lock owned by smem. In the event th

Re: [PATCH v2 3/4] soc: qcom: smem: Add qcom_smem_bust_hwspin_lock_by_host()

2024-05-28 Thread Chris Lew
On 5/28/2024 2:55 PM, Bjorn Andersson wrote: On Fri, May 24, 2024 at 06:26:42PM GMT, Chris Lew wrote: Add qcom_smem_bust_hwspin_lock_by_host to enable remoteproc to bust the hwspin_lock owned by smem. In the event the remoteproc crashes unexpectedly, the remoteproc driver can invoke this API

Re: [PATCH v2 3/4] soc: qcom: smem: Add qcom_smem_bust_hwspin_lock_by_host()

2024-05-28 Thread Bjorn Andersson
On Fri, May 24, 2024 at 06:26:42PM GMT, Chris Lew wrote: > Add qcom_smem_bust_hwspin_lock_by_host to enable remoteproc to bust the > hwspin_lock owned by smem. In the event the remoteproc crashes > unexpectedly, the remoteproc driver can invoke this API to try and bust > the hwspin_lock and release