Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Heng Qi
On Mon, 13 May 2024 11:42:33 -0700, Jakub Kicinski wrote: > On Mon, 13 May 2024 23:39:04 +0800 Heng Qi wrote: > > config PROVE_LOCKING > > bool "Lock debugging: prove locking correctness" > > - depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT > > + depends on DEBUG_KERNEL &&

Re: [PATCH v3 1/2] proc: restrict /proc/pid/mem access via param knobs

2024-05-13 Thread Kees Cook
On Fri, May 03, 2024 at 11:57:56AM +0200, Christian Brauner wrote: > On Fri, Apr 26, 2024 at 04:10:49PM -0700, Kees Cook wrote: > > On Tue, Apr 09, 2024 at 08:57:49PM +0300, Adrian Ratiu wrote: > > > Prior to v2.6.39 write access to /proc//mem was restricted, > > > after which it got allowed in com

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Jakub Kicinski
On Mon, 13 May 2024 23:39:04 +0800 Heng Qi wrote: > config PROVE_LOCKING > bool "Lock debugging: prove locking correctness" > - depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT > + depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && NET We can't make lockdep dependent on NET

Re: [PATCH v2 2/2] Documentation: hyperv: Improve synic and interrupt handling description

2024-05-13 Thread Easwar Hariharan
On 5/11/2024 6:38 AM, mhkelle...@gmail.com wrote: > From: Michael Kelley > > Current documentation does not describe how Linux handles the synthetic > interrupt controller (synic) that Hyper-V provides to guest VMs, nor how > VMBus or timer interrupts are handled. Add text describing the synic an

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Heng Qi
On Mon, 13 May 2024 08:24:12 -0700, Jakub Kicinski wrote: > On Mon, 13 May 2024 22:52:13 +0800 Heng Qi wrote: > > > > So I think we should declare "CONFIG_PROVE_LOCKING depends on > > > > CONFIG_NET". > > > > How do you think? > > > > > > Doesn't sound right, `can we instead make building lib/

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Jakub Kicinski
On Mon, 13 May 2024 22:52:13 +0800 Heng Qi wrote: > > > So I think we should declare "CONFIG_PROVE_LOCKING depends on CONFIG_NET". > > > How do you think? > > > > Doesn't sound right, `can we instead make building lib/dim/net_dim.c > > Why? IIUC, the reason is that if CONFIG_NET is not set to

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Heng Qi
On Mon, 13 May 2024 07:22:49 -0700, Jakub Kicinski wrote: > On Mon, 13 May 2024 00:36:58 +0800 Heng Qi wrote: > > This failed use case seems to come from this series triggering a problem > > that > > has not been triggered historically, namely lockdep_rtnl_is_held() is not > > called > > in an e

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Jakub Kicinski
On Mon, 13 May 2024 00:36:58 +0800 Heng Qi wrote: > This failed use case seems to come from this series triggering a problem that > has not been triggered historically, namely lockdep_rtnl_is_held() is not > called > in an environment where CONFIG_NET is not configured and CONFIG_PROVE_LOCKING >

[PATCH docs-next v3] docs: handling-regressions.rst: recommend using "Closes:" tags

2024-05-13 Thread Karel Balej
Update the handling-regressions guide to recommend using "Closes:" tags rather than "Link:" when referencing fixed reports. The latter was used originally but now is only recommended when the given patch only fixes part of the issue, as described in submitting-patches. Briefly mention that and also