Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-04-02 Thread Joe Perches
On Wed, 2024-04-03 at 10:21 +1300, Barry Song wrote: > On Wed, Apr 3, 2024 at 5:13 AM Jonathan Corbet wrote: > > > > So I'm not sure what your desired path for getting this upstream is. I > > can take it, but I'm generally quite leery of taking coding-style > > changes without some serious acks

Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-04-02 Thread Barry Song
On Wed, Apr 3, 2024 at 5:13 AM Jonathan Corbet wrote: > > So I'm not sure what your desired path for getting this upstream is. I > can take it, but I'm generally quite leery of taking coding-style > changes without some serious acks on them - nobody elected me as the > arbiter of proper coding st

Re: [PATCH] docs: submitting-patches: describe additional tags

2024-04-02 Thread Bjorn Andersson
On Mon, Apr 01, 2024 at 08:17:03AM +0300, Dmitry Baryshkov wrote: > Described tags do not fully cover development needs. For example the LKP > robot insists on using Reported-by: tag, but that's not fully correct. > The robot reports an issue with the patch, not the issue that is being > fixed by t

Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-04-02 Thread Jonathan Corbet
So I'm not sure what your desired path for getting this upstream is. I can take it, but I'm generally quite leery of taking coding-style changes without some serious acks on them - nobody elected me as the arbiter of proper coding style. A nit below Barry Song <21cn...@gmail.com> writes: > From

Re: [PATCH] trace doc: Minor grammatical correction

2024-04-02 Thread Jonathan Corbet
Sarat Mandava writes: > Use the correct relative pronoun. > > Signed-off-by: Sarat Mandava > --- > Documentation/trace/tracepoints.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/trace/tracepoints.rst > b/Documentation/trace/tracepoints.rst > index 0c

Re: [PATCH v5 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-04-02 Thread Mac Xu
> On Tue, 2024-04-02 at 00:16 +, Mac Xu wrote: > > > On Mon, 2024-04-01 at 14:21 +1300, Barry Song wrote: > > > > From: Xining Xu > > > > > > > > If function-like macros do not utilize a parameter, it might result in a > > > > build warning. In our coding style guidelines, we advocate for

Re: [PATCH 2/2] docs: handling-regressions.rst: clarify that "Closes:" tags work too

2024-04-02 Thread Karel Balej
Thorsten, thank you very much for your feedback. Thorsten Leemhuis, 2024-04-02T11:27:57+02:00: > On 01.04.24 17:19, Randy Dunlap wrote: > > On 4/1/24 1:38 AM, Thorsten Leemhuis wrote: > >> On 28.03.24 20:29, Karel Balej wrote: > >>> The regressions handling manual claims that regzbot associates p

Re: [PATCH 2/2] docs: handling-regressions.rst: clarify that "Closes:" tags work too

2024-04-02 Thread Thorsten Leemhuis
On 01.04.24 17:19, Randy Dunlap wrote: > On 4/1/24 1:38 AM, Thorsten Leemhuis wrote: >> On 28.03.24 20:29, Karel Balej wrote: >>> The regressions handling manual claims that regzbot associates patches >>> fixing an issue with the report based on the occurrence of the >>> appropriate "Link:" trailer