Re: [PATCH v4 0/2] codingstyle: avoid unused parameters for a function-like macro

2024-03-27 Thread Barry Song
On Thu, Mar 28, 2024 at 3:21 PM Barry Song <21cn...@gmail.com> wrote: > > From: Barry Song > > -v4: > * fix Xining's email address, s/ma@outlook.com/mac@outlook.com/g Hi Andrew, Apologies for the oversight. Could you please apply these two patches to replace the ones in the mm-nonmm-uns

[PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-27 Thread Barry Song
From: Xining Xu If function-like macros do not utilize a parameter, it might result in a build warning. In our coding style guidelines, we advocate for utilizing static inline functions to replace such macros. This patch verifies compliance with the new rule. For a macro such as the one below,

[PATCH v4 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-03-27 Thread Barry Song
From: Barry Song Recent commit 77292bb8ca69c80 ("crypto: scomp - remove memcpy if sg_nents is 1 and pages are lowmem") leads to warnings on xtensa and loongarch, In file included from crypto/scompress.c:12: include/crypto/scatterwalk.h: In function 'scatterwalk_pagedone': include/crypto/

[PATCH v4 0/2] codingstyle: avoid unused parameters for a function-like macro

2024-03-27 Thread Barry Song
From: Barry Song -v4: * fix Xining's email address, s/ma@outlook.com/mac@outlook.com/g * fix some false positives of checkpatch.pl * downgrade from ERROR to WARN in checkpatch.pl Thanks for Joe's comments! -v3: https://lore.kernel.org/all/20240322084937.66018-1-21cn...@gmail.com/