Re: [RFC PATCH 11/20] famfs: Add fs_context_operations

2024-02-27 Thread Randy Dunlap
On 2/27/24 16:59, John Groves wrote: > On 24/02/27 02:41PM, Christian Brauner wrote: >> On Fri, Feb 23, 2024 at 11:41:55AM -0600, John Groves wrote: >>> This commit introduces the famfs fs_context_operations and >>> famfs_get_inode() which is used by the context operations. >>> >>> Signed-off-by

Re: [RFC PATCH 08/20] famfs: Add famfs_internal.h

2024-02-27 Thread John Groves
On 24/02/27 10:28AM, Jonathan Cameron wrote: > On Mon, 26 Feb 2024 11:35:17 -0600 > John Groves wrote: > > > On 24/02/26 12:48PM, Jonathan Cameron wrote: > > > On Fri, 23 Feb 2024 11:41:52 -0600 > > > John Groves wrote: > > > > > > > Add the famfs_internal.h include file. This contains intern

Re: [RFC PATCH 11/20] famfs: Add fs_context_operations

2024-02-27 Thread John Groves
On 24/02/27 02:41PM, Christian Brauner wrote: > On Fri, Feb 23, 2024 at 11:41:55AM -0600, John Groves wrote: > > This commit introduces the famfs fs_context_operations and > > famfs_get_inode() which is used by the context operations. > > > > Signed-off-by: John Groves > > --- > > fs/famfs/famfs

Re: [RFC PATCH 18/20] famfs: Support character dax via the dev_dax_iomap patch

2024-02-27 Thread John Groves
On 24/02/26 01:52PM, Jonathan Cameron wrote: > On Fri, 23 Feb 2024 11:42:02 -0600 > John Groves wrote: > > > This commit introduces the ability to open a character /dev/dax device > > instead of a block /dev/pmem device. This rests on the dev_dax_iomap > > patches earlier in this series. > > Not

Re: [RFC PATCH 17/20] famfs: Add module stuff

2024-02-27 Thread John Groves
On 24/02/26 01:47PM, Jonathan Cameron wrote: > On Fri, 23 Feb 2024 11:42:01 -0600 > John Groves wrote: > > > This commit introduces the module init and exit machinery for famfs. > > > > Signed-off-by: John Groves > I'd prefer to see this from the start with the functionality of the module > bui

Re: [RFC PATCH 10/20] famfs: famfs_open_device() & dax_holder_operations

2024-02-27 Thread John Groves
On 24/02/27 02:39PM, Christian Brauner wrote: > On Fri, Feb 23, 2024 at 11:41:54AM -0600, John Groves wrote: > > Famfs works on both /dev/pmem and /dev/dax devices. This commit introduces > > the function that opens a block (pmem) device and the struct > > dax_holder_operations that are needed for

Re: [RFC PATCH 09/20] famfs: Add super_operations

2024-02-27 Thread John Groves
On 24/02/26 12:51PM, Jonathan Cameron wrote: > On Fri, 23 Feb 2024 11:41:53 -0600 > John Groves wrote: > > + */ > > +static int famfs_show_options( > > + struct seq_file *m, > > + struct dentry *root) > Not that familiar with fs code, but this unusual kernel style. I'd go with > something m

Re: [RFC PATCH 08/20] famfs: Add famfs_internal.h

2024-02-27 Thread John Groves
On 24/02/27 02:38PM, Christian Brauner wrote: > On Fri, Feb 23, 2024 at 11:41:52AM -0600, John Groves wrote: > > Add the famfs_internal.h include file. This contains internal data > > structures such as the per-file metadata structure (famfs_file_meta) > > and extent formats. > > > > Signed-off-by

Re: [RFC PATCH 11/20] famfs: Add fs_context_operations

2024-02-27 Thread Christian Brauner
On Fri, Feb 23, 2024 at 11:41:55AM -0600, John Groves wrote: > This commit introduces the famfs fs_context_operations and > famfs_get_inode() which is used by the context operations. > > Signed-off-by: John Groves > --- > fs/famfs/famfs_inode.c | 178 + >

Re: [RFC PATCH 10/20] famfs: famfs_open_device() & dax_holder_operations

2024-02-27 Thread Christian Brauner
On Fri, Feb 23, 2024 at 11:41:54AM -0600, John Groves wrote: > Famfs works on both /dev/pmem and /dev/dax devices. This commit introduces > the function that opens a block (pmem) device and the struct > dax_holder_operations that are needed for that ABI. > > In this commit, support for opening cha

Re: [RFC PATCH 08/20] famfs: Add famfs_internal.h

2024-02-27 Thread Christian Brauner
On Fri, Feb 23, 2024 at 11:41:52AM -0600, John Groves wrote: > Add the famfs_internal.h include file. This contains internal data > structures such as the per-file metadata structure (famfs_file_meta) > and extent formats. > > Signed-off-by: John Groves > --- > fs/famfs/famfs_internal.h | 53 +++

Re: [PATCH] docs: submit-checklist: structure by category

2024-02-27 Thread Geert Uytterhoeven
Hi Lukas, On Tue, Feb 27, 2024 at 12:04 PM Lukas Bulwahn wrote: > On Tue, Feb 27, 2024 at 9:57 AM Geert Uytterhoeven > wrote: > > On Tue, Feb 27, 2024 at 1:41 AM Randy Dunlap wrote: > > > > - Concerning checking with tools, checkpatch probably still makes > > > > sense; > > > > it point

Re: [PATCH] docs: submit-checklist: structure by category

2024-02-27 Thread Lukas Bulwahn
On Tue, Feb 27, 2024 at 9:57 AM Geert Uytterhoeven wrote: > > Hi Randy, > > On Tue, Feb 27, 2024 at 1:41 AM Randy Dunlap wrote: > > > - Concerning checking with tools, checkpatch probably still makes sense; > > > it pointed out in several places. If sparse and checkstack are really > > >

Re: [RFC PATCH 09/20] famfs: Add super_operations

2024-02-27 Thread Jonathan Cameron
On Mon, 26 Feb 2024 15:47:53 -0600 John Groves wrote: > On 24/02/26 12:51PM, Jonathan Cameron wrote: > > On Fri, 23 Feb 2024 11:41:53 -0600 > > John Groves wrote: > > > > > Introduce the famfs superblock operations > > > > > > Signed-off-by: John Groves > > > --- > > > fs/famfs/famfs_inode

Re: [RFC PATCH 08/20] famfs: Add famfs_internal.h

2024-02-27 Thread Jonathan Cameron
On Mon, 26 Feb 2024 11:35:17 -0600 John Groves wrote: > On 24/02/26 12:48PM, Jonathan Cameron wrote: > > On Fri, 23 Feb 2024 11:41:52 -0600 > > John Groves wrote: > > > > > Add the famfs_internal.h include file. This contains internal data > > > structures such as the per-file metadata struct

Re: [PATCH] docs: submit-checklist: structure by category

2024-02-27 Thread Geert Uytterhoeven
Hi Randy, On Tue, Feb 27, 2024 at 1:41 AM Randy Dunlap wrote: > > - Concerning checking with tools, checkpatch probably still makes sense; > > it pointed out in several places. If sparse and checkstack are really > > the next two tools to point out, I am not so sure about. > > I doubt t

Re: [PATCH] docs: submit-checklist: structure by category

2024-02-27 Thread Lukas Bulwahn
On Tue, Feb 27, 2024 at 1:41 AM Randy Dunlap wrote: > > Hi Lukas, > > I'll review the file changes separately. This is just replying > to the patch description comments. > > > On 2/26/24 02:46, Lukas Bulwahn wrote: (snipped) > > > Note that the previous first point still remains the first list eve