Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-24 Thread Randy Dunlap
On 2/24/24 15:32, John Groves wrote: > On 24/02/23 07:27PM, Randy Dunlap wrote: >> Hi John, >> >> On 2/23/24 18:23, John Groves wrote: > + > +#define FAMFSIOC_MAGIC 'u' This 'u' value should be documented in Documentation/userspace-api/ioctl/ioctl-number.rst. and if p

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-24 Thread John Groves
On 24/02/23 07:27PM, Randy Dunlap wrote: > Hi John, > > On 2/23/24 18:23, John Groves wrote: > >>> + > >>> +#define FAMFSIOC_MAGIC 'u' > >> This 'u' value should be documented in > >> Documentation/userspace-api/ioctl/ioctl-number.rst. > >> > >> and if possible, you might want to use values like 0