Re: [PATCH v3] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-01-23 Thread Bjorn Andersson
On Mon, Jan 22, 2024 at 02:56:45PM +0100, Joel Granados wrote: > On Fri, Jan 19, 2024 at 04:08:24PM +0800, Huang Yiwei wrote: [..] > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c [..] > > +enum ftrace_dump_mode get_ftrace_dump_mode(void) > > +{ > > + if (!strcmp("0", ftrace_dump_on_o

Re: [PATCH v3] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-01-23 Thread Steven Rostedt
On Tue, 23 Jan 2024 09:49:00 -0500 Steven Rostedt wrote: > On Tue, 23 Jan 2024 18:23:58 +0800 > Huang Yiwei wrote: > > > > And if we really want to be fancy! > > > > > > ftrace_dump_on_opps[=orig_cpu | = | =orig_cpu: > > > ][, | ,:orig_cpu] > > > > > Yeah, I agree to make the parameter

Re: [PATCH v3] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-01-23 Thread Steven Rostedt
On Tue, 23 Jan 2024 18:23:58 +0800 Huang Yiwei wrote: > > And if we really want to be fancy! > > > > ftrace_dump_on_opps[=orig_cpu | = | =orig_cpu: > > ][, | ,:orig_cpu] > > > Yeah, I agree to make the parameter more flexible. > > "=orig_cpu:" means to dump global and another instance?

Re: [PATCH v3] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-01-23 Thread Huang Yiwei
On 1/20/2024 12:56 AM, Steven Rostedt wrote: On Fri, 19 Jan 2024 16:08:24 +0800 Huang Yiwei wrote: - ftrace_dump_on_oops[=orig_cpu] + ftrace_dump_on_oops[=orig_cpu | =] I wonder if we should have it be: ftrace_dump_on_oops[=orig_cpu | = | =:orig_cpu ] Then last would