Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Al Viro
On Thu, Jan 04, 2024 at 11:35:37AM -0800, Linus Torvalds wrote: > > "file description" - is how the file is accessed (position in the file and > > flags associated to how it was opened) > > That's a horrible term that shouldn't be used at all. Apparently some > people use

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Linus Torvalds
On Thu, 4 Jan 2024 at 11:35, Linus Torvalds wrote: >> > Which is *NOT* the inode, because the 'struct file' has other things > in it (the file position, the permissions that were used at open time > etc, close-on-exec state etc etc). That close-on-exec thing was a particularly bad example of thin

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Linus Torvalds
On Thu, 4 Jan 2024 at 11:14, Steven Rostedt wrote: > > "file descriptor" - is just what maps to a specific inode. Nope. Technically and traditionally, file descriptor is just the integer index that is used to look up a 'struct file *'. Except in the kernel, we really just tend to use that term (

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Matthew Wilcox
On Thu, Jan 04, 2024 at 02:15:17PM -0500, Steven Rostedt wrote: > On Thu, 4 Jan 2024 18:25:02 + > Al Viro wrote: > > > Unfortunately, the terms are clumsy as hell - POSIX ends up with > > "file descriptor" (for numbers) vs. "file description" (for IO > > channels), which is hard to distinguis

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Linus Torvalds
On Thu, 4 Jan 2024 at 11:09, Steven Rostedt wrote: > > My mistake was thinking that the dentry was attached more to the path than > the inode. But that doesn't seem to be the case. I wasn't sure if there was > a way to get to a dentry from the inode. Yeah, so dentry->inode and path->dentry are on

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Steven Rostedt
On Thu, 4 Jan 2024 18:25:02 + Al Viro wrote: > Unfortunately, the terms are clumsy as hell - POSIX ends up with > "file descriptor" (for numbers) vs. "file description" (for IO > channels), which is hard to distinguish when reading and just > as hard to distinguish when listening. "Opened fi

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Steven Rostedt
On Thu, 4 Jan 2024 18:25:02 + Al Viro wrote: > On Thu, Jan 04, 2024 at 10:05:44AM -0500, Steven Rostedt wrote: > > > This is the "tribal knowledge" I'm talking about. I really didn't know how > > the root dentry parent worked. I guess that makes sense, as it matches the > > '..' of a directo

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Matthew Wilcox
On Thu, Jan 04, 2024 at 10:05:44AM -0500, Steven Rostedt wrote: > > file_system_type: what filesystem instances belong to. Not quite the same > > thing as fs driver (one driver can provide several of those). Usually > > it's 1-to-1, but that's not required (e.g. NFS vs NFSv4, or ext[234], > > or

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Al Viro
On Thu, Jan 04, 2024 at 10:05:44AM -0500, Steven Rostedt wrote: > This is the "tribal knowledge" I'm talking about. I really didn't know how > the root dentry parent worked. I guess that makes sense, as it matches the > '..' of a directory, and the '/' directory '..' points to itself. Although > m

Re: [PATCH v8 08/20] virt: geniezone: Add vcpu support

2024-01-04 Thread Simon Horman
On Thu, Dec 28, 2023 at 06:51:35PM +0800, Yi-De Wu wrote: > From: "Yingshiuan Pan" > > VMM use this interface to create vcpu instance which is a fd, and this > fd will be for any vcpu operations, such as setting vcpu registers and > accepts the most important ioctl GZVM_VCPU_RUN which requests Ge

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-04 Thread Steven Rostedt
On Thu, 4 Jan 2024 04:39:45 + Al Viro wrote: > On Wed, Jan 03, 2024 at 09:25:06PM -0500, Steven Rostedt wrote: > > On Thu, 4 Jan 2024 01:48:37 + > > Al Viro wrote: > > > > > On Wed, Jan 03, 2024 at 08:32:46PM -0500, Steven Rostedt wrote: > > > > > > > + /* Get the tracefs roo