Re: [PATCH v4 08/14] mm/gup: grab head page refcount once for group of subpages

2021-09-29 Thread Alistair Popple
On Thursday, 30 September 2021 5:34:05 AM AEST Jason Gunthorpe wrote: > On Wed, Sep 29, 2021 at 12:50:15PM +0100, Joao Martins wrote: > > > > If the get_dev_pagemap has to remain then it just means we have to > > > flush before changing pagemap pointers > > Right -- I don't think we should need it

Re: [PATCH v4 08/14] mm/gup: grab head page refcount once for group of subpages

2021-09-29 Thread Jason Gunthorpe
On Wed, Sep 29, 2021 at 12:50:15PM +0100, Joao Martins wrote: > > If the get_dev_pagemap has to remain then it just means we have to > > flush before changing pagemap pointers > Right -- I don't think we should need it as that discussion on the other > thread goes. > > OTOH, using @pgmap might be

Re: [PATCH v4 08/14] mm/gup: grab head page refcount once for group of subpages

2021-09-29 Thread Joao Martins
On 9/28/21 19:01, Jason Gunthorpe wrote: > On Thu, Sep 23, 2021 at 05:51:04PM +0100, Joao Martins wrote: >> So ... if pgmap accounting was removed from gup-fast then this patch >> would be a lot simpler and we could perhaps just fallback to the regular >> hugepage case (THP, HugeTLB) like your sugg