Re: [PATCH v3 13/14] mm/gup: grab head page refcount once for group of subpages

2021-08-25 Thread Joao Martins
On 8/25/21 8:15 PM, Matthew Wilcox wrote: > On Wed, Aug 25, 2021 at 08:10:39PM +0100, Joao Martins wrote: >> @@ -2273,8 +2273,7 @@ static int __gup_device_huge(unsigned long pfn, >> unsigned long addr, >> refs = record_subpages(page, addr, next, pages + *nr); >> >>

Re: [PATCH v3 13/14] mm/gup: grab head page refcount once for group of subpages

2021-08-25 Thread Matthew Wilcox
On Wed, Aug 25, 2021 at 08:10:39PM +0100, Joao Martins wrote: > @@ -2273,8 +2273,7 @@ static int __gup_device_huge(unsigned long pfn, > unsigned long addr, > refs = record_subpages(page, addr, next, pages + *nr); > > SetPageReferenced(head); > - pinne

Re: [PATCH v3 13/14] mm/gup: grab head page refcount once for group of subpages

2021-08-25 Thread Joao Martins
On 7/28/21 9:23 PM, Dan Williams wrote: > On Wed, Jul 28, 2021 at 1:08 PM Joao Martins > wrote: >> On 7/28/21 8:55 PM, Dan Williams wrote: >>> On Wed, Jul 14, 2021 at 12:36 PM Joao Martins >>> wrote: Use try_grab_compound_head() for device-dax GUP when configured with a compound