Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Joe Perches
On Fri, 2019-10-11 at 10:46 -0700, Linus Torvalds wrote: > On Fri, Oct 11, 2019 at 10:43 AM Joe Perches wrote: > > Shouldn't a conversion script be public somewhere? > > I feel the ones that might want to do the conversion on their own are > the ones that don't necessarily trust the script. > >

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Miguel Ojeda
On Sat, Oct 12, 2019 at 12:08 AM Kees Cook wrote: > > On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > > Hi Linus, > > > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > > wrote: > > > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > > > > > Add 'fallthrough' pseu

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Kees Cook
On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > Hi Linus, > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > wrote: > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > > like '/* fallthroug

Re: [RFC][PATCH] docs: process: Submitting a patch for a single git commit.

2019-10-11 Thread Ingo Rohloff
On Fri, 11 Oct 2019 11:23:57 -0600 Jonathan Corbet wrote: > On Fri, 11 Oct 2019 18:33:58 +0200 > Ingo Rohloff wrote: > > ... > > I think we should find a place for this kind of information, but I don't > think submitting-patches.rst is it. That's meant to be a comprehensive set > of rules and

[PATCH v1 1/3] of: property: Minor code formatting/style clean ups

2019-10-11 Thread Saravana Kannan
Better variable and function names. Remove "," after the sentinel in an array initialization list. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 923d6f8

[PATCH v1 2/3] driver: core: Improve documentation for fwnode_operations.add_links()

2019-10-11 Thread Saravana Kannan
The add_links() ops shouldn't return on the first failed device link add. It needs to continue trying to add device links to other suppliers that are available. The documentation didn't explain WHY this behavior is necessary. So, update the documentation with an example that explains why this is ne

[PATCH v1 3/3] docs: driver-model: Add documentation for sync_state

2019-10-11 Thread Saravana Kannan
The sync_state() driver callback was added recently, but the documentation was missing. Adding it now. Signed-off-by: Saravana Kannan --- .../driver-api/driver-model/driver.rst| 43 +++ 1 file changed, 43 insertions(+) diff --git a/Documentation/driver-api/driver-model/

[PATCH v1 0/3] Documentation/minor coding style fix ups

2019-10-11 Thread Saravana Kannan
Addressing a few coding style comments and adding a bunch of documentation. Saravana Kannan (3): of: property: Minor code formatting/style clean ups driver: core: Improve documentation for fwnode_operations.add_links() docs: driver-model: Add documentation for sync_state .../driver-api/dri

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Miguel Ojeda
Hi Linus, On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds wrote: > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > like '/* fallthrough */'. > > I applied patches 1-3 to my tree just to make it easier for people to

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Linus Torvalds
On Fri, Oct 11, 2019 at 10:43 AM Joe Perches wrote: > > Shouldn't a conversion script be public somewhere? I feel the ones that might want to do the conversion on their own are the ones that don't necessarily trust the script. But I don't even know if anybody does want to, I just feel it's an op

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Joe Perches
On Fri, 2019-10-11 at 09:29 -0700, Linus Torvalds wrote: > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > like '/* fallthrough */'. > > I applied patches 1-3 to my tree just to make it easier for people to > start doing

Re: [RFC][PATCH] docs: process: Submitting a patch for a single git commit.

2019-10-11 Thread Jonathan Corbet
On Fri, 11 Oct 2019 18:33:58 +0200 Ingo Rohloff wrote: > A short primer how to submit a single git commit as a patch via > e-mail using git send-email. > > Signed-off-by: Ingo Rohloff > --- > > Notes: > I just went through this process and did a lot of mistakes, > because I was confuse

[RFC][PATCH] docs: process: Submitting a patch for a single git commit.

2019-10-11 Thread Ingo Rohloff
A short primer how to submit a single git commit as a patch via e-mail using git send-email. Signed-off-by: Ingo Rohloff --- Notes: I just went through this process and did a lot of mistakes, because I was confused how git commits translate to patches via e-mail. So I thought ma

Re: [PATCH v7 0/8] efi/firmware/platform-x86: Add EFI embedded fw support

2019-10-11 Thread Greg Kroah-Hartman
On Fri, Oct 11, 2019 at 03:38:23PM +, Luis Chamberlain wrote: > On Fri, Oct 11, 2019 at 04:31:26PM +0200, Hans de Goede wrote: > > Hi, > > > > On 10/11/19 4:10 PM, Luis Chamberlain wrote: > > > Hey Hans, thanks for staying on top of this and follow up! For some > > > reason the universe conspi

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Linus Torvalds
On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > like '/* fallthrough */'. I applied patches 1-3 to my tree just to make it easier for people to start doing this. Maybe some people want to do the conversion on their own sub

Re: [TYPO] SafeSetID.rst: Remove spurious '???' characters

2019-10-11 Thread Micah Morton
Ah, thanks for this. We had this fixed in http://kernsec.org/pipermail/linux-security-module-archive/2019-May/013525.html, but looks like it got forgotten somehow. On Fri, Oct 11, 2019 at 9:00 AM Jonathan Corbet wrote: > > On Thu, 10 Oct 2019 20:36:16 -0700 (PDT) > Christian Kujau wrote: > > > W

Re: [PATCH] docs: misc: xilinx_sdfec: Actually add documentation

2019-10-11 Thread Kees Cook
On Fri, Oct 11, 2019 at 10:02:23AM -0600, Jonathan Corbet wrote: > On Fri, 11 Oct 2019 08:59:22 + > Dragan Cvetic wrote: > > > Yes, please add the file. > > OK, I've applied the patch, thanks. I took the liberty of sticking on a > final newline while I was at it. Yay! Thank you! :) -- Ke

Re: [PATCH] docs: misc: xilinx_sdfec: Actually add documentation

2019-10-11 Thread Jonathan Corbet
On Fri, 11 Oct 2019 08:59:22 + Dragan Cvetic wrote: > Yes, please add the file. OK, I've applied the patch, thanks. I took the liberty of sticking on a final newline while I was at it. jon

Re: [TYPO] SafeSetID.rst: Remove spurious '???' characters

2019-10-11 Thread Jonathan Corbet
On Thu, 10 Oct 2019 20:36:16 -0700 (PDT) Christian Kujau wrote: > While reading SafeSetID.rst I stumbled across those things. This patch > removes these spurious '???' characters. > > Signed-off-by: Christian Kujau I've applied this, thanks. I did take the liberty of rewriting the change

Re: [PATCH v7 0/8] efi/firmware/platform-x86: Add EFI embedded fw support

2019-10-11 Thread Luis Chamberlain
On Fri, Oct 11, 2019 at 04:31:26PM +0200, Hans de Goede wrote: > Hi, > > On 10/11/19 4:10 PM, Luis Chamberlain wrote: > > Hey Hans, thanks for staying on top of this and follow up! For some > > reason the universe conspired against your first and last patch ([1/8], > > [8/8]), and I never got them

Re: [PATCH v7 4/8] firmware: Add new platform fallback mechanism and firmware_request_platform()

2019-10-11 Thread Luis Chamberlain
On Fri, Oct 04, 2019 at 04:17:33PM -0700, Dmitry Torokhov wrote: > Hi Hans, > > On Fri, Oct 04, 2019 at 04:50:52PM +0200, Hans de Goede wrote: > > In some cases the platform's main firmware (e.g. the UEFI fw) may contain > > an embedded copy of device firmware which needs to be (re)loaded into the

Re: [PATCH v7 4/8] firmware: Add new platform fallback mechanism and firmware_request_platform()

2019-10-11 Thread Luis Chamberlain
On Fri, Oct 04, 2019 at 04:50:52PM +0200, Hans de Goede wrote: > diff --git a/drivers/base/firmware_loader/Makefile > b/drivers/base/firmware_loader/Makefile > index 0b2dfa6259c9..fec75895faae 100644 > --- a/drivers/base/firmware_loader/Makefile > +++ b/drivers/base/firmware_loader/Makefile > @@ -

Re: [PATCH v7 3/8] firmware: Rename FW_OPT_NOFALLBACK to FW_OPT_NOFALLBACK_SYSFS

2019-10-11 Thread Luis Chamberlain
On Fri, Oct 04, 2019 at 04:50:51PM +0200, Hans de Goede wrote: > diff --git a/drivers/base/firmware_loader/fallback.c > b/drivers/base/firmware_loader/fallback.c > index 62ee90b4db56..665b350419cb 100644 > --- a/drivers/base/firmware_loader/fallback.c > +++ b/drivers/base/firmware_loader/fallback.

[PATCH] ftpm: add shutdown call back

2019-10-11 Thread Pavel Tatashin
From: thiruan add shutdown call back to close existing session with fTPM TA to support kexec scenario. Signed-off-by: Thirupathaiah Annapureddy Signed-off-by: Pavel Tatashin --- drivers/char/tpm/tpm_ftpm_tee.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers

Re: [PATCH v7 2/8] efi: Add embedded peripheral firmware support

2019-10-11 Thread Luis Chamberlain
On Fri, Oct 04, 2019 at 04:50:50PM +0200, Hans de Goede wrote: > +static int __init efi_check_md_for_embedded_firmware( > + efi_memory_desc_t *md, const struct efi_embedded_fw_desc *desc) > +{ > + const u64 prefix = *((u64 *)desc->prefix); > + struct sha256_state sctx; > + struct em

Re: [PATCH v7 0/8] efi/firmware/platform-x86: Add EFI embedded fw support

2019-10-11 Thread Hans de Goede
Hi, On 10/11/19 4:10 PM, Luis Chamberlain wrote: Hey Hans, thanks for staying on top of this and follow up! For some reason the universe conspired against your first and last patch ([1/8], [8/8]), and I never got them. Could you bounce these or resend in case others confirm they also didn't get

Re: [PATCH 1/4] arm64: add support for the AMU extension v1

2019-10-11 Thread Catalin Marinas
On Fri, Oct 11, 2019 at 11:31:40AM +0100, Ionela Voinescu wrote: > On 10/10/2019 18:20, Catalin Marinas wrote: > > On Tue, Sep 17, 2019 at 02:42:25PM +0100, Ionela Voinescu wrote: > >> +#ifdef CONFIG_ARM64_AMU_EXTN > >> + > >> +/* > >> + * This per cpu variable only signals that the CPU implementat

Re: [PATCH v2 1/2] hwmon: Add support for ltc2947

2019-10-11 Thread Jonathan Corbet
On Fri, 11 Oct 2019 13:48:52 +0200 Nuno Sá wrote: > The ltc2947 is a high precision power and energy monitor with an > internal sense resistor supporting up to +/- 30A. Three internal no > Latency ADCs ensure accurate measurement of voltage and current, while > high-bandwidth analog multiplicatio

Re: [PATCH v7 0/8] efi/firmware/platform-x86: Add EFI embedded fw support

2019-10-11 Thread Luis Chamberlain
Hey Hans, thanks for staying on top of this and follow up! For some reason the universe conspired against your first and last patch ([1/8], [8/8]), and I never got them. Could you bounce these or resend in case others confirm they also didn't get it? While at it, can you Cc scott.bran...@broadcom.

[PATCH v2 2/2] dt-bindings: hwmon: Add ltc2947 documentation

2019-10-11 Thread Nuno Sá
Document the LTC2947 device devicetree bindings. Signed-off-by: Nuno Sá --- Changes in v2: * Add license identifier; * Fix the uint32-array properties; * Set maximum at the same indent as allOf in adi,accumulation-deadband-microamp; * Set enum at the same indent as allOf in adi,gpio-out-pol;

[PATCH v2 1/2] hwmon: Add support for ltc2947

2019-10-11 Thread Nuno Sá
The ltc2947 is a high precision power and energy monitor with an internal sense resistor supporting up to +/- 30A. Three internal no Latency ADCs ensure accurate measurement of voltage and current, while high-bandwidth analog multiplication of voltage and current provides accurate power measurement

Re: [PATCH 19/19] EDAC, Documentation: Describe CPER module definition and DIMM ranks

2019-10-11 Thread Mauro Carvalho Chehab
Em Thu, 10 Oct 2019 20:25:42 + Robert Richter escreveu: > Update on CPER DIMM naming convention and DIMM ranks. > > Signed-off-by: Robert Richter Reviewed-by: Mauro Carvalho Chehab > --- > Documentation/admin-guide/ras.rst | 31 +++ > 1 file changed, 19 inser

Re: [PATCH 1/4] arm64: add support for the AMU extension v1

2019-10-11 Thread Ionela Voinescu
Hi Catalin, On 10/10/2019 18:20, Catalin Marinas wrote: > Hi Ionela, > > On Tue, Sep 17, 2019 at 02:42:25PM +0100, Ionela Voinescu wrote: >> +#ifdef CONFIG_ARM64_AMU_EXTN >> + >> +/* >> + * This per cpu variable only signals that the CPU implementation supports >> the >> + * AMU but does not pro

Re: [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

2019-10-11 Thread Thomas Bogendoerfer
On Thu, 10 Oct 2019 19:37:15 +0300 Sergei Shtylyov wrote: > On 10/10/2019 05:59 PM, Thomas Bogendoerfer wrote: > > + /* enable ethernet PHY on IP29 systemboard */ > > + pci_read_config_dword(dev, PCI_SUBSYSTEM_VENDOR_ID, &sid); > > + if (sid == ((PCI_VENDOR_ID_SGI << 16) | IOC3_SUBSYS_IP29_

RE: [PATCH] docs: misc: xilinx_sdfec: Actually add documentation

2019-10-11 Thread Dragan Cvetic
Hi Jonathan, Yes, please add the file. Thank you Regards > -Original Message- > From: Jonathan Corbet [mailto:cor...@lwn.net] > Sent: Thursday 10 October 2019 23:39 > To: Kees Cook > Cc: Derek Kiernan ; Dragan Cvetic ; > linux-ker...@vger.kernel.org; linux- > d...@vger.kernel.org > Su

Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-11 Thread Thomas Bogendoerfer
On Thu, 10 Oct 2019 20:00:02 -0700 Jakub Kicinski wrote: > On Thu, 10 Oct 2019 16:59:49 +0200, Thomas Bogendoerfer wrote: > > dev = alloc_etherdev(sizeof(struct ioc3_private)); > > - if (!dev) { > > - err = -ENOMEM; > > - goto out_disable; > > - } > > - > > - if (pci

Re: [PATCH 2/3] hwmon: Add support for ltc2947

2019-10-11 Thread Sa, Nuno
On Thu, 2019-10-10 at 08:21 -0700, Guenter Roeck wrote: > [External] > > On Thu, Oct 10, 2019 at 07:13:06AM +, Sa, Nuno wrote: > > Quoting the reply I had: > > > > "As the LTC2947 is bi-directional, the most likely use for the > > Min/Max > > Energy thresholds are for monitoring a battery bei