Re: [PATCH] Documentation: kbuild: Add document about reproducible builds

2019-09-11 Thread Masahiro Yamada
On Wed, Sep 11, 2019 at 10:15 PM Ben Hutchings wrote: > > On Wed, 2019-09-11 at 14:04 +0100, Ben Hutchings wrote: > > On Wed, 2019-09-11 at 21:17 +0900, Masahiro Yamada wrote: > > > Hi Ben, > > > > > > > > > Thanks for this. > > > Please let me add some comments. > > > > > > > > > On Wed, Sep 11,

Re: [PATCH] doc: replace IFF abbreviation with 'if and only if'

2019-09-11 Thread Joe Perches
On Tue, 2019-09-10 at 15:17 +0200, Federico Vaga wrote: > Generally speaking compactness does not bring any value if then the text is > unclear or open to interpretation. It's somewhat difficult to choose between +1 and I agree.

Re: [PATCH 1/3] docs: scsi: fix typo

2019-09-11 Thread André Almeida
On 9/11/19 6:10 PM, Joe Perches wrote: > On Wed, 2019-09-11 at 17:37 -0300, André Almeida wrote: >> "Busses" is the third person conjugation of verb "to buss" in the >> present tense. "Buses" is the plural of bus, as in "serial bus". > > busses and buses are both acceptable plurals of bus > > htt

Re: [PATCH 1/3] docs: scsi: fix typo

2019-09-11 Thread Joe Perches
On Wed, 2019-09-11 at 17:37 -0300, André Almeida wrote: > "Busses" is the third person conjugation of verb "to buss" in the > present tense. "Buses" is the plural of bus, as in "serial bus". busses and buses are both acceptable plurals of bus https://www.dictionary.com/browse/bus

[PATCH 3/3] scsi: core: change function comments to kernel-doc style

2019-09-11 Thread André Almeida
Despite of functions being documented they are not in the kernel-doc specification, and could not be included in kernel documentation. Change the style of functions comments to be compliant to the kernel-doc style. Signed-off-by: André Almeida --- drivers/scsi/scsi_lib.c | 166 +++---

[PATCH 1/3] docs: scsi: fix typo

2019-09-11 Thread André Almeida
"Busses" is the third person conjugation of verb "to buss" in the present tense. "Buses" is the plural of bus, as in "serial bus". Signed-off-by: André Almeida --- Documentation/driver-api/scsi.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/driver-api/scsi.

[PATCH 2/3] scsi: core: remove trailing whitespaces

2019-09-11 Thread André Almeida
Remove all trailing whitespaces from scsi_lib.c Signed-off-by: André Almeida --- drivers/scsi/scsi_lib.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 11e64b50497f..8565bee31922 100644 --- a/drivers/

[PATCH] devices.txt: improve entry for comedi (char major 98)

2019-09-11 Thread Ian Abbott
Describe how the comedi minor device numbers are split across comedi devices and comedi subdevices. Replace the current, long dead URL with an official URL for the Comedi project. Signed-off-by: Ian Abbott --- Documentation/admin-guide/devices.txt | 11 ++- 1 file changed, 10 insertions

Re: [PATCH 2/4] Documentation/process: describe relaxing disclosing party NDAs

2019-09-11 Thread Dave Hansen
On 9/11/19 8:44 AM, Greg KH wrote: > Intel had months of review time for this document before this was > published. Your lawyers had it and never objected to this lack of > inclusion at all, and explictitly said that the document as written was > fine with them. So I'm sorry, but it is much too l

Re: [PATCH 4/4] Documentation/process: add transparency promise to list subscription

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:52AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Transparency is good. It it essential for everyone working under an > embargo to know who is involved and who else is a "knower". Being > transparent allows everyone to always make informed decisions about >

Re: [PATCH 3/4] Documentation/process: soften language around conference talk dates

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:51AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Both hardware companies and the kernel community prefer coordinated > disclosure to the alternatives. It is also obvious that sitting on > ready-to-go mitigations for months is not so nice for kernel > mainta

Re: [PATCH 2/4] Documentation/process: describe relaxing disclosing party NDAs

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:49AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Hardware companies like Intel have lots of information which they > want to disclose to some folks but not others. Non-disclosure > agreements are a tool of choice for helping to ensure that the > flow of inf

Re: [PATCH 2/4] Documentation/process: describe relaxing disclosing party NDAs

2019-09-11 Thread Dave Hansen
On 9/11/19 3:11 AM, Sasha Levin wrote: >> +Disclosing parties may have shared information about an issue under a >> +non-disclosure agreement with third parties.  In order to ensure that >> +these agreements do not interfere with the mitigation development >> +process, the disclosing party must pro

[PATCH v3] hwspinlock: allow sharing of hwspinlocks

2019-09-11 Thread Fabien Dessenne
Allow several clients to request (hwspin_lock_request_specific()) the same lock. In addition to that, protect a given lock from being locked (hwspin_trylock{_...}()) by more that one client at a time. Since the RAW and IN_ATOMIC modes do not implement that protection (unlike the default, IRQ and I

Re: [PATCH] Documentation: kbuild: Add document about reproducible builds

2019-09-11 Thread Ben Hutchings
On Wed, 2019-09-11 at 14:04 +0100, Ben Hutchings wrote: > On Wed, 2019-09-11 at 21:17 +0900, Masahiro Yamada wrote: > > Hi Ben, > > > > > > Thanks for this. > > Please let me add some comments. > > > > > > On Wed, Sep 11, 2019 at 8:54 PM Ben Hutchings wrote: > [...] > > > +Absolute filenames >

Re: [PATCH] Documentation: kbuild: Add document about reproducible builds

2019-09-11 Thread Ben Hutchings
On Wed, 2019-09-11 at 21:17 +0900, Masahiro Yamada wrote: > Hi Ben, > > > Thanks for this. > Please let me add some comments. > > > On Wed, Sep 11, 2019 at 8:54 PM Ben Hutchings wrote: [...] > > +Absolute filenames > > +-- > > + > > +When the kernel is built out-of-tree, debug

Re: [PATCH] Documentation: kbuild: Add document about reproducible builds

2019-09-11 Thread Masahiro Yamada
Hi Ben, Thanks for this. Please let me add some comments. On Wed, Sep 11, 2019 at 8:54 PM Ben Hutchings wrote: > > In the Distribution Kernels track at Linux Plumbers Conference there > was some discussion around the difficulty of making kernel builds > reproducible. > > This is a solved probl

Re: [PATCH 0/4] Documentation/process: embargoed hardware issues additions

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:44AM -0700, Dave Hansen wrote: > Intel will adhere to this process for future hardware embargoed > issues. This series contains a patch from Tony Luck with him > volunteering to be Intel's ambassador for this process. > > These are some minor improvements here to the

[PATCH] Documentation: kbuild: Add document about reproducible builds

2019-09-11 Thread Ben Hutchings
In the Distribution Kernels track at Linux Plumbers Conference there was some discussion around the difficulty of making kernel builds reproducible. This is a solved problem, but the solutions don't appear to be documented in one place. This document lists the issues I know about and the settings

[PATCH v2 2/2] trace-vmscan-postprocess: fix output table spacing

2019-09-11 Thread Florian Schmidt
Fix spacing so that both the headers in themselves, as well as the output of the two tables related to each other, are properly aligned. Signed-off-by: Florian Schmidt --- Documentation/trace/postprocess/trace-vmscan-postprocess.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[PATCH v2 0/2] trace-vmscan-postprocess: fix parsing and output

2019-09-11 Thread Florian Schmidt
This patch series updates trace-vmscan-postprocess.pl to work without throwing warnings and errors which stem from updates to several trace points. 3481c37ffa1d ("mm/vmscan: drop may_writepage and classzone_idx from direct reclaim begin template") removed "may_writepage" from mm_vmscan_direct_recl

[PATCH v2 1/2] trace-vmscan-postprocess: sync with tracepoints updates

2019-09-11 Thread Florian Schmidt
mm_vmscan_{direct_reclaim_begin,wakeup_kswapd,lru_isolate,lru_shrink_active} changed their output to the point where the script throws warnings and errors. Update it to be properly in line with those changes. Fixes: 3481c37ffa1d ("mm/vmscan: drop may_writepage and classzone_idx from direct reclai

Re: [PATCH 2/4] Documentation/process: describe relaxing disclosing party NDAs

2019-09-11 Thread Sasha Levin
On Tue, Sep 10, 2019 at 10:26:49AM -0700, Dave Hansen wrote: From: Dave Hansen Hardware companies like Intel have lots of information which they want to disclose to some folks but not others. Non-disclosure agreements are a tool of choice for helping to ensure that the flow of information is

Re: [PATCH v11 0/6] Solve postboot supplier cleanup and optimize probe ordering

2019-09-11 Thread Stephen Boyd
Quoting Saravana Kannan (2019-09-04 14:11:19) > v10->v11: > - Dropped 6/7 and 7/7 from previous series that tried to handle cycles in DT > dependencies. We can solve it later when we actually hit a real world issue > in DT. > - Added a new 1/7 that shifts the numbering for the rest of the patch

Re: [PATCH 1/2] trace-vmscan-postprocess: sync with tracepoints updates

2019-09-11 Thread Florian Schmidt
Hi Daniel, On 04/09/2019 21:44, Daniel Jordan wrote: > On Tue, Sep 03, 2019 at 11:14:12AM +, Florian Schmidt wrote: >> mm_vmscan_{direct_reclaim_begin,wakeup_kswapd,lru_isolate,lru_shrink_active} >> changed their output to the point where the script throws warnings and >> errors. Update it to

Re: [PATCH 0/2] trace-vmscan-postprocess: fix parsing and output

2019-09-11 Thread Florian Schmidt
Hi Daniel, On 04/09/2019 21:42, Daniel Jordan wrote: >> In addition, the tables that are printed by the script were not properly >> aligned any more, so patch 2 fixes the spacing. > > Nit, not for Pages Scanned. With your series I get > > Kswapd Kswapd Order Pages Pages

Re: [PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-09-11 Thread Stephen Boyd
Quoting Saravana Kannan (2019-09-04 14:11:22) > Add device links after the devices are created (but before they are > probed) by looking at common DT bindings like clocks and > interconnects. > > Automatically adding device links for functional dependencies at the > framework level provides the fo

Re: [PATCH v2] printf: add support for printing symbolic error codes

2019-09-11 Thread Rasmus Villemoes
On 11/09/2019 11.37, Uwe Kleine-König wrote: > On 9/11/19 8:43 AM, Rasmus Villemoes wrote: >> On 11/09/2019 02.15, Joe Perches wrote: >>> On Tue, 2019-09-10 at 18:26 +0300, Andy Shevchenko wrote: On Mon, Sep 9, 2019 at 11:39 PM Rasmus Villemoes wrote: > +{ > + /* Might as w

Re: [PATCH v2] printf: add support for printing symbolic error codes

2019-09-11 Thread Uwe Kleine-König
On 9/11/19 8:43 AM, Rasmus Villemoes wrote: > On 11/09/2019 02.15, Joe Perches wrote: >> On Tue, 2019-09-10 at 18:26 +0300, Andy Shevchenko wrote: >>> On Mon, Sep 9, 2019 at 11:39 PM Rasmus Villemoes >>> wrote: > +#define E(err) [err + BUILD_BUG_ON_ZERO(err <= 0 || err > 300)] = #err +#