Re: [PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-29 Thread Saravana Kannan
On Thu, Aug 29, 2019 at 9:43 AM Rob Herring wrote: > > On Thu, Aug 29, 2019 at 2:46 AM Saravana Kannan wrote: > > > > Add device-links to track functional dependencies between devices > > after they are created (but before they are probed) by looking at > > their common DT bindings like clocks, i

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 09:20:36PM -0400, Joel Fernandes wrote: > On Thu, Aug 29, 2019 at 05:47:56PM -0700, Paul E. McKenney wrote: > [snip] > > > > > Paul, also what what happens in the following scenario: > > > > > > > > > > CPU0 CPU1 > > > > > >

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Joel Fernandes
On Thu, Aug 29, 2019 at 05:47:56PM -0700, Paul E. McKenney wrote: [snip] > > > > Paul, also what what happens in the following scenario: > > > > > > > > CPU0 CPU1 > > > > > > > > A syscall causes rcu_eqs_exit() > > > > rcu_read_lock(); > > > >

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 01:14:54PM -0400, Joel Fernandes wrote: > On Thu, Aug 29, 2019 at 09:13:01AM -0700, Paul E. McKenney wrote: > > On Thu, Aug 29, 2019 at 11:13:25AM -0400, Joel Fernandes wrote: > > > On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > > > > On Wed, Aug 28, 2019

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 03:00:46PM -0400, Joel Fernandes wrote: > Hi Paul, > > On Thu, Aug 29, 2019 at 09:54:07AM -0700, Paul E. McKenney wrote: > > On Thu, Aug 29, 2019 at 09:21:46AM -0700, Andy Lutomirski wrote: > > > On Thu, Aug 29, 2019 at 9:10 AM Paul E. McKenney > > > wrote: > > > > > > >

Re: [PATCH 5/5] rcu: Remove kfree_call_rcu_nobatch()

2019-08-29 Thread Joel Fernandes
Hi Paul, I think this is the only contentious patch preventing my resend of the series, let me know what you think, I replied below: On Wed, Aug 28, 2019 at 02:56:36PM -0700, Paul E. McKenney wrote: > On Tue, Aug 27, 2019 at 03:01:59PM -0400, Joel Fernandes (Google) wrote: [snip] > > diff --git a

Re: [PATCH 4/5] rcu: Remove kfree_rcu() special casing and lazy handling

2019-08-29 Thread Joel Fernandes
All comments addressed on this one, thanks! - Joel On Wed, Aug 28, 2019 at 02:46:29PM -0700, Paul E. McKenney wrote: > On Tue, Aug 27, 2019 at 03:01:58PM -0400, Joel Fernandes (Google) wrote: > > Remove kfree_rcu() special casing and lazy handling from RCU. > > For Tiny RCU we fold the special

[PATCH v2 08/11] coresight: etm4x: Add missing single-shot control API to sysfs

2019-08-29 Thread Mike Leach
An API to control single-shot comparator operation was missing from sysfs. This adds the parameters to sysfs to allow programming of this feature. Signed-off-by: Mike Leach --- .../coresight/coresight-etm4x-sysfs.c | 122 ++ drivers/hwtracing/coresight/coresight-etm4x.c |

[PATCH v2 02/11] coresight: etm4x: Fix input validation for sysfs.

2019-08-29 Thread Mike Leach
A number of issues are fixed relating to sysfs input validation:- 1) bb_ctrl_store() - incorrect compare of bit select field to absolute value. Reworked per ETMv4 specification. 2) seq_event_store() - incorrect mask value - register has two event values. 3) cyc_threshold_store() - must mask with m

[PATCH v2 05/11] coresight: etm4x: Improve usability of sysfs - include/exclude addr.

2019-08-29 Thread Mike Leach
Setting include / exclude on a range had to be done by setting the bit in 'mode' before setting the range. However, setting this bit also had the effect of altering the current range as well. Changed to only set include / exclude setting of a range at the point of setting that range. Either use a

[PATCH v2 04/11] coresight: etm4x: Fix issues with start-stop logic.

2019-08-29 Thread Mike Leach
Fixes the following issues when using the ETMv4 start-stop logic. 1) Setting a start or a stop address should not automatically set the start-stop status to 'on'. The value set by the user in 'mode' must be respected or start instances could be missed. 2) Missing API for controlling TRCVIPCSSCTLR

[PATCH v2 07/11] coresight: etm4x: Add view comparator settings API to sysfs.

2019-08-29 Thread Mike Leach
Currently it is not possible to view the current settings of a given address comparator without knowing what type it is set to. For example, if a comparator is set as an addr_start comparator, attempting to read addr_stop for the same index will result in an error. addr_cmp_view is added to allow

[PATCH v2 11/11] coresight: etm4x: docs: Adds detailed document for programming etm4x.

2019-08-29 Thread Mike Leach
Add in detailed programmers reference for users wanting to program the CoreSight ETM 4.x driver using sysfs. Signed-off-by: Mike Leach --- .../coresight/coresight-etm4x-reference.txt | 458 ++ 1 file changed, 458 insertions(+) create mode 100644 Documentation/trace/coresight/c

[PATCH v2 06/11] coresight: etm4x: Improve usability of sysfs - CID and VMID masks.

2019-08-29 Thread Mike Leach
Context ID and VM ID masks required 2 value inputs, even when the second value is ignored as insufficient CID / VMID comparators are implemented. Permit a single value to be used if that is sufficient to cover all implemented comparators. Reviewed-by: Mathieu Poirier Signed-off-by: Mike Leach -

[PATCH v2 10/11] coresight: docs: Create common sub-directory for coresight trace.

2019-08-29 Thread Mike Leach
There are two files in the Documentation/trace directory relating to coresight, with more to follow, so create a Documentation/trace/coresight directory and move existing files there. Update MAINTAINERS to reference this sub-directory rather than the individual files. Signed-off-by: Mike Leach --

[PATCH v2 01/11] coresight: etm4x: Fixes for ETM v4.4 architecture updates.

2019-08-29 Thread Mike Leach
ETMv4.4 adds in support for tracing secure EL2 (per arch 8.x updates). Patch accounts for this new capability. Reviewed-by: Leo Yan Signed-off-by: Mike Leach --- .../hwtracing/coresight/coresight-etm4x-sysfs.c | 12 ++-- drivers/hwtracing/coresight/coresight-etm4x.c | 5 - dr

[PATCH v2 03/11] coresight: etm4x: Add missing API to set EL match on address filters

2019-08-29 Thread Mike Leach
TRCACATRn registers have match bits for secure and non-secure exception levels which are not accessible by the sysfs API. This adds a new sysfs parameter to enable this - addr_exlevel_s_ns. Signed-off-by: Mike Leach --- .../coresight/coresight-etm4x-sysfs.c | 42 +++ 1 fi

[PATCH v2 09/11] coresight: etm4x: docs: Update ABI doc for sysfs features added.

2019-08-29 Thread Mike Leach
Update document to include the new sysfs features added during this patchset. Updated to reflect the new sysfs component nameing schema. Signed-off-by: Mike Leach --- .../testing/sysfs-bus-coresight-devices-etm4x | 183 +++--- 1 file changed, 115 insertions(+), 68 deletions(-) diff

[PATCH v2 00/11] coresight: etm4x: Fixes and updates for sysfs API

2019-08-29 Thread Mike Leach
Review of ETMV4 sysfs code resulted in a number of minor issues being discovered. Patch set fixes these issues:- 1) Update for ETM v4.4 archtecture. 2) Add missing single shot comparator API. 3) Misc fixes and improvements to sysfs API 4) Updated programmers documentation and reference. Changes s

Re: [PATCH v2] rcu/tree: Add multiple in-flight batches of kfree_rcu work

2019-08-29 Thread Joel Fernandes
On Wed, Aug 28, 2019 at 01:45:21PM -0700, Paul E. McKenney wrote: > On Wed, Aug 28, 2019 at 10:09:52AM -0400, Joel Fernandes (Google) wrote: > > During testing, it was observed that amount of memory consumed due > > kfree_rcu() batching is 300-400MB. Previously we had only a single > > head_free po

Re: [PATCH 1/5] rcu/rcuperf: Add kfree_rcu() performance Tests

2019-08-29 Thread Joel Fernandes
On Wed, Aug 28, 2019 at 02:12:26PM -0700, Paul E. McKenney wrote: > On Tue, Aug 27, 2019 at 03:01:55PM -0400, Joel Fernandes (Google) wrote: > > This test runs kfree_rcu() in a loop to measure performance of the new > > kfree_rcu() batching functionality. > > > > The following table shows results

Re: [PATCH] [RFC] i2c: imx: make use of format specifier %dE

2019-08-29 Thread Wolfram Sang
On Thu, Aug 29, 2019 at 06:29:05AM +0200, Uwe Kleine-König wrote: > I created a patch that teaches printk et al to emit a symbolic error > name for an error valued integer[1]. With that applied > > dev_err(&pdev->dev, "can't enable I2C clock, ret=%dE\n", ret); > > emits > > ... can't

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Joel Fernandes
Hi Paul, On Thu, Aug 29, 2019 at 09:54:07AM -0700, Paul E. McKenney wrote: > On Thu, Aug 29, 2019 at 09:21:46AM -0700, Andy Lutomirski wrote: > > On Thu, Aug 29, 2019 at 9:10 AM Paul E. McKenney wrote: > > > > > > On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > > > > > > [ . . .

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Uwe Kleine-König
On 8/29/19 11:09 AM, Rasmus Villemoes wrote: > On 29/08/2019 10.27, Juergen Gross wrote: >> On 29.08.19 10:12, Petr Mladek wrote: >>> On Wed 2019-08-28 21:18:37, Uwe Kleine-König  wrote: I'd like to postpone the discussion about "how" until we agreed about the "if at all". >>> >>> It

Re: [PATCH v2] doc: kselftest: update for clarity on running kselftests in CI rings

2019-08-29 Thread shuah
On 8/29/19 11:30 AM, Brendan Higgins wrote: On Mon, Aug 26, 2019 at 5:37 PM Shuah Khan wrote: Update to add clarity and recommendations on running newer kselftests on older kernels vs. matching the kernel and kselftest revisions. The recommendation is "Match kernel revision and kselftest." S

Re: [PATCH v2] doc: kselftest: update for clarity on running kselftests in CI rings

2019-08-29 Thread Brendan Higgins
On Wed, Aug 28, 2019 at 12:18 PM shuah wrote: > > On 8/26/19 6:37 PM, Shuah Khan wrote: > > Update to add clarity and recommendations on running newer kselftests > > on older kernels vs. matching the kernel and kselftest revisions. > > > > The recommendation is "Match kernel revision and kselftest

Re: [PATCH v2] doc: kselftest: update for clarity on running kselftests in CI rings

2019-08-29 Thread Brendan Higgins
On Mon, Aug 26, 2019 at 5:37 PM Shuah Khan wrote: > > Update to add clarity and recommendations on running newer kselftests > on older kernels vs. matching the kernel and kselftest revisions. > > The recommendation is "Match kernel revision and kselftest." > > Signed-off-by: Shuah Khan Reviewed-

Re: [PATCH] [RFC] tty/serial: imx: make use of format specifier %dE

2019-08-29 Thread Uwe Kleine-König
On 8/29/19 3:43 PM, Andy Shevchenko wrote: > On Thu, Aug 29, 2019 at 7:40 AM Uwe Kleine-König > wrote: >> >> I created a patch that teaches printk et al to emit a symbolic error >> name for an error valued integer[1]. With that applied >> >> dev_err(&pdev->dev, "failed to get ipg clk: %dE

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Joel Fernandes
On Thu, Aug 29, 2019 at 09:13:01AM -0700, Paul E. McKenney wrote: > On Thu, Aug 29, 2019 at 11:13:25AM -0400, Joel Fernandes wrote: > > On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > > > On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: > > > [snip] > > > > > > >

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 09:21:46AM -0700, Andy Lutomirski wrote: > On Thu, Aug 29, 2019 at 9:10 AM Paul E. McKenney wrote: > > > > On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > > > > [ . . . ] > > > > > Paul, do we also nuke rcu_eqs_special_set()? Currently I don't see anyone

Re: [PATCH v10 2/7] of: property: Add functional dependency link from DT bindings

2019-08-29 Thread Rob Herring
On Thu, Aug 29, 2019 at 2:46 AM Saravana Kannan wrote: > > Add device links after the devices are created (but before they are > probed) by looking at common DT bindings like clocks and > interconnects. > > Automatically adding device links for functional dependencies at the > framework level prov

Re: [PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-29 Thread Rob Herring
On Thu, Aug 29, 2019 at 2:46 AM Saravana Kannan wrote: > > Add device-links to track functional dependencies between devices > after they are created (but before they are probed) by looking at > their common DT bindings like clocks, interconnects, etc. > > Having functional dependencies automatica

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 09:59:07AM -0400, Joel Fernandes wrote: > On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: > [snip] > > On the tracing patch... That patch might be a good idea regardless, > > but I bet that the reason that you felt the sudden need for it was due > > to th

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Andy Lutomirski
On Thu, Aug 29, 2019 at 9:10 AM Paul E. McKenney wrote: > > On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > > [ . . . ] > > > Paul, do we also nuke rcu_eqs_special_set()? Currently I don't see anyone > > using it. And also remove the bottom most bit of dynticks? > > > > Also wha

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 11:13:25AM -0400, Joel Fernandes wrote: > On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > > On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: > > [snip] > > > > > > > This change is not fixing a bug, so there is no need for an > > > > > > >

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: [ . . . ] > Paul, do we also nuke rcu_eqs_special_set()? Currently I don't see anyone > using it. And also remove the bottom most bit of dynticks? > > Also what happens if a TLB flush broadcast is needed? Do we IPI nohz or idle > C

Re: [PATCH] Documentation: add link to stm32mp157 docs

2019-08-29 Thread Jonathan Corbet
On Tue, 27 Aug 2019 17:23:30 +0200 Alexandre Torgue wrote: > >> +Datasheet and reference manual are publicly available on ST website: > >> +.. _STM32MP157: > >> https://www.st.com/en/microcontrollers-microprocessors/stm32mp157.html > >> + > > > > Adding the URL is a fine idea. But you don't

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Joel Fernandes
On Thu, Aug 29, 2019 at 10:43:55AM -0400, Joel Fernandes wrote: > On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: > [snip] > > > > > > This change is not fixing a bug, so there is no need for an > > > > > > emergency fix, > > > > > > and thus no point in additional churn. I unde

Re: [PATCH 3/9] lib: devres: provide new variants for devm_ioremap_resource()

2019-08-29 Thread Arnd Bergmann
On Thu, Aug 29, 2019 at 4:38 PM Bartosz Golaszewski wrote: > @@ -710,6 +710,10 @@ extern void devm_free_pages(struct device *dev, unsigned > long addr); > > void __iomem *devm_ioremap_resource(struct device *dev, > const struct resource *res); > +void __iomem

[PATCH] ALSA: doc: Fix PCM interface section typos

2019-08-29 Thread Miquel Raynal
Fix two mistakes in the PCM interface section: 1/ Members of the snd_pcm_hardware structure are channels_{min,max} and not channel_{min,max} (mind the 's'). 2/ Another sentence is incomplete as the reference to one structure member (period_bytes_max) is missing. There is no relevant 'Fixes:'

Re: [PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource()

2019-08-29 Thread Geert Uytterhoeven
Hi Bartosz, On Thu, Aug 29, 2019 at 4:38 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The new devm_platform_ioremap_resource() helper has now been widely > adopted and used in many drivers. Users of nocache and write-combined > ioremap() variants could profit from the same code

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Joel Fernandes
On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: [snip] > > > > > This change is not fixing a bug, so there is no need for an emergency > > > > > fix, > > > > > and thus no point in additional churn. I understand that it is a bit > > > > > annoying to code and test something and

[PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The new devm_platform_ioremap_resource() helper has now been widely adopted and used in many drivers. Users of nocache and write-combined ioremap() variants could profit from the same code shrinkage. This series provides two new versions of devm_platform_ioremap_resource

[PATCH 1/9] Documentation: devres: add missing entry for devm_platform_ioremap_resource()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski devm_platform_ioremap_resource() should be documented in devres.rst. Add the missing entry. Signed-off-by: Bartosz Golaszewski --- Documentation/driver-api/driver-model/devres.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/driver-api/driver-mode

[PATCH 4/9] drivers: provide new variants of devm_platform_ioremap_resource()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide two new variants of devm_platform_ioremap_resource() - one for nocache and one for write-combined ioremap. Move the core functionality into a separate static function - __devm_platform_ioremap_resource() - that takes an additional type argument. Signed-off-by:

[PATCH 5/9] gpio: em: use devm_platform_ioremap_resource_nocache()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devm_platform_ioremap_resource_nocache() helper for memory range mapping instead of devm_ioremap_nocache() combined with a call to platform_get_resource(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-em.c | 22 +- 1 file ch

[PATCH 6/9] gpio: ath79: use devm_platform_ioremap_resource_nocache()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devm_platform_ioremap_resource_nocache() helper for memory range mapping instead of devm_ioremap_nocache() combined with a call to platform_get_resource(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-ath79.c | 10 +++--- 1 file changed, 3

[PATCH 7/9] gpio: htc-egpio: use devm_platform_ioremap_resource_nocache()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devm_platform_ioremap_resource_nocache() helper for memory range mapping instead of devm_ioremap_nocache() combined with a call to platform_get_resource(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-htc-egpio.c | 13 ++--- 1 file chan

[PATCH 3/9] lib: devres: provide new variants for devm_ioremap_resource()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide two new variants of devm_ioremap_resource() - one for nocache and one for write-combined ioremap. Signed-off-by: Bartosz Golaszewski --- .../driver-api/driver-model/devres.rst| 2 ++ include/linux/device.h| 4 +++ lib/devres.c

[PATCH 8/9] gpio: xgene: use devm_platform_ioremap_resource_nocache()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devm_platform_ioremap_resource_nocache() helper for memory range mapping instead of devm_ioremap_nocache() combined with a call to platform_get_resource(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xgene.c | 14 +++--- 1 file changed

[PATCH 9/9] misc: sram: use devm_platform_ioremap_resource_wc()

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devm_platform_ioremap_resource_wc() helper instead of devm_ioremap_wc() combinded with a call to platform_get_resource(). Also use devm_platform_ioremap_resource() where applicable. Signed-off-by: Bartosz Golaszewski --- drivers/misc/sram.c | 28 --

[PATCH 2/9] lib: devres: prepare devm_ioremap_resource() for more variants

2019-08-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We want to add the nocache and write-combined variants of devm_ioremap_resource(). Let's first implement __devm_ioremap_resource() which takes an additional argument type. The types are the same as for __devm_ioremap(). The existing devm_ioremap_resource() now simply cal

Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter

2019-08-29 Thread Joel Fernandes
On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: [snip] > On the tracing patch... That patch might be a good idea regardless, > but I bet that the reason that you felt the sudden need for it was due > to the loss of information in your eventual ->dynticks_nesting field. > After a

Re: [PATCH] [RFC] tty/serial: imx: make use of format specifier %dE

2019-08-29 Thread Andy Shevchenko
On Thu, Aug 29, 2019 at 7:40 AM Uwe Kleine-König wrote: > > I created a patch that teaches printk et al to emit a symbolic error > name for an error valued integer[1]. With that applied > > dev_err(&pdev->dev, "failed to get ipg clk: %dE\n", ret); > > emits > > ... failed to get ip

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Andy Shevchenko
On Wed, Aug 28, 2019 at 12:14 AM Uwe Kleine-König wrote: > > The new format specifier %dE introduced with this patch pretty-prints > the typical negative error values. So > > pr_info("probing failed (%dE)\n", ret); > > yields > > probing failed (EIO) > > if ret holds -EIO. This is

Re: [PATCH v1 1/2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Andy Shevchenko
On Sun, Aug 25, 2019 at 2:40 AM Uwe Kleine-König wrote: > > pr_info("probing failed (%dE)\n", ret); > > expands to > > probing failed (EIO) > > if ret holds -EIO (or EIO). This introduces an array of error codes. If > the error code is missing, %dE falls back to %d and so prints th

Re: [PATCH v2 1/1] counter: cros_ec: Add synchronization sensor

2019-08-29 Thread William Breathitt Gray
On Fri, Aug 23, 2019 at 02:41:27PM +0200, Fabien Lahoudere wrote: > From: Gwendal Grignou > > EC returns a counter when there is an event on camera vsync. > This patch comes from chromeos kernel 4.4 > > Signed-off-by: Gwendal Grignou > Signed-off-by: Fabien Lahoudere > > CROS EC sync sensor w

Re: [PATCH v2 1/1] counter: cros_ec: Add synchronization sensor

2019-08-29 Thread Fabien Lahoudere
Le lundi 26 août 2019 à 09:56 +0100, Jonathan Cameron a écrit : > On Fri, 23 Aug 2019 14:41:27 +0200 > Fabien Lahoudere wrote: > > > From: Gwendal Grignou > > > > EC returns a counter when there is an event on camera vsync. > > This patch comes from chromeos kernel 4.4 > > > > Signed-off-by: G

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Rasmus Villemoes
On 29/08/2019 10.27, Juergen Gross wrote: > On 29.08.19 10:12, Petr Mladek wrote: >> On Wed 2019-08-28 21:18:37, Uwe Kleine-König  wrote: >>> >>> I'd like to postpone the discussion about "how" until we agreed about >>> the "if at all". >> >> It seems that all people like this feature. > > Hmm, wh

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Rasmus Villemoes
On 29/08/2019 10.12, Petr Mladek wrote: > On Wed 2019-08-28 21:18:37, Uwe Kleine-König wrote: > BTW: I though more about generating or cut&pasting the arrary. > I can't find any reasonable way how to generate it. Something like this seems to work, though it probably needs some massage to be acce

Re: [PATCH v3 5/5] ARM: dts: stm32: add ddrperfm on stm32mp157c

2019-08-29 Thread Alexandre Torgue
Hi Gerald On 8/27/19 5:08 PM, Gerald BAEZA wrote: The DDRPERFM is the DDR Performance Monitor embedded in STM32MP1 SOC. Signed-off-by: Gerald Baeza ---  arch/arm/boot/dts/stm32mp157c.dtsi | 8  1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/a

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Juergen Gross
On 29.08.19 10:12, Petr Mladek wrote: On Wed 2019-08-28 21:18:37, Uwe Kleine-König wrote: Hello Petr, On 8/28/19 1:32 PM, Petr Mladek wrote: On Tue 2019-08-27 23:12:44, Uwe Kleine-König wrote: Petr Mladek had some concerns: There are ideas to make the code even more tricky to reduce the si

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Petr Mladek
On Wed 2019-08-28 21:18:37, Uwe Kleine-König wrote: > Hello Petr, > > On 8/28/19 1:32 PM, Petr Mladek wrote: > > On Tue 2019-08-27 23:12:44, Uwe Kleine-König wrote: > >> Petr Mladek had some concerns: > >>> There are ideas to make the code even more tricky to reduce > >>> the size, keep it fast.

[PATCH v10 7/7] of: property: Add "depends-on" parsing support to of_fwnode_add_links()

2019-08-29 Thread Saravana Kannan
If dependencies inferred by of_fwnode_add_links() result in a cycle, it can prevent the probing of all the devices in the cycle. The depends-on property has been added to explicitly override inferred dependencies when they create a cycle. Add depends-on parsing support to of_fwnode_add_links() so

[PATCH v10 3/7] driver core: Add sync_state driver/bus callback

2019-08-29 Thread Saravana Kannan
This sync_state driver/bus callback is called once all the consumers of a supplier have probed successfully. This allows the supplier device's driver/bus to sync the supplier device's state to the software state with the guarantee that all the consumers are actively managing the resources provided

[PATCH v10 6/7] dt-bindings: Add depends-on property to break cyclic inferred dependencies

2019-08-29 Thread Saravana Kannan
The functional dependencies of a device can be inferred by looking at the common devicetree bindings like clocks, interconnects and regulators. However, this can sometimes result in cyclic dependencies where one of the inferred dependencies isn't really a functional dependency. Add a depends-on p

[PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-29 Thread Saravana Kannan
Add device-links to track functional dependencies between devices after they are created (but before they are probed) by looking at their common DT bindings like clocks, interconnects, etc. Having functional dependencies automatically added before the devices are probed, provides the following ben

[PATCH v10 1/7] driver core: Add support for linking devices during device addition

2019-08-29 Thread Saravana Kannan
The firmware corresponding to a device (dev.fwnode) might be able to provide functional dependency information between a device and its supplier and consumer devices. Tracking this functional dependency allows optimizing device probe order and informing a supplier when all its consumers have probe

[PATCH v10 4/7] of/platform: Pause/resume sync state during init and of_platform_populate()

2019-08-29 Thread Saravana Kannan
When all the top level devices are populated from DT during kernel init, the supplier devices could be added and probed before the consumer devices are added and linked to the suppliers. To avoid the sync_state() callback from being called prematurely, pause the sync_state() callbacks before popula

[PATCH v10 2/7] of: property: Add functional dependency link from DT bindings

2019-08-29 Thread Saravana Kannan
Add device links after the devices are created (but before they are probed) by looking at common DT bindings like clocks and interconnects. Automatically adding device links for functional dependencies at the framework level provides the following benefits: - Optimizes device probe order and avoi

[PATCH v10 5/7] of: property: Create device links for all child-supplier depencencies

2019-08-29 Thread Saravana Kannan
A parent device can have child devices that it adds when it probes. But this probing of the parent device can happen way after kernel init is done -- for example, when the parent device's driver is loaded as a module. In such cases, if the child devices depend on a supplier in the system, we need