Re: [PATCH v4 11/12] fpga: dfl: fme: add global error reporting support

2019-08-06 Thread Wu Hao
On Mon, Aug 05, 2019 at 05:56:26PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:21PM +0800, Wu Hao wrote: > > +static int fme_global_err_init(struct platform_device *pdev, > > + struct dfl_feature *feature) > > +{ > > + struct device *dev; > > + int ret = 0; >

Re: [PATCH v4 07/12] fpga: dfl: afu: add error reporting support.

2019-08-06 Thread Wu Hao
On Mon, Aug 05, 2019 at 05:54:37PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:17PM +0800, Wu Hao wrote: > > Error reporting is one important private feature, it reports error > > detected on port and accelerated function unit (AFU). It introduces > > several sysfs interfaces to allow use

Re: [PATCH v4 06/12] fpga: dfl: afu: export __port_enable/disable function.

2019-08-06 Thread Wu Hao
On Mon, Aug 05, 2019 at 05:52:40PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > > As these two functions are used by other private features. e.g. > > in error reporting private feature, it requires to check port status > > and reset port for error clearing. > >

Re: [PATCH v4 04/12] fpga: dfl: afu: add userclock sysfs interfaces.

2019-08-06 Thread Wu Hao
On Mon, Aug 05, 2019 at 05:51:13PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:14PM +0800, Wu Hao wrote: > > This patch introduces userclock sysfs interfaces for AFU, user > > could use these interfaces for clock setting to AFU. > > > > Please note that, this is only working for port hea

Re: [PATCH v4 1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing

2019-08-06 Thread Andrew Morton
(cc Brendan's other email address, hoping for review input ;)) On Mon, 5 Aug 2019 13:04:47 -0400 "Joel Fernandes (Google)" wrote: > The page_idle tracking feature currently requires looking up the pagemap > for a process followed by interacting with /sys/kernel/mm/page_idle. > Looking up PFN f

[PATCH AUTOSEL 5.2 10/59] mm/hmm: always return EBUSY for invalid ranges in hmm_range_{fault,snapshot}

2019-08-06 Thread Sasha Levin
From: Christoph Hellwig [ Upstream commit 2bcbeaefde2f0384d6ad351c151b1a9fe7791a0a ] We should not have two different error codes for the same condition. EAGAIN must be reserved for the FAULT_FLAG_ALLOW_RETRY retry case and signals to the caller that the mmap_sem has been unlocked. Use EBUSY fo

Re: [PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-08-06 Thread Suman Anna
On 8/6/19 1:21 PM, Bjorn Andersson wrote: > On Tue 06 Aug 10:38 PDT 2019, Suman Anna wrote: > >> Hi Fabien, >> >> On 8/5/19 12:46 PM, Bjorn Andersson wrote: >>> On Mon 05 Aug 01:48 PDT 2019, Fabien DESSENNE wrote: >>> On 01/08/2019 9:14 PM, Bjorn Andersson wrote: > On Wed 13 Mar 08:5

Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234

2019-08-06 Thread gre...@linuxfoundation.org
On Tue, Aug 06, 2019 at 05:11:17PM +, Stefan-gabriel Mirea wrote: > On 8/5/2019 6:31 PM, gre...@linuxfoundation.org wrote: > > On Fri, Aug 02, 2019 at 07:47:23PM +, Stefan-gabriel Mirea wrote: > >> > >> +/* Freescale Linflex UART */ > >> +#define PORT_LINFLEXUART 121 > > > > Do you rea

Re: [PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-08-06 Thread Bjorn Andersson
On Tue 06 Aug 10:38 PDT 2019, Suman Anna wrote: > Hi Fabien, > > On 8/5/19 12:46 PM, Bjorn Andersson wrote: > > On Mon 05 Aug 01:48 PDT 2019, Fabien DESSENNE wrote: > > > >> > >> On 01/08/2019 9:14 PM, Bjorn Andersson wrote: > >>> On Wed 13 Mar 08:50 PDT 2019, Fabien Dessenne wrote: [..] > >> B/

Re: [PATCH] Documentation: fs: Convert xfs-delayed-logging-design.txt to ReSt

2019-08-06 Thread Jonathan Corbet
On Tue, 6 Aug 2019 10:03:23 +0100 Sheriff Esseson wrote: > Convert xfs-delayed-logging-design.txt to ReST and fix broken references. > The enumerations at "Lifecycle Changes" breaks because of lines begining with > "<", treat as diagrams. [...] > @@ -27,14 +30,18 @@ written to disk after change

Re: [PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-08-06 Thread Suman Anna
Hi Fabien, On 8/5/19 12:46 PM, Bjorn Andersson wrote: > On Mon 05 Aug 01:48 PDT 2019, Fabien DESSENNE wrote: > >> >> On 01/08/2019 9:14 PM, Bjorn Andersson wrote: >>> On Wed 13 Mar 08:50 PDT 2019, Fabien Dessenne wrote: >>> The current implementation does not allow two different devices to u

Re: [PATCH v3 0/3] Convert some RCU articles to ReST

2019-08-06 Thread Jonathan Corbet
On Tue, 30 Jul 2019 19:10:27 -0400 "Joel Fernandes (Google)" wrote: > This patch is a respin of the RCU ReST patch from Mauro [1]. > > I updated his changelog, and made some fixes. > > [1] https://www.spinics.net/lists/rcu/msg00750.html > > Joel Fernandes (Google) (2): > docs: rcu: Correct lin

Re: [PATCH] docs/zh_CN: update Chinese howto.rst for latexdocs making

2019-08-06 Thread Jonathan Corbet
On Mon, 5 Aug 2019 11:17:58 +0800 Alex Shi wrote: > Mauro Carvalho Chehab foundd a reference > error in Chinese howto.rst. which need update introducations for > latexdocs/epubdocs format doc making. > > So I update this part according to latest howto.rst. This one doesn't apply to docs-next,

Re: [PATCH] Input: docs: fix spelling mistake "potocol" -> "protocol"

2019-08-06 Thread Jonathan Corbet
On Mon, 5 Aug 2019 11:49:51 +0100 Colin King wrote: > There is a minor spelling mistake in the documentation, fix it. > > Signed-off-by: Colin Ian King > --- > Documentation/input/multi-touch-protocol.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/

Re: [PATCH] kernel-doc: ignore __printf attribute

2019-08-06 Thread Jonathan Corbet
On Mon, 5 Aug 2019 09:29:50 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > Ignore __printf() function attributes just as other __attribute__ > strings are ignored. > > Fixes this kernel-doc warning message: > include/kunit/kunit-stream.h:58: warning: Function parameter or member '2' > not

Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234

2019-08-06 Thread Stefan-gabriel Mirea
On 8/5/2019 6:31 PM, gre...@linuxfoundation.org wrote: > On Fri, Aug 02, 2019 at 07:47:23PM +, Stefan-gabriel Mirea wrote: >> >> +/* Freescale Linflex UART */ >> +#define PORT_LINFLEXUART 121 > > Do you really need this modified? Hello Greg, This macro is meant to be assigned to port->ty

Re: [PATCH] docs: mtd: Update spi nor reference driver

2019-08-06 Thread Schrempf Frieder
Cc: +MTD/SPI-NOR/SPI maintainers Hi John, On 06.08.19 18:35, John Garry wrote: > On 06/08/2019 17:06, John Garry wrote: >> The reference driver no longer exists since commit 50f1242c6742 ("mtd: >> fsl-quadspi: Remove the driver as it was replaced by spi-fsl-qspi.c"). >> >> Update reference to spi

Re: [PATCH] docs: mtd: Update spi nor reference driver

2019-08-06 Thread John Garry
On 06/08/2019 17:06, John Garry wrote: The reference driver no longer exists since commit 50f1242c6742 ("mtd: fsl-quadspi: Remove the driver as it was replaced by spi-fsl-qspi.c"). Update reference to spi-fsl-qspi.c driver. Signed-off-by: John Garry diff --git a/Documentation/driver-api/mtd/s

[PATCH] docs: mtd: Update spi nor reference driver

2019-08-06 Thread John Garry
The reference driver no longer exists since commit 50f1242c6742 ("mtd: fsl-quadspi: Remove the driver as it was replaced by spi-fsl-qspi.c"). Update reference to spi-fsl-qspi.c driver. Signed-off-by: John Garry diff --git a/Documentation/driver-api/mtd/spi-nor.rst b/Documentation/driver-api/mt

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 11:47:47PM +0900, Minchan Kim wrote: > On Tue, Aug 06, 2019 at 01:57:03PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 07:14:46, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Minchan Kim
On Tue, Aug 06, 2019 at 01:57:03PM +0200, Michal Hocko wrote: > On Tue 06-08-19 07:14:46, Joel Fernandes wrote: > > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrot

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Michal Hocko
On Tue 06-08-19 09:43:21, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 01:57:03PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 07:14:46, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > > > O

Re: [PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 01:44:02PM +0200, Michal Hocko wrote: [snip] > > > > This operation even if expensive is only done once during the access of > > > > the > > > > page_idle file. Did you have a better fix in mind? > > > > > > Can we set the idle bit also for non-lru pages as long as they ar

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 01:57:03PM +0200, Michal Hocko wrote: > On Tue 06-08-19 07:14:46, Joel Fernandes wrote: > > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrot

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Michal Hocko
On Tue 06-08-19 07:14:46, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > > > > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: >

Re: [PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-06 Thread Michal Hocko
On Tue 06-08-19 07:19:21, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 12:51:49PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 06:45:54, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > > > > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: >

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 01:14:52PM +0200, Michal Hocko wrote: > On Tue 06-08-19 20:07:37, Minchan Kim wrote: > > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote:

Re: [PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 12:51:49PM +0200, Michal Hocko wrote: > On Tue 06-08-19 06:45:54, Joel Fernandes wrote: > > On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > > > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > > > During idle tracking, we see that sometimes faulte

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Michal Hocko
On Tue 06-08-19 20:07:37, Minchan Kim wrote: > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > > > > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > > >

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > > > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > > > > This bit will be used by idle page tracking code t

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Minchan Kim
On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > > > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > > > > This bit will be used by idle page tracking code t

Re: [PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-06 Thread Michal Hocko
On Tue 06-08-19 06:45:54, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > > During idle tracking, we see that sometimes faulted anon pages are in > > > pagevec but are not drained to LRU. Idle tra

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Michal Hocko
On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > > > This bit will be used by idle page tracking code to correctly identify > > > if a page that was swapped out was idle bef

Re: [PATCH v4 1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 10:56:05AM +0200, Michal Hocko wrote: > On Mon 05-08-19 13:04:47, Joel Fernandes (Google) wrote: > > The page_idle tracking feature currently requires looking up the pagemap > > for a process followed by interacting with /sys/kernel/mm/page_idle. > > Looking up PFN from page

Re: [PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > During idle tracking, we see that sometimes faulted anon pages are in > > pagevec but are not drained to LRU. Idle tracking considers pages only > > on LRU. Drain all CPU's L

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Joel Fernandes
On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > > This bit will be used by idle page tracking code to correctly identify > > if a page that was swapped out was idle before it got swapped out. > > Without this PTE bit, we los

[PATCH] Documentation: fs: Convert xfs-delayed-logging-design.txt to ReSt

2019-08-06 Thread Sheriff Esseson
Convert xfs-delayed-logging-design.txt to ReST and fix broken references. The enumerations at "Lifecycle Changes" breaks because of lines begining with "<", treat as diagrams. Signed-off-by: Sheriff Esseson --- Documentation/filesystems/index.rst | 1 + ...ign.txt => xfs-delayed-loggi

Re: [PATCH v4 1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing

2019-08-06 Thread Michal Hocko
On Mon 05-08-19 13:04:47, Joel Fernandes (Google) wrote: > The page_idle tracking feature currently requires looking up the pagemap > for a process followed by interacting with /sys/kernel/mm/page_idle. > Looking up PFN from pagemap in Android devices is not supported by > unprivileged process and

Re: [PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-06 Thread Michal Hocko
On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > During idle tracking, we see that sometimes faulted anon pages are in > pagevec but are not drained to LRU. Idle tracking considers pages only > on LRU. Drain all CPU's LRU before starting idle tracking. Please expand on why does this matt

Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-06 Thread Michal Hocko
On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > This bit will be used by idle page tracking code to correctly identify > if a page that was swapped out was idle before it got swapped out. > Without this PTE bit, we lose information about if a page is idle or not > since the page frame ge

RE: [PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-08-06 Thread Fabien DESSENNE
Hi Suman, Could you please let us know your thoughts or comments? BR Fabien > -Original Message- > From: Bjorn Andersson > Sent: lundi 5 août 2019 19:47 > To: Fabien DESSENNE > Cc: Ohad Ben-Cohen ; Rob Herring ; > Mark Rutland ; Maxime Coquelin > ; Alexandre TORGUE > ; Jonathan Corbe