Re: [PATCH 1/2] dt-bindings: hwmon: Add DT bindings for TI ads1000/ads1100 ADCs

2019-06-13 Thread Serge Semin
Hello Rob On Thu, Jun 13, 2019 at 02:33:13PM -0600, Rob Herring wrote: > On Wed, May 15, 2019 at 01:58:08AM +0300, Serge Semin wrote: > > Add dt-binding documentation for the Texas Instruments ads1000/ads1100 ADCs > > driver. > > > > Signed-off-by: Serge Semin > > --- > > .../devicetree/binding

Re: [RFC 0/7] Introduce TEE based Trusted Keys support

2019-06-13 Thread Sumit Garg
On Thu, 13 Jun 2019 at 22:10, Casey Schaufler wrote: > > On 6/13/2019 3:30 AM, Sumit Garg wrote: > > Add support for TEE based trusted keys where TEE provides the functionality > > to seal and unseal trusted keys using hardware unique key. Also, this is > > an alternative in case platform doesn't

Re: [RFC 4/7] KEYS: trusted: Introduce TEE based Trusted Keys

2019-06-13 Thread Sumit Garg
On Thu, 13 Jun 2019 at 21:02, Jarkko Sakkinen wrote: > > On Thu, Jun 13, 2019 at 04:00:30PM +0530, Sumit Garg wrote: > > Add support for TEE based trusted keys where TEE provides the functionality > > to seal and unseal trusted keys using hardware unique key. > > > > Refer to Documentation/tee.txt

Re: [RFC 6/7] doc: keys: Document usage of TEE based Trusted Keys

2019-06-13 Thread Sumit Garg
On Thu, 13 Jun 2019 at 21:04, Jarkko Sakkinen wrote: > > On Thu, Jun 13, 2019 at 04:00:32PM +0530, Sumit Garg wrote: > > Provide documentation for usage of TEE based Trusted Keys via existing > > user-space "keyctl" utility. Also, document various use-cases. > > > > Signed-off-by: Sumit Garg > >

Re: [PATCH] docs: stop suggesting strlcpy

2019-06-13 Thread Kees Cook
On Thu, Jun 13, 2019 at 06:25:48PM +0200, Stephen Kitt wrote: > Since strlcpy is deprecated, the documentation shouldn't suggest using > it. This patch fixes the examples to use strscpy instead. It also uses > sizeof instead of underlying constants as far as possible, to simplify > future changes t

Re: [RFC 2/7] tee: enable support to register kernel memory

2019-06-13 Thread Sumit Garg
On Thu, 13 Jun 2019 at 20:50, Jarkko Sakkinen wrote: > > On Thu, Jun 13, 2019 at 04:00:28PM +0530, Sumit Garg wrote: > > Enable support to register kernel memory reference with TEE. This change > > will allow TEE bus drivers to register memory references. > > > > Signed-off-by: Sumit Garg > > Rev

Re: [RFC 1/7] tee: optee: allow kernel pages to register as shm

2019-06-13 Thread Sumit Garg
On Thu, 13 Jun 2019 at 20:47, Jarkko Sakkinen wrote: > > On Thu, Jun 13, 2019 at 06:17:14PM +0300, Jarkko Sakkinen wrote: > > On Thu, Jun 13, 2019 at 06:12:57PM +0300, Jarkko Sakkinen wrote: > > > On Thu, Jun 13, 2019 at 04:00:27PM +0530, Sumit Garg wrote: > > > > Kernel pages are marked as normal

[PATCH 08/14] scripts/get_abi.pl: split label naming from xref logic

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Instead of using a ReST compilant label while parsing, move the label to ReST output. That makes the parsing logic more generic, allowing it to provide other types of output. As a side effect, now all files used to generate the output will be output. We can later add

[PATCH 05/14] scripts: add an script to parse the ABI files

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Add a script to parse the Documentation/ABI files and produce an output with all entries inside an ABI (sub)directory. Right now, it outputs its contents on ReST format. It shouldn't be hard to make it produce other kind of outputs, since the ABI file parser is implem

[PATCH 10/14] scripts/get_abi.pl: represent what in tables

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Several entries at the ABI have multiple What: with the same description. Instead of showing those symbols as sections, let's show them as tables. That makes easier to read on the final output, and avoid too much recursion at Sphinx parsing. We need to put file refer

[PATCH 11/14] scripts/get_abi.pl: fix parse issues with some files

2019-06-13 Thread Mauro Carvalho Chehab
A few files are failing to parse: Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats Documentation/ABI/testing/sysfs-class-pktcdvd Documentation/ABI/testing/sysfs-bus-nfit On all three files, the problem is that there is a ":" character at the initial file descripti

[PATCH 04/14] ABI: better identificate tables

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab When parsing via script, it is important to know if the script should consider a description as a literal block that should be displayed as-is, or if the description can be considered as a normal text. Change descriptions to ensure that the preceding line of a table e

[PATCH 02/14] ABI: sysfs-driver-hid: the "What" field doesn't parse fine

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab The What: field on this ABI description use a different syntax than expected, causing it to not be properly parsed by script. Fix it. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/testing/sysfs-driver-hid | 12

[PATCH 01/14] ABI: fix some syntax issues at the ABI database

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab On those three files, the ABI representation described at README are violated. - at sysfs-bus-iio-proximity-as3935: a ':' character is missing after "What" - at sysfs-class-devfreq: there's a typo at Description - at sysfs-class-cxl, it is using the

[PATCH 14/14] docs: sphinx/kernel_abi.py: fix UTF-8 support

2019-06-13 Thread Mauro Carvalho Chehab
The parser breaks with UTF-8 characters with Sphinx 1.4. Signed-off-by: Mauro Carvalho Chehab --- Documentation/sphinx/kernel_abi.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/sphinx/kernel_abi.py b/Documentation/sphinx/kernel_abi.py index 7fa78

[PATCH 09/14] scripts/get_abi.pl: add support for searching for ABI symbols

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Change its syntax to allow switching between ReST output mode and a new search mode, with allows to seek for ABI symbols using regex. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- scripts/get_abi.pl | 112

[PATCH 00/14] Add support to generate ABI documentation at admin-guide

2019-06-13 Thread Mauro Carvalho Chehab
Greg, As promised, I'm resending the patch series with adds the Kernel ABI to Documentation/admin-guide. Those patches are basically the version 3 patchset I sent back in 2017, rebased on the top of linux-next (next-20190613), and with some fixes in order for it to work. - The 4 initial pa

[PATCH 12/14] doc-rst: add ABI documentation to the admin-guide book

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab As we don't want a generic Sphinx extension to execute commands, change the one proposed to Markus to call the abi_book.pl script. Use a script to parse the Documentation/ABI directory and output it at the admin-guide. Signed-off-by: Mauro Carvalho Chehab Signed-off

[PATCH 07/14] scripts/get_abi.pl: avoid use literal blocks when not needed

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab The usage of literal blocks make the document very complex, causing the browser to take a long time to load. On most ABI descriptions, they're a plain text, and don't require a literal block. So, add a logic there with identifies when a literal block is needed. As,

[PATCH 13/14] sphinx/kernel_abi.py: make it compatible with Sphinx 1.7+

2019-06-13 Thread Mauro Carvalho Chehab
The same way kerneldoc.py needed changes to work with newer Sphinx, this script needs the same changes. Signed-off-by: Mauro Carvalho Chehab --- Documentation/sphinx/kernel_abi.py | 31 ++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/Documentation/sp

[PATCH 06/14] scripts/get_abi.pl: parse files with text at beginning

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab It sounds usefult o parse files with has some text at the beginning. Add support for it. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- scripts/get_abi.pl | 59 ++ 1 file changed, 54 inserti

[PATCH 03/14] ABI: sysfs-class-uwb_rc: remove a duplicated incomplete entry

2019-06-13 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab There are two entries for /sys/class/uwb_rc/uwbN//BPST. The second one has a missing description. Get rid of it. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/testing/sysfs-class-uwb_rc | 6 -- 1 file changed,

Re: [RFC 0/7] Introduce TEE based Trusted Keys support

2019-06-13 Thread Mimi Zohar
On Thu, 2019-06-13 at 09:40 -0700, Casey Schaufler wrote: > On 6/13/2019 3:30 AM, Sumit Garg wrote: > > Add support for TEE based trusted keys where TEE provides the functionality > > to seal and unseal trusted keys using hardware unique key. Also, this is > > an alternative in case platform doesn'

Re: [PATCH v2 2/5] dt-bindings: perf: stm32: ddrperfm support

2019-06-13 Thread Rob Herring
On Mon, 20 May 2019 15:27:16 +, Gerald BAEZA wrote: > The DDRPERFM is the DDR Performance Monitor embedded in STM32MP1 SOC. > > This documentation indicates how to enable stm32-ddr-pmu driver on > DDRPERFM peripheral, via the device tree. > > Signed-off-by: Gerald Baeza > --- > .../devicetr

Re: [PATCH 1/2] dt-bindings: hwmon: Add DT bindings for TI ads1000/ads1100 ADCs

2019-06-13 Thread Rob Herring
On Wed, May 15, 2019 at 01:58:08AM +0300, Serge Semin wrote: > Add dt-binding documentation for the Texas Instruments ads1000/ads1100 ADCs > driver. > > Signed-off-by: Serge Semin > --- > .../devicetree/bindings/hwmon/ads1000.txt | 61 Bindings should be separate patch. >

dringender Kredit

2019-06-13 Thread Herr David Williams
-- Benötigen Sie dringend einen Kredit? Wenn ja, antworten Sie für weitere Details

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-13 Thread Sasha Levin
On Wed, Jun 05, 2019 at 04:39:36PM +0530, Sumit Garg wrote: On Wed, 5 Jun 2019 at 01:39, Sasha Levin wrote: On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: >On Thu, 30 May 2019 at 20:58, Sasha Levin wrote: >> + /* Open context with TEE driver */ >> + pvt_data->ctx = te

Re: [RFC 0/7] Introduce TEE based Trusted Keys support

2019-06-13 Thread Casey Schaufler
On 6/13/2019 3:30 AM, Sumit Garg wrote: > Add support for TEE based trusted keys where TEE provides the functionality > to seal and unseal trusted keys using hardware unique key. Also, this is > an alternative in case platform doesn't possess a TPM device. > > This series also adds some TEE feature

Re: [PATCH v1 20/31] docs: hid: convert to ReST

2019-06-13 Thread Benjamin Tissoires
On Wed, Jun 12, 2019 at 8:39 PM Mauro Carvalho Chehab wrote: > > Rename the HID documentation files to ReST, add an > index for them and adjust in order to produce a nice html > output via the Sphinx build system. > > While here, fix the sysfs example from hid-sensor.txt, that > has a lot of "?" i

[PATCH] docs: stop suggesting strlcpy

2019-06-13 Thread Stephen Kitt
Since strlcpy is deprecated, the documentation shouldn't suggest using it. This patch fixes the examples to use strscpy instead. It also uses sizeof instead of underlying constants as far as possible, to simplify future changes to the corresponding data structures. Signed-off-by: Stephen Kitt ---

[PATCH v5 0/2] arm64 relaxed ABI

2019-06-13 Thread Vincenzo Frascino
On arm64 the TCR_EL1.TBI0 bit has been always enabled on the arm64 kernel, hence the userspace (EL0) is allowed to set a non-zero value in the top byte but the resulting pointers are not allowed at the user-kernel syscall ABI boundary. This patchset proposes a relaxation of the ABI with which it i

[PATCH v5 2/2] arm64: Relax Documentation/arm64/tagged-pointers.txt

2019-06-13 Thread Vincenzo Frascino
On arm64 the TCR_EL1.TBI0 bit has been always enabled hence the userspace (EL0) is allowed to set a non-zero value in the top byte but the resulting pointers are not allowed at the user-kernel syscall ABI boundary. With the relaxed ABI proposed in this set, it is now possible to pass tagged pointe

[PATCH v5 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Vincenzo Frascino
On arm64 the TCR_EL1.TBI0 bit has been always enabled hence the userspace (EL0) is allowed to set a non-zero value in the top byte but the resulting pointers are not allowed at the user-kernel syscall ABI boundary. With the relaxed ABI proposed through this document, it is now possible to pass tag

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Catalin Marinas
Hi Szabolcs, On Wed, Jun 12, 2019 at 05:30:34PM +0100, Szabolcs Nagy wrote: > On 12/06/2019 15:21, Vincenzo Frascino wrote: > > +2. ARM64 Tagged Address ABI > > +--- > > + > > +From the kernel syscall interface prospective, we define, for the purposes >

Re: [PATCH v3 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation

2019-06-13 Thread Peter Zijlstra
On Fri, May 31, 2019 at 05:08:30PM +0200, Marco Elver wrote: > This patch is a pre-requisite for enabling KASAN bitops instrumentation; > using static_cpu_has instead of boot_cpu_has avoids instrumentation of > test_bit inside the uaccess region. With instrumentation, the KASAN > check would otherw

Re: [PATCH v1 20/31] docs: hid: convert to ReST

2019-06-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Jun 2019 10:08:34 +0200 Benjamin Tissoires escreveu: > On Wed, Jun 12, 2019 at 8:39 PM Mauro Carvalho Chehab > wrote: > > > > Rename the HID documentation files to ReST, add an > > index for them and adjust in order to produce a nice html > > output via the Sphinx build system. > > >

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Catalin Marinas
On Thu, Jun 13, 2019 at 02:23:43PM +0100, Dave P Martin wrote: > On Thu, Jun 13, 2019 at 01:28:21PM +0100, Catalin Marinas wrote: > > On Thu, Jun 13, 2019 at 12:37:32PM +0100, Dave P Martin wrote: > > > On Thu, Jun 13, 2019 at 11:15:34AM +0100, Vincenzo Frascino wrote: > > > > On 12/06/2019 16:35,

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Vincenzo Frascino
Hi Catalin, On 12/06/2019 16:35, Catalin Marinas wrote: > Hi Vincenzo, > > Some minor comments below but it looks fine to me overall. Cc'ing > Szabolcs as well since I'd like a view from the libc people. > Thanks for this, I saw Szabolcs comments. > On Wed, Jun 12, 2019 at 03:21:10PM +0100, Vi

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Szabolcs Nagy
On 13/06/2019 10:20, Catalin Marinas wrote: > Hi Szabolcs, > > On Wed, Jun 12, 2019 at 05:30:34PM +0100, Szabolcs Nagy wrote: >> On 12/06/2019 15:21, Vincenzo Frascino wrote: >>> +2. ARM64 Tagged Address ABI >>> +--- >>> + >>> +From the kernel syscall interface prospective,

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Vincenzo Frascino
On 13/06/2019 16:32, Szabolcs Nagy wrote: > On 13/06/2019 15:03, Vincenzo Frascino wrote: >> On 13/06/2019 13:28, Szabolcs Nagy wrote: >>> On 13/06/2019 12:16, Vincenzo Frascino wrote: On 13/06/2019 11:14, Szabolcs Nagy wrote: > On 13/06/2019 10:20, Catalin Marinas wrote: >> On Wed,

[PATCH] dt: leds-lm36274.txt: fix a broken reference to ti-lmu.txt

2019-06-13 Thread Mauro Carvalho Chehab
There's a typo there: ti_lmu.txt -> ti-lmu.txt Signed-off-by: Mauro Carvalho Chehab --- Documentation/devicetree/bindings/leds/leds-lm36274.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/leds-lm36274.txt b/Documentation/dev

Re: [RFC 6/7] doc: keys: Document usage of TEE based Trusted Keys

2019-06-13 Thread Jarkko Sakkinen
On Thu, Jun 13, 2019 at 04:00:32PM +0530, Sumit Garg wrote: > Provide documentation for usage of TEE based Trusted Keys via existing > user-space "keyctl" utility. Also, document various use-cases. > > Signed-off-by: Sumit Garg Sorry missed this patch. Anyway, I don't think we want multiple trus

[RFC 3/7] tee: add private login method for kernel clients

2019-06-13 Thread Sumit Garg
There are use-cases where user-space shouldn't be allowed to communicate directly with a TEE device which is dedicated to provide a specific service for a kernel client. So add a private login method for kernel clients and disallow user-space to open-session using this login method. Signed-off-by:

[RFC 4/7] KEYS: trusted: Introduce TEE based Trusted Keys

2019-06-13 Thread Sumit Garg
Add support for TEE based trusted keys where TEE provides the functionality to seal and unseal trusted keys using hardware unique key. Refer to Documentation/tee.txt for detailed information about TEE. Approach taken in this patch acts as an alternative to a TPM device in case platform doesn't po

[PATCH] scripts/documentation-file-ref-check: ignore output dir

2019-06-13 Thread Mauro Carvalho Chehab
When there's no Documentation/output directory, the script will complain about those missing references: Documentation/doc-guide/sphinx.rst: Documentation/output Documentation/doc-guide/sphinx.rst: Documentation/output Documentation/process/howto.rst: Documentation/output

[RFC 2/7] tee: enable support to register kernel memory

2019-06-13 Thread Sumit Garg
Enable support to register kernel memory reference with TEE. This change will allow TEE bus drivers to register memory references. Signed-off-by: Sumit Garg --- drivers/tee/tee_shm.c | 16 ++-- include/linux/tee_drv.h | 1 + 2 files changed, 15 insertions(+), 2 deletions(-) diff

[RFC 0/7] Introduce TEE based Trusted Keys support

2019-06-13 Thread Sumit Garg
Add support for TEE based trusted keys where TEE provides the functionality to seal and unseal trusted keys using hardware unique key. Also, this is an alternative in case platform doesn't possess a TPM device. This series also adds some TEE features like: Patch #1, #2 enables support for registe

[RFC 1/7] tee: optee: allow kernel pages to register as shm

2019-06-13 Thread Sumit Garg
Kernel pages are marked as normal type memory only so allow kernel pages to be registered as shared memory with OP-TEE. Signed-off-by: Sumit Garg --- drivers/tee/optee/call.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c index aa94

[RFC 6/7] doc: keys: Document usage of TEE based Trusted Keys

2019-06-13 Thread Sumit Garg
Provide documentation for usage of TEE based Trusted Keys via existing user-space "keyctl" utility. Also, document various use-cases. Signed-off-by: Sumit Garg --- Documentation/security/keys/tee-trusted.rst | 93 + 1 file changed, 93 insertions(+) create mode 100644

[RFC 7/7] MAINTAINERS: Add entry for TEE based Trusted Keys

2019-06-13 Thread Sumit Garg
Add MAINTAINERS entry for TEE based Trusted Keys framework. Signed-off-by: Sumit Garg --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57f496c..db84fc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8728,6 +8728,15 @@ F: include/k

[RFC 5/7] KEYS: encrypted: Allow TEE based trusted master keys

2019-06-13 Thread Sumit Garg
Allow search for TEE based trusted keys to act as master keys in case TPM device is not present. Signed-off-by: Sumit Garg --- security/keys/encrypted-keys/masterkey_trusted.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/security/keys/encrypted-keys/masterkey_tr

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Szabolcs Nagy
On 13/06/2019 15:03, Vincenzo Frascino wrote: > On 13/06/2019 13:28, Szabolcs Nagy wrote: >> On 13/06/2019 12:16, Vincenzo Frascino wrote: >>> On 13/06/2019 11:14, Szabolcs Nagy wrote: On 13/06/2019 10:20, Catalin Marinas wrote: > On Wed, Jun 12, 2019 at 05:30:34PM +0100, Szabolcs Nagy wro

Re: [PATCH v3 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Andrey Ryabinin
On 5/31/19 6:08 PM, Marco Elver wrote: > This adds bitops tests to the test_kasan module. In a follow-up patch, > support for bitops instrumentation will be added. > > Signed-off-by: Marco Elver > --- > Changes in v3: > * Use kzalloc instead of kmalloc. > * Use sizeof(*bits). > > Changes in v

Re: [PATCH v3 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation

2019-06-13 Thread Andrey Ryabinin
On 5/31/19 6:08 PM, Marco Elver wrote: > This patch is a pre-requisite for enabling KASAN bitops instrumentation; > using static_cpu_has instead of boot_cpu_has avoids instrumentation of > test_bit inside the uaccess region. With instrumentation, the KASAN > check would otherwise be flagged by o

Re: [PATCH v3 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-06-13 Thread Andrey Ryabinin
On 5/31/19 6:08 PM, Marco Elver wrote: > This adds a new header to asm-generic to allow optionally instrumenting > architecture-specific asm implementations of bitops. > > This change includes the required change for x86 as reference and > changes the kernel API doc to point to bitops-instrumen

Re: [RFC 4/7] KEYS: trusted: Introduce TEE based Trusted Keys

2019-06-13 Thread Jarkko Sakkinen
On Thu, Jun 13, 2019 at 04:00:30PM +0530, Sumit Garg wrote: > Add support for TEE based trusted keys where TEE provides the functionality > to seal and unseal trusted keys using hardware unique key. > > Refer to Documentation/tee.txt for detailed information about TEE. > > Approach taken in this

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Vincenzo Frascino
Hi Szabolcs, thank you for your review. On 13/06/2019 11:14, Szabolcs Nagy wrote: > On 13/06/2019 10:20, Catalin Marinas wrote: >> Hi Szabolcs, >> >> On Wed, Jun 12, 2019 at 05:30:34PM +0100, Szabolcs Nagy wrote: >>> On 12/06/2019 15:21, Vincenzo Frascino wrote: +2. ARM64 Tagged Address ABI

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Dave Martin
On Thu, Jun 13, 2019 at 11:15:34AM +0100, Vincenzo Frascino wrote: > Hi Catalin, > > On 12/06/2019 16:35, Catalin Marinas wrote: > > Hi Vincenzo, > > > > Some minor comments below but it looks fine to me overall. Cc'ing > > Szabolcs as well since I'd like a view from the libc people. > > > > Th

[PATCH v4 0/3] Bitops instrumentation for KASAN

2019-06-13 Thread Marco Elver
Previous version: http://lkml.kernel.org/r/20190531150828.157832-1-el...@google.com * This version only changes lib/test_kasan.c. * Remaining files are identical to v3. Marco Elver (3): lib/test_kasan: Add bitops tests x86: Use static_cpu_has in uaccess region to avoid instrumentation asm-g

[PATCH v4 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation

2019-06-13 Thread Marco Elver
This patch is a pre-requisite for enabling KASAN bitops instrumentation; using static_cpu_has instead of boot_cpu_has avoids instrumentation of test_bit inside the uaccess region. With instrumentation, the KASAN check would otherwise be flagged by objtool. For consistency, kernel/signal.c was chan

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Catalin Marinas
On Thu, Jun 13, 2019 at 12:37:32PM +0100, Dave P Martin wrote: > On Thu, Jun 13, 2019 at 11:15:34AM +0100, Vincenzo Frascino wrote: > > On 12/06/2019 16:35, Catalin Marinas wrote: > > > On Wed, Jun 12, 2019 at 03:21:10PM +0100, Vincenzo Frascino wrote: > > >> + - PR_GET_TAGGED_ADDR_CTRL: can be us

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Szabolcs Nagy
On 13/06/2019 12:16, Vincenzo Frascino wrote: > Hi Szabolcs, > > thank you for your review. > > On 13/06/2019 11:14, Szabolcs Nagy wrote: >> On 13/06/2019 10:20, Catalin Marinas wrote: >>> Hi Szabolcs, >>> >>> On Wed, Jun 12, 2019 at 05:30:34PM +0100, Szabolcs Nagy wrote: On 12/06/2019 15:21

[PATCH v4 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Marco Elver
This adds bitops tests to the test_kasan module. In a follow-up patch, support for bitops instrumentation will be added. Signed-off-by: Marco Elver Acked-by: Mark Rutland --- Changes in v4: * Remove "within-bounds" tests. * Allocate sizeof(*bite) + 1, to not actually corrupt other memory in ca

[PATCH v4 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-06-13 Thread Marco Elver
This adds a new header to asm-generic to allow optionally instrumenting architecture-specific asm implementations of bitops. This change includes the required change for x86 as reference and changes the kernel API doc to point to bitops-instrumented.h instead. Rationale: the functions in x86's bit

Re: [PATCH v3 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Marco Elver
Thanks, I've sent v4. On Thu, 13 Jun 2019 at 12:49, Andrey Ryabinin wrote: > > > > On 5/31/19 6:08 PM, Marco Elver wrote: > > This adds bitops tests to the test_kasan module. In a follow-up patch, > > support for bitops instrumentation will be added. > > > > Signed-off-by: Marco Elver > > --- >

Re: [PATCH v4 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Andrey Ryabinin
On 6/13/19 3:30 PM, Marco Elver wrote: > This adds bitops tests to the test_kasan module. In a follow-up patch, > support for bitops instrumentation will be added. > > Signed-off-by: Marco Elver > Acked-by: Mark Rutland > --- Reviewed-by: Andrey Ryabinin > +static noinline void __init k

Re: [RFC 2/7] tee: enable support to register kernel memory

2019-06-13 Thread Jarkko Sakkinen
On Thu, Jun 13, 2019 at 04:00:28PM +0530, Sumit Garg wrote: > Enable support to register kernel memory reference with TEE. This change > will allow TEE bus drivers to register memory references. > > Signed-off-by: Sumit Garg Reviewed-by: Jarkko Sakkinen /Jarkko

[PATCH v5 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Marco Elver
This adds bitops tests to the test_kasan module. In a follow-up patch, support for bitops instrumentation will be added. Signed-off-by: Marco Elver Acked-by: Mark Rutland Reviewed-by: Andrey Ryabinin --- Changes in v5: * Remove incorrect comment. Changes in v4: * Remove "within-bounds" tests.

[PATCH v5 0/3] Bitops instrumentation for KASAN

2019-06-13 Thread Marco Elver
Previous version: http://lkml.kernel.org/r/20190613123028.179447-1-el...@google.com * Only changed lib/test_kasan in this version. Marco Elver (3): lib/test_kasan: Add bitops tests x86: Use static_cpu_has in uaccess region to avoid instrumentation asm-generic, x86: Add bitops instrumentatio

[PATCH v5 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation

2019-06-13 Thread Marco Elver
This patch is a pre-requisite for enabling KASAN bitops instrumentation; using static_cpu_has instead of boot_cpu_has avoids instrumentation of test_bit inside the uaccess region. With instrumentation, the KASAN check would otherwise be flagged by objtool. For consistency, kernel/signal.c was chan

[PATCH v5 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-06-13 Thread Marco Elver
This adds a new header to asm-generic to allow optionally instrumenting architecture-specific asm implementations of bitops. This change includes the required change for x86 as reference and changes the kernel API doc to point to bitops-instrumented.h instead. Rationale: the functions in x86's bit

Re: [PATCH v4 1/3] lib/test_kasan: Add bitops tests

2019-06-13 Thread Marco Elver
On Thu, 13 Jun 2019 at 14:49, Andrey Ryabinin wrote: > > > > On 6/13/19 3:30 PM, Marco Elver wrote: > > This adds bitops tests to the test_kasan module. In a follow-up patch, > > support for bitops instrumentation will be added. > > > > Signed-off-by: Marco Elver > > Acked-by: Mark Rutland > > -

Re: [RFC 1/7] tee: optee: allow kernel pages to register as shm

2019-06-13 Thread Jarkko Sakkinen
On Thu, Jun 13, 2019 at 06:17:14PM +0300, Jarkko Sakkinen wrote: > On Thu, Jun 13, 2019 at 06:12:57PM +0300, Jarkko Sakkinen wrote: > > On Thu, Jun 13, 2019 at 04:00:27PM +0530, Sumit Garg wrote: > > > Kernel pages are marked as normal type memory only so allow kernel pages > > > to be registered a

Re: [RFC 1/7] tee: optee: allow kernel pages to register as shm

2019-06-13 Thread Jarkko Sakkinen
On Thu, Jun 13, 2019 at 06:12:57PM +0300, Jarkko Sakkinen wrote: > On Thu, Jun 13, 2019 at 04:00:27PM +0530, Sumit Garg wrote: > > Kernel pages are marked as normal type memory only so allow kernel pages > > to be registered as shared memory with OP-TEE. > > > > Signed-off-by: Sumit Garg > > Jus

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Dave Martin
On Thu, Jun 13, 2019 at 01:28:21PM +0100, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 12:37:32PM +0100, Dave P Martin wrote: > > On Thu, Jun 13, 2019 at 11:15:34AM +0100, Vincenzo Frascino wrote: > > > On 12/06/2019 16:35, Catalin Marinas wrote: > > > > On Wed, Jun 12, 2019 at 03:21:10PM +0100

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-13 Thread Dave Martin
On Wed, Jun 12, 2019 at 12:04:01PM -0700, Yu-cheng Yu wrote: > On Wed, 2019-06-12 at 10:32 +0100, Dave Martin wrote: > > On Tue, Jun 11, 2019 at 12:31:34PM -0700, Yu-cheng Yu wrote: > > > On Tue, 2019-06-11 at 12:41 +0100, Dave Martin wrote: > > > > On Mon, Jun 10, 2019 at 07:24:43PM +0200, Florian

Re: [RFC 1/7] tee: optee: allow kernel pages to register as shm

2019-06-13 Thread Jarkko Sakkinen
On Thu, Jun 13, 2019 at 04:00:27PM +0530, Sumit Garg wrote: > Kernel pages are marked as normal type memory only so allow kernel pages > to be registered as shared memory with OP-TEE. > > Signed-off-by: Sumit Garg Just out of pure interest why this was not allowed before? /Jarkko

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Vincenzo Frascino
On 13/06/2019 13:28, Szabolcs Nagy wrote: > On 13/06/2019 12:16, Vincenzo Frascino wrote: >> Hi Szabolcs, >> >> thank you for your review. >> >> On 13/06/2019 11:14, Szabolcs Nagy wrote: >>> On 13/06/2019 10:20, Catalin Marinas wrote: Hi Szabolcs, On Wed, Jun 12, 2019 at 05:30:34PM

[PATCH 5/9] media: docs: v4l2-controls: rearrange control initialization sequence

2019-06-13 Thread Luca Ceresoli
The code snippet showing how to add controls to the driver’s top-level struct is present twice, but only the second time it is split in the V4L2 and subdev cases. Consolidate everything at the beginning. Also remove the "Where foo->bar is of type struct baz" sentences, this obvious from the code.

[PATCH 8/9] media: docs: v4l2-controls: document file to include

2019-06-13 Thread Luca Ceresoli
The tutorial in this section is almost complete, add the one missing bit. Signed-off-by: Luca Ceresoli --- Documentation/media/kapi/v4l2-controls.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/media/kapi/v4l2-controls.rst b/Documentation/media/kapi/v4l2-controls.rst i

[PATCH 3/9] media: docs: v4l2-controls: fix indentation

2019-06-13 Thread Luca Ceresoli
Fix indentation in example C code. Signed-off-by: Luca Ceresoli --- Documentation/media/uapi/v4l/extended-controls.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/uapi/v4l/extended-controls.rst b/Documentation/media/uapi/v4l/extended-controls.rst inde

[PATCH 2/9] media: docs: v4l2-controls: remove repeated ioctl names

2019-06-13 Thread Luca Ceresoli
Mentioning :ref:`VIDIOC_QUERYCTRL` renders all the three related ioctls. Explicitly adding VIDIOC_QUERY_EXT_CTRL and VIDIOC_QUERYMENU will make them render twice, so remove them Signed-off-by: Luca Ceresoli --- Documentation/media/uapi/v4l/extended-controls.rst | 4 +--- 1 file changed, 1 insert

[PATCH 1/9] media: docs: v4l2-controls: fix sentence rendered in a nonsense way

2019-06-13 Thread Luca Ceresoli
This sentence renders as: > Since such compound controls need to expose more information about > themselves than is possible with ioctls VIDIOC_QUERYCTRL, > VIDIOC_QUERY_EXT_CTRL and VIDIOC_QUERYMENU the VIDIOC_QUERY_EXT_CTRL ^ ^ >

[PATCH 4/9] media: docs: v4l2-controls: add links to structs

2019-06-13 Thread Luca Ceresoli
This section lacks links to struct definitions. Add one where each struct is introduced. Signed-off-by: Luca Ceresoli --- Documentation/media/kapi/v4l2-controls.rst | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/Documentation/media/kapi/v4l2-controls.rst

[PATCH 7/9] media: docs: v4l2-controls: convert code blocks to C

2019-06-13 Thread Luca Ceresoli
All these code blocks contain C code, enable C formatting for a nicer reading. Signed-off-by: Luca Ceresoli --- Documentation/media/kapi/v4l2-controls.rst | 74 +++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/Documentation/media/kapi/v4l2-controls.rst b/Do

[PATCH 9/9] media: docs: v4l2-controls: remove outdated paragraph

2019-06-13 Thread Luca Ceresoli
This paragraph was added by commit a42b57f5aacf ("V4L/DVB: Documentation: add v4l2-controls.txt documenting the new controls API") back in 2010, when the controls API has been improved. Nowadays it is a bit anachronistic, so remove it. The same information is stated in up-to-date wording a few par

[PATCH 6/9] media: docs: v4l2-controls: add links to functions

2019-06-13 Thread Luca Ceresoli
This section lacks links to functions. Add one to simplify reading. Signed-off-by: Luca Ceresoli --- Documentation/media/kapi/v4l2-controls.rst | 67 +++--- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/Documentation/media/kapi/v4l2-controls.rst b/Documentation