Re: [PATCH 2/3] x86: Move CPU feature test out of uaccess region

2019-05-31 Thread hpa
On May 31, 2019 2:57:36 AM PDT, Marco Elver wrote: >On Wed, 29 May 2019 at 16:29, wrote: >> >> On May 29, 2019 7:15:00 AM PDT, Marco Elver wrote: >> >This patch is a pre-requisite for enabling KASAN bitops >> >instrumentation: >> >moves boot_cpu_has feature test out of the uaccess region, as >>

Re: [PATCH v3 2/3] kernel/ucounts: expose count of inotify watches in use

2019-05-31 Thread Andrew Morton
On Fri, 31 May 2019 21:50:15 +0200 Albert Vaca Cintora wrote: > Adds a readonly 'current_inotify_watches' entry to the user sysctl table. > The handler for this entry is a custom function that ends up calling > proc_dointvec. Said sysctl table already contains 'max_inotify_watches' > and it gets

Re: [PATCH RFC] Rough draft document on merging and rebasing

2019-05-31 Thread Randy Dunlap
On 5/31/19 4:36 PM, Jonathan Corbet wrote: > On Thu, 30 May 2019 17:45:23 -0700 > Randy Dunlap wrote: > >> On 5/30/19 12:53 PM, Jonathan Corbet wrote: >>> + git merge v5.2-rc1^0 >> >> That line is presented in my email client (Thunderbird) as >> >> git merge v5.2-rc1{superscript 0} >> >>

Re: [PATCH RFC] Rough draft document on merging and rebasing

2019-05-31 Thread Jonathan Corbet
On Thu, 30 May 2019 17:45:23 -0700 Randy Dunlap wrote: > On 5/30/19 12:53 PM, Jonathan Corbet wrote: > > + git merge v5.2-rc1^0 > > That line is presented in my email client (Thunderbird) as > > git merge v5.2-rc1{superscript 0} > > Could you escape/quote it to prevent that? So I'm a

Re: [PATCH RFC] Rough draft document on merging and rebasing

2019-05-31 Thread David Rientjes
On Thu, 30 May 2019, Jonathan Corbet wrote: > docs: Add a document on repository management > > Every merge window seems to involve at least one episode where subsystem > maintainers don't manage their trees as Linus would like. Document the > expectations so that at least he has something to po

Re: [PATCH v3] Allow to exclude specific file types in LoadPin

2019-05-31 Thread Kees Cook
On Fri, May 31, 2019 at 11:25:53AM -0700, Ke Wu wrote: > Linux kernel already provide MODULE_SIG and KEXEC_VERIFY_SIG to > make sure loaded kernel module and kernel image are trusted. This > patch adds a kernel command line option "loadpin.exclude" which > allows to exclude specific file types from

[PATCH v3 2/3] kernel/ucounts: expose count of inotify watches in use

2019-05-31 Thread Albert Vaca Cintora
Adds a readonly 'current_inotify_watches' entry to the user sysctl table. The handler for this entry is a custom function that ends up calling proc_dointvec. Said sysctl table already contains 'max_inotify_watches' and it gets mounted under /proc/sys/user/. Inotify watches are a finite resource, i

[PATCH v3 3/3] Documentation for /proc/sys/user/*_inotify_*

2019-05-31 Thread Albert Vaca Cintora
Added docs for the existing and new inotify-related files Signed-off-by: Albert Vaca Cintora --- Documentation/sysctl/user.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/sysctl/user.txt b/Documentation/sysctl/user.txt index a5882865836e..99c288d39cf6 10064

[PATCH v3 1/3] Move *_ucounts functions above

2019-05-31 Thread Albert Vaca Cintora
So we can use them from proc_handler functions in user_table Signed-off-by: Albert Vaca Cintora --- kernel/ucount.c | 122 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/kernel/ucount.c b/kernel/ucount.c index f48d1b6376a4..909c85

Re: [PATCH RFC] Rough draft document on merging and rebasing

2019-05-31 Thread Linus Torvalds
On Thu, May 30, 2019 at 12:53 PM Jonathan Corbet wrote: > > This is a first attempt at following through on last month's discussion > about common merging and rebasing errors. Looks good to me, Linus

[PATCH v3] Allow to exclude specific file types in LoadPin

2019-05-31 Thread Ke Wu
Linux kernel already provide MODULE_SIG and KEXEC_VERIFY_SIG to make sure loaded kernel module and kernel image are trusted. This patch adds a kernel command line option "loadpin.exclude" which allows to exclude specific file types from LoadPin. This is useful when people want to use different mech

Re: [PATCH v3 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-05-31 Thread Mark Rutland
On Fri, May 31, 2019 at 05:08:31PM +0200, Marco Elver wrote: > This adds a new header to asm-generic to allow optionally instrumenting > architecture-specific asm implementations of bitops. > > This change includes the required change for x86 as reference and > changes the kernel API doc to point

Re: [PATCH v3 1/3] lib/test_kasan: Add bitops tests

2019-05-31 Thread Mark Rutland
On Fri, May 31, 2019 at 05:08:29PM +0200, Marco Elver wrote: > This adds bitops tests to the test_kasan module. In a follow-up patch, > support for bitops instrumentation will be added. > > Signed-off-by: Marco Elver > --- > Changes in v3: > * Use kzalloc instead of kmalloc. > * Use sizeof(*bits)

Re: [PATCH] Documentation/stackprotector: powerpc supports stack protector

2019-05-31 Thread Michael Ellerman
Jonathan Corbet writes: > On Thu, 30 May 2019 18:37:46 +0530 > Bhupesh Sharma wrote: > >> > This should probably go via the documentation tree? >> > >> > Acked-by: Michael Ellerman >> >> Thanks for the review Michael. >> I am ok with this going through the documentation tree as well. > > Work

Re: [PATCH v2 0/3] Bitops instrumentation for KASAN

2019-05-31 Thread Marco Elver
Addressed comments, and sent v3: http://lkml.kernel.org/r/20190531150828.157832-1-el...@google.com Many thanks! -- Marco On Wed, 29 May 2019 at 16:23, Marco Elver wrote: > > The previous version of this patch series and discussion can be found > here: https://lkml.org/lkml/2019/5/28/769 > > Th

[PATCH v3 3/3] asm-generic, x86: Add bitops instrumentation for KASAN

2019-05-31 Thread Marco Elver
This adds a new header to asm-generic to allow optionally instrumenting architecture-specific asm implementations of bitops. This change includes the required change for x86 as reference and changes the kernel API doc to point to bitops-instrumented.h instead. Rationale: the functions in x86's bit

[PATCH v3 1/3] lib/test_kasan: Add bitops tests

2019-05-31 Thread Marco Elver
This adds bitops tests to the test_kasan module. In a follow-up patch, support for bitops instrumentation will be added. Signed-off-by: Marco Elver --- Changes in v3: * Use kzalloc instead of kmalloc. * Use sizeof(*bits). Changes in v2: * Use BITS_PER_LONG. * Use heap allocated memory for test,

[PATCH v3 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation

2019-05-31 Thread Marco Elver
This patch is a pre-requisite for enabling KASAN bitops instrumentation; using static_cpu_has instead of boot_cpu_has avoids instrumentation of test_bit inside the uaccess region. With instrumentation, the KASAN check would otherwise be flagged by objtool. For consistency, kernel/signal.c was chan

[PATCH v3 0/3] Bitops instrumentation for KASAN

2019-05-31 Thread Marco Elver
Previous version of this patch series and discussion can be found here: http://lkml.kernel.org/r/20190529141500.193390-1-el...@google.com Marco Elver (3): lib/test_kasan: Add bitops tests x86: Use static_cpu_has in uaccess region to avoid instrumentation asm-generic, x86: Add bitops instrume

[PATCH] docs: clk: fix struct syntax

2019-05-31 Thread Luca Ceresoli
The clk_foo_ops struct example has syntax errors. Fix it so it can be copy-pasted and used more easily. Signed-off-by: Luca Ceresoli --- Documentation/driver-api/clk.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/driver-api/clk.rst b/Documentation/dri

Re: [PATCH 2/3] x86: Move CPU feature test out of uaccess region

2019-05-31 Thread Marco Elver
On Wed, 29 May 2019 at 16:29, wrote: > > On May 29, 2019 7:15:00 AM PDT, Marco Elver wrote: > >This patch is a pre-requisite for enabling KASAN bitops > >instrumentation: > >moves boot_cpu_has feature test out of the uaccess region, as > >boot_cpu_has uses test_bit. With instrumentation, the KASA