Re: [PATCH v3 0/2] ftpm: a firmware based TPM driver

2019-05-16 Thread Sumit Garg
+ Rob On Fri, 17 May 2019 at 00:54, Thirupathaiah Annapureddy wrote: > > > > > -Original Message- > > From: Sumit Garg > > Sent: Thursday, May 16, 2019 12:06 AM > > To: Thirupathaiah Annapureddy > > Cc: Sasha Levin ; Jarkko Sakkinen > > ; peterhu...@gmx.de; j...@ziepe.ca; > > cor...@lwn

Re: [PATCH 3/4] ima: don't ignore INTEGRITY_UNKNOWN EVM status

2019-05-16 Thread Sasha Levin
On Thu, May 16, 2019 at 08:30:20PM -0400, Mimi Zohar wrote: On Fri, 2019-05-17 at 00:10 +, Sasha Levin wrote: How should we proceed with this patch? Yikes!  This was posted earlier today.  I haven't even had a chance to look at it yet.  Similarly for "[PATCH 4/4] ima: only audit failed ap

Re: [PATCH v4 02/18] kunit: test: add test resource management API

2019-05-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:55) > diff --git a/kunit/test.c b/kunit/test.c > index 86f65ba2bcf92..a15e6f8c41582 100644 > --- a/kunit/test.c > +++ b/kunit/test.c [..] > + > +void *kunit_kmalloc(struct kunit *test, size_t size, gfp_t gfp) > +{ > + struct kunit_kmalloc_params param

Re: [PATCH v4 01/18] kunit: test: add KUnit test runner core

2019-05-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:54) > diff --git a/include/kunit/test.h b/include/kunit/test.h > new file mode 100644 > index 0..e682ea0e1f9a5 > --- /dev/null > +++ b/include/kunit/test.h > @@ -0,0 +1,162 @@ [..] > +/** > + * struct kunit - represents a running instance of a t

Re: [PATCH 3/4] ima: don't ignore INTEGRITY_UNKNOWN EVM status

2019-05-16 Thread Mimi Zohar
On Fri, 2019-05-17 at 00:10 +, Sasha Levin wrote: > > How should we proceed with this patch? Yikes!  This was posted earlier today.  I haven't even had a chance to look at it yet.  Similarly for "[PATCH 4/4] ima: only audit failed appraisal verifications". Mimi

Re: [TRIVIA] Re: [PATCH] docs: Move kref.txt to core-api/kref.rst

2019-05-16 Thread Tobin C. Harding
On Wed, May 15, 2019 at 10:56:48AM -0600, Jonathan Corbet wrote: > On Fri, 10 May 2019 16:45:45 -0400 > "Tobin C. Harding" wrote: > > > I read once that they used 72 characters on punch cards at times because > > the other 8 characters got mangled for some reason. > > Those of use who worked in

RE: [PATCH v3 0/2] ftpm: a firmware based TPM driver

2019-05-16 Thread Thirupathaiah Annapureddy
> -Original Message- > From: Sumit Garg > Sent: Thursday, May 16, 2019 12:06 AM > To: Thirupathaiah Annapureddy > Cc: Sasha Levin ; Jarkko Sakkinen > ; peterhu...@gmx.de; j...@ziepe.ca; > cor...@lwn.net; Linux Kernel Mailing List ; > linux-doc@vger.kernel.org; linux-integr...@vger.kerne

[PATCH 3/4] ima: don't ignore INTEGRITY_UNKNOWN EVM status

2019-05-16 Thread Roberto Sassu
Currently, ima_appraise_measurement() ignores the EVM status when evm_verifyxattr() returns INTEGRITY_UNKNOWN. If a file has a valid security.ima xattr with type IMA_XATTR_DIGEST or IMA_XATTR_DIGEST_NG, ima_appraise_measurement() returns INTEGRITY_PASS regardless of the EVM status. The problem is t

[PATCH 4/4] ima: only audit failed appraisal verifications

2019-05-16 Thread Roberto Sassu
This patch ensures that integrity_audit_msg() is called only when the status is not INTEGRITY_PASS. Fixes: 8606404fa555c ("ima: digital signature verification support") Signed-off-by: Roberto Sassu Cc: sta...@vger.kernel.org --- security/integrity/ima/ima_appraise.c | 5 +++-- 1 file changed, 3

[PATCH 1/4] evm: check hash algorithm passed to init_desc()

2019-05-16 Thread Roberto Sassu
This patch prevents memory access beyond the evm_tfm array by checking the validity of the index (hash algorithm) passed to init_desc(). The hash algorithm can be arbitrarily set if the security.ima xattr type is not EVM_XATTR_HMAC. Fixes: 5feeb61183dde ("evm: Allow non-SHA1 digital signatures") S

[PATCH 2/4] evm: reset status in evm_inode_post_setattr()

2019-05-16 Thread Roberto Sassu
This patch adds a call to evm_reset_status() in evm_inode_post_setattr(), before security.evm is updated. The same is done in the other evm_inode_post_* functions. Fixes: 523b74b16bcbb ("evm: reset EVM status when file attributes change") Signed-off-by: Roberto Sassu Cc: sta...@vger.kernel.org --

[PATCH AUTOSEL 5.0 28/34] KVM: fix KVM_CLEAR_DIRTY_LOG for memory slots of unaligned size

2019-05-16 Thread Sasha Levin
From: Paolo Bonzini [ Upstream commit 76d58e0f07ec203bbdfcaabd9a9fc10a5a3ed5ea ] If a memory slot's size is not a multiple of 64 pages (256K), then the KVM_CLEAR_DIRTY_LOG API is unusable: clearing the final 64 pages either requires the requested page range to go beyond memslot->npages, or requi

Re: [PATCH v3 0/2] ftpm: a firmware based TPM driver

2019-05-16 Thread Sumit Garg
On Thu, 16 May 2019 at 06:30, Thirupathaiah Annapureddy wrote: > > > > > -Original Message- > > From: Sumit Garg > > Sent: Tuesday, May 14, 2019 7:02 PM > > To: Sasha Levin > > Cc: Jarkko Sakkinen ; peterhu...@gmx.de; > > j...@ziepe.ca; cor...@lwn.net; Linux Kernel Mailing List > ker...