Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST

2019-02-22 Thread Paul Cercueil
Hi, Le jeu. 24 janv. 2019 à 19:53, Paul Cercueil a écrit : Le jeu. 24 janv. 2019 à 19:46, Stephen Boyd a écrit : Quoting Paul Cercueil (2019-01-24 12:46:28) Le jeu. 24 janv. 2019 à 16:28, Stephen Boyd a écrit : > Quoting Guenter Roeck (2019-01-23 10:01:55) >> On Wed, Jan 23, 2019

Re: [PATCH v9 14/27] pwm: jz4740: Improve algorithm of clock calculation

2019-02-22 Thread Paul Cercueil
Hi, Le jeu. 10 janv. 2019 à 11:04, Paul Cercueil a écrit : Adding Stephen to the discussion. Adding Stephen to the discussion. On Sat, Jan 5, 2019 at 6:27 PM, Uwe Kleine-König wrote: Hello Paul, On Sat, Jan 05, 2019 at 06:05:38PM -0300, Paul Cercueil wrote: On Sat, Jan 5, 2019 at 4:57 P

Re: [PATCH v10 04/12] mm, arm64: untag user pointers passed to memory syscalls

2019-02-22 Thread Dave Hansen
On 2/22/19 4:53 AM, Andrey Konovalov wrote: > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -578,6 +578,7 @@ static int do_mprotect_pkey(unsigned long start, size_t > len, > SYSCALL_DEFINE3(mprotect, unsigned long, start, size_t, len, > unsigned long, prot) > { > + start = unt

Re: [PATCH v10 07/12] fs, arm64: untag user pointers in fs/userfaultfd.c

2019-02-22 Thread Dave Hansen
On 2/22/19 4:53 AM, Andrey Konovalov wrote: > userfaultfd_register() and userfaultfd_unregister() use provided user > pointers for vma lookups, which can only by done with untagged pointers. So, we have to patch all these sites before the tagged values get to the point of hitting the vma lookup fu

Re: [PATCH v10 06/12] fs, arm64: untag user pointers in copy_mount_options

2019-02-22 Thread Dave Hansen
On 2/22/19 4:53 AM, Andrey Konovalov wrote: > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -2730,7 +2730,7 @@ void *copy_mount_options(const void __user * data) >* the remainder of the page. >*/ > /* copy_from_user cannot cross TASK_SIZE ! */ > - size = TASK_SIZE - (un

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Dave Hansen
On 2/22/19 4:53 AM, Andrey Konovalov wrote: > The following testing approaches has been taken to find potential issues > with user pointer untagging: > > 1. Static testing (with sparse [3] and separately with a custom static >analyzer based on Clang) to track casts of __user pointers to intege

[lwn:docs-next 68/69] htmldocs: include/linux/lsm_hooks.h:1783: warning: Function parameter or member 'quotactl' not described in 'security_list_options'

2019-02-22 Thread kbuild test robot
tree: git://git.lwn.net/linux-2.6 docs-next head: 19c3fe285cbaa5aa36d60638fc5c37706f2a1c3e commit: 80fcc98711a3980a8593d8ba4bd9cf9c7646fd60 [68/69] doc: security: Add kern-doc for lsm_hooks.h reproduce: make htmldocs All warnings (new ones prefixed by >>): drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH] net: dsa: Remove documentation for port_fdb_prepare

2019-02-22 Thread Florian Fainelli
On 2/22/19 11:07 AM, Hauke Mehrtens wrote: > This callback was removed some time ago, also remove the documentation. > > Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB") > Signed-off-by: Hauke Mehrtens Not sure if this is worth a Fixes: tag since this is not quite a functional chan

[PATCH] net: dsa: Remove documentation for port_fdb_prepare

2019-02-22 Thread Hauke Mehrtens
This callback was removed some time ago, also remove the documentation. Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB") Signed-off-by: Hauke Mehrtens --- Documentation/networking/dsa/dsa.txt | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Documentati

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Szabolcs Nagy
On 22/02/2019 15:40, Andrey Konovalov wrote: > On Fri, Feb 22, 2019 at 4:35 PM Szabolcs Nagy wrote: >> >> On 22/02/2019 12:53, Andrey Konovalov wrote: >>> This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. >>> >>> arm64 has a feature called Top Byte Ignore, which allows to

Re: [PATCH] docs: Explicitly state that the 'Fixes:' tag shouldn't split lines

2019-02-22 Thread Jonathan Corbet
On Tue, 19 Feb 2019 07:27:15 -0800 Sean Christopherson wrote: > ...and use a commit with an obnoxiously long summary in the example to > make it abundantly clear that keeping the tag on a single line takes > priority over wrapping at 75 columns. Without the explicit exemption, > one might assume

Re: [PATCH] doc: security: Add kern-doc for lsm_hooks.h

2019-02-22 Thread Jonathan Corbet
On Sun, 17 Feb 2019 14:19:01 -0800 Kees Cook wrote: > There is a lot of kern-doc for the LSM internals, but it wasn't visible > in the HTML output. This exposes some formatting flaws in lsm_hooks.h > that will be fixed in a later series of patches. > > Signed-off-by: Kees Cook Applied, thanks.

Re: [PATCH] doc: sctp: Merge and clean up rst files

2019-02-22 Thread Jonathan Corbet
On Sun, 17 Feb 2019 19:59:20 -0800 Kees Cook wrote: > > Are you planning this to go via the doc tree, or would you like me to > > grab it for the SELinux tree? Either way is fine with me. > > > > Acked-by: Paul Moore > > Thanks! I figured it'd go via the docs tree since it's mainly moving >

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Andrey Konovalov
On Fri, Feb 22, 2019 at 4:35 PM Szabolcs Nagy wrote: > > On 22/02/2019 12:53, Andrey Konovalov wrote: > > This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. > > > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > > tags into the top byte of each

Re: [PATCH] doc: fix typos in license-rules.rst

2019-02-22 Thread Jonathan Corbet
On Wed, 20 Feb 2019 23:46:09 +0100 Federico Vaga wrote: > The patches fixes some typos in process/license-rules.rst > > Signed-off-by: Federico Vaga Applied, thanks. jon

Re: [PATCH] Documentation: fix admin-guide/README.rst minimum gcc version requirement

2019-02-22 Thread Jonathan Corbet
On Wed, 20 Feb 2019 20:02:33 -0800 Randy Dunlap wrote: > From: Randy Dunlap > > Fix minimum gcc version as specified in Documentation/process/changes.rst. > > Suggested-by: Matthew Wilcox > Signed-off-by: Randy Dunlap > --- > Documentation/admin-guide/README.rst |2 +- > 1 file changed,

Re: [RFC v9 2/5] dt-bindings: pstore-block: new support for blkoops

2019-02-22 Thread Rob Herring
+boot-architecture list On Tue, Feb 19, 2019 at 07:52:47PM +0800, liaoweixiong wrote: > Create DT binding document for blkoops. > > Signed-off-by: liaoweixiong > --- > .../devicetree/bindings/pstore/blkoops.txt | 53 > ++ > MAINTAINERS

Re: [PATCH v2 1/2] doc: translations: sync translations 'remove info about -git patches'

2019-02-22 Thread Jonathan Corbet
On Thu, 21 Feb 2019 21:29:59 +0100 Federico Vaga wrote: > Synchonise translations: CN, IT, JP, KR > > commit 2c71d305caf9 ("docs: process: Remove outdated info about -git patches") > > I can guarantee for the Italian translations, but since we are removing > an entire chapter I think I did it r

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Szabolcs Nagy
On 22/02/2019 12:53, Andrey Konovalov wrote: > This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > tags into the top byte of each pointer. Userspace programs (such as > HWASan, a memory debugging

[PATCH v10 03/12] lib, arm64: untag user pointers in strn*_user

2019-02-22 Thread Andrey Konovalov
strncpy_from_user and strnlen_user accept user addresses as arguments, and do not go through the same path as copy_from_user and others, so here we need to handle the case of tagged user addresses separately. Untag user pointers passed to these functions. Signed-off-by: Andrey Konovalov --- lib

[PATCH v10 02/12] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-02-22 Thread Andrey Konovalov
copy_from_user (and a few other similar functions) are used to copy data from user memory into the kernel memory or vice versa. Since a user can provided a tagged pointer to one of the syscalls that use copy_from_user, we need to correctly handle such pointers. Do this by untagging user pointers i

[PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Andrey Konovalov
This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [2]) might use this feature and pass tagged user

[PATCH v10 04/12] mm, arm64: untag user pointers passed to memory syscalls

2019-02-22 Thread Andrey Konovalov
This commit allows tagged pointers to be passed to the following memory syscalls: madvise, mbind, get_mempolicy, mincore, mlock, mlock2, brk, mmap_pgoff, old_mmap, munmap, remap_file_pages, mprotect, pkey_mprotect, mremap, msync and shmdt. Signed-off-by: Andrey Konovalov --- ipc/shm.c | 2 +

[PATCH v10 09/12] kernel, arm64: untag user pointers in prctl_set_mm*

2019-02-22 Thread Andrey Konovalov
prctl_set_mm() and prctl_set_mm_map() use provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user pointers in these functions. Signed-off-by: Andrey Konovalov --- kernel/sys.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel/sy

[PATCH v10 06/12] fs, arm64: untag user pointers in copy_mount_options

2019-02-22 Thread Andrey Konovalov
In copy_mount_options a user address is being subtracted from TASK_SIZE. If the address is lower than TASK_SIZE, the size is calculated to not allow the exact_copy_from_user() call to cross TASK_SIZE boundary. However if the address is tagged, then the size will be calculated incorrectly. Untag th

[PATCH v10 11/12] arm64: update Documentation/arm64/tagged-pointers.txt

2019-02-22 Thread Andrey Konovalov
Document the changes in Documentation/arm64/tagged-pointers.txt. Signed-off-by: Andrey Konovalov --- Documentation/arm64/tagged-pointers.txt | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/Documentation/arm64/tagged-pointers.txt b/Documentation/ar

[PATCH v10 08/12] net, arm64: untag user pointers in tcp_zerocopy_receive

2019-02-22 Thread Andrey Konovalov
tcp_zerocopy_receive() uses provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user pointers in this function. Signed-off-by: Andrey Konovalov --- net/ipv4/tcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index

[PATCH v10 07/12] fs, arm64: untag user pointers in fs/userfaultfd.c

2019-02-22 Thread Andrey Konovalov
userfaultfd_register() and userfaultfd_unregister() use provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user pointers in these functions. Signed-off-by: Andrey Konovalov --- fs/userfaultfd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs

[PATCH v10 05/12] mm, arm64: untag user pointers in mm/gup.c

2019-02-22 Thread Andrey Konovalov
mm/gup.c provides a kernel interface that accepts user addresses and manipulates user pages directly (for example get_user_pages, that is used by the futex syscall). Since a user can provided tagged addresses, we need to handle such case. Add untagging to gup.c functions that use user addresses fo

[PATCH v10 12/12] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-02-22 Thread Andrey Konovalov
This patch adds a simple test, that calls the uname syscall with a tagged user pointer as an argument. Without the kernel accepting tagged user pointers the test fails with EFAULT. Signed-off-by: Andrey Konovalov --- tools/testing/selftests/arm64/.gitignore | 1 + tools/testing/selftests/a

[PATCH v10 10/12] tracing, arm64: untag user pointers in seq_print_user_ip

2019-02-22 Thread Andrey Konovalov
seq_print_user_ip() uses provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user pointers in this function. Signed-off-by: Andrey Konovalov --- kernel/trace/trace_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/

[PATCH v10 01/12] uaccess: add untagged_addr definition for other arches

2019-02-22 Thread Andrey Konovalov
To allow arm64 syscalls to accept tagged pointers from userspace, we must untag them when they are passed to the kernel. Since untagging is done in generic parts of the kernel, the untagged_addr macro needs to be defined for all architectures. Define it as a noop for architectures other than arm64

[PATCH net-next v2 1/2] net: phylink: update mac_config() documentation

2019-02-22 Thread Russell King
A detail for mac_config() had been missed in the documentation for the method - it is expected that the method will update the MAC to the settings, rather than completely reprogram the MAC on each call. Update the documentation for this method for this detail. Reviewed-by: Andrew Lunn Signed-off-

[PATCH net-next v2 2/2] doc: add phylink documentation to the networking book

2019-02-22 Thread Russell King
Add some phylink documentation to the networking book detailing how to convert network drivers from phylib to phylink. Signed-off-by: Russell King --- v2: updated with comments from Randy and updated to apply to net-next Documentation/networking/index.rst | 1 + Documentation/networking

Re: [PATCH 2/2] doc: add phylink documentation to the networking book

2019-02-22 Thread Russell King - ARM Linux admin
Hi Randy, Sorry for the delay. On Wed, Feb 13, 2019 at 08:00:29PM -0800, Randy Dunlap wrote: > On 2/5/19 7:58 AM, Russell King wrote: > > +uses in-band mode, where results from the PHYs negotiation are passed > > PHY's ... > > + Manipulation of the