Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 13:30:21 -0400 Steven Rostedt wrote: > On Sun, 4 Nov 2018 01:34:30 +0900 > Masami Hiramatsu wrote: > > > > > I was thinking of a bitmask that represents the handlers, and use that > > > to map which handler gets called for which shadow entry for a > > > particular task. > >

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Steven Rostedt
On Sat, 3 Nov 2018 13:30:21 -0400 Steven Rostedt wrote: > What I was thinking was to store a count and the functions to be called: > > > [original_return_address] > [function_A] > [function_B] > [function_C] > [ 3 ] > > Then the trampoline that processes the retur

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Steven Rostedt
On Sun, 4 Nov 2018 01:34:30 +0900 Masami Hiramatsu wrote: > > > I was thinking of a bitmask that represents the handlers, and use that > > to map which handler gets called for which shadow entry for a > > particular task. > > Hmm, I doubt that is too complicated and not scalable. I rather like

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 09:13:41 -0400 Steven Rostedt wrote: > On Sat, 3 Nov 2018 22:00:12 +0900 > Masami Hiramatsu wrote: > > > On Fri, 2 Nov 2018 12:13:07 -0400 > > Steven Rostedt wrote: > > > > > > Because that means if function graph tracer is active, then you can't > > > do a kretprobe, and

Re: Re: [PATCH V6 3/8] misc/pvpanic: add MMIO support

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 4:27 AM wrote: > > >> > >> On some architectures (e.g. arm64), it's preferable to use MMIO, since > >> this can be used standalone. Add MMIO support to the pvpanic driver. > >> > > > >0day complains b/c of 1st patch in the series. > > > >Reviewed-by: Andy Shevchenko > > > >

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Fri, 2 Nov 2018 09:16:58 -0400 Steven Rostedt wrote: > On Fri, 2 Nov 2018 17:59:32 +1100 > Aleksa Sarai wrote: > > > As an aside, I just tested with the frame unwinder and it isn't thrown > > off-course by kretprobe_trampoline (though obviously the stack is still > > wrong). So I think we ju

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Steven Rostedt
On Sat, 3 Nov 2018 22:00:12 +0900 Masami Hiramatsu wrote: > On Fri, 2 Nov 2018 12:13:07 -0400 > Steven Rostedt wrote: > > > Because that means if function graph tracer is active, then you can't > > do a kretprobe, and vice versa. I'd really like to have it working for > > multiple users, then

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Fri, 2 Nov 2018 12:13:07 -0400 Steven Rostedt wrote: > On Fri, 2 Nov 2018 10:43:26 -0500 > Josh Poimboeuf wrote: > > > > I'll hopefully have a prototype ready by plumbers. > > > > Why do we need multiple users? It would be a lot simpler if we could > > just enforce a single user per fgra

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Fri, 2 Nov 2018 15:37:33 +1100 Aleksa Sarai wrote: > On 2018-11-02, Masami Hiramatsu wrote: > > On Fri, 2 Nov 2018 08:13:43 +1100 > > Aleksa Sarai wrote: > > > > > On 2018-11-02, Masami Hiramatsu wrote: > > > > Please split the test case as an independent patch. > > > > > > Will do. Shoul

Re: [PATCH v10 0/2] dm: boot a mapped device without an initramfs

2018-11-03 Thread Richard Weinberger
Helen, Am Samstag, 3. November 2018, 04:53:39 CET schrieb Helen Koike: > As mentioned in the discussion from the previous version of this patch, > Android > and Chrome OS do not use initramfs mostly due to boot time and size liability. Do you have numbers on that? I understand that using someth

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Aleksa Sarai
On 2018-11-02, Steven Rostedt wrote: > > As an aside, I just tested with the frame unwinder and it isn't thrown > > off-course by kretprobe_trampoline (though obviously the stack is still > > wrong). So I think we just need to hook into the ORC unwinder to get it > > to continue skipping up the st