Hi Peng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-c
On 2018-11-01, Steven Rostedt wrote:
> On Thu, 1 Nov 2018 19:35:50 +1100
> Aleksa Sarai wrote:
> > @@ -1834,6 +1853,11 @@ static int pre_handler_kretprobe(struct kprobe *p,
> > struct pt_regs *regs)
> > ri->rp = rp;
> > ri->task = current;
> >
> > + trace.ent
Remove unnecessary header file init.h.
Reviewed-by: Andy Shevchenko
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 5378d5f..9c9d9f8 100644
--- a/drivers/misc/pvpa
Use acpi_dev_resource_io API.
Suggested-by: Andy Shevchenko
Reviewed-by: Andy Shevchenko
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
Add dt-bindings document for "qemu:pvpanic-mmio".
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
.../devicetree/bindings/misc/pvpanic-mmio.txt | 29 ++
1 file changed, 29 insertions(+)
create mode 100644 Documentation/devicetree/bindings/misc/pvpanic-mmio.txt
diff
By default, when ACPI tables and FDT coexist for ARM64,
current kernel takes precedence over FDT to get device information.
Virt machine in qemu provides both FDT and ACPI table. Increases the
way to get information through FDT.
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/pv
Remove a redundant comma in pvpanic_device_ids.
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 1826cdf..07149db 100644
--- a/drivers/misc/pvpanic.
Updates license to use SPDX-License-Identifier instead of
verbose license text.
Reviewed-by: Andy Shevchenko
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/dr
Move pvpanic.c from drivers/platform/x86 to drivers/misc.
Following patches will use pvpanic device as common driver.
Reviewed-by: Andy Shevchenko
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/Kconfig | 8
drivers/misc/Makefile
On some architectures (e.g. arm64), it's preferable to use MMIO, since
this can be used standalone. Add MMIO support to the pvpanic driver.
Suggested-by: Andy Shevchenko
Acked-by: Mark Rutland
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 14 ++
1 file changed, 10 insertions
On 2018-11-02, Masami Hiramatsu wrote:
> On Fri, 2 Nov 2018 08:13:43 +1100
> Aleksa Sarai wrote:
>
> > On 2018-11-02, Masami Hiramatsu wrote:
> > > Please split the test case as an independent patch.
> >
> > Will do. Should the Documentation/ change also be a separate patch?
>
> I think the D
Hi Aleksa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.19 next-20181101]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Fri, 2 Nov 2018 08:13:43 +1100
Aleksa Sarai wrote:
> On 2018-11-02, Masami Hiramatsu wrote:
> > Please split the test case as an independent patch.
>
> Will do. Should the Documentation/ change also be a separate patch?
I think the Documentation change can be coupled with code change
if the
On Thu, Nov 1, 2018 at 10:06 AM Linus Torvalds
wrote:
>
> The logic for using __no_sanitize_address *used* to be
>
> #if GCC_VERSION >= 40902
Ok, looking around, I think this has less to do with the attribute
being recognized, and simply just being because KASAN itself wants
gcc-4.9.2.
I'm a
On Thu, 1 Nov 2018 19:35:50 +1100
Aleksa Sarai wrote:
> Historically, kretprobe has always produced unusable stack traces
> (kretprobe_trampoline is the only entry in most cases, because of the
> funky stack pointer overwriting). This has caused quite a few annoyances
> when using tracing to deb
On 2018-11-02, Masami Hiramatsu wrote:
> Please split the test case as an independent patch.
Will do. Should the Documentation/ change also be a separate patch?
> > new file mode 100644
> > index ..03146c6a1a3c
> > --- /dev/null
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/
On Thu, Nov 1, 2018 at 6:06 PM Linus Torvalds
wrote:
>
> I'm not sure how much that matters (maybe the original check for 4.9.2
> was just a random pick by Andrey? Added to cc), but together with the
> movement to that looks like it also
> wouldn't want the CONFIG_KASAN tests, I wonder what the r
On Mon, Oct 22, 2018 at 3:59 AM Miguel Ojeda
wrote:
>
> Here it is the Compiler Attributes series/tree, which tries to disentangle
> the include/linux/compiler*.h headers and bring them up to date.
I've finally emptied the "normal" pull queues, and am looking at the
odd ones that I felt I needed
On Wed, Oct 31, 2018 at 03:57:21PM -0700, Andy Lutomirski wrote:
> > On Oct 31, 2018, at 2:00 PM, Peter Zijlstra wrote:
> >> On Wed, Oct 31, 2018 at 01:36:48PM -0700, Andy Lutomirski wrote:
> >> This stuff is called *rare* write for a reason. Do we really want to
> >> allow atomics beyond just st
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> this can be used standalone. Add MMIO support to the pvpanic driver.
> - if (acpi_dev_resource_io(res, &r) {
> - port = r.start;
> + if (acpi_dev_r
From: Peter Zijlstra
Sent: October 31, 2018 at 9:08:35 AM GMT
> To: Nadav Amit
> Cc: Andy Lutomirski , Matthew Wilcox
> , Kees Cook , Igor Stoppa
> , Mimi Zohar , Dave Chinner
> , James Morris , Michal Hocko
> , Kernel Hardening ,
> linux-integrity , linux-security-module
> , Igor Stoppa
>
On 01/11/2018 10:21, Thomas Gleixner wrote:
On Thu, 1 Nov 2018, Igor Stoppa wrote:
The rework could be done afterward.
Please don't go there. The usual approach is to
1) Rework existing code in a way that the new functionality can be added
with minimal effort afterwards and without
Hello Ahmed,
On 01/11/2018 01:21, Ahmed Soliman wrote:
Hello Igor,
This is very interesting, because it seems a very good match to the work
I'm doing, for supporting the creation of more targets for protection:
https://www.openwall.com/lists/kernel-hardening/2018/10/23/3
In my case the protec
Hi Aleksa,
On Thu, 1 Nov 2018 19:35:50 +1100
Aleksa Sarai wrote:
[...]
> diff --git
> a/tools/testing/selftests/ftrace/test.d/kprobe/kretprobe_stacktrace.tc
> b/tools/testing/selftests/ftrace/test.d/kprobe/kretprobe_stacktrace.tc
Please split the test case as an independent patch.
> new file
Fenghua,
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Fenghua Yu
> Sent: Wednesday, October 31, 2018 4:55 PM
> To: Moger, Babu
> Cc: t...@linutronix.de; mi...@redhat.com; b...@alien8.de; cor...@lwn.net;
> reinette.cha...@intel.com; p
Trivial fixes to spelling mistakes in ftrace.rst
v2: tripple -> triple
Signed-off-by: Amir Livneh
---
Documentation/trace/ftrace.rst | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
index 7ea16a0ce
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> use acpi_dev_resource_io API.
>
Same comments as per patch 1.
This should be patch 2/8 in the series.
Otherwise,
Reviewed-by: Andy Shevchenko
Also, you might consider to use Suggested-by tag here.
> Signed-off-by: Peng Hao
> ---
> drivers/m
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
After addressing Mark's comment consider to move this to be patch 7/8
in the series.
Otherwise,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Peng Ha
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote:
>
> remove unnecessary header file init.h.
>
Same comments as per patch 1, on top of this is ordering issue. This
patch should be 6/8.
Also, address Mark's comments, please.
Otherwise,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Peng Hao
> ---
On Thu, Nov 1, 2018 at 1:34 PM Mark Rutland wrote:
>
> On Thu, Nov 01, 2018 at 11:09:56PM +0800, Peng Hao wrote:
> > There is an extra semicolon in pvpanic_device_ids, remove it.
>
> This is a comma, not a semicolon.
>
> How about:
>
> Since there should be nothing after the sentinel entry in an
On Thu, Nov 1, 2018 at 8:59 AM Peng Hao wrote:
>
> move pvpanic.c from drivers/platform/x86 to drivers/misc.
> following patches will use pvpanic device in arm64.
There are few items you need to address in the next revision:
- use proper English grammar, i.e. Capitalize beginning of sentenses
- d
On Thu, Nov 01, 2018 at 11:10:01PM +0800, Peng Hao wrote:
> By default, when ACPI tables and FDT coexist for ARM64,
> current kernel takes precedence over FDT to get device information.
> Virt machine in qemu provides both FDT and ACPI table. This patch
> increases the way to get information throug
Please fix the spacing in the commit title. It should be formatted:
dt-bindings: misc/pvpanic: add document for pvpanic-mmio
On Thu, Nov 01, 2018 at 11:10:02PM +0800, Peng Hao wrote:
> Add dt-bindings document for "qemu:pvpanic-mmio".
>
> Signed-off-by: Peng Hao
With the title fixed:
Acked-
On Thu, Nov 01, 2018 at 11:10:00PM +0800, Peng Hao wrote:
> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> this can be used standalone. Add MMIO support to the pvpanic driver.
>
> Signed-off-by: Peng Hao
Acked-by: Mark Rutland
Mark.
> ---
> drivers/misc/pvpanic.c |
Hi,
Please fix the spacing for the colon in the commit title. It should be
formatted as:
misc/pvpanic: convert to SPDX license tags
On Thu, Nov 01, 2018 at 11:09:58PM +0800, Peng Hao wrote:
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
On Thu, Nov 01, 2018 at 11:34:29AM +, Mark Rutland wrote:
> On Thu, Nov 01, 2018 at 11:09:57PM +0800, Peng Hao wrote:
> > remove unnecessary header file init.h.
> >
> > Signed-off-by: Peng Hao
>
> Acked-by: Mark Rutland
... though please fix the title:
s/revmove/remove/
Mark.
On Thu, Nov 01, 2018 at 11:09:57PM +0800, Peng Hao wrote:
> remove unnecessary header file init.h.
>
> Signed-off-by: Peng Hao
Acked-by: Mark Rutland
Mark.
> ---
> drivers/misc/pvpanic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
On Thu, Nov 01, 2018 at 11:09:56PM +0800, Peng Hao wrote:
> There is an extra semicolon in pvpanic_device_ids, remove it.
This is a comma, not a semicolon.
How about:
Since there should be nothing after the sentinel entry in an
acpi_device_id list, it doesn't make sense for it to have a trai
On 2018-10-31 14:16, Amir Livneh wrote:
> @@ -2978,7 +2978,7 @@ The following commands are supported:
>When the function is hit, it will dump the contents of the ftrace
>ring buffer to the console. This is useful if you need to debug
>something, and want to dump the trace when a certain
Historically, kretprobe has always produced unusable stack traces
(kretprobe_trampoline is the only entry in most cases, because of the
funky stack pointer overwriting). This has caused quite a few annoyances
when using tracing to debug problems[1] -- since return values are only
available with kre
This is effectively a reversion of commit 76094a2cf46e ("ftrace:
distinguish kretprobe'd functions in trace logs"), as the checking of
kretprobe_trampoline *for tracing* is no longer necessary with the new
kretprobe stack trace changes.
Signed-off-by: Aleksa Sarai
---
kernel/trace/trace_output.c
Historically, kretprobe has always produced unusable stack traces
(kretprobe_trampoline is the only entry in most cases, because of the
funky stack pointer overwriting). This has caused quite a few annoyances
when using tracing to debug problems[1] -- since return values are only
available with kre
Igor,
On Thu, 1 Nov 2018, Igor Stoppa wrote:
> On 01/11/2018 01:19, Andy Lutomirski wrote:
>
> > ISTM you don't need that atomic operation -- you could take a spinlock
> > and then just add one directly to the variable.
>
> It was my intention to provide a 1:1 conversion of existing code, as it
There is an extra comma in pvpanic_device_ids, remove it.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index fd86dab..059005c 100644
--- a/drivers/misc/pvpanic.c
+++ b/driver
use devm variant for of_provider registration.
Signed-off-by: Matti Vaittinen
---
drivers/clk/qcom/apcs-msm8916.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c
index b1cc8dbcd327..f4e0c136ab1a 100644
---
use devm variant for of_provider registration so provider is freed
at exit.
Signed-off-by: Matti Vaittinen
---
drivers/clk/clk-twl6040.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
index 25dfe050ae9f..e9da09453eb2
Simplify clean-up for rk808 by using managed version of of_provider
registration.
Signed-off-by: Matti Vaittinen
---
drivers/clk/clk-rk808.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c
index 6461f2820a5b..
use devm variant for of_provider registration so provider is freed
at exit.
Signed-off-by: Matti Vaittinen
---
drivers/clk/clk-hi655x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-hi655x.c b/drivers/clk/clk-hi655x.c
index 403a0188634a..394d0109104d 100
Use devm based clkdev lookup registration to avoid leaking lookup
structures.
Signed-off-by: Matti Vaittinen
---
drivers/clk/x86/clk-st.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c
index fb62f3938008..32d8df9bd853 100
Use devm variant of clkdev lookup registration in order to avoid
clkdev lookup leak at device remove.
Signed-off-by: Matti Vaittinen
---
drivers/clk/samsung/clk-s3c2410-dclk.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/samsung/clk-s3c2410-dclk
clk-max77686 never clean clkdev lookup at remove. This can cause
oops if clk-max77686 is removed and inserted again. Fix leak by
using new devm clkdev lookup registration. Simplify also error
path by using new devm_of_clk_add_parent_hw_provider.
Signed-off-by: Matti Vaittinen
---
drivers/clk/clk
With MFD devices the clk properties may be contained in MFD (parent) DT
node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD
subdevice not to MFD device (parent). Add
devm_of_clk_add_hw_provider_parent to tackle this issue.
Also clkdev registration lacks of managed registratio
Patch series adding managed clkdev and of_provider registrations
Few clk drivers appear to be leaking clkdev lookup registrations at
driver remove. The patch series adds devm versions of lookup
registrations and cleans up few drivers. Driver clean-up patches have
not been tested as I lack the HW.
On Wed, Oct 31, 2018 at 03:06:22PM +, Daniel Colascione wrote:
> State explicitly that holding a /proc/pid file descriptor open does
> not reserve the PID. Also note that in the event of PID reuse, these
> open file descriptors refer to the old, now-dead process, and not the
> new one that happ
Add dt-bindings document for "qemu:pvpanic-mmio".
Signed-off-by: Peng Hao
---
.../devicetree/bindings/misc/pvpanic-mmio.txt | 29 ++
1 file changed, 29 insertions(+)
create mode 100644 Documentation/devicetree/bindings/misc/pvpanic-mmio.txt
diff --git a/Documentation/d
remove unnecessary header file init.h.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 059005c..66534d4 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -22,7 +22,6 @@
This patch updates license to use SPDX-License-Identifier
instead of verbose license text.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 66534d4..0bcf1
By default, when ACPI tables and FDT coexist for ARM64,
current kernel takes precedence over FDT to get device information.
Virt machine in qemu provides both FDT and ACPI table. This patch
increases the way to get information through FDT.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 66
use acpi_dev_resource_io API.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 0bcf1cd..c20fdff 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpani
On some architectures (e.g. arm64), it's preferable to use MMIO, since
this can be used standalone. Add MMIO support to the pvpanic driver.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/pvpa
move pvpanic.c from drivers/platform/x86 to drivers/misc.
following patches will use pvpanic device in arm64.
Signed-off-by: Peng Hao
---
drivers/misc/Kconfig | 8 +++
drivers/misc/Makefile| 1 +
drivers/{platform/x86 => misc}/pvpanic.c | 0
drivers/pl
There is an extra semicolon in pvpanic_device_ids, remove it.
Signed-off-by: Peng Hao
---
drivers/misc/pvpanic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index fd86dab..059005c 100644
--- a/drivers/misc/pvpanic.c
+++ b/dr
62 matches
Mail list logo
