On September 27, 2017 10:03:28 PM PDT, David Lin wrote:
>Dmitry,
>
>On Fri, Sep 15, 2017 at 3:30 PM, Dmitry Torokhov
> wrote:
>> On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski
>> wrote:
>>> On 09/15/2017 08:34 PM, Dmitry Torokhov wrote:
On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote
Dmitry,
On Fri, Sep 15, 2017 at 3:30 PM, Dmitry Torokhov
wrote:
> On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski
> wrote:
>> On 09/15/2017 08:34 PM, Dmitry Torokhov wrote:
>>> On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote:
On Thu 2017-09-14 21:31:31, Jacek Anaszewski wrote:
>
> Erik, please review.
I apologize for the delay. I see that you've already applied this, and
it's mostly LGTM except I have one thing I'm not seeing clearly.
The documentation accept_dad now claims:
DAD operation and mode on a given interface will be selected according
to the maximum v
Em Wed, 27 Sep 2017 14:20:03 -0700
Randy Dunlap escreveu:
> On 09/27/17 14:10, Mauro Carvalho Chehab wrote:
> > kernel-doc-nano-HOWTO.txt has a chapter about man pages
>
> kernel-doc.rst has a chapter (or section)
I actually meant to say that kernel-doc-nano-HOWTO.txt has a chapter
about ma
Hi Randy,
Em Wed, 27 Sep 2017 15:32:12 -0700
Randy Dunlap escreveu:
> > +Types of V4L2 media hardware control
> > +
> > +
> > +V4L2 hardware periferal is usually complex: support for it is
>
> peripheral (in several places...)
Thanks for n
From: Rafael J. Wysocki
Commit 33fc30b47098 (cpufreq: intel_pstate: Document the current
behavior and user interface) dropped the intel-pstate.txt file
from Documentation/cpu-freq/, but it did not update the index.txt
file in there accordingly, so do that now.
Fixes: 33fc30b47098 (cpufreq: intel
Greetings,
I see that the devices.txt file is used to reserve major numbers, and
has a secondary effect of "reserving" name space in /dev - but I
haven't located any precedent for reserving name space without
reserving a major number.
My team at Micron plans to start open sourcing some kernel mod
On 09/27/17 15:23, Mauro Carvalho Chehab wrote:
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/media/uapi/v4l/open.rst | 40
> +++
> 1 file changed, 40 insertions(+)
>
> diff --git a/Documentation/media/uapi/v4l/open.rst
> b/Documentation/media/
minor numbers use to range between 0 to 255, but that
was changed a long time ago. While it still applies when
CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is
dynamically allocated, this may not be true. In any case,
this is not relevant, as udev will take care of it.
So, remove this use
When we added support for omap3, back in 2010, we added a new
type of V4L2 devices that aren't fully controlled via the V4L2
device node.
Yet, we have never clearly documented in the V4L2 specification
the differences between the two types.
Let's document them based on the the current implementat
As we now have a glossary, some terms used on open.rst
require adjustments.
Acked-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/open.rst | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/media/uapi/v4l/open.rs
As both vdev-centric and MC-centric devices may implement the
same APIs, we need a flag to allow userspace to distinguish
between them.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/open.rst| 7 +++
Documentation/media/uapi/v4l/vidioc-querycap.rst | 5
Right now, only kAPI documentation describes the device naming.
However, such description is needed at the uAPI too. Add it,
and describe how to get an unique identify for a given device.
Acked-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/open.rst | 44
Add a glossary of terms for V4L2, as several concepts are complex
enough to cause misunderstandings.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/v4l/glossary.rst | 136 ++
Documentation/media/uapi/v4l/v4l2.rst | 1 +
2 files changed, 137 in
On Kernel 2.6.39, the omap3 driver was introduced together with a new way
to control complex V4L2 devices used on embedded systems, but this was
never documented, as the original idea were to have "soon" support for
standard apps to use it as well, via libv4l, but that didn't happen so far.
Also,
The documentation doesn't mention if vdev-centric hardware
control would have subdev API or not.
Add a notice about that, reflecting the current status, where
three drivers use it, in order to support some subdev-specific
controls.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/ua
Em Fri, 1 Sep 2017 12:26:39 +0200
Hans Verkuil escreveu:
> On 29/08/17 15:17, Mauro Carvalho Chehab wrote:
> > Add a glossary of terms for V4L2, as several concepts are complex
> > enough to cause misunderstandings.
> >
> > Signed-off-by: Mauro Carvalho Chehab
> > ---
> > Documentation/media/u
Documentation/binfmt_misc.txt was moved to
Documentation/admin-guide/binfmt_misc.rst
Signed-off-by: Tom Saeger
---
Documentation/sysctl/README | 2 +-
Documentation/sysctl/fs.txt | 2 +-
fs/Kconfig.binfmt | 2 +-
fs/binfmt_misc.c| 3 ++-
4 files changed, 5 insertions(+), 4
v2:
- replaced wrong binfmt_misc.rst with binfmt-misc.rst
Tom Saeger (1):
docs: Update binfmt_misc links
Documentation/sysctl/README | 2 +-
Documentation/sysctl/fs.txt | 2 +-
fs/Kconfig.binfmt | 2 +-
fs/binfmt_misc.c| 3 ++-
4 files changed, 5 insertions(+), 4 de
Now that kernel-doc handles nested unions, better document the
bus union at struct v4l2_fwnode_endpoint.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-fwnode.h | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/media/v4l2-fwnode.h b/include/me
The can_reduce_fps() is already documented, but it is not
using the kernel-doc markup. Convert it, in order to generate
documentation from it.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-dv-timings.h | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git
The description of this enum doesn't match what it
actually represents. Adjust it.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/rc-core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/media/rc-core.h b/include/media/rc-core.h
index 314a1edb6189..a381ab
This struct is not used anymore. Get rid of it and update
the documentation about what should still be converted.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-common.h | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/include/media/v4l2-common.h b/
Both v4l2-event.rst and v4l2-event.h have an overview of
events, but there are some inconsistencies there:
- at v4l2-event, the event's ringbuffer is called kevent. Its
name is, instead, v4l2_kevent;
- Some things are mentioned on both places (with different words),
others are either on one o
Now that nested structs are supported, change the
documentation to use it. While here, add cross-references
where pertinent and use monotonic fonts where pertinent,
using the right markup tags.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/videobuf2-core.h | 59 +
This enum is already documented, but it is not using a kernel-doc
format. Convert its format, in order to produce documentation.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/cec-pin.h | 81 +++--
1 file changed, 52 insertions(+), 29 deletions
The RC core does several assumptions, but those aren't documented
anywhere, with could make harder for ones that want to understand
what's there.
So, add an introduction explaining the basic concepts of RC and
how they're related to the RC core implementation.
Signed-off-by: Mauro Carvalho Chehab
There are a few nested members at v4l2-ctrls.h. Now that
kernel-doc supports, document them.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-ctrls.h | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
Currently, there's no way to document #define foo
with kernel-doc. So, convert it to an enum, and document.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-ioctl.h | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/include/media/v
This patch series is meant to improve V4L documentation. It touches
some files at the tree doing some cleanup, in order to simplify
the source code.
Mauro Carvalho Chehab (17):
media: tuner-types: add kernel-doc markups for struct tunertype
media: v4l2-common: get rid of v4l2_routing dead stru
There are several widely macros that aren't documented using kernel-docs
markups.
Add it.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-device.h | 238 +---
1 file changed, 204 insertions(+), 34 deletions(-)
diff --git a/include/media/v4l2-
Now that nested structs are parsed by kernel-doc, add markups
to them.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/media-entity.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index 222d379960b7..d7a669058b5e 10064
There are several ancillary functions that aren't documented.
Document them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-common.c | 14 -
include/media/v4l2-common.h | 104 ++
2 files changed, 94 insertions(+), 24 deletion
Now that kernel-doc handles nested unions, better document the
match union at struct v4l2_async_subdev.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-async.h | 35 ---
1 file changed, 32 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-
This struct is lacking documentation. Add it.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/tuner-types.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/media/tuner-types.h b/include/media/tuner-types.h
index aed539068d2d..55bc14093c0f 100644
--- a/include/
This struct is there just two store two arguments of
v4l2_find_nearest_format(). The other two arguments are passed
as parameter.
IMHO, there isn't much sense on doing that, and that will just
add one more struct to document ;)
So, let's get rid of the struct, passing the parameters directly.
Si
Instead of using an integer to represent it, use boolean,
as this better describes what this field really means.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.c| 12 ++--
drivers/media/dvb-core/dvb_demux.h| 2 +-
drivers/media/pci/ttpci/av7110.c
Enums can be documented via kernel-doc. So, convert the
DVB_DEVICE_* macros to an enum.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvbdev.c | 34 +++
drivers/media/dvb-core/dvbdev.h | 51 -
2 files changed, 64 i
Currently, there are two handlers for ioctls:
- dvb_frontend_ioctl_properties()
- dvb_frontend_ioctl_legacy()
Despite their names, both handles non-legacy DVB ioctls.
Besides that, there's no reason why to not handle all ioctls
on a single handler function.
So, merge them into a single functio
There are several functions at the dvbdev that are common to all
digital TV device nodes with aren't documented.
Add documentation for them. No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvbdev.h | 86 +
1 file cha
This field is not used. So, get rid of it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/dvb-core/dvb_demux.h
b/drivers/media/dvb-core/dvb_demux.h
index b24d69b5a20f..045f7fd1a8b1 100644
--- a/drivers
In the past, I guess the idea was to use state in order to
allow an autofush logic. However, in the current code, it is
used only for debug messages, on a poor man's solution, as
there's already a debug message to indicate when the properties
got flushed.
So, just get rid of it for good.
Reviewed
From: Satendra Singh Thakur
Since all properties in the func dtv_property_process_set() use
at most 4 bytes arguments, change the code to pass
u32 cmd and u32 data as function arguments, instead of passing a
pointer to the entire struct dtv_property *tvp.
Instead of having a generic dtv_property
kernel-doc allows documenting enums. Also, it makes clearer
about the meaning of each field on structures.
So, convert DMX_STATE_* to an enum.
While here, get rid of the unused DMX_STATE_SET.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 25 ++---
Add a cross-reference to a mentioned structure and split
the kernel-doc stuff on a separate chapter.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/dtv-demux.rst | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/media/kapi/dtv-demux.
As reported by Laurent, when a DVB frontend need to register
two drivers (e. g. a tuner and a demod), if the second driver
fails to register (for example because it was not compiled),
the error handling logic frees the frontend by calling
dvb_frontend_detach(). That used to work fine, but changeset
There are three structs defined inside dvb_demux.h. None
of them are currently documented.
Add documentation for them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.c | 1 +
drivers/media/dvb-core/dvb_demux.h | 58 --
2 files chan
Two readonly ioctls can't be allowed if the frontend device
is opened in read only mode. Explain why.
Reviewed by: Shuah Khan
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/
There are several problems with regards to the return of
FE_SET_PROPERTY. The original idea were to return per-property
return codes via tvp->result field, and to return an updated
set of values.
However, that never worked. What's actually implemented is:
- the FE_SET_PROPERTY implementation does
This isn't used anywere. Get rid of it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_demux.h
b/drivers/media/dvb-core/dvb_demux.h
index 9db3c2b7c64e..d9b30d669bf3 100644
--- a/drivers/
Only lg2160 implement gets_property, but there's no need for that,
as no other driver calls this callback, as get_frontend() does the
same, and set_frontend() also calls lg2160 get_frontend().
So, get rid of it.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Michael Ira Krufky
---
drivers/m
Now that we have kernel-doc markups at dvb_demux.h and dmxdev.h,
parse them.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/dtv-demux.rst | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/Documentation/media/kapi/dtv-demux.rst
b/Documentation
That's the last DVB kAPI that misses documentation.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/dtv-core.rst | 1 +
Documentation/media/kapi/dtv-net.rst | 4
Documentation/media/uapi/dvb/net-types.rst | 2 +-
drivers/media/dvb-core/dvb_net.h | 3
Several minor adjustments at the kernel-doc markups:
- some syntax fixes;
- some cross-references;
- add cross-references for the mentioned ioctls;
- some constants marked as such.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.h | 94 ++
The stv6110 has a weird code that checks if get_property
and set_property ioctls are defined. If they're, it initializes
a "srate" var from properties cache. Otherwise, it sets to
15MBaud, with won't make any sense.
Thankfully, it seems that someone else discovered the issue in
the past, as "srate
Document those two structs using kernel-doc markups.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 49 --
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_demux.h
b/drivers/media/dvb-cor
kernel-doc allows documenting enums. Also, it makes clearer
about the meaning of each field on structures.
So, convert DMX_TYPE_* to an enum.
While here, get rid of the unused DMX_TYPE_PES.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 17 -
1 fi
Simplify the get property handling and move it to the existing
code at dtv_property_process_get() directly.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 43 ++-
1 file changed, 12 insertions(+), 31 deletions(-)
diff --git a/dri
Use a switch() on this function, just like on other ioctl
handlers and handle parameters inside each part of the
switch.
That makes it easier to integrate with the already existing
ioctl handler function.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 83 ++
Better document the DVB common parts by adding two sections
and an introductory text for each.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/dtv-core.rst | 12
1 file changed, 12 insertions(+)
diff --git a/Documentation/media/kapi/dtv-core.rst
b/Documentation/m
Now that all clients of set_property() were removed, get rid
of this callback.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 7 ---
drivers/media/dvb-core/dvb_frontend.h | 5 -
2 files changed, 12 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_fr
This patch series merges a 6 patches series I sent earlier, and a 25 patch
series.
It comes after the patch series with add support for nexted structs/enums
on kernel-doc.
I"m pushing it on my experimental tree:
https://git.linuxtv.org/mchehab/experimental.git/log/?h=dvb-fixes-v5
It is main
Now that kernel-doc supports nested structs/unions, use it.
Signed-off-by: Mauro Carvalho Chehab
---
include/uapi/linux/dvb/frontend.h | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/include/uapi/linux/dvb/frontend.h
b/include/uapi/linux
Just like pes_type, this field represents an enum. Properly
identify it as such.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-core/dvb_demux.h
b/drivers/media/dvb-core/dvb_demux.
This driver doesn't implement support for set_property(). Yet,
it implements a boilerplate for it. Get rid of it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/stv0288.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv0288.c
b/driv
There are too much tabs on several properties, for no good
reason. That sounds confusing while reading the struct, so
adjust them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers
Instead of document all kAPI into a single file, split it
on multiple ones. That makes easier to maintain each part.
As a side effect, it will produce multiple html pages, with
is a good idea.
No changes at the text. Just some chapter levels changed.
Signed-off-by: Mauro Carvalho Chehab
---
Do
This callback is not actually doing anything but making it to
return an error depending on the DTV frontend command. Well,
that could break userspace for no good reason, and, if needed,
should be implemented, instead, at set_frontend() callback.
So, get rid of it.
Signed-off-by: Mauro Carvalho Ch
Now that kernel-doc supports nested structs/unions, use it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_demux.h
b/drivers/media/dvb-core/dvb_de
That section is too outdated and got superseded by DVBv5 and
by libdvbv5.
Maybe some day we'll end adding updated examples there, but
while nobody has time or interest of doing that, just mention
that there and get rid of the current examples for good.
Signed-off-by: Mauro Carvalho Chehab
---
D
The functions used on dvb_demux.h are largely used on DVB drivers.
Yet, none of them are documented.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.h | 106 +++--
1 file changed, 103 insertions(+), 3 deletions(-)
Now that kernel-doc supports nested structs/unions, use it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dmxdev.h | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/media/dvb-core/dmxdev.h b/drivers/media/dvb-core/dmxd
Despite being used by DVB drivers, this header was not documented.
Document it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dmxdev.h | 90 -
1 file changed, 88 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-core/dmxdev.h
The struct dvb_demux_filter.doneq is a boolean.
Mark it as such, as it helps to understand what it does.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_demux.c | 4 ++--
drivers/media/dvb-core/dvb_demux.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
On 09/27/17 14:10, Mauro Carvalho Chehab wrote:
> kernel-doc-nano-HOWTO.txt has a chapter about man pages
kernel-doc.rst has a chapter (or section)
> production. While we don't have a working "make manpages"
> target, add it.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/do
Documentation/binfmt_misc.txt was moved to
Documentation/admin-guide/binfmt_misc.rst
Signed-off-by: Tom Saeger
---
Documentation/sysctl/README | 2 +-
Documentation/sysctl/fs.txt | 2 +-
fs/Kconfig.binfmt | 2 +-
fs/binfmt_misc.c| 3 ++-
4 files changed, 5 insertions(+), 4
There is a mess on this chapter: it suggests that even
enums and unions should be documented with "struct". That's
not the way it should be ;-)
Fix it and move it to happen earlier.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 48 +---
Everything there is already described at
Documentation/doc-guide/kernel-doc.rst. So, there's no reason why
to keep it anymore.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/00-INDEX | 2 -
Documentation/kernel-doc-nano-HOWTO.txt | 322
Add a new section to describe kernel-doc arguments,
adding examples about how identation should happen, as failing
to do that causes Sphinx to do the wrong thing.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 44 +++---
1 file chang
Describe nested struct/union fields
NOTE: This is a pure test patch, meant to validate if the
parsing logic for nested structs is working properly.
I've no idea if the random text I added there is correct!
Signed-off-by: Mauro Carvalho Chehab
---
drivers/w1/w1_netlink.h | 4
1 file change
The check_sections() function has a $nested parameter, meant
to identify when a nested struct is present. As we now have
a logic that handles it, get rid of such parameter.
Suggested-by: Markus Heiser
Signed-off-by: Mauro Carvalho Chehab
---
scripts/kernel-doc | 19 ---
1 file c
The private members section can now be moved to be together
with the arguments section. Move it there and add an example
about the usage of public:
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 56 ++
1 file changed, 30 insertio
Right now, it is not possible to document nested struct and nested unions.
kernel-doc simply ignore them.
Add support to document them.
Patch 1 gets rid of the now unused output formats for kernel-doc: since
we got rid of all DocBook stuff, we should not need them anymore. The
reason for droppin
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
Move its contents to happen earlier and improve the description
of return values, adding a subsection to it. Most of the contents
there came from kernel-doc-nano-HOWTO.txt.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 100 -
1
kernel-doc-nano-HOWTO.txt has a chapter about man pages
production. While we don't have a working "make manpages"
target, add it.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 34 ++
1 file changed, 34 insertions(+)
diff --git
Add documentation about typedefs for function prototypes and
move it to happen earlier.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/Documentation/doc-guide/k
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code
Since there isn't any docbook code anymore upstream,
we can get rid of several output formats:
- docbook/xml, html, html5 and list formats were used by
the old build system;
- As ReST is text, there's not much sense on outputting
on a different text format.
After this patch, only man and rst
Function arguments are different than usual ones. So, an
special logic is needed in order to handle such arguments
on nested structs.
Signed-off-by: Mauro Carvalho Chehab
---
scripts/kernel-doc | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff -
Em Wed, 27 Sep 2017 17:36:59 +0300
Jani Nikula escreveu:
> On Tue, 26 Sep 2017, Mauro Carvalho Chehab wrote:
> > Since there isn't any docbook code anymore upstream,
> > we can get rid of several output formats:
> >
> > - docbook/xml, html, html5 and list formats were used by
> > the old build
On Wed, Sep 27, 2017 at 9:23 AM, Roman Gushchin wrote:
> On Wed, Sep 27, 2017 at 08:35:50AM -0700, Tim Hockin wrote:
>> On Wed, Sep 27, 2017 at 12:43 AM, Michal Hocko wrote:
>> > On Tue 26-09-17 20:37:37, Tim Hockin wrote:
>> > [...]
>> >> I feel like David has offered examples here, and many of
On Wed, Sep 27, 2017 at 08:35:50AM -0700, Tim Hockin wrote:
> On Wed, Sep 27, 2017 at 12:43 AM, Michal Hocko wrote:
> > On Tue 26-09-17 20:37:37, Tim Hockin wrote:
> > [...]
> >> I feel like David has offered examples here, and many of us at Google
> >> have offered examples as long ago as 2013 (i
On Wed, Sep 27, 2017 at 12:43 AM, Michal Hocko wrote:
> On Tue 26-09-17 20:37:37, Tim Hockin wrote:
> [...]
>> I feel like David has offered examples here, and many of us at Google
>> have offered examples as long ago as 2013 (if I recall) of cases where
>> the proposed heuristic is EXACTLY WRONG.
On Tue, 26 Sep 2017, Mauro Carvalho Chehab wrote:
> Since there isn't any docbook code anymore upstream,
> we can get rid of several output formats:
>
> - docbook/xml, html, html5 and list formats were used by
> the old build system;
> - As ReST is text, there's not much sense on outputting
>
On Wed, Sep 27 2017 at 10:13:33 am BST, Will Deacon wrote:
> On Wed, Sep 27, 2017 at 09:31:41AM +0100, Marc Zyngier wrote:
>> On Tue, Sep 26 2017 at 9:45:42 pm BST, Yury Norov
>> wrote:
>> > On Wed, Sep 13, 2017 at 09:08:30PM +0300, Yury Norov wrote:
>> >> The Documentation/arm64/memory.txt say
This patchset makes the OOM killer cgroup-aware.
v9:
- Change siblings-to-siblings comparison to the tree-wide search,
make related refactorings
- Make oom_group implicitly propagated down by the tree
- Fix an issue with task selection in root cgroup
v8:
- Do not kill tasks with OOM_S
The oom_kill_process() function consists of two logical parts:
the first one is responsible for considering task's children as
a potential victim and printing the debug information.
The second half is responsible for sending SIGKILL to all
tasks sharing the mm struct with the given victim.
This co
Traditionally, the OOM killer is operating on a process level.
Under oom conditions, it finds a process with the highest oom score
and kills it.
This behavior doesn't suit well the system with many running
containers:
1) There is no fairness between containers. A small container with
few large pr
Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware
OOM killer. If not set, the OOM selection is performed in
a "traditional" per-process way.
The behavior can be changed dynamically by remounting the cgroupfs.
Signed-off-by: Roman Gushchin
Cc: Michal Hocko
Cc: Vladimir Davydov
1 - 100 of 113 matches
Mail list logo
