Re: [PATCH v6 8/9] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux

2017-01-02 Thread Peter Rosin
On 2017-01-02 22:13, Jonathan Cameron wrote: > > > On 2 January 2017 20:47:58 GMT+00:00, Peter Rosin wrote: >> On 2017-01-02 19:05, Jonathan Cameron wrote: >>> On 02/01/17 16:01, Peter Rosin wrote: On 2017-01-01 12:00, Jonathan Cameron wrote: > On 30/11/16 08:17, Peter Rosin wrote:

Re: Warnings for documentation of private elements of a structure.

2017-01-02 Thread Markus Heiser
Am 02.01.2017 um 10:33 schrieb Jani Nikula : > On Mon, 02 Jan 2017, Markus Heiser wrote: >> IMO we should no longer investigate in the kernel_doc perl script, which >> is at it ends. Instead we should merge the python version from my linuxdoc >> project (BTW: with, we get man-pages from and lint

Re: [PATCH v6] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2017-01-02 Thread Guenter Roeck
On 01/02/2017 07:22 PM, Hui Chun Ong wrote: On Thu, 2016-12-29 at 02:09 -0800, Guenter Roeck wrote: On 12/28/2016 10:56 PM, Hui Chun Ong wrote: Add support for the watchdog timer on PXI Embedded Controller. Reviewed-by: Guenter Roeck Signed-off-by: Hui Chun Ong --- v5: Add Reviewed-by. The

Re: [PATCH v6] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2017-01-02 Thread Hui Chun Ong
On Thu, 2016-12-29 at 02:09 -0800, Guenter Roeck wrote: > On 12/28/2016 10:56 PM, Hui Chun Ong wrote: > > > > Add support for the watchdog timer on PXI Embedded Controller. > > > > Reviewed-by: Guenter Roeck > > Signed-off-by: Hui Chun Ong > > --- > > v5: Add Reviewed-by. > There is no need to

Re: [RFC 10/10] kmod: add a sanity check on module loading

2017-01-02 Thread Rusty Russell
"Luis R. Rodriguez" writes: >> Maybe a similar hack for try_then_request_module(), but many places seem >> to open-code request_module() so it's not as trivial... Hi Luis, Jessica (who is the main module maintainer now), Back from break, sorry about delay. > Right, out of ~350 request_m

Re: [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst

2017-01-02 Thread Rafael J. Wysocki
On Monday, January 02, 2017 03:39:20 PM Jonathan Corbet wrote: > On Mon, 02 Jan 2017 23:05:31 +0100 > "Rafael J. Wysocki" wrote: > > > > From: Rafael J. Wysocki > > > > > > The references to drivers/base/power/main.c and > > > drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst

Re: [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst

2017-01-02 Thread Jonathan Corbet
On Mon, 02 Jan 2017 23:05:31 +0100 "Rafael J. Wysocki" wrote: > > From: Rafael J. Wysocki > > > > The references to drivers/base/power/main.c and > > drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst > > are confusing. They both cause descriptions of functions that are > > n

Re: [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst

2017-01-02 Thread Rafael J. Wysocki
On Monday, December 19, 2016 09:36:39 PM Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The references to drivers/base/power/main.c and > drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst > are confusing. They both cause descriptions of functions that are > not relevan

Re: [PATCH v6 8/9] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux

2017-01-02 Thread Jonathan Cameron
On 2 January 2017 20:47:58 GMT+00:00, Peter Rosin wrote: >On 2017-01-02 19:05, Jonathan Cameron wrote: >> On 02/01/17 16:01, Peter Rosin wrote: >>> On 2017-01-01 12:00, Jonathan Cameron wrote: On 30/11/16 08:17, Peter Rosin wrote: > Analog Devices ADG792A/G is a triple 4:1 mux. > >>

Re: [PATCH v6 8/9] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux

2017-01-02 Thread Peter Rosin
On 2017-01-02 19:05, Jonathan Cameron wrote: > On 02/01/17 16:01, Peter Rosin wrote: >> On 2017-01-01 12:00, Jonathan Cameron wrote: >>> On 30/11/16 08:17, Peter Rosin wrote: Analog Devices ADG792A/G is a triple 4:1 mux. Signed-off-by: Peter Rosin >>> Few comments inline. Worth add

Re: Documentation: fix spelling mistakes of "Celcius" -- > "Celsius"

2017-01-02 Thread Guenter Roeck
On Wed, Dec 28, 2016 at 09:51:37PM +, Colin Ian King wrote: > From: Colin Ian King > > Signed-off-by: Colin Ian King Acked-by: Guenter Roeck > --- > Documentation/hwmon/ds1621| 8 > Documentation/thermal/nouveau_thermal | 2 +- > 2 files changed, 5 insertions(+), 5 d

Re: [PATCH v4 13/20] perf bench: New microbenchmark for userspace mutex performance

2017-01-02 Thread Waiman Long
On 01/02/2017 12:16 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 29, 2016 at 11:13:39AM -0500, Waiman Long escreveu: >> This microbenchmark simulates how the use of different futex types >> can affect the actual performanace of userspace mutex locks. The >> usage is: >> >> perf bench f

Re: [PATCH v6 9/9] misc: mux-adg792a: add mux controller driver for ADG792A/G

2017-01-02 Thread Jonathan Cameron
On 02/01/17 11:00, Peter Rosin wrote: > On 2017-01-01 12:24, Jonathan Cameron wrote: >> On 30/11/16 08:17, Peter Rosin wrote: >>> Analog Devices ADG792A/G is a triple 4:1 mux. >>> >>> Signed-off-by: Peter Rosin >> Looks pretty good. Some minor suggestions inline. >> >> This convinced me of two thi

Re: [PATCH v6 8/9] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux

2017-01-02 Thread Jonathan Cameron
On 02/01/17 16:01, Peter Rosin wrote: > On 2017-01-01 12:00, Jonathan Cameron wrote: >> On 30/11/16 08:17, Peter Rosin wrote: >>> Analog Devices ADG792A/G is a triple 4:1 mux. >>> >>> Signed-off-by: Peter Rosin >> Few comments inline. Worth adding anything about the gpio (output pins) to >> the b

Re: [PATCH v4 13/20] perf bench: New microbenchmark for userspace mutex performance

2017-01-02 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 29, 2016 at 11:13:39AM -0500, Waiman Long escreveu: > This microbenchmark simulates how the use of different futex types > can affect the actual performanace of userspace mutex locks. The > usage is: > > perf bench futex mutex Showing the tool output is preferred, trim it if

Re: [PATCH v6 8/9] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux

2017-01-02 Thread Peter Rosin
On 2017-01-01 12:00, Jonathan Cameron wrote: > On 30/11/16 08:17, Peter Rosin wrote: >> Analog Devices ADG792A/G is a triple 4:1 mux. >> >> Signed-off-by: Peter Rosin > Few comments inline. Worth adding anything about the gpio (output pins) to > the binding at this stage as well? Would certainly

Re: [PATCH v6 7/9] i2c: i2c-mux-simple: new driver

2017-01-02 Thread Peter Rosin
On 2017-01-01 16:38, Andy Shevchenko wrote: > On Wed, Nov 30, 2016 at 10:17 AM, Peter Rosin wrote: >> This is a generic simple i2c mux that uses the generic multiplexer >> subsystem to do the muxing. > >> +static const struct of_device_id i2c_mux_of_match[] = { >> + { .compatible = "i2c-mux

[PATCH 4/5] kernel-doc: make member highlighting available in all backends

2017-01-02 Thread Paolo Bonzini
Note that, in order to produce the correct Docbook markup, the "." or "->" must be separated from the member name in the regex's captured fields. For consistency, this change is applied to $type_member and $type_member_func too, not just to $type_member_xml. List mode only prints the struct name,

[PATCH 2/5] kernel-doc: strip attributes even if they have an argument

2017-01-02 Thread Paolo Bonzini
An inline function can have an attribute, as in include/linux/log2.h, and kernel-doc handles this already for simple cases. However, some attributes have arguments (e.g. the "target" attribute). Handle those too. Furthermore, attributes could be at the beginning of a function declaration, before

[PATCH 5/5] kernel-doc: make highlights more homogenous for the various backends

2017-01-02 Thread Paolo Bonzini
$type_struct_full and friends are only used by the restructuredText backend, because it needs to separate enum/struct/typedef/union from the name of the type. However, $type_struct is *also* used by the rST backend. This is confusing. This patch replaces $type_struct's use in the rST backend wit

[PATCH 1/5] kernel-doc: cleanup parameter type in function-typed arguments

2017-01-02 Thread Paolo Bonzini
A prototype like /** * foo - sample definition * @bar: a parameter */ int foo(int (*bar)(int x, int y)); is currently producing .. c:function:: int foo (int (*bar) (int x,int y) sample definition **Parameters**

[PATCH 3/5] kernel-doc: include parameter type in docbook output

2017-01-02 Thread Paolo Bonzini
The restructuredText output includes both the parameter type and the name for functions and function-typed members. Do the same for docbook. Signed-off-by: Paolo Bonzini --- scripts/kernel-doc | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/kernel-doc b/scripts

[PATCH 0/5] kernel-doc tweaks and cleanup of rST vs. non-rST backends

2017-01-02 Thread Paolo Bonzini
Hi, these patches are the result of my experiments with using kernel-doc for QEMU's documentation. Patches 1 and 2 should be relatively straightforward, as they are simple bugfixes. Patches 3 to 5, instead, are making the docbook backend (and the others too) more consistent with the input and ou

Re: [PATCH 1/2] cfg80211: update wireless-regdb repo url in Documentation

2017-01-02 Thread Johannes Berg
On Mon, 2017-01-02 at 08:28 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > It's maintained by Seth Forshe for a long time now. > Both applied, thanks. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH v6 9/9] misc: mux-adg792a: add mux controller driver for ADG792A/G

2017-01-02 Thread Peter Rosin
On 2017-01-01 12:24, Jonathan Cameron wrote: > On 30/11/16 08:17, Peter Rosin wrote: >> Analog Devices ADG792A/G is a triple 4:1 mux. >> >> Signed-off-by: Peter Rosin > Looks pretty good. Some minor suggestions inline. > > This convinced me of two things: > 1. Need a separate subsystem directory

Re: Warnings for documentation of private elements of a structure.

2017-01-02 Thread Jani Nikula
On Mon, 02 Jan 2017, Markus Heiser wrote: > IMO we should no longer investigate in the kernel_doc perl script, which > is at it ends. Instead we should merge the python version from my linuxdoc > project (BTW: with, we get man-pages from and lint of kernel-doc comments). > > To see how this python

Re: Warnings for documentation of private elements of a structure.

2017-01-02 Thread Jonathan Cameron
On 2 January 2017 09:26:03 GMT+00:00, Jani Nikula wrote: >On Sun, 01 Jan 2017, Jonathan Cameron wrote: >> Hi All, >> >> I have very little idea how the internals of the kernel-doc >processing >> code work, but was wondering if it would be possible to suppress >warnings >> of the type: >> >> .

Re: Warnings for documentation of private elements of a structure.

2017-01-02 Thread Jani Nikula
On Sun, 01 Jan 2017, Jonathan Cameron wrote: > Hi All, > > I have very little idea how the internals of the kernel-doc processing > code work, but was wondering if it would be possible to suppress warnings > of the type: > > ./include/linux/iio/buffer.h:142: warning: Excess struct/union/enum/type

Re: [PATCH v6 2/9] misc: minimal mux subsystem and gpio-based mux controller

2017-01-02 Thread Jonathan Cameron
On 2 January 2017 09:14:34 GMT+00:00, Peter Rosin wrote: >On 2016-12-31 17:19, Jonathan Cameron wrote: >> On 30/11/16 08:16, Peter Rosin wrote: >>> Add a new minimalistic subsystem that handles multiplexer >controllers. >>> When multiplexers are used in various places in the kernel, and the >>>

Re: [PATCH v6 2/9] misc: minimal mux subsystem and gpio-based mux controller

2017-01-02 Thread Peter Rosin
On 2016-12-31 17:19, Jonathan Cameron wrote: > On 30/11/16 08:16, Peter Rosin wrote: >> Add a new minimalistic subsystem that handles multiplexer controllers. >> When multiplexers are used in various places in the kernel, and the >> same multiplexer controller can be used for several independent th

Re: Warnings for documentation of private elements of a structure.

2017-01-02 Thread Markus Heiser
Am 01.01.2017 um 15:05 schrieb Jonathan Cameron : > Hi All, > > I have very little idea how the internals of the kernel-doc processing > code work, but was wondering if it would be possible to suppress warnings > of the type: > > ./include/linux/iio/buffer.h:142: warning: Excess struct/union/en