Re: [RFC 10/10] kmod: add a sanity check on module loading

2016-12-20 Thread Rusty Russell
"Luis R. Rodriguez" writes: > OK -- if userspace messes up again it may be a bit hard to prove > unless we have a validation debug thing in place, would such a thing > in debug form be reasonable ? That makes perfect sense. Untested hack: diff --git a/fs/filesystems.c b/fs/filesystems.c index c

Re: [RFC 10/10] kmod: add a sanity check on module loading

2016-12-20 Thread Luis R. Rodriguez
On Mon, Dec 19, 2016 at 6:53 PM, Rusty Russell wrote: > Where does this NULL-deref is the module isn't correctly loaded? No you are right, sorry -- I had confused a failure to mount over null deref, my mistake. >> *Iff* we want a sanity check to verify kmod's umh is not lying to us we >> need to

[PATCH v2 1/3] PM / core: Update kerneldoc comments in pm.h

2016-12-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Refresh the struct dev_pm_ops kerneldoc comment, so that it looks better and is more readable after processing by Sphinx, and drop the kerneldoc marker from a few other comments ("PM_EVENT_ messages" and a couple of enum types declarations) which are not proper kerneldoc a

[PATCH v2 3/3] PM / sleep / docs: Convert PM notifiers document to reST

2016-12-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Move the document describing PM notifiers (used during system sleep state transitions) to Documentation/driver-api/pm/, convert it to reST and update it to use current terminology. Also replace the remaining references to the old version of it in .txt documents with refer

[PATCH v2 2/3] PM / core / docs: Convert sleep states API document to reST

2016-12-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Move the document describing the system sleep state transitions API for devices to Documentation/driver-api/pm/, convert it to reST and update it to use current terminology. Also remove the remaining reference to the old version of it from pm.h. The new document still co

[PATCH v2 0/3] PM / docs: linux/pm.h kerneldocs update and conversion of two documents to reST

2016-12-20 Thread Rafael J. Wysocki
On Monday, December 19, 2016 09:40:20 PM Rafael J. Wysocki wrote: > Hi Everyone, > > These two patches update kerneldoc comments in include/linux/pm.h ([1/2]) and > convert Documentation/power/devices.txt to reST ([2/2], RFC). > > Please have a look, especially at patch [2/2], and let me know wha

Re: Documentation/unaligned-memory-access.txt: fix incorrect comparison operator

2016-12-20 Thread Ozgur Karatas
20.12.2016, 02:22, "Cihangir Akturk" : > On Sun, Dec 18, 2016 at 12:52:12AM +0200, Ozgur Karatas wrote: >>  17.12.2016, 19:43, "Cihangir Akturk" : >>  > In the actual implementation ether_addr_equal function tests for equality >> to 0 >>  > when returning. It seems in commit 0d74c4 it is somehow o

Re: [PATCH] Documentation/unaligned-memory-access.txt: fix incorrect comparison operator

2016-12-20 Thread Ozgur Karatas
20.12.2016, 01:13, "Jonathan Corbet" : > On Mon, 19 Dec 2016 23:53:40 +0200 > Cihangir Akturk wrote: > >>  In the actual implementation ether_addr_equal function tests for equality >> to 0 >>  when returning. It seems in commit 0d74c4 it is somehow overlooked to change >>  this operator to reflec

Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware)

2016-12-20 Thread Mika Westerberg
On Mon, Dec 19, 2016 at 05:21:39PM +, mario.limoncie...@dell.com wrote: > Dell - Internal Use - Confidential > > > > > There is small problem, though. On non-Apple systems the host controller > > only > > appears when something is connected to thunderbolt ports. So the char device > > woul