Re: btrfs: issues with SUBVOL_SETFLAGS

2011-02-09 Thread Li Zefan
Dan Rosenberg wrote: > Commit 0caa102da82799efaba88e234484786a9591c797 introduced the > SUBVOL_SETFLAGS ioctl, which contains the following check: > > if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC) Oops, should be: if (flags & BTRFS_SUBVOL_CREATE_ASYNC) > return -EINVAL; > >

btrfs: issues with SUBVOL_SETFLAGS

2011-02-09 Thread Dan Rosenberg
Commit 0caa102da82799efaba88e234484786a9591c797 introduced the SUBVOL_SETFLAGS ioctl, which contains the following check: if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC) return -EINVAL; if (flags & ~BTRFS_SUBVOL_RDONLY) return -EOPNOTSUPP; Is it intentiona