RE: [PATCH 10/16] Btrfs: Avoid trustless page-level-repair in dev-replace

2015-01-19 Thread Zhao Lei
Hi, Stefan Behrens Thanks for review these patch. * From: Stefan Behrens [mailto:sbehr...@giantdisaster.de] > Sent: Monday, January 19, 2015 8:26 PM > On Mon, 19 Jan 2015 19:20:59 +0800, Zhaolei wrote: > > From: Zhao Lei > > > > Current code of page level repair for dev-replace can only support

Re: [PATCH 10/16] Btrfs: Avoid trustless page-level-repair in dev-replace

2015-01-19 Thread Stefan Behrens
On Mon, 19 Jan 2015 19:20:59 +0800, Zhaolei wrote: > From: Zhao Lei > > Current code of page level repair for dev-replace can only support > io-error, we can't use it in checksum-fail case. > > We can skip this kind of repair in dev-replace just as we in scrub. Why? I see dev-replace as a disk

[PATCH 10/16] Btrfs: Avoid trustless page-level-repair in dev-replace

2015-01-19 Thread Zhaolei
From: Zhao Lei Current code of page level repair for dev-replace can only support io-error, we can't use it in checksum-fail case. We can skip this kind of repair in dev-replace just as we in scrub. Signed-off-by: Zhao Lei Signed-off-by: Miao Xie --- fs/btrfs/scrub.c | 8 1 file cha