Re: [PATCH] btrfs: fix WARNING in btrfs_select_ref_head()

2016-09-06 Thread David Sterba
Josef, can you please review this? On Mon, Jun 20, 2016 at 09:18:52AM +0800, Wang Xiaoguang wrote: > This issue was found when testing in-band dedupe enospc behaviour, > sometimes run_one_delayed_ref() may fail for enospc reason, then > __btrfs_run_delayed_refs()will return, but forget to add num_

Re: [PATCH] btrfs: fix WARNING in btrfs_select_ref_head()

2016-07-08 Thread David Sterba
On Mon, Jun 20, 2016 at 09:18:52AM +0800, Wang Xiaoguang wrote: > @@ -2665,7 +2665,10 @@ static noinline int __btrfs_run_delayed_refs(struct > btrfs_trans_handle *trans, > > btrfs_free_delayed_extent_op(extent_op); > if (ret) { > + spin_lock(&delay

[PATCH] btrfs: fix WARNING in btrfs_select_ref_head()

2016-06-19 Thread Wang Xiaoguang
This issue was found when testing in-band dedupe enospc behaviour, sometimes run_one_delayed_ref() may fail for enospc reason, then __btrfs_run_delayed_refs()will return, but forget to add num_heads_read back, which will trigger "WARN_ON(delayed_refs->num_heads_ready == 0)" in btrfs_select_ref_head