Re: [PATCH] btrfs: avoid double put of block group when emptying cluster

2021-02-17 Thread David Sterba
On Thu, Feb 11, 2021 at 01:25:52PM +0200, Nikolay Borisov wrote: > > > On 11.02.21 г. 0:50 ч., David Sterba wrote: > > On Tue, Jan 26, 2021 at 09:30:45AM -0500, Josef Bacik wrote: > >> On 1/26/21 4:02 AM, Nikolay Borisov wrote: > >>> On 25.01.21 г. 23:42 ч., Josef Bacik wrote: > In __btrfs_r

Re: [PATCH] btrfs: avoid double put of block group when emptying cluster

2021-02-11 Thread Nikolay Borisov
On 11.02.21 г. 0:50 ч., David Sterba wrote: > On Tue, Jan 26, 2021 at 09:30:45AM -0500, Josef Bacik wrote: >> On 1/26/21 4:02 AM, Nikolay Borisov wrote: >>> On 25.01.21 г. 23:42 ч., Josef Bacik wrote: In __btrfs_return_cluster_to_free_space we will bail doing the cleanup of the cluster

Re: [PATCH] btrfs: avoid double put of block group when emptying cluster

2021-02-10 Thread David Sterba
On Tue, Jan 26, 2021 at 09:30:45AM -0500, Josef Bacik wrote: > On 1/26/21 4:02 AM, Nikolay Borisov wrote: > > On 25.01.21 г. 23:42 ч., Josef Bacik wrote: > >> In __btrfs_return_cluster_to_free_space we will bail doing the cleanup > >> of the cluster if the block group we passed in doesn't match the

Re: [PATCH] btrfs: avoid double put of block group when emptying cluster

2021-01-26 Thread Josef Bacik
On 1/26/21 4:02 AM, Nikolay Borisov wrote: On 25.01.21 г. 23:42 ч., Josef Bacik wrote: In __btrfs_return_cluster_to_free_space we will bail doing the cleanup of the cluster if the block group we passed in doesn't match the block group on the cluster. However we drop a reference to block_group

Re: [PATCH] btrfs: avoid double put of block group when emptying cluster

2021-01-26 Thread Nikolay Borisov
On 25.01.21 г. 23:42 ч., Josef Bacik wrote: > In __btrfs_return_cluster_to_free_space we will bail doing the cleanup > of the cluster if the block group we passed in doesn't match the block > group on the cluster. However we drop a reference to block_group, as > the cluster holds a reference to

[PATCH] btrfs: avoid double put of block group when emptying cluster

2021-01-25 Thread Josef Bacik
In __btrfs_return_cluster_to_free_space we will bail doing the cleanup of the cluster if the block group we passed in doesn't match the block group on the cluster. However we drop a reference to block_group, as the cluster holds a reference to the block group while it's attached to the cluster. I