Re: [PATCH] Btrfs: fix endless loop in balancing block groups

2016-08-31 Thread Qu Wenruo
At 09/01/2016 08:54 AM, Liu Bo wrote: On Thu, Sep 01, 2016 at 08:32:00AM +0800, Qu Wenruo wrote: At 09/01/2016 07:43 AM, Liu Bo wrote: Qgroup function may overwrite the saved error 'err' with 0 in case quota is not enabled, and this ends up with a endless loop in balance because we keep goi

Re: [PATCH] Btrfs: fix endless loop in balancing block groups

2016-08-31 Thread Liu Bo
On Thu, Sep 01, 2016 at 08:32:00AM +0800, Qu Wenruo wrote: > > > At 09/01/2016 07:43 AM, Liu Bo wrote: > > Qgroup function may overwrite the saved error 'err' with 0 > > in case quota is not enabled, and this ends up with a > > endless loop in balance because we keep going back to balance > > the

Re: [PATCH] Btrfs: fix endless loop in balancing block groups

2016-08-31 Thread Qu Wenruo
At 09/01/2016 07:43 AM, Liu Bo wrote: Qgroup function may overwrite the saved error 'err' with 0 in case quota is not enabled, and this ends up with a endless loop in balance because we keep going back to balance the same block group. In which case? If join_trans() fails, we won't go through

[PATCH] Btrfs: fix endless loop in balancing block groups

2016-08-31 Thread Liu Bo
Qgroup function may overwrite the saved error 'err' with 0 in case quota is not enabled, and this ends up with a endless loop in balance because we keep going back to balance the same block group. It really should use 'ret' instead. Signed-off-by: Liu Bo --- fs/btrfs/relocation.c | 8 +---