Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Liu Bo
On Fri, Nov 20, 2015 at 08:29:06PM -0700, Jens Axboe wrote: > On 11/20/2015 08:14 PM, Liu Bo wrote: > >On Fri, Nov 20, 2015 at 07:26:45PM -0700, Jens Axboe wrote: > >>On 11/20/2015 04:08 PM, Liu Bo wrote: > >>>On Fri, Nov 20, 2015 at 02:30:43PM -0700, Jens Axboe wrote: > On 11/20/2015 06:13 AM,

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Jens Axboe
On 11/20/2015 08:14 PM, Liu Bo wrote: On Fri, Nov 20, 2015 at 07:26:45PM -0700, Jens Axboe wrote: On 11/20/2015 04:08 PM, Liu Bo wrote: On Fri, Nov 20, 2015 at 02:30:43PM -0700, Jens Axboe wrote: On 11/20/2015 06:13 AM, Chris Mason wrote: On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Liu Bo
On Fri, Nov 20, 2015 at 07:26:45PM -0700, Jens Axboe wrote: > On 11/20/2015 04:08 PM, Liu Bo wrote: > >On Fri, Nov 20, 2015 at 02:30:43PM -0700, Jens Axboe wrote: > >>On 11/20/2015 06:13 AM, Chris Mason wrote: > >>>On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: > while xfstesting, this

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Jens Axboe
On 11/20/2015 04:08 PM, Liu Bo wrote: On Fri, Nov 20, 2015 at 02:30:43PM -0700, Jens Axboe wrote: On 11/20/2015 06:13 AM, Chris Mason wrote: On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, so those sub-stripe wri

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Liu Bo
On Fri, Nov 20, 2015 at 02:30:43PM -0700, Jens Axboe wrote: > On 11/20/2015 06:13 AM, Chris Mason wrote: > >On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: > >>while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, > >>so those sub-stripe writes are gatherred into plug ca

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Jens Axboe
On 11/20/2015 06:13 AM, Chris Mason wrote: On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, so those sub-stripe writes are gatherred into plug callback list and hopefully we can have a full stripe writes. However,

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Chris Mason
On Fri, Nov 20, 2015 at 12:06:33PM -0800, Liu Bo wrote: > On Fri, Nov 20, 2015 at 09:57:49AM -0800, Liu Bo wrote: > > On Fri, Nov 20, 2015 at 08:13:58AM -0500, Chris Mason wrote: > > > On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: > > > > while xfstesting, this bug[1] is spotted by both b

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Liu Bo
On Fri, Nov 20, 2015 at 09:57:49AM -0800, Liu Bo wrote: > On Fri, Nov 20, 2015 at 08:13:58AM -0500, Chris Mason wrote: > > On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: > > > while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, > > > so those sub-stripe writes are gat

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Liu Bo
On Fri, Nov 20, 2015 at 08:13:58AM -0500, Chris Mason wrote: > On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: > > while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, > > so those sub-stripe writes are gatherred into plug callback list and > > hopefully we can have a f

Re: [PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-20 Thread Chris Mason
On Thu, Nov 19, 2015 at 05:49:37PM -0800, Liu Bo wrote: > while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, > so those sub-stripe writes are gatherred into plug callback list and > hopefully we can have a full stripe writes. > > However, while processing these plugged callb

[PATCH] Btrfs: fix a bug of sleeping in atomic context

2015-11-19 Thread Liu Bo
while xfstesting, this bug[1] is spotted by both btrfs/061 and btrfs/063, so those sub-stripe writes are gatherred into plug callback list and hopefully we can have a full stripe writes. However, while processing these plugged callbacks, it's within an atomic context which is provided by blk_sq_ma