Re: [PATCH u-boot] fs: btrfs: do not fail when offset of a ROOT_ITEM is not -1

2021-02-10 Thread Marek Behun
On Wed, 10 Feb 2021 09:20:11 +0800 Qu Wenruo wrote: > You're correct, the kernel is using new schema, btrfs_get_fs_root(), > which only requires root objectid and completely get rid of the > offset/type, which is far less possible to call with wrong parameters. > > It would be a good timing to

Re: [PATCH u-boot] fs: btrfs: do not fail when offset of a ROOT_ITEM is not -1

2021-02-09 Thread Marek Behun
On Wed, 10 Feb 2021 08:09:14 +0800 Qu Wenruo wrote: > On 2021/2/10 上午1:33, Marek Behún wrote: > > When the btrfs_read_fs_root() function is searching a ROOT_ITEM with > > location key offset other than -1, it currently fails via BUG_ON. > > > > The offset can have other value than -1, though. Thi

Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig

2021-01-27 Thread Marek Behun
On Wed, 27 Jan 2021 14:47:58 +0100 David Sterba wrote: > If it's a series then please mention u-boot in the cover letter, no need > to change the patches, I'll go check CC if I'm too confused about the > patch. I would suggest using subject prefix [PATCH u-boot]

Can a compressed file extent have non-zero offset?

2017-08-29 Thread Marek Behun
Hello, I cannot find this in the documentation (and the sources are too long), so I am trying here: can a file_extent_item with item.type == BTRFS_FILE_EXTENT_REG and item.compression != BTRFS_COMPRESS_NONE have non zero offset (item.offset != 0) ? What does it mean in such a case? That com