Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-03-01 Thread Dave Chinner
On Mon, Mar 01, 2021 at 12:55:53PM -0800, Dan Williams wrote: > On Sun, Feb 28, 2021 at 2:39 PM Dave Chinner wrote: > > > > On Sat, Feb 27, 2021 at 03:40:24PM -0800, Dan Williams wrote: > > > On Sat, Feb 27, 2021 at 2:36 PM Dave Chinner wrote: > > > > On Fri, Feb 26, 2021 at 02:41:34PM -0800, Dan

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-03-01 Thread Dan Williams
On Sun, Feb 28, 2021 at 11:27 PM Yasunori Goto wrote: > > Hello, Dan-san, > > On 2021/02/27 4:24, Dan Williams wrote: > > On Fri, Feb 26, 2021 at 11:05 AM Darrick J. Wong wrote: > >> > >> On Fri, Feb 26, 2021 at 09:45:45AM +, ruansy.f...@fujitsu.com wrote: > >>> Hi, guys > >>> > >>> Beside th

Re: [PATCH] btrfs-progs: docs: add seeding device section for btrfs-man5

2021-03-01 Thread David Sterba
On Sun, Feb 14, 2021 at 05:17:38PM +, Sidong Yang wrote: > This patch adds a section about seeding device for btrfs-man5. > Description and examples are from btrfs-wiki page. Sorry, but the contents of the wiki page are useless as documentation. There's no explanation of the usecase just a bun

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-03-01 Thread Dan Williams
On Sun, Feb 28, 2021 at 2:39 PM Dave Chinner wrote: > > On Sat, Feb 27, 2021 at 03:40:24PM -0800, Dan Williams wrote: > > On Sat, Feb 27, 2021 at 2:36 PM Dave Chinner wrote: > > > On Fri, Feb 26, 2021 at 02:41:34PM -0800, Dan Williams wrote: > > > > On Fri, Feb 26, 2021 at 1:28 PM Dave Chinner

Re: [PATCH] btrfs: fix warning when creating a directory with smack enabled

2021-03-01 Thread David Sterba
On Fri, Feb 26, 2021 at 05:51:44PM +, fdman...@kernel.org wrote: > From: Filipe Manana > > When we have smack enabled, during the creation of a directory smack may > attempt to add a "smack transmute" xattr on the inode, which results in > the following warning and trace: > > [ 220.732359]

Re: [GIT PULL] Btrfs updates for 5.12-rc2

2021-03-01 Thread pr-tracker-bot
The pull request you sent on Mon, 1 Mar 2021 14:44:16 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c608aca57dd034d09f307b109b670d1cfb829279 Thank you! -- Deet-doot-dot, I am a

Re: [PATCH] btrfs: fix the false data csum mismatch error caused

2021-03-01 Thread David Sterba
On Mon, Mar 01, 2021 at 04:44:22PM +0800, Qu Wenruo wrote: > [BUG] > When running fstresss, we can hit strange data csum mismatch where the > on-disk data is in fact correct (passes both scrub and btrfs check > --check-data-csum). check --chech-data-csum is not 100% reliable so I'd rather not ment

Re: [PATCH 0/6] Qgroup/delayed node related fixes

2021-03-01 Thread David Sterba
On Mon, Feb 22, 2021 at 06:40:41PM +0200, Nikolay Borisov wrote: > This series contains a couple of fixes and code simplifications around qgroup > and delayed node interation. The first 3 patches fix 2 separate issues - one > possible underflow when freeing qgroup-reserved space and the other one i

Re: [PATCH 6/6] btrfs: Simplify code flow in btrfs_delayed_inode_reserve_metadata

2021-03-01 Thread David Sterba
On Mon, Mar 01, 2021 at 06:20:29PM +0200, Nikolay Borisov wrote: > > > On 1.03.21 г. 18:15 ч., David Sterba wrote: > > On Mon, Feb 22, 2021 at 06:40:47PM +0200, Nikolay Borisov wrote: > >> btrfs_block_rsv_add can return only ENOSPC since it's called with > >> NO_FLUSH modifier. This so simplify t

Re: Adding Device Fails - Why?

2021-03-01 Thread Christian Völker
Hi, just a little update on the issue. As soon as I omit the encryption part I can easily add the device to the btrfs filesystem. It does not matter if the crypted device is on top of DRBD or directly on the /dev/sdc. In both cases btrs refuses to add the device when a luks-encrypted device i

Re: [PATCH 09/12] btrfs: extent_io: introduce end_bio_subpage_eb_writepage() function

2021-03-01 Thread David Sterba
On Mon, Feb 22, 2021 at 02:33:54PM +0800, Qu Wenruo wrote: > +static void end_bio_subpage_eb_writepage(struct btrfs_fs_info *fs_info, > + struct bio *bio) > +{ > + struct bio_vec *bvec; > + struct bvec_iter_all iter_all; > + > + ASSERT(!bio_flagged(b

Re: [PATCH 00/12] btrfs: support read-write for subpage metadata

2021-03-01 Thread David Sterba
On Mon, Feb 22, 2021 at 02:33:45PM +0800, Qu Wenruo wrote: > This patchset can be fetched from the following github repo, along with > the full subpage RW support: > https://github.com/adam900710/linux/tree/subpage > > This patchset is for metadata read write support. > > [TEST] > Since the data

Re: [PATCH 03/12] btrfs: disk-io: allow btree_set_page_dirty() to do more sanity check on subpage metadata

2021-03-01 Thread David Sterba
On Mon, Feb 22, 2021 at 03:58:00PM +0800, Su Yue wrote: > > On Mon 22 Feb 2021 at 14:33, Qu Wenruo wrote: > > > For btree_set_page_dirty(), we should also check the extent > > buffer > > sanity for subpage support. > > > > Unlike the regular sector size case, since one page can contain > > mul

Re: [PATCH 00/12] btrfs: support read-write for subpage metadata

2021-03-01 Thread David Sterba
On Mon, Feb 22, 2021 at 02:33:45PM +0800, Qu Wenruo wrote: > This patchset can be fetched from the following github repo, along with > the full subpage RW support: > https://github.com/adam900710/linux/tree/subpage > > This patchset is for metadata read write support. I've skimmed the patches, it

Re: [PATCH 6/6] btrfs: Simplify code flow in btrfs_delayed_inode_reserve_metadata

2021-03-01 Thread Nikolay Borisov
On 1.03.21 г. 18:15 ч., David Sterba wrote: > On Mon, Feb 22, 2021 at 06:40:47PM +0200, Nikolay Borisov wrote: >> btrfs_block_rsv_add can return only ENOSPC since it's called with >> NO_FLUSH modifier. This so simplify the logic in >> btrfs_delayed_inode_reserve_metadata to exploit this invarian

Re: [PATCH 6/6] btrfs: Simplify code flow in btrfs_delayed_inode_reserve_metadata

2021-03-01 Thread David Sterba
On Mon, Feb 22, 2021 at 06:40:47PM +0200, Nikolay Borisov wrote: > btrfs_block_rsv_add can return only ENOSPC since it's called with > NO_FLUSH modifier. This so simplify the logic in > btrfs_delayed_inode_reserve_metadata to exploit this invariant. This seems quite fragile, it's not straightforwa

[GIT PULL] Btrfs updates for 5.12-rc2

2021-03-01 Thread David Sterba
From: David Sterba Hi, first batch of fixes that usually arrive during the merge window code freeze. Regressions and stable material. Please pull, thanks. Regressions: - fix deadlock in log sync in zoned mode - fix bugs in subpage mode still wrongly assuming sectorsize == page size Fixes:

Re: [PATCH 1/3] btrfs: zoned: move superblock logging zone location

2021-03-01 Thread David Sterba
On Mon, Mar 01, 2021 at 05:17:52AM +, Damien Le Moal wrote: > On 2021/03/01 14:02, Naohiro Aota wrote: > > On Fri, Feb 26, 2021 at 08:11:30PM +0100, David Sterba wrote: > >> On Fri, Feb 26, 2021 at 06:34:36PM +0900, Naohiro Aota wrote: > >>> This commit moves the location of superblock logging

Re: Adding Device Fails - Why?

2021-03-01 Thread Christian Völker
Hi, unfortunately I do not have any sources or compilers installed on this box. So I am unable to install this here. I can not even take a snapshot to install and compile because it is a two-node setup with drbd so resetting to a snapshot will fail for the drbd sync. A reboot did not help.

Re: Adding Device Fails - Why?

2021-03-01 Thread Qu Wenruo
On 2021/3/1 下午7:19, Christian Völker wrote: Hi all, I am using BTRS on a Debian10 system. I am trying to extend my existing filesystem with another device but adding it fails for no reason. This is my setup of existing btrfs:  2x DRBD Devices (Network RAID1)  top of each a luks encrypted d

Re: Adding Device Fails - Why?

2021-03-01 Thread Hugo Mills
On Mon, Mar 01, 2021 at 12:19:12PM +0100, Christian Völker wrote: > I am using BTRS on a Debian10 system. I am trying to extend my existing > filesystem with another device but adding it fails for no reason. > > This is my setup of existing btrfs: > >  2x DRBD Devices (Network RAID1) >  top of ea

Adding Device Fails - Why?

2021-03-01 Thread Christian Völker
Hi all, I am using BTRS on a Debian10 system. I am trying to extend my existing filesystem with another device but adding it fails for no reason. This is my setup of existing btrfs:  2x DRBD Devices (Network RAID1)  top of each a luks encrypted device (crypt_drbd1 and crypt_drbd3): vdb  

[PATCH v2 2/2] btrfs: add btree read ahead for incremental send operations

2021-03-01 Thread fdmanana
From: Filipe Manana Currently we do not do btree read ahead when doing an incremental send, however we know that we will read and process any node or leaf in the send root that has a generation greater than the generation of the parent root. So triggering read ahead for such nodes and leafs is be

[PATCH v2 1/2] btrfs: add btree read ahead for full send operations

2021-03-01 Thread fdmanana
From: Filipe Manana When doing a full send we know that we are going to be reading every node and leaf of the send root, so we benefit from enabling read ahead for the btree. This change enables read ahead for full send operations only, incremental sends will have read ahead enabled in a differe

[PATCH v2 0/2] btrfs: add btree read ahead for send operations

2021-03-01 Thread fdmanana
From: Filipe Manana This patchset adds btree read ahead for full and incremental send operations, which results in some nice speedups. Test and results are mentioned in the change log of each patch. V2: Updated second patch, for incremental sends, to limit readahead to avoid too many reads i

[PATCH] btrfs: fix the false data csum mismatch error caused

2021-03-01 Thread Qu Wenruo
[BUG] When running fstresss, we can hit strange data csum mismatch where the on-disk data is in fact correct (passes both scrub and btrfs check --check-data-csum). With some extra debug info added, we have the following traces: 510482us : btrfs_do_readpage: root=5 ino=284 offset=393216, submit fo