[PATCH] btrfs: remove repeated word

2021-01-24 Thread Nigel Christian
Comment for processed extent end of range has an unnecessary "in". Eradicate it. Signed-off-by: Nigel Christian --- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 7f689ad7709c..2dc98eeb3c93 100644 --- a/f

Re: Recover data from damage disk in "array"

2021-01-24 Thread Hérikz Nawarro
> OK, that's weird. Multiple disks should always have metadata in a raid1* > profile (raid1, raid10, raid1c3, or raid1c4). dup metadata on multiple > disks, especially spinners, is going to be slow and brittle with no > upside. I didn't know about this. > There are other ways to do this, but th

Re: Recover data from damage disk in "array"

2021-01-24 Thread Hérikz Nawarro
> I'm not sure what you mean by isolate, or what's meant by recover all > data. To recover all data on all four disks suggests replicating all > of it to another file system - i.e. backup, rsync, snapshot(s) + > send/receive. I mean, dd the disk to a file and copy the data, before replacing the br

Re: [PATCH v4 00/18] btrfs: add read-only support for subpage sector size

2021-01-24 Thread Qu Wenruo
On 2021/1/24 下午8:29, David Sterba wrote: On Tue, Jan 19, 2021 at 07:26:17AM +0800, Qu Wenruo wrote: On 2021/1/19 上午7:17, David Sterba wrote: On Sat, Jan 16, 2021 at 03:15:15PM +0800, Qu Wenruo wrote: As the subpage support is sort of an isolated feature we could afford to get the first batch

Re: Unexpected reflink/subvol snapshot behaviour

2021-01-24 Thread Qu Wenruo
On 2021/1/25 上午6:36, Dave Chinner wrote: On Sat, Jan 23, 2021 at 04:42:33PM +0800, Qu Wenruo wrote: On 2021/1/22 上午6:20, Dave Chinner wrote: Hi btrfs-gurus, I'm running a simple reflink/snapshot/COW scalability test at the moment. It is just a loop that does "fio overwrite of 10,000 4kB r

Re: Unexpected reflink/subvol snapshot behaviour

2021-01-24 Thread Dave Chinner
On Sat, Jan 23, 2021 at 04:42:33PM +0800, Qu Wenruo wrote: > > > On 2021/1/22 上午6:20, Dave Chinner wrote: > > Hi btrfs-gurus, > > > > I'm running a simple reflink/snapshot/COW scalability test at the > > moment. It is just a loop that does "fio overwrite of 10,000 4kB > > random direct IOs in a

Re: kernel BUG at fs/btrfs/relocation.c:3494

2021-01-24 Thread Markus Hartung
On 23/01/2021 23:57, Zygo Blaxell wrote: You don't have enough space to convert metadata yet, and you also don't have enough space to lock one of your 3 metadata block groups without running out of global reserve space, so this balance command forces the filesystem read-only due to lack of space.

RE: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64

2021-01-24 Thread David Laight
> One open question is whether IORING_OP_GETDENTS64 should be more like > pread(2) and allow passing in a starting offset to read from the > directory from. (This would require some more surgery in fs/readdir.c.) Since directories are seekable this ought to work. Modulo horrid issues with 32bit f

Re: Unexpected reflink/subvol snapshot behaviour

2021-01-24 Thread Dave Chinner
On Sat, Jan 23, 2021 at 07:19:03PM -0500, Zygo Blaxell wrote: > On Fri, Jan 22, 2021 at 09:20:51AM +1100, Dave Chinner wrote: > > Hi btrfs-gurus, > > > > I'm running a simple reflink/snapshot/COW scalability test at the > > moment. It is just a loop that does "fio overwrite of 10,000 4kB > > rando

Re: [RFC][PATCH V5] btrfs: preferred_metadata: preferred device for metadata

2021-01-24 Thread Goffredo Baroncelli
On 1/23/21 6:44 PM, Graham Cobb wrote: [...] I gave a few very simple examples, but I can think of many more cases where a disk may contain files which users might be able to access if the disk was mounted (maybe the disk has subvols used by many different systems but UIDs are not coordinated, or

Re: Cannot resize filesystem: not enough free space

2021-01-24 Thread Hugo Mills
On Sun, Jan 24, 2021 at 08:11:37PM +0100, Jakob Schöttl wrote: > > Hugo Mills writes: > > > On Sun, Jan 24, 2021 at 07:23:21PM +0100, Jakob Schöttl wrote: > > > > > > Help please, increasing the filesystem size doesn't work. > > > > > > When mounting my btrfs filesystem, I had errors saying, "

Re: Cannot resize filesystem: not enough free space

2021-01-24 Thread Jakob Schöttl
Hugo Mills writes: On Sun, Jan 24, 2021 at 07:23:21PM +0100, Jakob Schöttl wrote: Help please, increasing the filesystem size doesn't work. When mounting my btrfs filesystem, I had errors saying, "no space left on device". Now I managed to mount the filesystem with -o skip_balance but:

Re: [PATCH] btrfs: Prevent nowait or async read from doing sync IO

2021-01-24 Thread Martin Raiber
On 12.01.2021 18:01 Pavel Begunkov wrote: On 12/01/2021 15:36, David Sterba wrote: On Fri, Jan 08, 2021 at 12:02:48AM +, Martin Raiber wrote: When reading from btrfs file via io_uring I get following call traces: Is there a way to reproduce by common tools (fio) or is a specialized one nee

Re: Cannot resize filesystem: not enough free space

2021-01-24 Thread Hugo Mills
On Sun, Jan 24, 2021 at 07:23:21PM +0100, Jakob Schöttl wrote: > > Help please, increasing the filesystem size doesn't work. > > When mounting my btrfs filesystem, I had errors saying, "no space left > on device". Now I managed to mount the filesystem with -o skip_balance but: > > # btrfs fi df

Cannot resize filesystem: not enough free space

2021-01-24 Thread Jakob Schöttl
Help please, increasing the filesystem size doesn't work. When mounting my btrfs filesystem, I had errors saying, "no space left on device". Now I managed to mount the filesystem with -o skip_balance but: # btrfs fi df /mnt Data, RAID1: total=147.04GiB, used=147.02GiB System, RAID1: total=8

[PATCH] btrfs: Remove unused variable

2021-01-24 Thread Nikolay Borisov
This fixes fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used [-Wunused-but-set-variable] 491 | u64 zone_size; Which got introduced in 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode") Signed-off-by: Nikolay Borisov --- fs/btrfs/zoned.c | 2 --

Re: [PATCH v2 14/14] btrfs: Enable W=1 checks for btrfs

2021-01-24 Thread David Sterba
On Thu, Jan 21, 2021 at 09:31:34AM +0200, Nikolay Borisov wrote: > On 20.01.21 г. 17:55 ч., Josef Bacik wrote: > > On 1/20/21 5:25 AM, Nikolay Borisov wrote: > >> Now that the btrfs' codebase is clean of W=1 warning let's enable those > >> checks unconditionally for the entire fs/btrfs/ and its sub

Re: [PATCH v3] btrfs: fix possible free space tree corruption with online conversion

2021-01-24 Thread David Sterba
On Fri, Jan 15, 2021 at 04:26:17PM -0500, Josef Bacik wrote: > While running btrfs/011 in a loop I would often ASSERT() while trying to > add a new free space entry that already existed, or get an -EEXIST while > adding a new block to the extent tree, which is another indication of > double allocat

Re: Unexpected reflink/subvol snapshot behaviour

2021-01-24 Thread Filipe Manana
On Sat, Jan 23, 2021 at 8:46 AM Qu Wenruo wrote: > > > > On 2021/1/22 上午6:20, Dave Chinner wrote: > > Hi btrfs-gurus, > > > > I'm running a simple reflink/snapshot/COW scalability test at the > > moment. It is just a loop that does "fio overwrite of 10,000 4kB > > random direct IOs in a 4GB file;

Re: [PATCH v3 0/2] ->total_bytes_pinned fixes for early ENOSPC issues

2021-01-24 Thread David Sterba
On Fri, Jan 15, 2021 at 04:48:54PM -0500, Josef Bacik wrote: > v2->v3: > - Updated the changelog in patch 2 to refer to the patchset that inspired the > change. > - Added Nik's reviewed-by for patch 2. Thanks, the patches have been in for-next, adding v3 to misc-next. I've tagged it for stable

Re: [PATCH v4 00/18] btrfs: add read-only support for subpage sector size

2021-01-24 Thread David Sterba
On Tue, Jan 19, 2021 at 07:26:17AM +0800, Qu Wenruo wrote: > On 2021/1/19 上午7:17, David Sterba wrote: > > On Sat, Jan 16, 2021 at 03:15:15PM +0800, Qu Wenruo wrote: > > As the subpage support is > > sort of an isolated feature we could afford to get the first batch of > > code in and continue polis

Re: [PATCH v4 01/18] btrfs: update locked page dirty/writeback/error bits in __process_pages_contig()

2021-01-24 Thread David Sterba
On Sun, Jan 24, 2021 at 08:35:27AM +0800, Qu Wenruo wrote: > On 2021/1/24 上午3:13, David Sterba wrote: > > On Thu, Jan 21, 2021 at 02:51:46PM +0800, Qu Wenruo wrote: > >> On 2021/1/21 下午2:32, Qu Wenruo wrote: > >>> On 2021/1/20 上午5:41, Josef Bacik wrote: > On 1/16/21 2:15 AM, Qu Wenruo wrote: >

Re: [PATCH v3 13/14] lib/zstd: Convert constants to defines

2021-01-24 Thread David Sterba
On Sat, Jan 23, 2021 at 05:50:52PM +, Nick Terrell wrote: > > > > On Jan 22, 2021, at 1:58 AM, Nikolay Borisov wrote: > > > > Those constants are really used internally by zstd and including > > linux/zstd.h into users results in the following warnings: > > > > In file included from fs/btr