Re: [PATCH 0/5] blk: introduce block layer helpers to calculate num of queues

2025-07-01 Thread Jens Axboe
helpers to calculate num of queues commit: 94970cfb5f10ea381df8c402d36c5023765599da [5/5] virtio: blk/scsi: use block layer helpers to calculate num of queues commit: 0a50ed0574ffe853f15c3430794b5439b2e6150a Best regards, -- Jens Axboe

Re: [PATCH] Revert "block: don't reorder requests in blk_add_rq_to_plug"

2025-06-11 Thread Jens Axboe
> Also be curious, why does writeback produce so many 2KiB bios? I was pondering that too, sounds like a misconfiguration of sorts. But even without that, in a quick synthetic test here locally, I do see a lot of missed merges that is solved with the alternative patch I sent out. I strongly suspect it'll fix this issue too. -- Jens Axboe

Re: [PATCH] Revert "block: don't reorder requests in blk_add_rq_to_plug"

2025-06-11 Thread Jens Axboe
if (rq->q == q) { if (blk_attempt_bio_merge(q, rq, bio, nr_segs, false) == -- Jens Axboe

Re: [PATCH] selftests: ublk: kublk: improve behavior on init failure

2025-06-03 Thread Jens Axboe
a (not very descriptive) log line when this happens. > > [...] Applied, thanks! [1/1] selftests: ublk: kublk: improve behavior on init failure commit: a2f4c1ae163b815dc81e3cab97c3149fdc6639e3 Best regards, -- Jens Axboe

Re: [PATCH v8 0/9] ublk: decouple server threads from ublk_queues/hctxs

2025-05-30 Thread Jens Axboe
9/9] Documentation: ublk: document UBLK_F_PER_IO_DAEMON commit: b02f5eedbcabe6e1982fdd7ff3f0ac5d1fddc68f Best regards, -- Jens Axboe

Re: [PATCH v8 1/9] ublk: have a per-io daemon instead of a per-queue daemon

2025-05-29 Thread Jens Axboe
LGTM: Reviewed-by: Jens Axboe -- Jens Axboe

Re: [PATCH 0/3] selftests: ublk: more misc fixes

2025-05-05 Thread Jens Axboe
Bleh, sorry, I meant to send this as a reply to v2: > > https://lore.kernel.org/linux-block/20250429-ublk_selftests-v2-0-e970b6d9e...@purestorage.com/ Let's give Ming a chance to review v2, then I can get it queued up. -- Jens Axboe

Re: [PATCH v2 0/3] selftests: ublk: more misc fixes

2025-05-05 Thread Jens Axboe
ftests: ublk: kublk: fix include path commit: e371b9d3368ccb6b55fe9747be12c3107b2817b3 Best regards, -- Jens Axboe

Re: [PATCH 0/3] selftests: ublk: more misc fixes

2025-05-05 Thread Jens Axboe
On 5/5/25 4:53 PM, Uday Shankar wrote: > On Mon, May 05, 2025 at 04:44:19PM -0600, Jens Axboe wrote: >> On 5/5/25 2:34 PM, Uday Shankar wrote: >>> On Mon, May 05, 2025 at 02:31:40PM -0600, Uday Shankar wrote: >>>> Hi Jens, >>>> >>>> Can yo

Re: (subset) [PATCH 0/2] selftests: ublk: misc fixes

2025-04-24 Thread Jens Axboe
On Wed, 23 Apr 2025 15:29:01 -0600, Uday Shankar wrote: > Fix a couple of small issues in the ublk selftests > > Applied, thanks! [2/2] selftests: ublk: common: fix _get_disk_dev_t for pre-9.0 coreutils commit: 1d019736b6f812bebf3ef89d6e887d06e2a822fc Best regards, -- Jens Axboe

Re: [PATCH 1/2] selftests: ublk: kublk: build with -Werror

2025-04-23 Thread Jens Axboe
se random warnings on different compilers, and then just causing trouble for people rather than being useful. If you think it's a good idea, make it follow CONFIG_WERROR at least, don't make it unconditional. -- Jens Axboe

Re: [RFC PATCH 00/11] pcache: Persistent Memory Cache for Block Devices

2025-04-16 Thread Jens Axboe
On 4/16/25 12:08 AM, Dongsheng Yang wrote: > > On 2025/4/16 9:04, Jens Axboe wrote: >> On 4/15/25 12:00 PM, Dan Williams wrote: >>> Thanks for making the comparison chart. The immediate question this >>> raises is why not add "multi-tree per backend", &q

Re: [RFC PATCH 00/11] pcache: Persistent Memory Cache for Block Devices

2025-04-15 Thread Jens Axboe
device-mapper is everywhere, has a long track record, and enhancing it > immediately engages a community of folks in this space. Strongly agree. -- Jens Axboe

Re: [PATCH] block: add SPDX header line to blk-throttle.h

2025-04-14 Thread Jens Axboe
also uses that identifier. > > > [...] Applied, thanks! [1/1] block: add SPDX header line to blk-throttle.h commit: 1b4194053f6b30556272ff11750dd518e067ea49 Best regards, -- Jens Axboe

Re: [PATCH 0/2] ublk: fixes for selftests

2025-04-02 Thread Jens Axboe
On 4/2/25 1:34 PM, Uday Shankar wrote: > On Wed, Apr 02, 2025 at 07:12:45AM -0600, Jens Axboe wrote: >> >> On Tue, 01 Apr 2025 14:49:07 -0600, Uday Shankar wrote: >>> Fix a couple of issues I saw when developing selftests for ublk. These >>> patches are sp

Re: [PATCH 0/2] ublk: fixes for selftests

2025-04-02 Thread Jens Axboe
t; > Applied, thanks! [1/2] selftests: ublk: kublk: use ioctl-encoded opcodes (no commit info) [2/2] selftests: ublk: kublk: fix an error log line (no commit info) Best regards, -- Jens Axboe

Re: [PATCH 0/2] ublk: specify io_cmd_buf pointer type

2025-03-29 Thread Jens Axboe
_cmd_buf pointer type commit: 25aaa81371e7db34ddb42c69ed4f6c5bc8de2afa Best regards, -- Jens Axboe

Re: [PATCH 0/2] ublk: specify io_cmd_buf pointer type

2025-03-28 Thread Jens Axboe
buf's type to struct ublksrv_io_desc * so it can be > indexed directly and the compiler can type-check the code. > > Make the same change to the ublk selftests. Looks good to me, nice cleanup, more readable now. -- Jens Axboe

Re: [PATCH] block: remove unused parameter

2025-03-13 Thread Jens Axboe
On Thu, 13 Mar 2025 09:23:18 +0530, Anuj Gupta wrote: > request_queue param is not used by blk_rq_map_sg and __blk_rq_map_sg. > remove it. > > Applied, thanks! [1/1] block: remove unused parameter commit: 61667cb6644f6fb01eb8baa928e381c016b5ed7b Best regards, -- Jens Axboe

Re: [PATCH 00/11] selftests: ublk: bug fixes & consolidation

2025-03-11 Thread Jens Axboe
4fcd5b5a6dff71cf82212dd208dc1765ca8a8088 [11/11] selftests: ublk: improve test usability commit: 22c880f446a149f5ee11260690a34d4b3f95c221 Best regards, -- Jens Axboe

Re: [PATCH v2 0/2] block: nvme: fix blktests nvme/039 failure

2025-03-11 Thread Jens Axboe
me_end_req() to __nvme_end_req() commit: e5c2bcc0cd47321d78bb4e865d7857304139f95d [2/2] block: change blk_mq_add_to_batch() third argument type to bool commit: f00baf2eac785bba837e5ed79d489f16520e7a6d Best regards, -- Jens Axboe

Re: [PATCH v2 0/2] block: nvme: fix blktests nvme/039 failure

2025-03-11 Thread Jens Axboe
gh requests, and the second patch covers the non-passthrough > requests. Looks good to me, and better than the quick fix-up for the problem. Thanks for taking the time to do it right! -- Jens Axboe

Re: [PATCH 00/11] selftests: ublk: bug fixes & consolidation

2025-03-11 Thread Jens Axboe
On 3/10/25 10:35 PM, Ming Lei wrote: > On Mon, Mar 10, 2025 at 09:17:56AM -0600, Jens Axboe wrote: >> On 3/10/25 9:09 AM, Ming Lei wrote: >>> On Mon, Mar 3, 2025 at 8:43?PM Ming Lei wrote: >>>> >>>> Hello Jens and guys, >>>> >>&g

Re: [PATCH 00/11] selftests: ublk: bug fixes & consolidation

2025-03-11 Thread Jens Axboe
libring uses 77 and >> kselftests takes 4 > > Hi Jens, > > Can you merge this patchset if you are fine? Yep sorry, was pondering how best to get it staged. Should go into block, but depends on the other bits that I staged for io_uring. So I'll just put it there, not a big deal. -- Jens Axboe

Re: [PATCH V2 00/12] badblocks: bugfix and cleanup for badblocks

2025-03-06 Thread Jens Axboe
dd99f3ad1f981671ad5b4f24ac48c568ad [12/12] badblocks: use sector_t instead of int to avoid truncation of badblocks length commit: d301f164c3fbff611bd71f57dfa553b9219f0f5e Best regards, -- Jens Axboe

Re: [PATCH V3 0/3] selftests: add ublk selftests

2025-02-28 Thread Jens Axboe
On 2/28/25 6:11 PM, Ming Lei wrote: > On Fri, Feb 28, 2025 at 09:37:47AM -0700, Jens Axboe wrote: >> On 2/28/25 9:19 AM, Ming Lei wrote: >>> Hello Jens, >>> >>> This patchset adds ublk kernel selftests, which is very handy for >>> developer for ver

Re: [PATCH V3 0/3] selftests: add ublk selftests

2025-02-28 Thread Jens Axboe
t; Please consider it for v6.15. Can we add the zc bits to the liburing test case as well? -- Jens Axboe

Re: [PATCH V3 0/3] selftests: add ublk selftests

2025-02-28 Thread Jens Axboe
l selftests for ublk commit: 6aecda00b7d1e187c31e702d607d2b51bbcddbcc [2/3] selftests: ublk: add file backed ublk commit: 5d95bfb5357111028b7a37464d1a18702722efe9 [3/3] selftests: ublk: add ublk zero copy test commit: bedc9cbc5f9709b97646fe3423dbf530b74b09d5 Best regards, -- Jens Axboe

Re: (subset) [PATCH v11 0/7] Support for hardware-wrapped inline encryption keys

2025-02-10 Thread Jens Axboe
d021d02f4d2ed734e7b65e2a [2/7] blk-crypto: show supported key types in sysfs commit: e35fde43e25ad725d27315992fba8088d1210b01 [3/7] blk-crypto: add ioctls to create and prepare hardware-wrapped keys commit: 1ebd4a3c095cd538d3c1c7c12738ef47d8e71f96 Best regards, -- Jens Axboe

Re: [PATCH] block: force noio scope in blk_mq_freeze_queue

2025-02-03 Thread Jens Axboe
he non-owner freezes, >> and they will be addressed separately. >> >> Signed-off-by: Christoph Hellwig > > All sparc64 builds fail with this patch in the tree. Yep, Stephen reported the same yesterday. The patch is queued up, will most likely just send it out separately. -- Jens Axboe

Re: [PATCH] block: force noio scope in blk_mq_freeze_queue

2025-01-31 Thread Jens Axboe
7be8d03c1c Best regards, -- Jens Axboe

Re: [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk

2024-12-17 Thread Jens Axboe
On 12/17/24 2:00 PM, Stefan Hajnoczi wrote: > On Tue, 17 Dec 2024 at 12:54, Jens Axboe wrote: >> >> On 12/16/24 11:08 PM, Jingbo Xu wrote: >>>> That's why I asked Jens to weigh in on whether there is a generic >>>> block layer solution here.

Re: [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk

2024-12-17 Thread Jens Axboe
lows things down, which is why passthrough ends up being faster. -- Jens Axboe

Re: [PATCH v6 0/8] blk: refactor queue affinity helpers

2024-12-17 Thread Jens Axboe
o: blk/scsi: replace blk_mq_virtio_map_queues with blk_mq_map_hw_queues commit: 5a1c50296039ca32a22015bbb9696d6a96514947 [8/8] blk-mq: remove unused queue mapping helpers commit: 737371e839a368007758be329413b3f5ec9e7976 Best regards, -- Jens Axboe

Re: [PATCH] virtio-blk: don't keep queue frozen during system suspend

2024-12-05 Thread Jens Axboe
spend commit: 7678abee0867e6b7fb89aa40f6e9f575f755fb37 Best regards, -- Jens Axboe

Re: [PATCH 4/6] block: add a rq_list type

2024-11-15 Thread Jens Axboe
On 11/15/24 5:49 AM, Jens Axboe wrote: > On 11/14/24 1:11 PM, Nathan Chancellor wrote: >> Hi Christoph, >> >> On Wed, Nov 13, 2024 at 04:20:44PM +0100, Christoph Hellwig wrote: >>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h >>> index 65f3

Re: [PATCH 4/6] block: add a rq_list type

2024-11-15 Thread Jens Axboe
uilding a queue of related requests by holding the I/O > * fragments for a short period. This allows merging of sequential requests > Fix looks fine, but I can't apply a patch that hasn't been signed off. Please send one, or I'll just have to sort it out manually as we're really close to this code shipping. -- Jens Axboe

Re: don't reorder requests passed to ->queue_rqs

2024-11-14 Thread Jens Axboe
On 11/13/24 9:16 PM, Christoph Hellwig wrote: > On Wed, Nov 13, 2024 at 01:51:48PM -0700, Jens Axboe wrote: >> Thanks for testing, but you can't verify any kind of perf change with >> that kind of setup. I'll be willing to bet that it'll be 1-2% drop at >> hig

Re: don't reorder requests passed to ->queue_rqs

2024-11-13 Thread Jens Axboe
On 11/13/24 3:23 PM, Chaitanya Kulkarni wrote: > On 11/13/2024 12:51 PM, Jens Axboe wrote: >>> Looks good to me. I ran the quick performance numbers [1]. >>> >>> Reviewed-by: Chaitanya Kulkarni >>> >>> -ck >>> >>> fio rand

Re: don't reorder requests passed to ->queue_rqs

2024-11-13 Thread Jens Axboe
. I'll be willing to bet that it'll be 1-2% drop at higher rates, which is substantial. But the reordering is a problem, not just for zoned devices, which is why I chose to merge this. -- Jens Axboe

Re: [PATCH 2/6] virtio_blk: reverse request order in virtio_queue_rqs

2024-11-13 Thread Jens Axboe
message should say "virtio_queue_rqs". I fixed it up. As well as the annoying "two spaces after a period", that should just go away. -- Jens Axboe

Re: don't reorder requests passed to ->queue_rqs

2024-11-13 Thread Jens Axboe
5ad90 [5/6] block: don't reorder requests in blk_add_rq_to_plug commit: 05634083a304eb3d4b5733fe8d6e2fd0c1041ca8 [6/6] block: don't reorder requests in blk_mq_add_to_batch commit: 65550dea43815d01f45d7ece38e458855d5e2962 Best regards, -- Jens Axboe

Re: don't reorder requests passed to ->queue_rqs

2024-11-13 Thread Jens Axboe
hen does the same for I/O completions as >> well. > > Hi Christoph, > > Could something like the patch below replace this patch series? I > don't have a strong opinion about which approach to select. I mean it obviously could, but it'd be a terrible way to go as we're now iterating the full list just to reverse it... -- Jens Axboe

Re: [PATCH 1/6] blk-mq: introduce blk_mq_hctx_map_queues

2024-09-15 Thread Jens Axboe
27;t object to the code, but it seems > like it could go somewhere in block/? Probably not a bad idea. Unrelated to that topic, but Daniel, all your email gets marked as spam. I didn't see your series before this reply. This has been common recently for people that haven't kept up with kernel.org changes, please check for smtp changes there. -- Jens Axboe

Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions

2024-08-28 Thread Jens Axboe
On 8/28/24 1:10 AM, Philipp Stanner wrote: > On Tue, 2024-08-27 at 13:05 -0600, Jens Axboe wrote: >> On 8/27/24 12:56 PM, Philipp Stanner wrote: >>> pcim_iomap_regions() and pcim_iomap_table() have been deprecated by >>> the >>> PCI subsystem in

Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions

2024-08-27 Thread Jens Axboe
gt; Replace pcim_iomap_regions() and pcim_iomap_table(). > > Remove the calls to pcim_iounmap_regions(). Looks fine to me - since it depends on other trees, feel free to take it through those: Reviewed-by: Jens Axboe -- Jens Axboe

Re: [PATCH v2] virtio_blk: implement init_hctx MQ operation

2024-08-08 Thread Jens Axboe
o do this. Reviewed-by: Jens Axboe -- Jens Axboe

Re: [PATCH v2 0/5] Validate logical block size in blk_validate_limits()

2024-07-08 Thread Jens Axboe
70 [4/5] virtio_blk: Don't bother validating blocksize commit: af2817229158cea7960b9132e0a8c4470ebbfef5 [5/5] loop: Don't bother validating blocksize commit: 9423c653fe611070d875b374fb322dc44acce3f2 Best regards, -- Jens Axboe

Re: pass queue_limits to blk_alloc_disk for simple drivers

2024-02-20 Thread Jens Axboe
limits to blk_mq_alloc_disk commit: af190c53c995bf7c742c3387f6537534f8b92322 Best regards, -- Jens Axboe

Re: [PATCH v4] nbd: null check for nla_nest_start

2024-02-18 Thread Jens Axboe
commit: 31edf4bbe0ba27fd03ac7d87eb2ee3d2a231af6d Best regards, -- Jens Axboe

Re: atomic queue limits updates v5

2024-02-13 Thread Jens Axboe
the atomic queue limits update API commit: 473516b361936cbc27d7728df649a5b3094b6170 Best regards, -- Jens Axboe

Re: [PATCH V2] virtio-blk: Ensure no requests in virtqueues before deleting vqs.

2024-02-08 Thread Jens Axboe
virtqueues before deleting vqs. (no commit info) Best regards, -- Jens Axboe

Re: atomic queue limits updates v3

2024-02-08 Thread Jens Axboe
git;a=shortlog;h=refs/heads/blk-limits-base > > with the bisection hazard found by Keith and the various review tags. Can you send a v4 so we can get it applied? -- Jens Axboe

Re: [PATCH] trace/blktrace: fix task hung in blk_trace_remove

2024-01-31 Thread Jens Axboe
On 1/31/24 6:28 AM, Edward Adam Davis wrote: > Delete critical sections that are time-consuming and protected by other > mutexes > to avoid this issue. What is "this issue"? -- Jens Axboe

Re: [Report] requests are submitted to hardware in reverse order from nvme/virtio-blk queue_rqs()

2024-01-25 Thread Jens Axboe
q, { if (blk_queue_quiesced(q)) return; + plug->mq_list = blk_plug_reverse_order(plug); q->mq_ops->queue_rqs(&plug->mq_list); } -- Jens Axboe

Re: [PATCH] badblocks: avoid checking invalid range in badblocks_check()

2023-12-23 Thread Jens Axboe
iple >> ranges handling") >> Reported-and-tested-by: Ira Weiny >> Signed-off-by: Coly Li >> Link: >> https://lore.kernel.org/nvdimm/3035e75a-9be0-4bc3-8d4a-6e52c207f...@leemhuis.info/ >> Cc: Dan Williams >> Cc: Geliang Tang >> Cc: Hannes Rein

Re: [PATCH] badblocks: avoid checking invalid range in badblocks_check()

2023-12-23 Thread Jens Axboe
ront range. > > This patch checkes whether 'prev >= 0' is true before calling > overlap_front(), to void such invalid operations. > > [...] Applied, thanks! [1/1] badblocks: avoid checking invalid range in badblocks_check() commit: 146e843f6b09271233c021b1677e561b7dc16303 Best regards, -- Jens Axboe

Re: [PATCH] block/rnbd-srv: Check for unlikely string overflow

2023-12-13 Thread Jens Axboe
ot;%s/%s", > | ^~ > 617 | dev_search_path, dev_name); > | ~~ > > [...] Applied, thanks! [1/1] block/rnbd-srv: Check for unlikely string overflow commit: 9e4bf6a08d1e127bcc4bd72557f2dfafc6bc7f41 Best regards, -- Jens Axboe

Re: [PATCH] virtio_blk: set the default scheduler to none

2023-12-07 Thread Jens Axboe
eed to happen here, but rather at the lower end. But there could be an argument to be made for having fewer commands coming out of virtio-blk, however. Would be interesting to test. -- Jens Axboe

Re: Merging raw block device writes

2023-11-28 Thread Jens Axboe
On 11/28/23 12:29 PM, Michael Kelley wrote: > From: Jens Axboe Sent: Monday, November 27, 2023 8:10 AM >> >> On 11/26/23 11:59 PM, h...@lst.de wrote: >>> On Sat, Nov 25, 2023 at 05:38:28PM +, Michael Kelley wrote: >>>> Hyper-V guests and the Azure c

Re: Merging raw block device writes

2023-11-27 Thread Jens Axboe
I/O scheduler. Reducing > the number of I/Os without an I/O scheduler isn't (and I'll argue > shouldn't) be a concern for the non I/O scheduler. Yep fully agree. -- Jens Axboe

Re: [PATCH v2] aoe: replace strncpy with strscpy

2023-10-03 Thread Jens Axboe
Applied, thanks! [1/1] aoe: replace strncpy with strscpy commit: 5e9b7cfc209b84d135993b8cb75ea383f24b2bba Best regards, -- Jens Axboe

Re: [PATCH v3] null_blk: replace strncpy with strscpy

2023-10-03 Thread Jens Axboe
] Applied, thanks! [1/1] null_blk: replace strncpy with strscpy commit: e1f2760ba3478fa3f8c48db8e91fbe3df8bea2f8 Best regards, -- Jens Axboe

Re: [PATCH v7 0/6] badblocks improvement for multiple bad block ranges

2023-09-25 Thread Jens Axboe
ock handling code commit: aa511ff8218b3fb328181fbaac48aa5e9c5c6d93 Best regards, -- Jens Axboe

Re: [PATCH v2] null_blk: refactor deprecated strncpy

2023-09-18 Thread Jens Axboe
On 9/18/23 1:25 AM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. Commit title again... -- Jens Axboe

Re: [PATCH] aoe: refactor deprecated strncpy

2023-09-18 Thread Jens Axboe
strscpy"? That's a lot more descriptive, as a) it's actually accurate, and b) this is what the patch does. You just sent another one with this refactor wording which makes zero sense, please resend this and others targeted at block with a proper description. -- Jens Axboe

Re: [PATCH] aoe: refactor deprecated strncpy

2023-09-15 Thread Jens Axboe
ded. > (Or more precisely, it's already zeroed and this function is called > once.) > > Reviewed-by: Kees Cook Change looks fine to me too, but for the love of $deity, please use a proper subject line for these kinds of patches. It's not refactoring anything. -- Jens Axboe

Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT

2023-08-02 Thread Jens Axboe
w, please also always add linux-block to the Cc list for block > driver patches that are even the slightest bit about the block > layer interface. Indeed. Particularly for these nowait changes, as some of them have been pretty broken in the past. -- Jens Axboe

Re: remove ->rw_page

2023-01-25 Thread Jens Axboe
ng it. There's no reason for this weird rw_page interface to exist. -- Jens Axboe

Re: [PATCH 01/10] iss-simdisk: use bvec_kmap_local in simdisk_submit_bio

2022-03-04 Thread Jens Axboe
commit: 3eddaa60b8411c135d1c71090dea9b59ff3f2e26 [10/10] floppy: use memcpy_{to,from}_bvec commit: 13d4ef0f66b7ee9415e101e213acaf94a0cb28ee Best regards, -- Jens Axboe

Re: [PATCH v3] nvdimm/btt: do not call del_gendisk() if not needed

2021-11-03 Thread Jens Axboe
On Wed, 3 Nov 2021 09:58:43 -0700, Luis Chamberlain wrote: > del_gendisk() should not called if the disk has not been added. Fix this. > > Applied, thanks! [1/1] nvdimm/btt: do not call del_gendisk() if not needed commit: 3aefb5ee843fbe4789d03bb181e190d462df95e4 Best regards,

Re: [PATCH 06/13] nvdimm/blk: avoid calling del_gendisk() on early failures

2021-11-02 Thread Jens Axboe
the last few patches to add __must_check for the final >> add_disk() error handling changes. > > True, I don't think I can get it nuked in time, so you can add my > Reviewed-by for this one. Luis, I lost track of the nv* patches from this discussion. If you want them in 5.16 and they are reviewed, please do resend and I'll pick them up for the middle-of-merge-window push. -- Jens Axboe

Re: (subset) [PATCH 00/13] block: add_disk() error handling stragglers

2021-10-30 Thread Jens Axboe
; mtd/ubi/block: add error handling support for add_disk() > > [...] Applied, thanks! [01/13] block/brd: add error handling support for add_disk() commit: e1528830bd4ebf435d91c154e309e6e028336210 Best regards, -- Jens Axboe

Re: (subset) [PATCH 00/13] block: add_disk() error handling stragglers

2021-10-30 Thread Jens Axboe
d749f76040f782f0618656cd23e33 [11/13] ps3vram: add error handling support for add_disk() commit: 3c30883acab1d20ecbd3c48dc12b147b51548742 Best regards, -- Jens Axboe

Re: [PATCH v2 00/10] block: second batch of add_disk() error handling conversions

2021-09-27 Thread Jens Axboe
On 9/27/21 4:00 PM, Luis Chamberlain wrote: > This is the second series of driver conversions for add_disk() > error handling. You can find this set and the rest of the 7th set of > driver conversions on my 20210927-for-axboe-add-disk-error-handling > branch [0]. Applied 1, thank

Re: [PATCH] io_uring: ensure cq_entries is at least equal to or greater than sq_entries

2019-10-23 Thread Jens Axboe
? I think you want to keep that check. sq_entries being zero is already checked and failed at this point. So I think the patch looks fine from that perspective. Is there really a strong reason to disallow this? Yes, it could cause overflows, but it's just doing what was asked for. The normal case is of course cq_entries being much larger than sq_entries. -- Jens Axboe

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-23 Thread Jens Axboe
On 10/23/19 6:04 AM, Wolfgang Bumiller wrote: > On Thu, Oct 17, 2019 at 03:28:56PM -0600, Jens Axboe wrote: >> This is in preparation for adding opcodes that need to modify files >> in a process file table, either adding new ones or closing old ones. >> >> If an opc

Re: liburing 0.2 release?

2019-10-21 Thread Jens Axboe
On 10/21/19 9:47 AM, Jeff Moyer wrote: > Jens Axboe writes: > >> On 10/9/19 2:34 AM, Stefan Hajnoczi wrote: >>> Hi Jens, >>> I would like to add a liburing package to Fedora. The liburing 0.1 >>> release was in January and there have been many changes si

Re: [RFC PATCH 1/2] block: add support for redirecting IO completion through eBPF

2019-10-21 Thread Jens Axboe
ing confused as well. I'm not against adding BPF functionality to the block layer, but this one seems a bit contrived. -- Jens Axboe

Re: [PATCH liburing] Add test for overflow of timeout request's sequence

2019-10-21 Thread Jens Axboe
>req2->req4->req3, which the right order should be > req1->req2->req3->req4. > 4. setup two nop requests. And the timeout requests will return > correctly with the patch. > > Add this testcase to cover it. Thanks, applied. -- Jens Axboe

Re: [PATCH] io_uring: fix up O_NONBLOCK handling for sockets

2019-10-21 Thread Jens Axboe
On 10/20/19 6:23 PM, Jackie Liu wrote: > > >> 2019年10月17日 23:24,Jens Axboe 写道: >> >> We've got two issues with the non-regular file handling for non-blocking >> IO: >> >> 1) We don't want to re-do a short read in full for a non-regular file, &

[GIT PULL] Block fixes for 5.4-rc4

2019-10-18 Thread Jens Axboe
linus-2019-10-18 Ard Biesheuvel (1): nvme: retain split access workaround for capability reads Damien Le Moal (1): block: Fix elv_support_iosched() Dan Williams (1): libata/ahci: Fix PCS quirk application Jens

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 12:06 PM, Jann Horn wrote: > On Fri, Oct 18, 2019 at 7:05 PM Jens Axboe wrote: >> On 10/18/19 10:36 AM, Jens Axboe wrote: >>>> Ignoring the locking elision, basically the logic is now this: >>>> >>>> static void

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 10:36 AM, Jens Axboe wrote: >> Ignoring the locking elision, basically the logic is now this: >> >> static void io_sq_wq_submit_work(struct work_struct *work) >> { >> struct io_kiocb *req = container_of(work, struct io_kiocb, work); >>

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 10:20 AM, Jann Horn wrote: > On Fri, Oct 18, 2019 at 5:55 PM Jens Axboe wrote: >> On 10/18/19 9:00 AM, Jens Axboe wrote: >>> On 10/18/19 8:52 AM, Jann Horn wrote: >>>> On Fri, Oct 18, 2019 at 4:43 PM Jens Axboe wrote: >>>>> >>>

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 9:00 AM, Jens Axboe wrote: > On 10/18/19 8:52 AM, Jann Horn wrote: >> On Fri, Oct 18, 2019 at 4:43 PM Jens Axboe wrote: >>> >>> On 10/18/19 8:40 AM, Jann Horn wrote: >>>> On Fri, Oct 18, 2019 at 4:37 PM Jens Axboe wrote: >>>>> >

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 8:52 AM, Jann Horn wrote: > On Fri, Oct 18, 2019 at 4:43 PM Jens Axboe wrote: >> >> On 10/18/19 8:40 AM, Jann Horn wrote: >>> On Fri, Oct 18, 2019 at 4:37 PM Jens Axboe wrote: >>>> >>>> On 10/18/19 8:34 AM, Jann Horn wrote: >>

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 8:40 AM, Jann Horn wrote: > On Fri, Oct 18, 2019 at 4:37 PM Jens Axboe wrote: >> >> On 10/18/19 8:34 AM, Jann Horn wrote: >>> On Fri, Oct 18, 2019 at 4:01 PM Jens Axboe wrote: >>>> On 10/17/19 8:41 PM, Jann Horn wrote: >>>>>

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/18/19 8:34 AM, Jann Horn wrote: > On Fri, Oct 18, 2019 at 4:01 PM Jens Axboe wrote: >> On 10/17/19 8:41 PM, Jann Horn wrote: >>> On Fri, Oct 18, 2019 at 4:01 AM Jens Axboe wrote: >>>> This is in preparation for adding opcodes that need to modify files >&g

Re: [RFC v3] io_uring: add set of tracing events

2019-10-18 Thread Jens Axboe
On 10/18/19 2:59 AM, Dmitry Dolgov wrote: >> On Fri, Oct 18, 2019 at 1:28 AM Jens Axboe wrote: >> >> Looks good to me, I've applied it for some testing. Thanks! > > Thank you! Already saved me some time in verifying some activity, so well worth it! -- Jens Axboe

Re: [PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-18 Thread Jens Axboe
On 10/17/19 8:41 PM, Jann Horn wrote: > On Fri, Oct 18, 2019 at 4:01 AM Jens Axboe wrote: >> This is in preparation for adding opcodes that need to modify files >> in a process file table, either adding new ones or closing old ones. > > Closing old ones would be tricky.

Re: [PATCH RESEND] null_blk: return fixed zoned reads > write pointer

2019-10-17 Thread Jens Axboe
On 10/17/19 3:19 PM, Chaitanya Kulkarni wrote: > From: Ajay Joshi > > A zoned block device maintains a write pointer within a zone, and reads > beyond the write pointer are undefined. Fill data buffer returned above > the write pointer with 0xFF. Applied, thanks. -- Jens Axboe

Re: [RFC v3] io_uring: add set of tracing events

2019-10-17 Thread Jens Axboe
case is how io_uring optimizations (e.g. registered files) are >utilized. Looks good to me, I've applied it for some testing. Thanks! -- Jens Axboe

[PATCHSET] io_uring: add support for accept(4)

2019-10-17 Thread Jens Axboe
| 3 ++ include/uapi/linux/io_uring.h | 7 +++- net/socket.c | 65 ++- 4 files changed, 103 insertions(+), 28 deletions(-) -- Jens Axboe

[PATCH 1/3] io_uring: add support for async work inheriting files table

2019-10-17 Thread Jens Axboe
a reference to the process file table. When the work is completed, the reference is dropped again. Signed-off-by: Jens Axboe --- fs/io_uring.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 635856023fdf..ad462237275e

[PATCH 3/3] io_uring: add support for IORING_OP_ACCEPT

2019-10-17 Thread Jens Axboe
This allows an application to call accept4() in an async fashion. Like other opcodes, we first try a non-blocking accept, then punt to async context if we have to. Signed-off-by: Jens Axboe --- fs/io_uring.c | 35 +++ include/uapi/linux/io_uring.h

[PATCH 2/3] net: add __sys_accept4_file() helper

2019-10-17 Thread Jens Axboe
ler Cc: net...@vger.kernel.org Signed-off-by: Jens Axboe --- include/linux/socket.h | 3 ++ net/socket.c | 65 ++ 2 files changed, 44 insertions(+), 24 deletions(-) diff --git a/include/linux/socket.h b/include/linux/socket.h index fc0bed59f

Re: [PATCH] io_uring: fix logic error in io_timeout

2019-10-17 Thread Jens Axboe
On 10/16/19 10:12 PM, yangerkun wrote: > If ctx->cached_sq_head < nxt_sq_head, we should add UINT_MAX to tmp, not > tmp_nxt. Applied, thanks. -- Jens Axboe

[PATCH] io_uring: fix up O_NONBLOCK handling for sockets

2019-10-17 Thread Jens Axboe
REQ_F_NOWAIT is set. Cc: sta...@vger.kernel.org Reported-by: Hrvoje Zeba Signed-off-by: Jens Axboe --- fs/io_uring.c | 55 +++ 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index d2cb277da2f4..a4ee5

[PATCH] io_uring: add support for canceling timeout requests

2019-10-16 Thread Jens Axboe
We might have cases where the need for a specific timeout is gone, add support for canceling an existing timeout operation. This works like the POLL_REMOVE command, where the application passes in the user_data of the timeout it wishes to cancel in the sqe->addr field. Signed-off-by: Jens Ax

  1   2   3   4   5   6   7   8   9   10   >