Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Kent Overstreet
On Thu, Jan 30, 2025 at 05:34:18PM -0800, Dave Hansen wrote: > On 1/30/25 16:56, Kent Overstreet wrote: > > On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote:... > >> Any suggestions for fully describing the situation? I tried to sprinkle > >> comments liberally but I'm also painfully awa

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Dave Hansen
On 1/30/25 16:56, Kent Overstreet wrote: > On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote:... >> Any suggestions for fully describing the situation? I tried to sprinkle >> comments liberally but I'm also painfully aware that I'm not doing a >> perfect job of talking about the fs code.

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Kent Overstreet
On Fri, Jan 31, 2025 at 08:36:29AM +1100, Dave Chinner wrote: > On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote: > > On 1/29/25 23:44, Kent Overstreet wrote: > > > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > > >> tl;dr: The VFS and several filesystems have some suspec

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Kent Overstreet
On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote: > On 1/29/25 23:44, Kent Overstreet wrote: > > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > >> tl;dr: The VFS and several filesystems have some suspect prefaulting > >> code. It is unnecessarily slow for the common case

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Dave Chinner
On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote: > On 1/29/25 23:44, Kent Overstreet wrote: > > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > >> tl;dr: The VFS and several filesystems have some suspect prefaulting > >> code. It is unnecessarily slow for the common case

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Dave Hansen
On 1/29/25 23:44, Kent Overstreet wrote: > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: >> tl;dr: The VFS and several filesystems have some suspect prefaulting >> code. It is unnecessarily slow for the common case where a write's >> source buffer is resident and does not need to be

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-29 Thread Kent Overstreet
On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > tl;dr: The VFS and several filesystems have some suspect prefaulting > code. It is unnecessarily slow for the common case where a write's > source buffer is resident and does not need to be faulted in. > > Move these "prefaulting" oper

[PATCH 0/7] Move prefaulting into write slow paths

2025-01-29 Thread Dave Hansen
tl;dr: The VFS and several filesystems have some suspect prefaulting code. It is unnecessarily slow for the common case where a write's source buffer is resident and does not need to be faulted in. Move these "prefaulting" operations to slow paths where they ensure forward progress but they do not