Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-25 Thread Kent Overstreet
On Sat, Oct 26, 2024 at 12:23:40AM +, Piotr Zalewski wrote: > > > > > > Sent with Proton Mail secure email. > > On Saturday, October 26th, 2024 at 2:16 AM, Kent Overstreet > wrote: > > > On Fri, Oct 25, 2024 at 08:11:50PM -0400, Kent Overstreet wrote: > > > > > On Wed, Oct 23, 2024 at

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-25 Thread Piotr Zalewski
Sent with Proton Mail secure email. On Saturday, October 26th, 2024 at 2:16 AM, Kent Overstreet wrote: > On Fri, Oct 25, 2024 at 08:11:50PM -0400, Kent Overstreet wrote: > > > On Wed, Oct 23, 2024 at 03:33:22PM +0800, Alan Huang wrote: > > > > > On Oct 23, 2024, at 15:21, Piotr Zalewski

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-25 Thread Piotr Zalewski
Hi Alan and all, On Wednesday, October 23rd, 2024 at 10:06 AM, Piotr Zalewski wrote: > Hi Alan, > > On Wednesday, October 23rd, 2024 at 9:33 AM, Alan Huang mmpgour...@gmail.com > wrote: > > > On Oct 23, 2024, at 15:21, Piotr Zalewski pz010001011...@proton.me wrote: > > > > > Add NULL check for

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-25 Thread Kent Overstreet
On Fri, Oct 25, 2024 at 08:11:50PM -0400, Kent Overstreet wrote: > On Wed, Oct 23, 2024 at 03:33:22PM +0800, Alan Huang wrote: > > On Oct 23, 2024, at 15:21, Piotr Zalewski wrote: > > > > > > Add NULL check for key returned from bch2_btree_and_journal_iter_peek in > > > btree_node_iter_and_journa

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-25 Thread Kent Overstreet
On Fri, Oct 25, 2024 at 11:39:38PM +, Piotr Zalewski wrote: > Hi Alan and all, > > On Wednesday, October 23rd, 2024 at 10:06 AM, Piotr Zalewski > wrote: > > > Hi Alan, > > > > On Wednesday, October 23rd, 2024 at 9:33 AM, Alan Huang > > mmpgour...@gmail.com wrote: > > > > > On Oct 23, 2024,

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-25 Thread Kent Overstreet
On Wed, Oct 23, 2024 at 03:33:22PM +0800, Alan Huang wrote: > On Oct 23, 2024, at 15:21, Piotr Zalewski wrote: > > > > Add NULL check for key returned from bch2_btree_and_journal_iter_peek in > > btree_node_iter_and_journal_peek to avoid NULL ptr dereference in > > bch2_bkey_buf_reassemble. > >

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-23 Thread Piotr Zalewski
Hi Alan, On Wednesday, October 23rd, 2024 at 9:33 AM, Alan Huang wrote: > On Oct 23, 2024, at 15:21, Piotr Zalewski pz010001011...@proton.me wrote: > > > Add NULL check for key returned from bch2_btree_and_journal_iter_peek in > > btree_node_iter_and_journal_peek to avoid NULL ptr dereference

Re: [PATCH] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal_peek

2024-10-23 Thread Alan Huang
On Oct 23, 2024, at 15:21, Piotr Zalewski wrote: > > Add NULL check for key returned from bch2_btree_and_journal_iter_peek in > btree_node_iter_and_journal_peek to avoid NULL ptr dereference in > bch2_bkey_buf_reassemble. It would be helpful if the commit message explained why k.k is null in thi