Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Kent Overstreet
On Thu, Jan 30, 2025 at 05:34:18PM -0800, Dave Hansen wrote: > On 1/30/25 16:56, Kent Overstreet wrote: > > On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote:... > >> Any suggestions for fully describing the situation? I tried to sprinkle > >> comments liberally but I'm also painfully awa

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Dave Hansen
On 1/30/25 16:56, Kent Overstreet wrote: > On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote:... >> Any suggestions for fully describing the situation? I tried to sprinkle >> comments liberally but I'm also painfully aware that I'm not doing a >> perfect job of talking about the fs code.

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Kent Overstreet
On Fri, Jan 31, 2025 at 08:36:29AM +1100, Dave Chinner wrote: > On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote: > > On 1/29/25 23:44, Kent Overstreet wrote: > > > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > > >> tl;dr: The VFS and several filesystems have some suspec

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Kent Overstreet
On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote: > On 1/29/25 23:44, Kent Overstreet wrote: > > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > >> tl;dr: The VFS and several filesystems have some suspect prefaulting > >> code. It is unnecessarily slow for the common case

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Dave Chinner
On Thu, Jan 30, 2025 at 08:04:49AM -0800, Dave Hansen wrote: > On 1/29/25 23:44, Kent Overstreet wrote: > > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: > >> tl;dr: The VFS and several filesystems have some suspect prefaulting > >> code. It is unnecessarily slow for the common case

Re: [GIT PULL] bcachefs fixes for 6.14-rc1

2025-01-30 Thread pr-tracker-bot
The pull request you sent on Wed, 29 Jan 2025 15:17:38 -0500: > git://evilpiepirate.org/bcachefs.git tags/bcachefs-2025-01-29 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8080ff5ac656b9ca6c282e4044be19d2b8a837df Thank you! -- Deet-doot-dot, I am a bot. https://kor

Re: [PATCH 0/7] Move prefaulting into write slow paths

2025-01-30 Thread Dave Hansen
On 1/29/25 23:44, Kent Overstreet wrote: > On Wed, Jan 29, 2025 at 10:17:49AM -0800, Dave Hansen wrote: >> tl;dr: The VFS and several filesystems have some suspect prefaulting >> code. It is unnecessarily slow for the common case where a write's >> source buffer is resident and does not need to be

Re: [PATCH 11/21] bcachefs: improve the eytzinger0_find_le tests

2025-01-30 Thread Andreas Gruenbacher
On Thu, Jan 30, 2025 at 12:36 AM Kent Overstreet wrote: > I've fetched it to my repo and added it to the CI: > > https://evilpiepirate.org/~testdashboard/ci?user=kmo&branch=eytzinger Ah, the following went wrong in "bcachefs: convert eytzinger0_find to be 1-based": diff --git a/fs/bcachefs/e

Re: [PATCH 01/21] bcachefs: remove dead code in is_aligned

2025-01-30 Thread Eric Herman
Hello Andreas, On 2025-01-29 14:19, Andreas Gruenbacher wrote: On Wed, Jan 29, 2025 at 11:32 AM Eric Herman wrote: Hello Andreas, On 2025-01-28 17:38, Andreas Gruenbacher wrote: This statement does nothing. I would suggest this statement does nothing only in the case of #ifndef CONFIG_HAVE_