Re: [PATCH 05/07] Watchdog: DA9052/53 watchdog support v1

2012-03-30 Thread Wolfram Sang
e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

Re: SD/MMC for i.MX51

2010-10-19 Thread Wolfram Sang
ot > log) I didn't follow this thread very closely (actually I'm on holiday :)), but have you disabled CONFIG_SYSFS_DEPRECATED? This causes issues with newer udevs if activated. One of them is that mmcblk devices are not created when initally booting. -- Pengutronix e.K.

Re: [PATCH 0/5] make sdhci device drivers self registered

2011-03-21 Thread Wolfram Sang
> If you don't get any other feedback and Chris is happy with the I would like to have a look at it, please give me a few days. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengut

Re: [PATCH 2/5] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data

2011-04-19 Thread Wolfram Sang
to handle quirks across io-accessor calls */ > + > + /* migrate from sdhci_of_host */ > + unsigned int clock; > + u16 xfer_mode_shadow; xfer_mode_shadow can be merged into scratchpad. They both fix the same issue. -- Pengutronix e.K. | Wo

Re: [PATCH 1/5] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-04-19 Thread Wolfram Sang
); > err_request: > sdhci_free_host(host); > err: > - printk(KERN_ERR"Probing of sdhci-pltfm failed: %d\n", ret); > - return ret; > + pr_err("%s failed %d\n", __func__, ret); dev_err? > + return NULL; > } > I d

Re: [PATCH 0/5] consolidate sdhci pltfm & OF drivers and get them self registered

2011-04-19 Thread Wolfram Sang
Also, I think the next version of this series should have all makers of a sdhci-pltfm user CCed so we give them a chance to report breakage. Or donate acks or tested-by. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 3/5] mmc: sdhci: make sdhci-of device drivers self registered

2011-04-19 Thread Wolfram Sang
"); > +MODULE_LICENSE("GPL v2"); Please double check the authors. It is based on the fsl driver, but the copyright should go to * Copyright (C) 2009 The GameCube Linux Team * Copyright (C) 2009 Albert Herranz I think. -- Pengutronix e.K. | Wolfram

Re: [PATCH 4/5] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-04-19 Thread Wolfram Sang
sta Software, Inc. > + * Author: Anton Vorontsov > + * > + * Copyright (c) 2010 Pengutronix e.K. > + * Author: Wolfram Sang > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published b

Re: [PATCH 5/5] mmc: sdhci: merge two sdhci-pltfm.h into one

2011-04-19 Thread Wolfram Sang
f-by: Shawn Guo Reviewed-by: Wolfram Sang -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ lin

Re: [PATCH 0/5] consolidate sdhci pltfm & OF drivers and get them self registered

2011-04-19 Thread Wolfram Sang
his is very much welcome. I'd suggest waiting for Shawn's interface to stabilize, though. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Descrip

Re: [PATCH 1/5] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-04-21 Thread Wolfram Sang
ally I do not even know how v2+ is stated. Do you have an example > for me to refer? Check davinci_mmc.c (or grep for 'any later version'). -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://w

Re: [PATCH 0/5] consolidate sdhci pltfm & OF drivers and get them self registered

2011-04-26 Thread Wolfram Sang
ose users anyway, it's not an argument here. sdhci-dove needs to overload readw/readl. If there is a user not needings such, i.e. only plain quirks (or even nothing, what a dream!), then a generic driver might be worthwhile. Can wait until we see such a user, though. Regards, Wolfram -- Pen