PLL) / (core_ratio + 1);
This output is not dout_apll.
Please fix it.
> + dout_apll /= (core2_ratio + 1);
>
> return dout_apll;
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
AX_CHANNEL 5
>
> +/* Enable devicetree support */
> +#define CONFIG_OF_LIBFDT
> +
Why you separate this patch?
Thanks.
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
L [27:24]
> */
> +#ifdef CONFIG_EXYNOS5
> + sel = readl(&clk->src_peric0);
> +#else
> sel = readl(&clk->src_peril0);
> +#endif
NAK.
We don't allow to using ifdef for separating SoCs.
Please refer s5pc1xx case for solve
Options */
> #define CONFIG_SAMSUNG 1 /* in a SAMSUNG core */
> #define CONFIG_S5P 1 /* S5P Family */
> +#define CONFIG_EXYNOS4 1 /* EXYNOS4 Family */
> #define CONFIG_EXYNOS4210 1 /* which is a EXYNOS
nos/clock.c | 15 +--
> 1 files changed, 9 insertions(+), 6 deletions(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
-)
>
applied to u-boot-samsung.
Thanks,Minkyu Kang.--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
s_s5pcXXX check.
>> Is it a acceptable solution? Or is it necessary to write SoC specific
>> function
>> in clock.c as done in case of s5pc1xx/clock.c.
>>
>> Please Advice
> Removing CONFIG_EXYNOS5 and following s5pc1xx case will not allow to
> reuse t
Dear Chander Kashyap,
On 5 January 2012 19:31, Chander Kashyap wrote:
> Hi Minkyu Kang,
>
> On 5 January 2012 12:13, Minkyu Kang wrote:
>> Dear Chander Kashyap,
>>
>> On 27 December 2011 17:48, Chander Kashyap
>> wrote:
>>>>> > Torsten
>
> +#define exynos5_gpio_part1_get_nr(bank, pin) \
If it support just one part then remove part1. (exynos5_gpio_get_nr)
> + ((unsigned int) &(((struct exynos5_gpio_part1 *) \
> + EXYNOS5_GPIO_PART1_BASE)->bank)) \
> + - EXYNOS5_GP
efile
> create mode 100644 board/samsung/smdk5250/lowlevel_init.S
> create mode 100644 board/samsung/smdk5250/mem_setup.S
> create mode 100644 board/samsung/smdk5250/smdk5250.c
> create mode 100644 board/samsung/smdk5250/smdk5250_setup.h
> create mo
; + } else if (cpu_is_exynos4()) {
> + if (nr < EXYNOS4_GPIO_PART1_MAX)
> + return EXYNOS4_GPIO_PART1_BASE;
> + else
> + return EXYNOS4_GPIO_PART2_BASE;
> + }
> else
> - return EXYNOS4_GPIO_PART2_BASE;
> -
> - return 0;
> + return 0;
Please remove "else", and do return.
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
GPIO_PULL_NONE);
> s5p_gpio_cfg_pin(&gpio1->a1, i,
> GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
> --
Actually we don't have to set all of UARTs.
Because, we only use UART2 for serial.
I will post new patch for it.
Thanks
Minkyu K
k5250/lowlevel_init.S
> create mode 100644 board/samsung/smdk5250/mmc_boot.c
> create mode 100644 board/samsung/smdk5250/setup.h
> create mode 100644 board/samsung/smdk5250/smdk5250.c
> create mode 100644 board/samsung/smdk5250/tzpc_init.c
> create mo
++
>> include/configs/smdk5250.h | 11 -
>> 2 files changed, 103 insertions(+), 2 deletions(-)
>>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
1 files changed, 109 insertions(+), 0 deletions(-)
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
ed with Kyungmin.
>From now, let's called "exynos" for common name including s5pc1xx and
s5pc2xx and exynos4 and exynos5.. etc.
>
>> number of tzpc. It can be covered one exynos_tzpc. or we can define
>> it for each SoC.
> One structure is enough as fields are same.
>
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
+ || (EXYNOS_ID == (#type[sizeof(#type) - 2] - '0'))) \
> + ? 1 : 0; \
> }
>
Sorry, I can't understand this patch.
What is it for?
Thanks.
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
Dear Chander Kashyap,
On 15 March 2012 12:34, Chander Kashyap wrote:
> TZPC IP is common across Exynos based SoC'c. Renaming exynos5_tzpc
> in arch/arm/include/asm/arch-exynos/tzpc.h to exynos_tzpc will allow generic
> usase of tzpc.
>
> Also modify board/samsung/smdk5250/tzpc_init.c to use exyno
ta at
> +* 14K-4 offset.
> +*
> +* This function takes two filenames:
> +* IN "u-boot-spl.bin" and
> +* OUT "u-boot-mmc-spl.bin" as filenames.
> +* It reads the "u-boot-spl.bin" in 16K buffer.
> +* It calculates checksum of 14K-4 Bytes and
te mode 100644 board/samsung/origen/origen.c
> create mode 100644 include/configs/origen.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2bba7b4..bb98115 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -704,6 +704,7 @@ Minkyu Kang
> Chander Kashya
ot-samsung.git;a=commitdiff;h=095ae309787f242067d122d98a7025b4136aadc0
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
t; mmc_spl/board/samsung/smdkv310/u-boot.lds | 2 ++
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
gt; get_bad_stack
> bad_save_user_regs
> bl do_undefined_instruction
>
> Signed-off-by: Chander Kashyap
> ---
> mmc_spl/board/samsung/smdkv310/Makefile | 1 +
> mmc_spl/board/samsung/smdkv310/mmc_boot.c | 30
>
rd/samsung/origen/origen.c
> create mode 100644 board/samsung/origen/origen_setup.h
> create mode 100644 include/configs/origen.h
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
les changed, 221 insertions(+), 1 deletions(-)
> create mode 100644 board/samsung/origen/mmc_boot.c
> create mode 100644 board/samsung/origen/tools/mkv310_image.c
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
;= ~(1 << 1);
>
>
> I know these were like this before, but those numbers are awfully
> magical. You should really define constants for them.
We decided to use comments instead of defines.
>
> Also, this seems like a very confusing way to do this? Why not clear
> bo
Dear Wolfgang Denk,
On 1 September 2011 14:51, Wolfgang Denk wrote:
> Dear Minkyu Kang,
>
> In message
> you
> wrote:
>>
>> > I know these were like this before, but those numbers are awfully
>> > magical. You should really define constants for them.
&
ie
> ---
> board/samsung/origen/Makefile | 6 +++---
> spl/Makefile | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
l
ed-by: Chander Kashyap
>> ---
>> include/configs/origen.h | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
applied to u-boot-samsung.
Thanks.
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailin
> delete mode 100644 mmc_spl/board/samsung/smdkv310/u-boot.lds
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
xx/cpu.h:89: if (cpu_is_s5pc210())
\
arch-s5pc2xx/gpio.h:35:struct s5pc210_gpio_part1 {
arch-s5pc2xx/gpio.h:54:struct s5pc210_gpio_part2 {
arch-s5pc2xx/gpio.h:78:struct s5pc210_gpio_part3 {
arch-s5pc2xx/gpio.h:95:#define s5pc210_gpio_part1_get_nr(bank, pin) \
arch-s5pc2xx/gpio.h:96: ((unsigned int) &(((struct s5pc210_gpio_part1 *) \
arch-s5pc2xx/gpio.h:101:#define GPIO_PART1_MAX ((sizeof(struct
s5pc210_gpio_part1) \
arch-s5pc2xx/gpio.h:104:#define s5pc210_gpio_part2_get_nr(bank, pin) \
arch-s5pc2xx/gpio.h:105:(((unsigned int) &(((struct
s5pc210_gpio_part2 *) \
Similarly, you can found such things in board files and config files.
Please modify them also.
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
t; rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/uart.h (100%)
>
Applying: S5PC2XX: Rename S5pc2XX to exynos4
error: patch failed: boards.cfg:195
error: boards.cfg: patch does not apply
Patch failed at 0001 S5PC2XX: Rename S5pc2XX to exynos4
I couldn't test your patch.
Please remake the patch.
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
rch-s5pc2xx => arch-exynos}/gpio.h (84%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos}/mmc.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos}/pwm.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos}/sromc.h (100%)
> rename arch/arm/
On 15 October 2012 22:06, Chander Kashyap wrote:
> From: Minkyu Kang
>
> Based upon single SoC there can be multiple variants.
> This patch add support to match the complete product ID.
>
> Signed-off-by: Chander Kashyap
> ---
> Changes from v1:
> - Author nam
On 15 October 2012 20:58, Chander Kashyap wrote:
> From: Minkyu Kang
>
> Moved the common code to calculate pll clock rate to new function
> exynos_get_pll_clk().
>
> Signed-off-by: Chander Kashyap
> ---
> Changes from v1:
> - Author name changed
> arc
t;> 3 files changed, 402 insertions(+), 7 deletions(-)
>>
Patches are looks good.
Please rebase this patchset.
Thanks.
Minkyu Kang.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
On 26/12/12 15:13, Minkyu Kang wrote:
> From: Chander Kashyap
>
> This patch adds clock structure for Exynos4x12.
>
> Signed-off-by: Chander Kashyap
> Signed-off-by: Minkyu Kang
> ---
> Changes since v2:
> - None
>
> arch/arm/inclu
On 26/12/12 15:13, Minkyu Kang wrote:
> From: Chander Kashyap
>
> This patch adds gpio structure for Exynos4x12.
>
> Signed-off-by: Chander Kashyap
> Signed-off-by: Minkyu Kang
> ---
> Changes since v2:
> - None
>
> arch/arm/incl
From: Chander Kashyap
This patch populates base addresses of Exynos4x12 registers.
Signed-off-by: Chander Kashyap
Signed-off-by: Minkyu Kang
---
Changes since v2:
- rebased, add SPI and I2S addresses.
arch/arm/include/asm/arch-exynos/cpu.h | 48
1
On 26/12/12 15:13, Minkyu Kang wrote:
> From: Chander Kashyap
>
> This patch populates base addresses of Exynos4x12 registers.
>
> Signed-off-by: Chander Kashyap
> Signed-off-by: Minkyu Kang
> ---
> Changes since v2:
> - rebased, add SPI and I2S addresses.
From: Chander Kashyap
This patch adds gpio structure for Exynos4x12.
Signed-off-by: Chander Kashyap
Signed-off-by: Minkyu Kang
---
Changes since v2:
- None
arch/arm/include/asm/arch-exynos/gpio.h | 85 +++
1 file changed, 85 insertions(+)
diff --git a
From: Chander Kashyap
This patch adds clock structure for Exynos4x12.
Signed-off-by: Chander Kashyap
Signed-off-by: Minkyu Kang
---
Changes since v2:
- None
arch/arm/include/asm/arch-exynos/clock.h | 276 ++
1 file changed, 276 insertions(+)
diff --git
> +#define CONFIG_SYS_NO_FLASH 1
> +#undef CONFIG_CMD_IMLS
> +#define CONFIG_IDENT_STRING " for SMDKC210/V310"
> +
> +/* base address for uboot */
> +#define CONFIG_SYS_PHY_UBOOT_BASE (CONFIG_SYS_SDRAM_BASE + 0x3e0)
> +#define CONFIG_SYS_MMC_UBOOT_START CONFIG_SYS_PHY_UBOOT_BASE
> +
> +#ifdef CONFIG_USE_IRQ
> +#define CONFIG_STACKSIZE_IRQ (4*1024) /* IRQ stack */
> +#define CONFIG_STACKSIZE_FIQ (4*1024) /* FIQ stack */
> +#endif
> +
> +#define CONFIG_CLK_1000_400_200
> +#define CONFIG_BOOTM_LINUX 1
Already defined at config_cmd_default.h
Please remove it.
> +#define CONFIG_INCLUDE_TEST
> +#define CONFIG_IMAGE_BOOT
> +#define USE_MMC2
> +#define MMC_MAX_CHANNEL 4
What is these defines?
> +
> +#define CONFIG_ENV_IS_IN_MMC 1
> +#define CONFIG_SYS_MMC_ENV_DEV 0
> +#define CONFIG_ENV_SIZE (16 << 10) /* 16 KB */
> +#define RESERVE_BLOCK_SIZE (512)
> +#define BL1_SIZE (16 << 10) /*16 K reserved for BL1*/
> +#define CONFIG_ENV_OFFSET (RESERVE_BLOCK_SIZE + BL1_SIZE)
> +#define CONFIG_DOS_PARTITION 1
> +
> +#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR -
> 0x100)
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR -
GENERATED_GBL_DATA_SIZE)
is better.
> +
> +#undef CONFIG_SKIP_RELOCATE_UBOOT
> +#undef CONFIG_USE_NOR_BOOT
> +#undef CONFIG_USE_IRQ
> +#undef CONFIG_NO_SDMMC_DETECTION
> +#undef CONFIG_USB_STORAGE
remove these defines.
Please don't make private defines if you don't have special reason.
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
initialize */
>> > + bl mem_ctrl_asm_init
>>
>> Is it OK that memory initialize on u-boot?
>> Maybe only do on mmc spl?
>
> This is generic initialisation Code. We need this in case of NOR boot. This
> initialisation
> is excluded in case of SPL boot.
00644 arch/arm/include/asm/arch-s5pc1xx/sromc.h
>
No. Please make it one patch.
And please use git mv instead of rm and cp.
Thanks.
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
IO_DRV_2X 0x1
> -#define GPIO_DRV_3X 0x2
> +#define GPIO_DRV_2X 0x2
> +#define GPIO_DRV_3X 0x1
Please make orders correctly (0x0, 0x1, 0x2, 0x3)
> #define GPIO_DRV_4X 0x3
> #define GPIO_DRV_FAST 0x0
> #define GPIO_DRV_SLOW 0x1
Nice catch : )
Could
quot; and please fix it.
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
Dear Chander Kashyap,
On 18 April 2011 12:50, Chander Kashyap wrote:
>
> No need to change. As existing gpio configuration is as per s5pc1xx
> specification.
According to S5PC110 TRM, DRV levels are as following,
00 = 1x
10 = 2x
01 = 3x
11 = 4x
Please fix it at s5pc1xx also.
Than
644 arch/arm/cpu/armv7/s5p-common/sromc.c
> delete mode 100644 arch/arm/cpu/armv7/s5pc1xx/sromc.c
> delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/smc.h
> create mode 100644 arch/arm/include/asm/arch-s5pc1xx/sromc.h
>
Thanks.
Minkyu Kang.
--
from. prom.
www.promsoft.net
___
Macro value order fixed.
> - Added Changes for S5PC1XX.
>
> arch/arm/include/asm/arch-s5pc1xx/gpio.h | 4 ++--
> arch/arm/include/asm/arch-s5pc2xx/gpio.h | 7 +++
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
applied to u-boot-samsung
Thanks
Min
on/sromc.c
> delete mode 100644 arch/arm/cpu/armv7/s5pc1xx/sromc.c
> delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/smc.h
> create mode 100644 arch/arm/include/asm/arch-s5pc1xx/sromc.h
>
applied to u-boot-samsung
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net
opy_sd_mmc_to_mem)(0x2488);
> + copy_bl2(65, BL2_SIZE_BLOC_COUNT, (u32 *)CONFIG_SYS_PHY_UBOOT_BASE);
CONFIG_SYS_PHY_UBOOT_BASE -> CONFIG_SYS_TEXT_BASE?
> +}
> +
> +void board_init_f(unsigned long bootflag)
> +{
> + __at
to s5p-common/sromc.c for SROM related
>> subroutines.
>>
>> Signed-off-by: Chander Kashyap
>
> It appears this is missing arch/arm/include/asm/arch-s5pc2xx/sromc.h
>
> Please squash with patch submitted here:
>
> 05/17 Minkyu Kang [U-Boot] [PATCH] S5PC2XX
Dear Wolfgang Denk,
On 18 May 2011 16:49, Wolfgang Denk wrote:
> Dear Minkyu Kang,
>
> In message you wrote:
>>
>> > diff --git a/boards.cfg b/boards.cfg
>> > index 554e06c..01edb79 100644
>> > --- a/boards.cfg
>> > +++ b/boards.c
7 harmony
> nvidia tegra2
> seaboard arm armv7 seaboard
> nvidia tegra2
> actux1 arm ixp
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
n 'board_init_r':
mmc_boot.c:51: warning: 'noreturn' function does return
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
board/samsung/smdkv310/mmc_boot.c
> create mode 100644 mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c
> create mode 100644 mmc_spl/board/samsung/smdkv310/u-boot.lds
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
310/mem_setup.S
> create mode 100644 board/samsung/smdkv310/smdkv310.c
> create mode 100644 include/configs/smdkv310.h
>
applied to u-boot-samsung
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
d, 2 insertions(+), 2 deletions(-)
>
Acked-by: Minkyu Kang
Dear Albert ARIBAUD,
This patch is for bugfix.
Please apply it to arm tree directly.
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
61 matches
Mail list logo
